Re: [PHP-DEV] Passing specific bison to build

2013-07-17 Thread Julien Pauli
On Wed, Jul 17, 2013 at 4:00 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:

 Hi all,

 I've upgraded to Fedora 19 and bison is too new for PHP 5.4/5.3
 I would like to users to select specific bison to build with.


 --- a/Zend/acinclude.m4
 +++ b/Zend/acinclude.m4
 @@ -12,7 +12,7 @@ AC_DEFUN([LIBZEND_BISON_CHECK],[
bison_version=none
if test $YACC; then
  AC_CACHE_CHECK([for bison version], php_cv_bison_version, [
 -  bison_version_vars=`bison --version 2 /dev/null | grep 'GNU Bison'
 | cut -d ' ' -f 4 |
 +  bison_version_vars=`$YACC --version 2 /dev/null | grep 'GNU Bison'
 | cut -d ' ' -f 4 |
php_cv_bison_version=invalid
if test -n $bison_version_vars; then
  set $bison_version_vars

 To build with specific bison, you may do

 YACC=/usr/local/bin/bison1 ./configure

 Any comments?


+1.

Would be very useful for RMing as well, as we have to test different bison
versions and use one for RMing which may not be the system's one.

Julien.Pauli


[PHP-DEV] Passing specific bison to build

2013-07-16 Thread Yasuo Ohgaki
Hi all,

I've upgraded to Fedora 19 and bison is too new for PHP 5.4/5.3
I would like to users to select specific bison to build with.


--- a/Zend/acinclude.m4
+++ b/Zend/acinclude.m4
@@ -12,7 +12,7 @@ AC_DEFUN([LIBZEND_BISON_CHECK],[
   bison_version=none
   if test $YACC; then
 AC_CACHE_CHECK([for bison version], php_cv_bison_version, [
-  bison_version_vars=`bison --version 2 /dev/null | grep 'GNU Bison'
| cut -d ' ' -f 4 |
+  bison_version_vars=`$YACC --version 2 /dev/null | grep 'GNU Bison'
| cut -d ' ' -f 4 |
   php_cv_bison_version=invalid
   if test -n $bison_version_vars; then
 set $bison_version_vars

To build with specific bison, you may do

YACC=/usr/local/bin/bison1 ./configure

Any comments?

--
Yasuo Ohgaki
yohg...@ohgaki.net