[PHP-DEV] Re: [PATCH] Consistent type names in error messages
On 20 Dec 2014, at 15:50, Andrea Faulds a...@ajf.me wrote: On 14 Dec 2014, at 18:35, Andrea Faulds a...@ajf.me wrote: I’ve made a patch which makes zend_parse_parameters and userland type hints consistently show “integer” and “float” rather than “long” and “double”: https://github.com/php/php-src/pull/955 I also wrote a GNU sed script which I used to update the tests: https://gist.github.com/TazeTSchnitzel/c0d780466def9f226318 Hi, Is anyone here opposed to this, or should I just merge it? I don’t think it really needs an RFC. It doesn’t break BC. Thanks. Hey, I’ve merged the patch into master, PHP 7 will have consistent type names in its error messages. :) Thanks. -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PATCH] Consistent type names in error messages
On 21 Dec 2014 13:25, Andrea Faulds a...@ajf.me wrote: On 20 Dec 2014, at 15:50, Andrea Faulds a...@ajf.me wrote: On 14 Dec 2014, at 18:35, Andrea Faulds a...@ajf.me wrote: I’ve made a patch which makes zend_parse_parameters and userland type hints consistently show “integer” and “float” rather than “long” and “double”: https://github.com/php/php-src/pull/955 I also wrote a GNU sed script which I used to update the tests: https://gist.github.com/TazeTSchnitzel/c0d780466def9f226318 Hi, Is anyone here opposed to this, or should I just merge it? I don’t think it really needs an RFC. It doesn’t break BC. Thanks. Hey, I’ve merged the patch into master, PHP 7 will have consistent type names in its error messages. :) Thanks for the patch and the other contribs you've been doing lately. Thanks. -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PATCH] Consistent type names in error messages
On 14 Dec 2014, at 18:35, Andrea Faulds a...@ajf.me wrote: I’ve made a patch which makes zend_parse_parameters and userland type hints consistently show “integer” and “float” rather than “long” and “double”: https://github.com/php/php-src/pull/955 I also wrote a GNU sed script which I used to update the tests: https://gist.github.com/TazeTSchnitzel/c0d780466def9f226318 Hi, Is anyone here opposed to this, or should I just merge it? I don’t think it really needs an RFC. It doesn’t break BC. Thanks. -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
