On Thu, Apr 9, 2020 at 10:02 AM Nikita Popov wrote:
>
> On Thu, Mar 26, 2020 at 7:52 PM Nikita Popov wrote:
>
> > Hi internals,
> >
> > This has been declined in the past, but I just keep making this mistake,
> > and believe it deserves reconsideration...
> >
> > https://wiki.php.net/rfc/trailing_comma_in_parameter_list
> >
>
> Heads up: I plan to move this to voting tomorrow. Don't think there's much
> to discuss here...
>
> Nikita
Hello Nikita,
I'm personally favorable, but since some concern has been raised that
it *might* be interpreted as "encouraging" functions with many
parameters (and I fear that could be taken as a motive for voting
"no"), I would just suggest (again) that you could add an example (or
even replace the current one) of a function with only two/three
parameters that would still exceed 120 columns if on a single line
(with e.g. descriptive names, [union] type declarations for parameters
and/or return, and/or a class constant as default value for the last
parameter, that's not so uncommon)... Just my two cents ;)
Best regards,
--
Guilliam Xavier
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
