[PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2015-01-16 Thread Sara Golemon
On Thu, Dec 25, 2014 at 6:20 PM, Sara Golemon poll...@php.net wrote:
 On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon poll...@php.net wrote:
 While playing around with Andrea's unicode literals syntax proposal, I
 was reminded of just how little of ICU is exposed.  I've put up a
 short proposal for adding IntlChar exporting these APIs as static
 methods (with a matching non-oop interface).

 https://wiki.php.net/rfc/intl.char

 Better late than never, voting is open until 2015-01-16 06:00 UTC

After 3 week voting period, IntlChar is now accepted 14-0

I'll land it in both projects shortly.

-Sara

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-25 Thread Sara Golemon
On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon poll...@php.net wrote:
 While playing around with Andrea's unicode literals syntax proposal, I
 was reminded of just how little of ICU is exposed.  I've put up a
 short proposal for adding IntlChar exporting these APIs as static
 methods (with a matching non-oop interface).

 https://wiki.php.net/rfc/intl.char

Better late than never, voting is open until 2015-01-16 06:00 UTC

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-25 Thread Pierre Joye
On Fri, Dec 26, 2014 at 1:20 PM, Sara Golemon poll...@php.net wrote:
 On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon poll...@php.net wrote:
 While playing around with Andrea's unicode literals syntax proposal, I
 was reminded of just how little of ICU is exposed.  I've put up a
 short proposal for adding IntlChar exporting these APIs as static
 methods (with a matching non-oop interface).

 https://wiki.php.net/rfc/intl.char

 Better late than never, voting is open until 2015-01-16 06:00 UTC

Wohooo! :)


btw, it would be very nice to start a new thread for each phase, so it
does not go hidden in some random old threads. Thanks :)

-- 
Pierre

@pierrejoye | http://www.libgd.org

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-16 Thread Stanislav Malyshev
Hi!

 Full implementation available now at
 https://github.com/sgolemon/php-src/compare/intl.uchar
 RFC updated to remove the functional API and clarify some things based
 on what I learned while implementing.

Thanks for your work! I think it may be good to make it a pull, since
it'd be easier to comment on that (and also Travis can say its word of
course :)

 Pay special attention to the #notes section regarding $limit which I
 think is a somewhat non-PHP API.

It says some methods but I found just one which is user-callable -
enumCharNames - and one that consumes callback with the same setup -
enumCharTypes - in the latter case I don't think it makes sense to
change anything since it's a callback for ICU. So, if I didn't miss
anything, it's one function and at that one that has matching callback
in ICU API. So I think it's best to leave it as is, especially that PHP
doesn't have the concept of ranges as such...
-- 
Stas Malyshev
smalys...@gmail.com

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-16 Thread Sara Golemon
On Tue, Dec 16, 2014 at 12:49 AM, Stanislav Malyshev
smalys...@gmail.com wrote:
 Thanks for your work! I think it may be good to make it a pull, since
 it'd be easier to comment on that (and also Travis can say its word of
 course :)

Can do!
https://github.com/php/php-src/pull/961

 It says some methods but I found just one which is user-callable -
 enumCharNames - and one that consumes callback with the same setup -
 enumCharTypes - in the latter case I don't think it makes sense to
 change anything since it's a callback for ICU. So, if I didn't miss
 anything, it's one function and at that one that has matching callback
 in ICU API. So I think it's best to leave it as is, especially that PHP
 doesn't have the concept of ranges as such...

You've read it right and I agree with you.  The less magic the better.
I just wanted to call it out since it lacks some intuitiveness.

-Sara

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] Re: [RFC] IntlChar class and intl_char_*() functions

2014-12-15 Thread Sara Golemon
On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon poll...@php.net wrote:
 While playing around with Andrea's unicode literals syntax proposal, I
 was reminded of just how little of ICU is exposed.  I've put up a
 short proposal for adding IntlChar exporting these APIs as static
 methods (with a matching non-oop interface).

 https://wiki.php.net/rfc/intl.char

Full implementation available now at
https://github.com/sgolemon/php-src/compare/intl.uchar
RFC updated to remove the functional API and clarify some things based
on what I learned while implementing.

Pay special attention to the #notes section regarding $limit which I
think is a somewhat non-PHP API.

-Sara

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php