RE: [PHP-DEV] phar bug #65028
Hello Ralph! I am a new subscriber to the PHP list am not sure of the details of the bug you mention #65028... Was this post Microsoft SQL integration or prior to it? Regards, Rajneesh http://my.opera.com/shettyrn/about/ Rajneesh N. Shetty Tel : (+61)468371858 From: Ralph Schindler [ra...@ralphschindler.com] Sent: Monday, 5 August 2013 6:46 AM To: internals@lists.php.net Subject: Re: [PHP-DEV] phar bug #65028 Well, if he's still up to it I think we should list him as a maintainer. Ralph? Yes, I am ready to get back on this horse. Stas, I will address your questions on my original PR this week, perhaps we can get it to a place where you can close it out. -ralph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] phar bug #65028
Well, if he's still up to it I think we should list him as a maintainer. Ralph? Yes, I am ready to get back on this horse. Stas, I will address your questions on my original PR this week, perhaps we can get it to a place where you can close it out. -ralph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] phar bug #65028
On 24 July 2013 18:46, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a part of PHP, IMHO, to be without a maintainer. Well, if he's still up to it I think we should list him as a maintainer. Ralph? So are we finally ready to give karma?! Ralph are you ready? :) -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] phar bug #65028
hi we don't have a maintainer for phar as far as I know. Ralph volunteered(twice) to take over phar but was pretty much ignored. He is the last person that I know looking into the phar code and fixing stuff so maybe he could review your changes. On Mon, Jul 22, 2013 at 10:09 AM, Stas Malyshev smalys...@sugarcrm.comwrote: Hi! I was looking at bug https://bugs.php.net/bug.php?id=65028 and looks like it happens because phar writes manifest after HALT_COMPILER(); ? and first 4 bytes of manifest are manifest length (little-endian), but when it read the header, it checks if there's \r\n after ?. So if length has lowest byte 0x0d or 0x0a, bad things happen. I've created https://github.com/php/php-src/pull/392 to fix this problem, however I'd like somebody with more familiarity with phar details to take a look if it's the best way to do it. P.S.: BTW, who is official phar maintainer now? I'm seeing that last commit from anybody listed as maintainer is 4 years ago... Is it time to update ownership? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- Ferenc Kovács @Tyr43l - http://tyrael.hu
Re: [PHP-DEV] phar bug #65028
Am 22.07.2013 10:09, schrieb Stas Malyshev: P.S.: BTW, who is official phar maintainer now? I'm seeing that last commit from anybody listed as maintainer is 4 years ago... Is it time to update ownership? As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a part of PHP, IMHO, to be without a maintainer. -- Sebastian BergmannCo-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] phar bug #65028
Hi! As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a part of PHP, IMHO, to be without a maintainer. Well, if he's still up to it I think we should list him as a maintainer. Ralph? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] phar bug #65028
Hi! I was looking at bug https://bugs.php.net/bug.php?id=65028 and looks like it happens because phar writes manifest after HALT_COMPILER(); ? and first 4 bytes of manifest are manifest length (little-endian), but when it read the header, it checks if there's \r\n after ?. So if length has lowest byte 0x0d or 0x0a, bad things happen. I've created https://github.com/php/php-src/pull/392 to fix this problem, however I'd like somebody with more familiarity with phar details to take a look if it's the best way to do it. P.S.: BTW, who is official phar maintainer now? I'm seeing that last commit from anybody listed as maintainer is 4 years ago... Is it time to update ownership? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
