Re: [PHP-DEV] zend bison check

2013-08-09 Thread Michael Wallner
On 9 August 2013 02:48, Yasuo Ohgaki yohg...@ohgaki.net wrote:
 Hi,

 I proposed that specify any bison as developer wants.
 It seems it is not merged, yet.

 Usage:
 YACC=/usr/local/bin/mybison ./configure

 diff --git a/Zend/acinclude.m4 b/Zend/acinclude.m4
 index 454513f..1440a2a 100644
 --- a/Zend/acinclude.m4
 +++ b/Zend/acinclude.m4
 @@ -12,7 +12,7 @@ AC_DEFUN([LIBZEND_BISON_CHECK],[
bison_version=none
if test $YACC; then
  AC_CACHE_CHECK([for bison version], php_cv_bison_version, [
 -  bison_version_vars=`bison --version 2 /dev/null | grep 'GNU Bison' |
 cut -d ' ' -f 4 | $SED -e 's/\./
 +  bison_version_vars=`$YACC --version 2 /dev/null | grep 'GNU Bison' |
 cut -d ' ' -f 4 | $SED -e 's/\./
php_cv_bison_version=invalid
if test -n $bison_version_vars; then
  set $bison_version_vars




 On Fri, Aug 9, 2013 at 8:05 AM, Ángel González keis...@gmail.com wrote:

 On 08/08/13 20:56, Michael Wallner wrote:

 As I have no Zend karma, is anybody kind enough to merge the bison
 blacklist patch?
 https://github.com/php/php-src/pull/402

 Maybe it should be bison_version_exclude=none so that the error message
 is nicer?

Thank you, I incorporated all your suggestions


-- 
Regards,
Mike

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] zend bison check

2013-08-08 Thread Michael Wallner
As I have no Zend karma, is anybody kind enough to merge the bison
blacklist patch?
https://github.com/php/php-src/pull/402

-- 
Regards,
Mike

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] zend bison check

2013-08-08 Thread Ángel González

On 08/08/13 20:56, Michael Wallner wrote:

As I have no Zend karma, is anybody kind enough to merge the bison
blacklist patch?
https://github.com/php/php-src/pull/402
Maybe it should be bison_version_exclude=none so that the error 
message is nicer?




--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] zend bison check

2013-08-08 Thread Yasuo Ohgaki
Hi,

I proposed that specify any bison as developer wants.
It seems it is not merged, yet.

Usage:
YACC=/usr/local/bin/mybison ./configure

diff --git a/Zend/acinclude.m4 b/Zend/acinclude.m4
index 454513f..1440a2a 100644
--- a/Zend/acinclude.m4
+++ b/Zend/acinclude.m4
@@ -12,7 +12,7 @@ AC_DEFUN([LIBZEND_BISON_CHECK],[
   bison_version=none
   if test $YACC; then
 AC_CACHE_CHECK([for bison version], php_cv_bison_version, [
-  bison_version_vars=`bison --version 2 /dev/null | grep 'GNU Bison'
| cut -d ' ' -f 4 | $SED -e 's/\./
+  bison_version_vars=`$YACC --version 2 /dev/null | grep 'GNU Bison'
| cut -d ' ' -f 4 | $SED -e 's/\./
   php_cv_bison_version=invalid
   if test -n $bison_version_vars; then
 set $bison_version_vars


--
Yasuo Ohgaki
yohg...@ohgaki.net


On Fri, Aug 9, 2013 at 8:05 AM, Ángel González keis...@gmail.com wrote:

 On 08/08/13 20:56, Michael Wallner wrote:

 As I have no Zend karma, is anybody kind enough to merge the bison
 blacklist patch?
 https://github.com/php/php-**src/pull/402https://github.com/php/php-src/pull/402

 Maybe it should be bison_version_exclude=none so that the error message
 is nicer?




 --
 PHP Internals - PHP Runtime Development Mailing List
 To unsubscribe, visit: http://www.php.net/unsub.php