Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

[Andrea Faulds]

Hi Pascal,

Pascal MARTIN, AFUP wrote:

Le 13/01/2016 19:48, Thomas Punt a écrit :

Voting has opened for the inclusion of a digit separator in PHP[1].
Voting ends in
one week's time on January 20th.


Hi,

At AFUP, we would be on the -1 side (by a huge margin).

The "good" thing would be code that's a bit more readable, yes.

But it would be harder to search in code, as there would be more than
one way to write a number. Basically, it would break grep/find.

Splitting numbers so they are more readable is kind of a presentation
matter and, as such, could be done by an editor/IDE when displaying
code, without having to modify the code by hand (actually, I'm quite
surprised it's not a feature I remember seeing in any IDE).

In any case, thanks for you work on this!


One other approach I thought of is to use constant scalar expressions:

+('123'.'456'.'789')

It's not quite the same of native support, but it works.

Thanks.
--
Andrea Faulds
https://ajf.me/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

[Yasuo Ohgaki]

Hi Andrea,

On Thu, Jan 21, 2016 at 4:18 AM, Andrea Faulds  wrote:
>
> One other approach I thought of is to use constant scalar expressions:
>
> +('123'.'456'.'789')
>
> It's not quite the same of native support, but it works.

This is what I do on occasions.

I have to read var_export()ed PHP code sometimes.
If PHP supports this RFC and var_export() support it,
it would be much easier to read.

It's irrelevant for this RFC, but if PHP supports compile
time string concatenation

echo "Very long sting "
"that is concatenated "
"at compile time.";

It would be nice to have.

Regards,

--
Yasuo Ohgaki
yohg...@ohgaki.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

[Pascal MARTIN, AFUP]

Le 13/01/2016 19:48, Thomas Punt a écrit :

Voting has opened for the inclusion of a digit separator in PHP[1]. Voting ends 
in
one week's time on January 20th.


Hi,

At AFUP, we would be on the -1 side (by a huge margin).

The "good" thing would be code that's a bit more readable, yes.

But it would be harder to search in code, as there would be more than 
one way to write a number. Basically, it would break grep/find.


Splitting numbers so they are more readable is kind of a presentation 
matter and, as such, could be done by an editor/IDE when displaying 
code, without having to modify the code by hand (actually, I'm quite 
surprised it's not a feature I remember seeing in any IDE).


In any case, thanks for you work on this!

--
Pascal MARTIN, AFUP - French UG
http://php-internals.afup.org/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] [RFC][VOTE] Number Format Separator

[Thomas Punt]

Hi Björn,

> Well, if I had a vote it would definetly be +1. A small question
> though, why is the voting period only one week (small RFC or)?

The RFC is quite simple and short, so I thought a one week voting period would
suffice. I'm more than happy to extend this though if people don't think they'll
have time to review it within the next week.

> Regards //Björn Larsson

-Tom  
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

[Björn Larsson]

Den 2016-01-14 kl. 18:21, skrev Thomas Punt:

Hi Björn,


Well, if I had a vote it would definetly be +1. A small question
though, why is the voting period only one week (small RFC or)?

The RFC is quite simple and short, so I thought a one week voting period would
suffice. I'm more than happy to extend this though if people don't think they'll
have time to review it within the next week.


Regards //Björn Larsson

-Tom

Well, even if it's small one there could be a value in having a slightly
longer voting period. Just thought that many CoC mails on the list
now takes focus.

Still, no point in making a hen out of a feather :-)

Regards //Björn

PS I'm not sure the RFC process allows to change voting period
once the voting is opened.


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

[Björn Larsson]

Den 2016-01-13 kl. 19:48, skrev Thomas Punt:

Hi internals!

Voting has opened for the inclusion of a digit separator in PHP[1]. Voting ends 
in
one week's time on January 20th.

Thanks,
Tom

[1]: http://wiki.php.net/rfc/number_format_separator


Well, if I had a vote it would definetly be +1. A small question
though, why is the voting period only one week (small RFC or)?

Regards //Björn Larsson


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php