Re: [PHP-DEV] Adding pecl/http to core
Hi Johannes, Am Montag, den 27.10.2008, 19:59 +0100 schrieb Johannes Schlüter: [...] I think it's fine to have settings for limitations on pconnects, but stuff like http.request.methods.allowed or http.only_exceptions should imo be set as object properties (or similar), not globally using ini settings. I totally agree, reasons like that and others like Class::singleton() instead of getInstance() (which seems more common in the PHP world) is the reason I would like to do a proper API review, before promoting it to core. cu, Lars signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Re: [PHP-DEV] Adding pecl/http to core
I've not seen plenty of Class::singleton() myself, getInstance is an accepted standard in all languages, including the PHP code I wrote, and I've had experience with. Regards, Stan Vassilev -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Hi Stan, Am Dienstag, den 28.10.2008, 14:33 +0200 schrieb Stan Vassilev | FM: [...] I've not seen plenty of Class::singleton() myself, getInstance is an accepted standard in all languages, including the PHP code I wrote, and I've had experience with. That's my point, yes. pecl_http uses ::singleton() instead of getInstance(). cu, Lars -- Jabber: [EMAIL PROTECTED] Weblog: http://usrportage.de signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Re: [PHP-DEV] Adding pecl/http to core
Johannes Schlüter wrote: I think it's fine to have settings for limitations on pconnects, but stuff like http.request.methods.allowed or http.only_exceptions should http.request.methods.allowed is handled at RINIT. http.only_exceptions is PHP_INI_ALL, though introducing it at all might have been a bad idea. In fact pretty all settings are PHP_INI_ALL except auto_start for inflate/deflate output handler (PHP_INI_PERDIR), maximum count of persistent handles and what the global request data share should cache. Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Lars Strojny wrote: I've not seen plenty of Class::singleton() myself, getInstance is an accepted standard in all languages, including the PHP code I wrote, and I've had experience with. That's my point, yes. pecl_http uses ::singleton() instead of getInstance(). Well, sure--that depends. PEAR for example defined ::singleton() as the standard name and most of the code I've dealt with at that time used ::singleton() either. I guess this is merely a matter of taste, respectively what's PHP going to use in the future. Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
While overall solid, I have 1 api critique that may or may not influence inclusion.. The naming's seem slightly awkward for HttpResponse. Seemingly, HttpResponse is the compliment to HttpRequest given their namings. But looking at the api (the fact that its all static methods), it leads me to believe that this class is more closely tied to the CURRENT PHP response buffer. Is this the case? While looking at the API for HttpRequest, it appears that after a request is sent, it retrives an HTTPMessage object back (which would make that class the compliment in the Request/Response paradigm). If so, perhaps an alternate API and naming could be suggested? HttpCurrentResponse makes alot of sense to me (as to not imply itself as HttpRequest's compliment).. Also, would it make any sense (in this case), to change the API to non-static methods, and object instantiation to a getInstance() singleton pattern? This would allow for the class to be extended and decorated and would be given more of an object feel- which i feel like this the real value added here. Please correct me if I am wrong, Thanks, Ralph Hannes Magnusson wrote: On Tue, Sep 23, 2008 at 13:54, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: I have not talked to Johannes about this, but unless there is a major major major outcry from the internals folks to add it, its too late for 5.3. I count one vote against it... -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Johannes Schlüter escribió: or http.only_exceptions should imo be set as object properties (or similar), not globally using ini settings. Or just throw only exceptions and no ini setting at all. -- A computer is like an Old Testament god, with a lot of rules and no mercy. Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research Development http://www.opensuse.org/ signature.asc Description: OpenPGP digital signature
Re: [PHP-DEV] Adding pecl/http to core
Hi Michael, Am Montag, den 22.09.2008, 20:17 +0200 schrieb Michael Wallner: [...] I wonder what the general opinion is on adding pecl/http to the main PHP distribution? Many people have poked me in the past, so I guessed it's time to ask me and you that question once for all. I would like to see pecl_http in just not in 5.3. I think we are too far in the release process to do the required work to add it. And API review would be required (I didn't looked at it closely but is), general code review and so on. Of course I do not speak for our release managers, but I would say yes, but. cu, Lars -- Jabber: [EMAIL PROTECTED] Weblog: http://usrportage.de signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
Re: [PHP-DEV] Adding pecl/http to core
On Mon, Sep 22, 2008 at 20:17, Michael Wallner [EMAIL PROTECTED] wrote: Hi, I wonder what the general opinion is on adding pecl/http to the main PHP distribution? +1 -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
On 23.09.2008, at 14:02, Lars Strojny wrote: Hi Michael, Am Montag, den 22.09.2008, 20:17 +0200 schrieb Michael Wallner: [...] I wonder what the general opinion is on adding pecl/http to the main PHP distribution? Many people have poked me in the past, so I guessed it's time to ask me and you that question once for all. I would like to see pecl_http in just not in 5.3. I think we are too far in the release process to do the required work to add it. And API review would be required (I didn't looked at it closely but is), general code review and so on. Of course I do not speak for our release managers, but I would say yes, but. I have not talked to Johannes about this, but unless there is a major major major outcry from the internals folks to add it, its too late for 5.3. That being said, there is some overlap in features with existing functionality. Maybe if we schedule this for PHP 6, then we might want to mark a few things as deprecated in PHP 5.3. regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
On Tue, Sep 23, 2008 at 14:54, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: That being said, there is some overlap in features with existing functionality. Maybe if we schedule this for PHP 6, then we might want to mark a few things as deprecated in PHP 5.3. Doesn't sound like a good idea. To be of any use pecl/http needs curl, I don't think built-in functions which do not require external things should be deprecated... -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Hello Hannes, Tuesday, September 23, 2008, 3:04:16 PM, you wrote: On Tue, Sep 23, 2008 at 14:54, Lukas Kahwe Smith [EMAIL PROTECTED] wrote: That being said, there is some overlap in features with existing functionality. Maybe if we schedule this for PHP 6, then we might want to mark a few things as deprecated in PHP 5.3. Doesn't sound like a good idea. To be of any use pecl/http needs curl, I don't think built-in functions which do not require external things should be deprecated... Exactly. Still we want http for its superior functionality. And are we really that far with release? I had to interrupt the release party but as far as I know, the number one addition still isn't finalized yet. Even if no one cmplains about it anymore we still need some time for adjustments. Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Hello Michael, I think it is pretty useful. marcus Monday, September 22, 2008, 8:17:58 PM, you wrote: Hi, I wonder what the general opinion is on adding pecl/http to the main PHP distribution? Many people have poked me in the past, so I guessed it's time to ask me and you that question once for all. Regards, Mike Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Michael Wallner escribió: Hi, I wonder what the general opinion is on adding pecl/http to the main PHP distribution? Many people have poked me in the past, so I guessed it's time to ask me and you that question once for all. +1000, :) probably the most useful addition in years. -- A computer is like an Old Testament god, with a lot of rules and no mercy. Cristian Rodríguez R. Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research Development http://www.opensuse.org/ signature.asc Description: OpenPGP digital signature
Re: [PHP-DEV] Adding pecl/http to core
I have to agree here. Is the book already closed on core extensions in 5.3? -ralph Cristian Rodríguez wrote: Michael Wallner escribió: Hi, I wonder what the general opinion is on adding pecl/http to the main PHP distribution? Many people have poked me in the past, so I guessed it's time to ask me and you that question once for all. +1000, :) probably the most useful addition in years. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Adding pecl/http to core
Hi 2008/9/22 Michael Wallner [EMAIL PROTECTED]: Hi, I wonder what the general opinion is on adding pecl/http to the main PHP distribution? Many people have poked me in the past, so I guessed it's time to ask me and you that question once for all. Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php Big +1 from me aswell, and its already well documented which makes it even greater :) -- Kalle Sommer Nielsen -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
