Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
Uwe Schindler wrote: We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there, too. So for consistency I added this parameter. At 16:37 15.04.2005, you wrote: Then file_exists() is also incosistent :). Do add additional param to it too. Andrey -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
I can remove this parameter. Without it, the function declaration keeps constant and we could add this patch to PHP_5_0, too. It does not change the user interface but makes C code simplier and adds support for URLs without any cost to it. The original intention to change the md5/sha1 code was to remove stdio and convert to posix io (as done in 4.3 and 5.0) because of the solaris stdio problems. But php_streams is even better. Uwe At 17:08 15.04.2005, you wrote: Uwe Schindler wrote: We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there, too. So for consistency I added this parameter. At 16:37 15.04.2005, you wrote: Then file_exists() is also incosistent :). Do add additional param to it too. Andrey - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de - http://www.schindlers-software.de eMails: [EMAIL PROTECTED] (private); [EMAIL PROTECTED] (company) Tel./Fax: +49 700 PCLATEIN (+49 700 72528346) Schindlers Software - Home of Schindlers PC-LATEIN 3.10 DIE Software zum Lateinlernen! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
On Fri, 15 Apr 2005, Uwe Schindler wrote: I can remove this parameter. Without it, the function declaration keeps constant and we could add this patch to PHP_5_0, too. It does not change the user interface but makes C code simplier and adds support for URLs without any cost to it. I think you should remove it from these two files... they are for ONE file... it would be silly if they followed the include path. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
On Fri, 15 Apr 2005, Andrey Hristov wrote: Uwe Schindler wrote: We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there, too. So for consistency I added this parameter. At 16:37 15.04.2005, you wrote: Then file_exists() is also incosistent :). Do add additional param to it too. No! Do not do that - that will definitely going to break BC. Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
We can left that out. The flag to search in the include path is
available to
all file_* functions in PHP. Make it sense to search in the include
path for
example in the exif-functions? But this parameter is available there,
too.
So for consistency I added this parameter.
Except that it's not. Most, in fact, do not include it. It's just the high
visibility ones {fopen(), file(), file_get_contents()} that you see it on.
Then file_exists() is also incosistent :). Do add additional param to it
too.
No! Do not do that - that will definitely going to break BC.
Rather than getting prototype change happy. How about a context parameter
for the file:// wrapper since it only applies to plainfiles anyway. (Note:
Okay so it applies to plainfile wrappers like compress.gzip:// but that just
opens the subordinate resource as a wrapper and winds up at file:// anyway)
Keep the flag on functions like fopen() for BC purposes, but don't add it
anywhere else, there's no need for it.
-Sara
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
At 18:51 15.04.2005, Sara Golemon wrote: Rather than getting prototype change happy. How about a context parameter for the file:// wrapper since it only applies to plainfiles anyway. (Note: Okay so it applies to plainfile wrappers like compress.gzip:// but that just opens the subordinate resource as a wrapper and winds up at file:// anyway) Keep the flag on functions like fopen() for BC purposes, but don't add it anywhere else, there's no need for it. Parameter removed again. Any complaints to add this patch (lowlevel file io to streams in sha1_file md5_file) to PHP_5_0 (PHP_4_3 ???), too? Uwe - Uwe Schindler [EMAIL PROTECTED] - http://www.php.net NSAPI SAPI developer Bremen, Germany -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c
Parameter removed again. Any complaints to add this patch (lowlevel file io to streams in sha1_file md5_file) to PHP_5_0 (PHP_4_3 ???), too? I have no objections to MFHing the path to 4.3. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
