Re: [PATCH v3] iommu: revisit iommu_insert_resv_region() implementation
Looks good, Reviewed-by: Christoph Hellwig
[PATCH] Remove wrong default domain comments
These comments are wrong. request_default_domain_for_dev doesn't just handle direct mapped domains. Signed-off-by: Tom Murphy --- drivers/iommu/iommu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index ea95080372e7..3b6807e7a2d8 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -2179,7 +2179,6 @@ request_default_domain_for_dev(struct device *dev, unsigned long type) mutex_lock(&group->mutex); - /* Check if the default domain is already direct mapped */ ret = 0; if (group->default_domain && group->default_domain->type == type) goto out; @@ -2189,7 +2188,6 @@ request_default_domain_for_dev(struct device *dev, unsigned long type) if (iommu_group_device_count(group) != 1) goto out; - /* Allocate a direct mapped domain */ ret = -ENOMEM; domain = __iommu_domain_alloc(dev->bus, type); if (!domain) @@ -2204,7 +2202,7 @@ request_default_domain_for_dev(struct device *dev, unsigned long type) iommu_group_create_direct_mappings(group, dev); - /* Make the direct mapped domain the default for this group */ + /* Make the domain the default for this group */ if (group->default_domain) iommu_domain_free(group->default_domain); group->default_domain = domain; -- 2.20.1
Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages
Christoph, On Sun, Aug 25, 2019 at 10:10 AM Christoph Hellwig wrote: > > On Fri, Aug 23, 2019 at 09:56:52PM +0900, Masahiro Yamada wrote: > > + linux-mmc, Ulf Hansson, Adrian Hunter, > > > > > > ADMA of SDHCI is not working > > since bd2e75633c8012fc8a7431c82fda66237133bf7e > > Does it work for you with this commit: > > http://git.infradead.org/users/hch/dma-mapping.git/commitdiff/90ae409f9eb3bcaf38688f9ec22375816053a08e This is included in v5.3-rc6 so I tested it. No, it did not fix the problem. -- Best Regards Masahiro Yamada
Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages
Hi Nicolin, On Sat, Aug 24, 2019 at 7:10 AM Nicolin Chen wrote: > > On Fri, Aug 23, 2019 at 09:49:46PM +0900, Masahiro Yamada wrote: > > > > Reverting this commit fixed the problem. > > We are having another problem with the new API and Christoph > submitted a patch at: https://lkml.org/lkml/2019/8/20/86 > > Would it be possible for you to test to see if it can fix? It is included in 5.3-rc6 I tested 5.3-rc6 in on my board, but I still see the same DMA fauilure. Masahiro > We can revert my fallback change after all, if Christoph's > patch doesn't work for you either. > > Thanks > Nicolin -- Best Regards Masahiro Yamada ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
