Re: [PATCH] dma-mapping: remove unused attrs parameter to dma_common_get_sgtable
From: Stefano Stabellini Sent: Friday, January 04, 2019 1:55 AM > On Thu, 3 Jan 2019, Huaisheng Ye wrote: > > From: Huaisheng Ye > > > > dma_common_get_sgtable has parameter attrs which is not used at all. > > Remove it. > > > > Signed-off-by: Huaisheng Ye > > Acked-by: Stefano Stabellini > > FYI the patch doesn't apply cleanly to master. Got it, I will rebase it to branch master and resend the patch later. Cheers, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [External] Re: [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD
From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On Behalf Of Michal Hocko Sent: Monday, May 28, 2018 9:38 PM > > In my opinion, originally there shouldn't be such many wrong > > combinations of these bottom 3 bits. For any user, whether or > > driver and fs, they should make a decision that which zone is they > > preferred. Matthew's idea is great, because with it the user must > > offer an unambiguous flag to gfp zone bits. > > Well, I would argue that those shouldn't really care about any zones at > all. All they should carea bout is whether they really need a low mem > zone (aka directly accessible to the kernel), highmem or they are the > allocation is generally movable. Mixing zones into the picture just > makes the whole thing more complicated and error prone. Dear Michal, I don't quite understand that. I think those, mostly drivers, need to get the correct zone they want. ZONE_DMA32 is an example, if drivers can be satisfied with a low mem zone, why they mark the gfp flags as 'GFP_KERNEL|__GFP_DMA32'? GFP_KERNEL is enough to make sure a directly accessible low mem, but it is obvious that they want to get a DMA accessible zone below 4G. > This should be a part of the changelog. Please note that you should > provide some number if you claim performance benefits. The complexity > will always be subjective. Sure, I will post them to changelog with next version of patches. Sincerely, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [External] Re: [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD
From: Michal Hocko [mailto:mho...@kernel.org] Sent: Thursday, May 24, 2018 8:19 PM> > > Let me try to reply your questions. > > Exactly, GFP_ZONE_TABLE is too complicated. I think there are two advantages > > from the series of patches. > > > > 1. XOR operation is simple and efficient, GFP_ZONE_TABLE/BAD need to do > > twice > > shift operations, the first is for getting a zone_type and the second is for > > checking the to be returned type is a correct or not. But with these patch > > XOR > > operation just needs to use once. Because the bottom 3 bits of GFP bitmask > > have > > been used to represent the encoded zone number, we can say there is no bad > > zone > > number if all callers could use it without buggy way. Of course, the > > returned > > zone type in gfp_zone needs to be no more than ZONE_MOVABLE. > > But you are losing the ability to check for wrong usage. And it seems > that the sad reality is that the existing code do screw up. In my opinion, originally there shouldn't be such many wrong combinations of these bottom 3 bits. For any user, whether or driver and fs, they should make a decision that which zone is they preferred. Matthew's idea is great, because with it the user must offer an unambiguous flag to gfp zone bits. Ideally, before any user wants to modify the address zone modifier, they should clear it firstly, then ORing the GFP zone flag which comes from the zone they prefer. With these patches, we can loudly announce that, the bottom 3 bits of zone mask couldn't accept internal ORing operations. The operations like __GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM is illegal. The current GFP_ZONE_TABLE is precisely the root of this problem, that is __GFP_DMA, __GFP_DMA32 and __GFP_HIGHMEM are formatted as 0x1, 0x2 and 0x4. > > > 2. GFP_ZONE_TABLE has limit with the amount of zone types. Current > > GFP_ZONE_TABLE > > is 32 bits, in general, there are 4 zone types for most ofX86_64 platform, > > they > > are ZONE_DMA, ZONE_DMA32, ZONE_NORMAL and ZONE_MOVABLE. If we want to > > expand the > > amount of zone types to larger than 4, the zone shift should be 3. > > But we do not want to expand the number of zones IMHO. The existing zoo > is quite a maint. pain. > > That being said. I am not saying that I am in love with GFP_ZONE_TABLE. > It always makes my head explode when I look there but it seems to work > with the current code and it is optimized for it. If you want to change > this then you should make sure you describe reasons _why_ this is an > improvement. And I would argue that "we can have more zones" is a > relevant one. Yes, GFP_ZONE_TABLE is too complicated. The patches have 4 advantages as below. * The address zone modifiers have new operation method, that is, user should decide which zone is preferred at first, then give the encoded zone number to bottom 3 bits in GFP mask. That is much direct and clear than before. * No bad zone combination, because user should choose just one address zone modifier always. * Better performance and efficiency, current gfp_zone has to take shifting operation twice for GFP_ZONE_TABLE and GFP_ZONE_BAD. With these patches, gfp_zone() just needs one XOR. * Up to 8 zones can be used. At least it isn't a disadvantage, right? Sincerely, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [External] Re: [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD
From: Michal Hocko [mailto:mho...@kernel.org] Sent: Wednesday, May 23, 2018 2:37 AM > > On Mon 21-05-18 23:20:21, Huaisheng Ye wrote: > > From: Huaisheng Ye> > > > Replace GFP_ZONE_TABLE and GFP_ZONE_BAD with encoded zone number. > > > > Delete ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 from GFP bitmasks, > > the bottom three bits of GFP mask is reserved for storing encoded > > zone number. > > > > The encoding method is XOR. Get zone number from enum zone_type, > > then encode the number with ZONE_NORMAL by XOR operation. > > The goal is to make sure ZONE_NORMAL can be encoded to zero. So, > > the compatibility can be guaranteed, such as GFP_KERNEL and GFP_ATOMIC > > can be used as before. > > > > Reserve __GFP_MOVABLE in bit 3, so that it can continue to be used as > > a flag. Same as before, __GFP_MOVABLE respresents movable migrate type > > for ZONE_DMA, ZONE_DMA32, and ZONE_NORMAL. But when it is enabled with > > __GFP_HIGHMEM, ZONE_MOVABLE shall be returned instead of ZONE_HIGHMEM. > > __GFP_ZONE_MOVABLE is created to realize it. > > > > With this patch, just enabling __GFP_MOVABLE and __GFP_HIGHMEM is not > > enough to get ZONE_MOVABLE from gfp_zone. All callers should use > > GFP_HIGHUSER_MOVABLE or __GFP_ZONE_MOVABLE directly to achieve that. > > > > Decode zone number directly from bottom three bits of flags in gfp_zone. > > The theory of encoding and decoding is, > > A ^ B ^ B = A > > So why is this any better than the current code. Sure I am not a great > fan of GFP_ZONE_TABLE because of how it is incomprehensible but this > doesn't look too much better, yet we are losing a check for incompatible > gfp flags. The diffstat looks really sound but then you just look and > see that the large part is the comment that at least explained the gfp > zone modifiers somehow and the debugging code. So what is the selling > point? Dear Michal, Let me try to reply your questions. Exactly, GFP_ZONE_TABLE is too complicated. I think there are two advantages from the series of patches. 1. XOR operation is simple and efficient, GFP_ZONE_TABLE/BAD need to do twice shift operations, the first is for getting a zone_type and the second is for checking the to be returned type is a correct or not. But with these patch XOR operation just needs to use once. Because the bottom 3 bits of GFP bitmask have been used to represent the encoded zone number, we can say there is no bad zone number if all callers could use it without buggy way. Of course, the returned zone type in gfp_zone needs to be no more than ZONE_MOVABLE. 2. GFP_ZONE_TABLE has limit with the amount of zone types. Current GFP_ZONE_TABLE is 32 bits, in general, there are 4 zone types for most ofX86_64 platform, they are ZONE_DMA, ZONE_DMA32, ZONE_NORMAL and ZONE_MOVABLE. If we want to expand the amount of zone types to larger than 4, the zone shift should be 3. That is to say, a 32 bits zone table is not enough to store all zone types. And the most painful thing is that, current GFP bitmasks' space is quite space-constrained it only have four ___GFP_XXX could be used as below, #define ___GFP_DMA 0x01u #define ___GFP_HIGHMEM 0x02u #define ___GFP_DMA320x04u (___GFP_NORMAL equals to 0x00) If we use the implementation of these patches, there is a maximum of 8 zone types could be used. The method of encoding and decoding is quite simple and users could have an intuitive feeling for this as below, and the most important is that, there is no BAD zone types eventually. A ^ B ^ B = A And by the way, our v3 patches are ready, but the smtp of Gmail is quite unstable for some firewall reason in my side, I will try to resend them ASAP. Sincerely, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [External] Re: [RFC PATCH v2 10/12] mm/zsmalloc: update usage of address zone modifiers
From: owner-linux...@kvack.org On Behalf Of Matthew Wilcox > > On Mon, May 21, 2018 at 11:20:31PM +0800, Huaisheng Ye wrote: > > @@ -343,7 +343,7 @@ static void destroy_cache(struct zs_pool *pool) > > static unsigned long cache_alloc_handle(struct zs_pool *pool, gfp_t gfp) > > { > > return (unsigned long)kmem_cache_alloc(pool->handle_cachep, > > - gfp & ~(__GFP_HIGHMEM|__GFP_MOVABLE)); > > + gfp & ~__GFP_ZONE_MOVABLE); > > } > > This should be & ~GFP_ZONEMASK > > Actually, we should probably have a function to clear those bits rather > than have every driver manipulating the gfp mask like this. Maybe > > #define gfp_normal(gfp) ((gfp) & ~GFP_ZONEMASK) Good idea! > > return (unsigned long)kmem_cache_alloc(pool->handle_cachep, > - gfp & ~(__GFP_HIGHMEM|__GFP_MOVABLE)); > + gfp_normal(gfp)); Sincerely, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD
From: owner-linux...@kvack.org On Behalf Of Christoph Hellwig > This seems to be missing patch 1 and generally be in somewhat odd format. > Can you try to resend it with git-send-email and against current Linus' > tree? > Sure, I will rebase them to current mainline ASAP. > Also I'd suggest you do cleanups like adding and using __GFP_ZONE_MASK > at the beginning of the series before doing any real changes. Ok, thanks for your suggestion. Sincerely, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [External] Re: [RFC PATCH v2 02/12] arch/x86/kernel/amd_gart_64: update usage of address zone modifiers
From: owner-linux...@kvack.org On Behalf Of Christoph Hellwig > > This code doesn't exist in current mainline. What kernel version > is your patch against? > > On Mon, May 21, 2018 at 11:20:23PM +0800, Huaisheng Ye wrote: > > From: Huaisheng Ye> > > > Use __GFP_ZONE_MASK to replace (__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32). > > > > ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP > > bitmasks, the bottom three bits of GFP mask is reserved for storing > > encoded zone number. > > __GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated by OR. > > If they have already been deleted the identifier should not exist > anymore, so either your patch has issues, or at least the description. Dear Christoph, The kernel version of my patches against is Linux 4.16, the most of modifications come from include/Linux/gfp.h. I think they should be pushed to Linux-mm, so I follow the requirement of maintainers to make patches based on mmotm/master. I just checked the current mainline, yes, (__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32) has been deleted, I can rebase my patches to mainline, and resend them to mail list. Sincerely, Huaisheng Ye ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH v2 09/12] mm/vmpressure: update usage of address zone modifiers
Use __GFP_ZONE_MOVABLE to replace (__GFP_HIGHMEM | __GFP_MOVABLE). ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP bitmasks, the bottom three bits of GFP mask is reserved for storing encoded zone number. __GFP_ZONE_MOVABLE contains encoded ZONE_MOVABLE and __GFP_MOVABLE flag. With GFP_ZONE_TABLE, __GFP_HIGHMEM ORing __GFP_MOVABLE means gfp_zone should return ZONE_MOVABLE. In order to keep that compatible with GFP_ZONE_TABLE, replace (__GFP_HIGHMEM | __GFP_MOVABLE) with __GFP_ZONE_MOVABLE. Signed-off-by: Huaisheng YeCc: Andrew Morton Cc: zhongjiang Cc: Minchan Kim Cc: Dan Carpenter Cc: David Rientjes --- mm/vmpressure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmpressure.c b/mm/vmpressure.c index 85350ce..30a40e2 100644 --- a/mm/vmpressure.c +++ b/mm/vmpressure.c @@ -256,7 +256,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree, * Indirect reclaim (kswapd) sets sc->gfp_mask to GFP_KERNEL, so * we account it too. */ - if (!(gfp & (__GFP_HIGHMEM | __GFP_MOVABLE | __GFP_IO | __GFP_FS))) + if (!(gfp & (__GFP_ZONE_MOVABLE | __GFP_IO | __GFP_FS))) return; /* -- 1.8.3.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH v2 08/12] drivers/block/zram/zram_drv: update usage of address zone modifiers
Use __GFP_ZONE_MOVABLE to replace (__GFP_HIGHMEM | __GFP_MOVABLE). ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP bitmasks, the bottom three bits of GFP mask is reserved for storing encoded zone number. __GFP_ZONE_MOVABLE contains encoded ZONE_MOVABLE and __GFP_MOVABLE flag. With GFP_ZONE_TABLE, __GFP_HIGHMEM ORing __GFP_MOVABLE means gfp_zone should return ZONE_MOVABLE. In order to keep that compatible with GFP_ZONE_TABLE, replace (__GFP_HIGHMEM | __GFP_MOVABLE) with __GFP_ZONE_MOVABLE. Signed-off-by: Huaisheng YeCc: Minchan Kim Cc: Nitin Gupta Cc: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 0afa6c8..39cb7d6 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -997,14 +997,12 @@ static int __zram_bvec_write(struct zram *zram, struct bio_vec *bvec, handle = zs_malloc(zram->mem_pool, comp_len, __GFP_KSWAPD_RECLAIM | __GFP_NOWARN | - __GFP_HIGHMEM | - __GFP_MOVABLE); + __GFP_ZONE_MOVABLE); if (!handle) { zcomp_stream_put(zram->comp); atomic64_inc(>stats.writestall); handle = zs_malloc(zram->mem_pool, comp_len, - GFP_NOIO | __GFP_HIGHMEM | - __GFP_MOVABLE); + GFP_NOIO | __GFP_ZONE_MOVABLE); if (handle) goto compress_again; return -ENOMEM; -- 1.8.3.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH v2 07/12] fs/btrfs/extent_io: update usage of address zone modifiers
Use __GFP_ZONE_MASK to replace (__GFP_DMA32 | __GFP_HIGHMEM). In function alloc_extent_state, it is obvious that __GFP_DMA is not the expecting zone type. ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP bitmasks, the bottom three bits of GFP mask is reserved for storing encoded zone number. __GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated with each others by OR. Signed-off-by: Huaisheng YeCc: Chris Mason Cc: Josef Bacik Cc: David Sterba --- fs/btrfs/extent_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index dfeb74a..6653e9a 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -220,7 +220,7 @@ static struct extent_state *alloc_extent_state(gfp_t mask) * The given mask might be not appropriate for the slab allocator, * drop the unsupported bits */ - mask &= ~(__GFP_DMA32|__GFP_HIGHMEM); + mask &= ~__GFP_ZONE_MASK; state = kmem_cache_alloc(extent_state_cache, mask); if (!state) return state; -- 1.8.3.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH v2 06/12] drivers/xen/swiotlb-xen: update usage of address zone modifiers
Use __GFP_ZONE_MASK to replace (__GFP_DMA | __GFP_HIGHMEM). In function xen_swiotlb_alloc_coherent, it is obvious that __GFP_DMA32 is not the expecting zone type. ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP bitmasks, the bottom three bits of GFP mask is reserved for storing encoded zone number. __GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated with each others by OR. Signed-off-by: Huaisheng YeCc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: Juergen Gross --- drivers/xen/swiotlb-xen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 5bb72d3..00e8368 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -315,7 +315,7 @@ int __ref xen_swiotlb_init(int verbose, bool early) * machine physical layout. We can't allocate highmem * because we can't return a pointer to it. */ - flags &= ~(__GFP_DMA | __GFP_HIGHMEM); + flags &= ~__GFP_ZONE_MASK; /* On ARM this function returns an ioremap'ped virtual address for * which virt_to_phys doesn't return the corresponding physical -- 1.8.3.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu