Re: [PATCH] iommu/sun50i: Fix set-but-not-used variable warning

2020-09-07 Thread Maxime Ripard 
On Fri, Sep 04, 2020 at 01:39:06PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel 
> 
> Fix the following warning the the SUN50I driver:
> 
>drivers/iommu/sun50i-iommu.c: In function 'sun50i_iommu_irq':
>drivers/iommu/sun50i-iommu.c:890:14: warning: variable 'iova' set but not 
> used [-Wunused-but-set-variable]
>  890 |  phys_addr_t iova;
>  |  ^~~~
> 
> Reported-by: kernel test robot 
> Signed-off-by: Joerg Roedel 

Acked-by: Maxime Ripard 

Thanks!
Maxime
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH] iommu/sun50i: Fix set-but-not-used variable warning

2020-09-04 Thread Joerg Roedel 
From: Joerg Roedel 

Fix the following warning the the SUN50I driver:

   drivers/iommu/sun50i-iommu.c: In function 'sun50i_iommu_irq':
   drivers/iommu/sun50i-iommu.c:890:14: warning: variable 'iova' set but not 
used [-Wunused-but-set-variable]
 890 |  phys_addr_t iova;
 |  ^~~~

Reported-by: kernel test robot 
Signed-off-by: Joerg Roedel 
---
 drivers/iommu/sun50i-iommu.c | 15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c
index 3b1bf2fb94f5..ea6db1341916 100644
--- a/drivers/iommu/sun50i-iommu.c
+++ b/drivers/iommu/sun50i-iommu.c
@@ -881,7 +881,6 @@ static phys_addr_t sun50i_iommu_handle_perm_irq(struct 
sun50i_iommu *iommu)
 static irqreturn_t sun50i_iommu_irq(int irq, void *dev_id)
 {
struct sun50i_iommu *iommu = dev_id;
-   phys_addr_t iova;
u32 status;
 
spin_lock(>iommu_lock);
@@ -893,15 +892,15 @@ static irqreturn_t sun50i_iommu_irq(int irq, void *dev_id)
}
 
if (status & IOMMU_INT_INVALID_L2PG)
-   iova = sun50i_iommu_handle_pt_irq(iommu,
- IOMMU_INT_ERR_ADDR_L2_REG,
- IOMMU_L2PG_INT_REG);
+   sun50i_iommu_handle_pt_irq(iommu,
+   IOMMU_INT_ERR_ADDR_L2_REG,
+   IOMMU_L2PG_INT_REG);
else if (status & IOMMU_INT_INVALID_L1PG)
-   iova = sun50i_iommu_handle_pt_irq(iommu,
- IOMMU_INT_ERR_ADDR_L1_REG,
- IOMMU_L1PG_INT_REG);
+   sun50i_iommu_handle_pt_irq(iommu,
+  IOMMU_INT_ERR_ADDR_L1_REG,
+  IOMMU_L1PG_INT_REG);
else
-   iova = sun50i_iommu_handle_perm_irq(iommu);
+   sun50i_iommu_handle_perm_irq(iommu);
 
iommu_write(iommu, IOMMU_INT_CLR_REG, status);
 
-- 
2.26.2

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu