Re: [PATCH 2/7] da8xx-fb: pass struct device to DMA API functions

2019-04-03 Thread Bartlomiej Zolnierkiewicz


On 03/21/2019 11:52 PM, Christoph Hellwig wrote:
> The DMA API generally relies on a struct device to work properly, and
> only barely works without one for legacy reasons.  Pass the easily
> available struct device from the platform_device to remedy this.
> 
> Signed-off-by: Christoph Hellwig 

Acked-by: Bartlomiej Zolnierkiewicz 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


[PATCH 2/7] da8xx-fb: pass struct device to DMA API functions

2019-03-21 Thread Christoph Hellwig
The DMA API generally relies on a struct device to work properly, and
only barely works without one for legacy reasons.  Pass the easily
available struct device from the platform_device to remedy this.

Signed-off-by: Christoph Hellwig 
---
 drivers/video/fbdev/da8xx-fb.c | 13 +++--
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index 43f2a4816860..ec62274b914b 100644
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1097,9 +1097,9 @@ static int fb_remove(struct platform_device *dev)
 
unregister_framebuffer(info);
fb_dealloc_cmap(>cmap);
-   dma_free_coherent(NULL, PALETTE_SIZE, par->v_palette_base,
+   dma_free_coherent(par->dev, PALETTE_SIZE, par->v_palette_base,
  par->p_palette_base);
-   dma_free_coherent(NULL, par->vram_size, par->vram_virt,
+   dma_free_coherent(par->dev, par->vram_size, par->vram_virt,
  par->vram_phys);
pm_runtime_put_sync(>dev);
pm_runtime_disable(>dev);
@@ -1425,7 +1425,7 @@ static int fb_probe(struct platform_device *device)
par->vram_size = roundup(par->vram_size/8, ulcm);
par->vram_size = par->vram_size * LCD_NUM_BUFFERS;
 
-   par->vram_virt = dma_alloc_coherent(NULL,
+   par->vram_virt = dma_alloc_coherent(par->dev,
par->vram_size,
>vram_phys,
GFP_KERNEL | GFP_DMA);
@@ -1446,7 +1446,7 @@ static int fb_probe(struct platform_device *device)
da8xx_fb_fix.line_length - 1;
 
/* allocate palette buffer */
-   par->v_palette_base = dma_alloc_coherent(NULL, PALETTE_SIZE,
+   par->v_palette_base = dma_alloc_coherent(par->dev, PALETTE_SIZE,
 >p_palette_base,
 GFP_KERNEL | GFP_DMA);
if (!par->v_palette_base) {
@@ -1532,11 +1532,12 @@ static int fb_probe(struct platform_device *device)
fb_dealloc_cmap(_fb_info->cmap);
 
 err_release_pl_mem:
-   dma_free_coherent(NULL, PALETTE_SIZE, par->v_palette_base,
+   dma_free_coherent(par->dev, PALETTE_SIZE, par->v_palette_base,
  par->p_palette_base);
 
 err_release_fb_mem:
-   dma_free_coherent(NULL, par->vram_size, par->vram_virt, par->vram_phys);
+   dma_free_coherent(par->dev, par->vram_size, par->vram_virt,
+ par->vram_phys);
 
 err_release_fb:
framebuffer_release(da8xx_fb_info);
-- 
2.20.1

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu