Re: [PATCH v1 3/4] iommu/tegra: gart: Move PFN validation out of spinlock

[Thierry Reding]

On Wed, Jul 05, 2017 at 07:29:47PM +0300, Dmitry Osipenko wrote:
> Validation of page frame number doesn't require protection with a spinlock,
> let's move it out of spinlock for consistency.
> 
> Signed-off-by: Dmitry Osipenko 
> ---
>  drivers/iommu/tegra-gart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Thierry Reding 


signature.asc
Description: PGP signature
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH v1 3/4] iommu/tegra: gart: Move PFN validation out of spinlock

[Dmitry Osipenko]

Validation of page frame number doesn't require protection with a spinlock,
let's move it out of spinlock for consistency.

Signed-off-by: Dmitry Osipenko 
---
 drivers/iommu/tegra-gart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index 54699e341110..55fdb56d85ea 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -276,13 +276,13 @@ static int gart_iommu_map(struct iommu_domain *domain, 
unsigned long iova,
if (!gart_iova_range_valid(gart, iova, bytes))
return -EINVAL;
 
-   spin_lock_irqsave(>pte_lock, flags);
pfn = __phys_to_pfn(pa);
if (!pfn_valid(pfn)) {
dev_err(gart->dev, "Invalid page: %pa\n", );
-   spin_unlock_irqrestore(>pte_lock, flags);
return -EINVAL;
}
+
+   spin_lock_irqsave(>pte_lock, flags);
pte = gart_read_pte(gart, iova);
if (pte & GART_ENTRY_PHYS_ADDR_VALID) {
spin_unlock_irqrestore(>pte_lock, flags);
-- 
2.13.2

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu