Re: [PATCH v2 0/7] IOMMU: Groups support
On Wed, May 30, 2012 at 02:18:29PM -0600, Alex Williamson wrote: Alex Williamson (7): iommu: Remove group_mf intel-iommu: Make use of DMA quirks and ACS checks in IOMMU groups amd_iommu: Make use of DMA quirks and ACS checks in IOMMU groups intel-iommu: Support IOMMU groups amd_iommu: Support IOMMU groups iommu: IOMMU Groups driver core: Add iommu_group tracking to struct device .../ABI/testing/sysfs-kernel-iommu_groups | 14 Documentation/kernel-parameters.txt|1 arch/ia64/include/asm/iommu.h |2 arch/ia64/kernel/pci-dma.c |1 arch/x86/include/asm/iommu.h |1 arch/x86/kernel/pci-dma.c | 11 drivers/iommu/amd_iommu.c | 70 ++ drivers/iommu/intel-iommu.c| 89 ++- drivers/iommu/iommu.c | 578 +++- include/linux/device.h |2 include/linux/iommu.h | 104 +++- 11 files changed, 767 insertions(+), 106 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-kernel-iommu_groups Applied and pushed all of them. Thanks a lot, Alex. -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 0/7] IOMMU: Groups support
Hi, On Mon, Jun 18, 2012 at 11:31:43AM -0600, Alex Williamson wrote: Anyone? Alexey BenH, I know you're familiar with IOMMU groups, please give Joerg some kind of indication that you approve of this for POWER. David Woodhouse, these patches touch intel-iommu, please ack or comment: https://lkml.org/lkml/2012/5/30/445 https://lkml.org/lkml/2012/5/30/450 Joerg, maybe we can just add CC: to the commit log? Thanks, Well, we can't hold up things forever. Given that the POWER guys had long discussions with you about previous versions but not about this one counts as a silent Ack for me ;) So I already applied the patches into my local tree yesterday and gave them some additional testing. All looks good so far. I think I will push the result soon to get this into linux-next. I'll probably rebase to add the Cc's to the commits before pushing it out. Regards, Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 0/7] IOMMU: Groups support
Anyone? Alexey BenH, I know you're familiar with IOMMU groups, please give Joerg some kind of indication that you approve of this for POWER. David Woodhouse, these patches touch intel-iommu, please ack or comment: https://lkml.org/lkml/2012/5/30/445 https://lkml.org/lkml/2012/5/30/450 Joerg, maybe we can just add CC: to the commit log? Thanks, Alex On Mon, 2012-06-11 at 09:37 -0600, Alex Williamson wrote: On Wed, 2012-06-06 at 13:05 +0200, Joerg Roedel wrote: On Wed, May 30, 2012 at 02:18:29PM -0600, Alex Williamson wrote: v2: - Trickle down changes from pci_get_dma_source() to better handle PCI device reference counting in IOMMU driver patches Okay, I looked again over the code and looks good for merging to me. Great, thanks Joerg! The IOMMU Groups code depends on changes in the PCI code. We need to work out how to merge this. Bjorn, I need the PCI changes before I can merge the IOMMU Groups code. There are two ways that would work for me: a) You Ack the PCI patch-set from Alex and I put it into my tree and merge the IOMMU Group code on-top, or b) You merge the PCI related patch-set into a seperate branch which you can merge into your next-branch and which I can pull in to merge IOMMU Groups on-top. Please let me know what works best for you. I also poked Bjorn with a minor v3 spin on his series, no change to this series. What I would also appreciate are a few more Acks from other IOMMU maintainers (David W.?) and from the Power side. Alexey, BenH, can either of you comment on this series from the POWER side? I know Alexey has an implementation of VFIO/Qemu device assignment working on POWER with this series. David Woodhouse, any comments? Thanks, Alex ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 0/7] IOMMU: Groups support
On Wed, 2012-06-06 at 13:05 +0200, Joerg Roedel wrote: On Wed, May 30, 2012 at 02:18:29PM -0600, Alex Williamson wrote: v2: - Trickle down changes from pci_get_dma_source() to better handle PCI device reference counting in IOMMU driver patches Okay, I looked again over the code and looks good for merging to me. Great, thanks Joerg! The IOMMU Groups code depends on changes in the PCI code. We need to work out how to merge this. Bjorn, I need the PCI changes before I can merge the IOMMU Groups code. There are two ways that would work for me: a) You Ack the PCI patch-set from Alex and I put it into my tree and merge the IOMMU Group code on-top, or b) You merge the PCI related patch-set into a seperate branch which you can merge into your next-branch and which I can pull in to merge IOMMU Groups on-top. Please let me know what works best for you. I also poked Bjorn with a minor v3 spin on his series, no change to this series. What I would also appreciate are a few more Acks from other IOMMU maintainers (David W.?) and from the Power side. Alexey, BenH, can either of you comment on this series from the POWER side? I know Alexey has an implementation of VFIO/Qemu device assignment working on POWER with this series. David Woodhouse, any comments? Thanks, Alex ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 0/7] IOMMU: Groups support
On Mon, Jun 11, 2012 at 8:37 AM, Alex Williamson alex.william...@redhat.com wrote: On Wed, 2012-06-06 at 13:05 +0200, Joerg Roedel wrote: On Wed, May 30, 2012 at 02:18:29PM -0600, Alex Williamson wrote: v2: - Trickle down changes from pci_get_dma_source() to better handle PCI device reference counting in IOMMU driver patches Okay, I looked again over the code and looks good for merging to me. Great, thanks Joerg! The IOMMU Groups code depends on changes in the PCI code. We need to work out how to merge this. Bjorn, I need the PCI changes before I can merge the IOMMU Groups code. There are two ways that would work for me: a) You Ack the PCI patch-set from Alex and I put it into my tree and merge the IOMMU Group code on-top, or b) You merge the PCI related patch-set into a seperate branch which you can merge into your next-branch and which I can pull in to merge IOMMU Groups on-top. Please let me know what works best for you. Joerg, I put the PCI changes into my next branch (http://git.kernel.org/?p=linux/kernel/git/helgaas/pci.git;a=shortlog;h=refs/heads/next). My feeble excuse is that I was on vacation last week, but that's pretty lame because this has been hanging for much longer than that. Bjorn ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu