Re: [PATCH v2 1/2] iommu/ipmmu-vmsa: Modify ipmmu_slave_whitelist() to check SoC revisions

2018-11-29 Thread Simon Horman
On Wed, Nov 28, 2018 at 09:23:36AM +, Yoshihiro Shimoda wrote:
> Some R-Car Gen3 SoCs has hardware restrictions on the IPMMU. So,
> to check whether this R-Car Gen3 SoC can use the IPMMU correctly,
> this patch modifies the ipmmu_slave_whitelist().
> 
> Signed-off-by: Yoshihiro Shimoda 
> Reviewed-by: Geert Uytterhoeven 

Reviewed-by: Simon Horman 
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


[PATCH v2 1/2] iommu/ipmmu-vmsa: Modify ipmmu_slave_whitelist() to check SoC revisions

2018-11-28 Thread Yoshihiro Shimoda
Some R-Car Gen3 SoCs has hardware restrictions on the IPMMU. So,
to check whether this R-Car Gen3 SoC can use the IPMMU correctly,
this patch modifies the ipmmu_slave_whitelist().

Signed-off-by: Yoshihiro Shimoda 
Reviewed-by: Geert Uytterhoeven 
---
 drivers/iommu/ipmmu-vmsa.c | 34 ++
 1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 9e2655f..5f88031 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -754,12 +754,6 @@ static int ipmmu_init_platform_device(struct device *dev,
return 0;
 }
 
-static bool ipmmu_slave_whitelist(struct device *dev)
-{
-   /* By default, do not allow use of IPMMU */
-   return false;
-}
-
 static const struct soc_device_attribute soc_rcar_gen3[] = {
{ .soc_id = "r8a774a1", },
{ .soc_id = "r8a7795", },
@@ -771,11 +765,35 @@ static bool ipmmu_slave_whitelist(struct device *dev)
{ /* sentinel */ }
 };
 
+static const struct soc_device_attribute soc_rcar_gen3_whitelist[] = {
+   { .soc_id = "r8a7795", .revision = "ES3.*" },
+   { .soc_id = "r8a77965", },
+   { .soc_id = "r8a77990", },
+   { .soc_id = "r8a77995", },
+   { /* sentinel */ }
+};
+
+static bool ipmmu_slave_whitelist(struct device *dev)
+{
+   /*
+* For R-Car Gen3 use a white list to opt-in slave devices.
+* For Other SoCs, this returns true anyway.
+*/
+   if (!soc_device_match(soc_rcar_gen3))
+   return true;
+
+   /* Check whether this R-Car Gen3 can use the IPMMU correctly or not */
+   if (!soc_device_match(soc_rcar_gen3_whitelist))
+   return false;
+
+   /* By default, do not allow use of IPMMU */
+   return false;
+}
+
 static int ipmmu_of_xlate(struct device *dev,
  struct of_phandle_args *spec)
 {
-   /* For R-Car Gen3 use a white list to opt-in slave devices */
-   if (soc_device_match(soc_rcar_gen3) && !ipmmu_slave_whitelist(dev))
+   if (!ipmmu_slave_whitelist(dev))
return -ENODEV;
 
iommu_fwspec_add_ids(dev, spec->args, 1);
-- 
1.9.1

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu