Re: [PATCH v3 09/25] iommu/sprd: Drop IOVA cookie management

[Chunyan Zhang]

On Thu, Aug 5, 2021 at 1:18 AM Robin Murphy  wrote:
>
> The core code bakes its own cookies now.
>
> CC: Chunyan Zhang 
> Signed-off-by: Robin Murphy 

Thank you for the patch!

Acked-by: Chunyan Zhang 

>
> ---
>
> v3: Also remove unneeded include
> ---
>  drivers/iommu/sprd-iommu.c | 7 ---
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
> index 73dfd9946312..27ac818b0354 100644
> --- a/drivers/iommu/sprd-iommu.c
> +++ b/drivers/iommu/sprd-iommu.c
> @@ -8,7 +8,6 @@
>
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> @@ -144,11 +143,6 @@ static struct iommu_domain 
> *sprd_iommu_domain_alloc(unsigned int domain_type)
> if (!dom)
> return NULL;
>
> -   if (iommu_get_dma_cookie(&dom->domain)) {
> -   kfree(dom);
> -   return NULL;
> -   }
> -
> spin_lock_init(&dom->pgtlock);
>
> dom->domain.geometry.aperture_start = 0;
> @@ -161,7 +155,6 @@ static void sprd_iommu_domain_free(struct iommu_domain 
> *domain)
>  {
> struct sprd_iommu_domain *dom = to_sprd_domain(domain);
>
> -   iommu_put_dma_cookie(domain);
> kfree(dom);
>  }
>
> --
> 2.25.1
>
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH v3 09/25] iommu/sprd: Drop IOVA cookie management

[Robin Murphy]

The core code bakes its own cookies now.

CC: Chunyan Zhang 
Signed-off-by: Robin Murphy 

---

v3: Also remove unneeded include
---
 drivers/iommu/sprd-iommu.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
index 73dfd9946312..27ac818b0354 100644
--- a/drivers/iommu/sprd-iommu.c
+++ b/drivers/iommu/sprd-iommu.c
@@ -8,7 +8,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -144,11 +143,6 @@ static struct iommu_domain 
*sprd_iommu_domain_alloc(unsigned int domain_type)
if (!dom)
return NULL;
 
-   if (iommu_get_dma_cookie(&dom->domain)) {
-   kfree(dom);
-   return NULL;
-   }
-
spin_lock_init(&dom->pgtlock);
 
dom->domain.geometry.aperture_start = 0;
@@ -161,7 +155,6 @@ static void sprd_iommu_domain_free(struct iommu_domain 
*domain)
 {
struct sprd_iommu_domain *dom = to_sprd_domain(domain);
 
-   iommu_put_dma_cookie(domain);
kfree(dom);
 }
 
-- 
2.25.1

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu