Re: [PATCH v6 00/21] IOMMU: Tegra GART driver clean up and optimization
On 12.12.2018 13:43, Joerg Roedel wrote: > Hi Thierry, Hi Dmitry, > > On Wed, Dec 12, 2018 at 11:24:15AM +0100, Thierry Reding wrote: >> So appart from the one issue in the "memory controller integration" >> patch this looks good and I've acked the remaining patches. Once the one >> remaining issue is fixed I think this is ready to be merged. >> >> Joerg, given the dependencies between the various parts of the series, I >> think it may be better for you to merge everything through the IOMMU >> tree if you don't mind. > > Sounds good. Dmitry, can you please address Thierry's comments on patch > 13, add his Acks on the other patches and re-send? I'll queue it in the > iommu-tree then. Sure, thanks to you both! ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v6 00/21] IOMMU: Tegra GART driver clean up and optimization
Hi Thierry, Hi Dmitry, On Wed, Dec 12, 2018 at 11:24:15AM +0100, Thierry Reding wrote: > So appart from the one issue in the "memory controller integration" > patch this looks good and I've acked the remaining patches. Once the one > remaining issue is fixed I think this is ready to be merged. > > Joerg, given the dependencies between the various parts of the series, I > think it may be better for you to merge everything through the IOMMU > tree if you don't mind. Sounds good. Dmitry, can you please address Thierry's comments on patch 13, add his Acks on the other patches and re-send? I'll queue it in the iommu-tree then. Regards, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v6 00/21] IOMMU: Tegra GART driver clean up and optimization
On Tue, Dec 11, 2018 at 10:53:17AM +0100, Joerg Roedel wrote: > On Sun, Dec 09, 2018 at 11:29:29PM +0300, Dmitry Osipenko wrote: > > Dmitry Osipenko (21): > > iommu/tegra: gart: Remove pr_fmt and clean up includes > > iommu/tegra: gart: Clean up driver probe errors handling > > iommu/tegra: gart: Ignore devices without IOMMU phandle in DT > > iommu: Introduce iotlb_sync_map callback > > iommu/tegra: gart: Optimize mapping / unmapping performance > > dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc > > ARM: dts: tegra20: Update Memory Controller node to the new binding > > memory: tegra: Don't invoke Tegra30+ specific memory timing setup on > > Tegra20 > > memory: tegra: Adapt to Tegra20 device-tree binding changes > > memory: tegra: Read client ID on GART page fault > > memory: tegra: Use of_device_get_match_data() > > memory: tegra: Use relaxed versions of readl/writel > > iommu/tegra: gart: Integrate with Memory Controller driver > > iommu/tegra: gart: Fix spinlock recursion > > iommu/tegra: gart: Fix NULL pointer dereference > > iommu/tegra: gart: Allow only one active domain at a time > > iommu/tegra: gart: Don't use managed resources > > iommu/tegra: gart: Prepend error/debug messages with "gart:" > > iommu/tegra: gart: Don't detach devices from inactive domains > > iommu/tegra: gart: Simplify clients-tracking code > > iommu/tegra: gart: Perform code refactoring > > This is making progress, but some parts have no Ack or Review yet, I'll > wait for Thierry before applying these patches into the iommu tree. So appart from the one issue in the "memory controller integration" patch this looks good and I've acked the remaining patches. Once the one remaining issue is fixed I think this is ready to be merged. Joerg, given the dependencies between the various parts of the series, I think it may be better for you to merge everything through the IOMMU tree if you don't mind. Thierry signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v6 00/21] IOMMU: Tegra GART driver clean up and optimization
On 11.12.2018 12:53, Joerg Roedel wrote: > On Sun, Dec 09, 2018 at 11:29:29PM +0300, Dmitry Osipenko wrote: >> Dmitry Osipenko (21): >> iommu/tegra: gart: Remove pr_fmt and clean up includes >> iommu/tegra: gart: Clean up driver probe errors handling >> iommu/tegra: gart: Ignore devices without IOMMU phandle in DT >> iommu: Introduce iotlb_sync_map callback >> iommu/tegra: gart: Optimize mapping / unmapping performance >> dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc >> ARM: dts: tegra20: Update Memory Controller node to the new binding >> memory: tegra: Don't invoke Tegra30+ specific memory timing setup on >> Tegra20 >> memory: tegra: Adapt to Tegra20 device-tree binding changes >> memory: tegra: Read client ID on GART page fault >> memory: tegra: Use of_device_get_match_data() >> memory: tegra: Use relaxed versions of readl/writel >> iommu/tegra: gart: Integrate with Memory Controller driver >> iommu/tegra: gart: Fix spinlock recursion >> iommu/tegra: gart: Fix NULL pointer dereference >> iommu/tegra: gart: Allow only one active domain at a time >> iommu/tegra: gart: Don't use managed resources >> iommu/tegra: gart: Prepend error/debug messages with "gart:" >> iommu/tegra: gart: Don't detach devices from inactive domains >> iommu/tegra: gart: Simplify clients-tracking code >> iommu/tegra: gart: Perform code refactoring > > This is making progress, but some parts have no Ack or Review yet, I'll > wait for Thierry before applying these patches into the iommu tree. Okay, waiting.. zZZ :) Pretty much all of the patches are actually reviewed, those that are missing review/ack tags just have changes that were requested in a review comments to the previous version of the series. I hope it won't take much time to finalize the review of the patches. Thierry, could you please acknowledge that you'll come back to these patches? More than two months passed since the last time you were replying regarding this series. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v6 00/21] IOMMU: Tegra GART driver clean up and optimization
On Sun, Dec 09, 2018 at 11:29:29PM +0300, Dmitry Osipenko wrote: > Dmitry Osipenko (21): > iommu/tegra: gart: Remove pr_fmt and clean up includes > iommu/tegra: gart: Clean up driver probe errors handling > iommu/tegra: gart: Ignore devices without IOMMU phandle in DT > iommu: Introduce iotlb_sync_map callback > iommu/tegra: gart: Optimize mapping / unmapping performance > dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc > ARM: dts: tegra20: Update Memory Controller node to the new binding > memory: tegra: Don't invoke Tegra30+ specific memory timing setup on > Tegra20 > memory: tegra: Adapt to Tegra20 device-tree binding changes > memory: tegra: Read client ID on GART page fault > memory: tegra: Use of_device_get_match_data() > memory: tegra: Use relaxed versions of readl/writel > iommu/tegra: gart: Integrate with Memory Controller driver > iommu/tegra: gart: Fix spinlock recursion > iommu/tegra: gart: Fix NULL pointer dereference > iommu/tegra: gart: Allow only one active domain at a time > iommu/tegra: gart: Don't use managed resources > iommu/tegra: gart: Prepend error/debug messages with "gart:" > iommu/tegra: gart: Don't detach devices from inactive domains > iommu/tegra: gart: Simplify clients-tracking code > iommu/tegra: gart: Perform code refactoring This is making progress, but some parts have no Ack or Review yet, I'll wait for Thierry before applying these patches into the iommu tree. Regards, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH v6 00/21] IOMMU: Tegra GART driver clean up and optimization
Hello, This patch-series integrates the GART (IOMMU) driver with the Memory Controller driver, that allows to report the name of a faulty memory client on GART page fault. A major code clean up and performance optimization is performed in this series as well. Changelog: v6: v5 that is re-based on the recent linux-next. v5: Addressed review comments from Thierry Reding to v4. Added WARN_ON() to make sure that active domain isn't getting released, kept include headers where necessary, etc.. All changes are quite minor. Added new patch "memory: tegra: Use relaxed versions of readl/writel". v4: In the v3 Rob Herring requested to make device-tree binding changes backwards-compatible with the older kernels, that is achieved by changing the 'compatible' value of the DT node. The code-refactoring patches got some more (minor) polish. Added new patch "memory: tegra: Use of_device_get_match_data()". v3: Memory Controller integration part has been reworked and now GART's device-tree binding is changed. Adding Rob Herring for the device-tree changes reviewing. GART now disallows more than one active domain at a time. Fixed "spinlock recursion", "NULL pointer dereference" and "detaching of all devices from inactive domains". New code-refactoring patches. The previously standalone patch "memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20" is now included into this series because there is a dependency on that patch and it wasn't applied yet. v2: Addressed review comments from Robin Murphy to v1 by moving devices iommu_fwspec check to gart_iommu_add_device(). Dropped the "Provide single domain and group for all devices" patch from the series for now because after some more considering it became not exactly apparent whether that is what we need, that was also suggested by Robin Murphy in the review comment. Maybe something like a runtime IOMMU usage for devices would be a better solution, allowing to implement transparent context switching of virtual IOMMU domains. Some very minor code cleanups, reworded commit messages. Dmitry Osipenko (21): iommu/tegra: gart: Remove pr_fmt and clean up includes iommu/tegra: gart: Clean up driver probe errors handling iommu/tegra: gart: Ignore devices without IOMMU phandle in DT iommu: Introduce iotlb_sync_map callback iommu/tegra: gart: Optimize mapping / unmapping performance dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc ARM: dts: tegra20: Update Memory Controller node to the new binding memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 memory: tegra: Adapt to Tegra20 device-tree binding changes memory: tegra: Read client ID on GART page fault memory: tegra: Use of_device_get_match_data() memory: tegra: Use relaxed versions of readl/writel iommu/tegra: gart: Integrate with Memory Controller driver iommu/tegra: gart: Fix spinlock recursion iommu/tegra: gart: Fix NULL pointer dereference iommu/tegra: gart: Allow only one active domain at a time iommu/tegra: gart: Don't use managed resources iommu/tegra: gart: Prepend error/debug messages with "gart:" iommu/tegra: gart: Don't detach devices from inactive domains iommu/tegra: gart: Simplify clients-tracking code iommu/tegra: gart: Perform code refactoring .../bindings/iommu/nvidia,tegra20-gart.txt| 14 - .../memory-controllers/nvidia,tegra20-mc.txt | 27 +- arch/arm/boot/dts/tegra20.dtsi| 15 +- drivers/iommu/Kconfig | 1 + drivers/iommu/iommu.c | 8 +- drivers/iommu/tegra-gart.c| 470 +++--- drivers/memory/tegra/mc.c | 93 +++- drivers/memory/tegra/mc.h | 10 +- include/linux/iommu.h | 1 + include/soc/tegra/mc.h| 29 +- 10 files changed, 307 insertions(+), 361 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iommu/nvidia,tegra20-gart.txt -- 2.19.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
