Re: [patch] iommu/vt-d: silence an uninitialized variable warning

[Joerg Roedel]

On Wed, Apr 06, 2016 at 09:38:56PM +0300, Dan Carpenter wrote:
> My static checker complains that "dma_alias" is uninitialized unless we
> are dealing with a pci device.  This is true but harmless.  Anyway, we
> can flip the condition around to silence the warning.
> 
> Signed-off-by: Dan Carpenter 

Applied, thanks.

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[patch] iommu/vt-d: silence an uninitialized variable warning

[Dan Carpenter]

My static checker complains that "dma_alias" is uninitialized unless we
are dealing with a pci device.  This is true but harmless.  Anyway, we
can flip the condition around to silence the warning.

Signed-off-by: Dan Carpenter 

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a2e1b7f..e1852e8 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -2458,7 +2458,7 @@ static struct dmar_domain *get_domain_for_dev(struct 
device *dev, int gaw)
}
 
/* register PCI DMA alias device */
-   if (req_id != dma_alias && dev_is_pci(dev)) {
+   if (dev_is_pci(dev) && req_id != dma_alias) {
tmp = dmar_insert_one_dev_info(iommu, PCI_BUS_NUM(dma_alias),
   dma_alias & 0xff, NULL, domain);
 
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu