Re: [PATCH v9 3/5] block: sort headers on blk-setting.c
Hi Jens, thanks for the feedback. > Please just drop this patch. OK, we will do. And patch 4/5? Is it OK or do you need some more time to think about it? Regards, Wolfram signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [PATCH v9 3/5] block: sort headers on blk-setting.c
Hi Jens, > From: Jens Axboe, Sent: Monday, August 19, 2019 11:54 PM > > On 8/16/19 1:50 PM, Wolfram Sang wrote: > > On Fri, Jul 26, 2019 at 05:31:14PM +0900, Yoshihiro Shimoda wrote: > >> This patch sorts the headers in alphabetic order to ease > >> the maintenance for this part. > >> > >> Signed-off-by: Yoshihiro Shimoda > >> Reviewed-by: Wolfram Sang > >> Reviewed-by: Simon Horman > >> --- > > > > Jens, can we have your ack for this patch so Christoph can take this > > series via his tree (also for patch 4/5)? > > Please just drop this patch. I'm afraid, but would you also review the following patch? https://marc.info/?l=linux-block=156412995120069=2 This patch 4/5 is a main patch of the block subsystem on this patch series. Best regards, Yoshihiro Shimoda > -- > Jens Axboe ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v9 3/5] block: sort headers on blk-setting.c
On 8/16/19 1:50 PM, Wolfram Sang wrote: > On Fri, Jul 26, 2019 at 05:31:14PM +0900, Yoshihiro Shimoda wrote: >> This patch sorts the headers in alphabetic order to ease >> the maintenance for this part. >> >> Signed-off-by: Yoshihiro Shimoda >> Reviewed-by: Wolfram Sang >> Reviewed-by: Simon Horman >> --- > > Jens, can we have your ack for this patch so Christoph can take this > series via his tree (also for patch 4/5)? Please just drop this patch. -- Jens Axboe ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v9 3/5] block: sort headers on blk-setting.c
On Fri, Jul 26, 2019 at 05:31:14PM +0900, Yoshihiro Shimoda wrote: > This patch sorts the headers in alphabetic order to ease > the maintenance for this part. > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Wolfram Sang > Reviewed-by: Simon Horman > --- Jens, can we have your ack for this patch so Christoph can take this series via his tree (also for patch 4/5)? Thanks, Wolfram > block/blk-settings.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/block/blk-settings.c b/block/blk-settings.c > index 2ae348c..45f2c52 100644 > --- a/block/blk-settings.c > +++ b/block/blk-settings.c > @@ -2,16 +2,16 @@ > /* > * Functions related to setting various queue properties from drivers > */ > -#include > -#include > -#include > #include > #include > -#include /* for max_pfn/max_low_pfn */ > #include > -#include > -#include > #include > +#include > +#include > +#include > +#include > +#include /* for max_pfn/max_low_pfn */ > +#include > > #include "blk.h" > #include "blk-wbt.h" > -- > 2.7.4 > signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
