Re: [PATCH 0/6] iommu/amd: Locking Fixes

2019-09-25 Thread Joerg Roedel 
Hi Jerry,

On Wed, Sep 25, 2019 at 05:25:15PM -0700, Jerry Snitselaar wrote:
> On Wed Sep 25 19, Joerg Roedel wrote:
> > Joerg Roedel (6):
> >  iommu/amd: Remove domain->updated
> >  iommu/amd: Remove amd_iommu_devtable_lock
> >  iommu/amd: Take domain->lock for complete attach/detach path
> >  iommu/amd: Check for busy devices earlier in attach_device()
> >  iommu/amd: Lock dev_data in attach/detach code paths
> >  iommu/amd: Lock code paths traversing protection_domain->dev_list
> > 
> > drivers/iommu/amd_iommu.c   | 166 
> > drivers/iommu/amd_iommu_types.h |   4 +-
> > 2 files changed, 85 insertions(+), 85 deletions(-)
> 
> What branch is this on top of in your repo?

This is on-top of my iommu/fixes branch in the iommu-tree.

HTH,

Joerg
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 0/6] iommu/amd: Locking Fixes

2019-09-25 Thread Jerry Snitselaar 

On Wed Sep 25 19, Joerg Roedel wrote:

Hi,

here are a couple of fixes for the amd iommu driver to fix a
few locking issues around protection-domains. Main problem
was that some traversals of ->dev_list were not locked in
any form, causing potential race conditions.

But there are more issues fixed here, for example the racy
access to protection_domain->updated and races in the
attach/detach_device code paths.

Changes are boot-tested with lockdep enabled, looked all
good so far.

Please review.

Thanks,

Joerg

Joerg Roedel (6):
 iommu/amd: Remove domain->updated
 iommu/amd: Remove amd_iommu_devtable_lock
 iommu/amd: Take domain->lock for complete attach/detach path
 iommu/amd: Check for busy devices earlier in attach_device()
 iommu/amd: Lock dev_data in attach/detach code paths
 iommu/amd: Lock code paths traversing protection_domain->dev_list

drivers/iommu/amd_iommu.c   | 166 
drivers/iommu/amd_iommu_types.h |   4 +-
2 files changed, 85 insertions(+), 85 deletions(-)

--
2.17.1

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


Hi Joerg,

What branch is this on top of in your repo?

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu