Re: fully convert arm to use dma-direct v3
On Thu, Jul 07, 2022 at 10:09:27AM +0200, Greg Kroah-Hartman wrote: > > Anyone who has real concerns, please scream now. > > Sounds like a good plan to me, pull it in and let's see if anyone even > notices. Ok, I've added the series to the dma-mapping tree now. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct v3
On Thu, Jul 07, 2022 at 06:58:40AM +0200, Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 08:41:32AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 29, 2022 at 08:28:37AM +0200, Christoph Hellwig wrote: > > > Any comments or additional testing? It would be really great to get > > > this off the table. > > > > For the USB bits: > > > > Acked-by: Greg Kroah-Hartman > > So given that we're not making any progress on getting anyone interested > on the series, I'm tempted to just pull it into the dma-mapping tree > this weekend so that we'll finally have all architectures using the > common code. > > Anyone who has real concerns, please scream now. Sounds like a good plan to me, pull it in and let's see if anyone even notices. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct v3
On Thu, Jul 7, 2022 at 6:58 AM Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 08:41:32AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 29, 2022 at 08:28:37AM +0200, Christoph Hellwig wrote: > > > Any comments or additional testing? It would be really great to get > > > this off the table. > > > > For the USB bits: > > > > Acked-by: Greg Kroah-Hartman > > So given that we're not making any progress on getting anyone interested > on the series, I'm tempted to just pull it into the dma-mapping tree > this weekend so that we'll finally have all architectures using the > common code. Yes, please do! Getting it into linux-next now should give plenty of time to test it with the automated kernelci and lkft systems, as well as Russell's Assabet. I'm sure we can fix up any regressions before this actually hits the 5.20 release. Arnd ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct v3
On Wed, Jun 29, 2022 at 08:41:32AM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 29, 2022 at 08:28:37AM +0200, Christoph Hellwig wrote: > > Any comments or additional testing? It would be really great to get > > this off the table. > > For the USB bits: > > Acked-by: Greg Kroah-Hartman So given that we're not making any progress on getting anyone interested on the series, I'm tempted to just pull it into the dma-mapping tree this weekend so that we'll finally have all architectures using the common code. Anyone who has real concerns, please scream now. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct v3
On Wed, Jun 29, 2022 at 08:28:37AM +0200, Christoph Hellwig wrote: > Any comments or additional testing? It would be really great to get > this off the table. For the USB bits: Acked-by: Greg Kroah-Hartman ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct v3
Any comments or additional testing? It would be really great to get this off the table. On Tue, Jun 14, 2022 at 11:20:37AM +0200, Christoph Hellwig wrote: > Hi all, > > arm is the last platform not using the dma-direct code for directly > mapped DMA. With the dmaboune removal from Arnd we can easily switch > arm to always use dma-direct now (it already does for LPAE configs > and nommu). I'd love to merge this series through the dma-mapping tree > as it gives us the opportunity for additional core dma-mapping > improvements. > > Changes since v2: > - rebased to Linux 5.19-rc2 > > Changes since v1: > - remove another unused function > - improve a few commit logs > - add three more patches from Robin > > Diffstat: > arch/arm/common/dmabounce.c | 582 - > arch/arm/include/asm/dma-mapping.h | 128 --- > b/arch/arm/Kconfig |5 > b/arch/arm/common/Kconfig|6 > b/arch/arm/common/Makefile |1 > b/arch/arm/common/sa.c | 64 - > b/arch/arm/include/asm/device.h |3 > b/arch/arm/include/asm/dma-direct.h | 49 - > b/arch/arm/include/asm/memory.h |2 > b/arch/arm/mach-footbridge/Kconfig |1 > b/arch/arm/mach-footbridge/common.c | 19 > b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 > b/arch/arm/mach-footbridge/include/mach/memory.h |4 > b/arch/arm/mach-highbank/highbank.c |2 > b/arch/arm/mach-mvebu/coherency.c|2 > b/arch/arm/mm/dma-mapping.c | 649 > ++- > b/drivers/usb/core/hcd.c | 17 > b/drivers/usb/host/ohci-sa.c | 25 > 18 files changed, 137 insertions(+), 1430 deletions(-) > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
fully convert arm to use dma-direct v3
Hi all, arm is the last platform not using the dma-direct code for directly mapped DMA. With the dmaboune removal from Arnd we can easily switch arm to always use dma-direct now (it already does for LPAE configs and nommu). I'd love to merge this series through the dma-mapping tree as it gives us the opportunity for additional core dma-mapping improvements. Changes since v2: - rebased to Linux 5.19-rc2 Changes since v1: - remove another unused function - improve a few commit logs - add three more patches from Robin Diffstat: arch/arm/common/dmabounce.c | 582 - arch/arm/include/asm/dma-mapping.h | 128 --- b/arch/arm/Kconfig |5 b/arch/arm/common/Kconfig|6 b/arch/arm/common/Makefile |1 b/arch/arm/common/sa.c | 64 - b/arch/arm/include/asm/device.h |3 b/arch/arm/include/asm/dma-direct.h | 49 - b/arch/arm/include/asm/memory.h |2 b/arch/arm/mach-footbridge/Kconfig |1 b/arch/arm/mach-footbridge/common.c | 19 b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 b/arch/arm/mach-footbridge/include/mach/memory.h |4 b/arch/arm/mach-highbank/highbank.c |2 b/arch/arm/mach-mvebu/coherency.c|2 b/arch/arm/mm/dma-mapping.c | 649 ++- b/drivers/usb/core/hcd.c | 17 b/drivers/usb/host/ohci-sa.c | 25 18 files changed, 137 insertions(+), 1430 deletions(-) ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Mon, May 9, 2022 at 5:44 PM Russell King (Oracle) wrote: > Assabet is what needs testing for that, or one of the SA1110 machines. > I'm away from home on my boat (and have been for the last two and a bit > weeks) so can't test. Sorry. Hm I actually have an Assabet, but I never even powered it up. I'm on parental leave for another week but after that I could actually try to get that machine up, but it'd be a bit late for this merge window indeed. BR Linus Walleij ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Fri, Apr 22, 2022 at 11:17:20PM +0200, Linus Walleij wrote: > On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: > > > arm is the last platform not using the dma-direct code for directly > > mapped DMA. With the dmaboune removal from Arnd we can easily switch > > arm to always use dma-direct now (it already does for LPAE configs > > and nommu). I'd love to merge this series through the dma-mapping tree > > as it gives us the opportunity for additional core dma-mapping > > improvements. > (...) > > > b/arch/arm/mach-footbridge/Kconfig |1 > > b/arch/arm/mach-footbridge/common.c | 19 > > b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 > > b/arch/arm/mach-footbridge/include/mach/memory.h |4 > > I think Marc Z has a Netwinder that he can test this on. Marc? > I have one too, just not much in my office because of parental leave. Netwinder is just more of a PC-but-with-ARM - it doesn't make use of any of the dmabounce code. Assabet is what needs testing for that, or one of the SA1110 machines. I'm away from home on my boat (and have been for the last two and a bit weeks) so can't test. Sorry. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Fri, May 06, 2022 at 01:06:14PM +0100, Marc Zyngier wrote: > > I think Marc Z has a Netwinder that he can test this on. Marc? > > I have one too, just not much in my office because of parental leave. > > Finally found some time to hook the machine up and throw a new kernel > at it. Booted at its usual glacial speed, so FWIW: > > Tested-by: Marc Zyngier Thanks. I've not heard anything from Russell and we're pretty late in the merge window, so I'm tempted to wait until the next merge window. I'd like to pull in ASAP for that though as I have other changes that are just waiting for it. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Fri, 22 Apr 2022 22:17:20 +0100, Linus Walleij wrote: > > On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: > > > arm is the last platform not using the dma-direct code for directly > > mapped DMA. With the dmaboune removal from Arnd we can easily switch > > arm to always use dma-direct now (it already does for LPAE configs > > and nommu). I'd love to merge this series through the dma-mapping tree > > as it gives us the opportunity for additional core dma-mapping > > improvements. > (...) > > > b/arch/arm/mach-footbridge/Kconfig |1 > > b/arch/arm/mach-footbridge/common.c | 19 > > b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 > > b/arch/arm/mach-footbridge/include/mach/memory.h |4 > > I think Marc Z has a Netwinder that he can test this on. Marc? > I have one too, just not much in my office because of parental leave. Finally found some time to hook the machine up and throw a new kernel at it. Booted at its usual glacial speed, so FWIW: Tested-by: Marc Zyngier Thanks, M. -- Without deviation from the norm, progress is not possible. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
fully convert arm to use dma-direct v2
Hi all, arm is the last platform not using the dma-direct code for directly mapped DMA. With the dmaboune removal from Arnd we can easily switch arm to always use dma-direct now (it already does for LPAE configs and nommu). I'd love to merge this series through the dma-mapping tree as it gives us the opportunity for additional core dma-mapping improvements. Changes since v1: - remove another unused function - improve a few commit logs - add three more patches from Robin Diffstat: arch/arm/common/dmabounce.c | 582 - arch/arm/include/asm/dma-mapping.h | 128 --- b/arch/arm/Kconfig |5 b/arch/arm/common/Kconfig|6 b/arch/arm/common/Makefile |1 b/arch/arm/common/sa.c | 64 - b/arch/arm/include/asm/device.h |3 b/arch/arm/include/asm/dma-direct.h | 49 - b/arch/arm/include/asm/memory.h |2 b/arch/arm/mach-footbridge/Kconfig |1 b/arch/arm/mach-footbridge/common.c | 19 b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 b/arch/arm/mach-footbridge/include/mach/memory.h |4 b/arch/arm/mach-highbank/highbank.c |2 b/arch/arm/mach-mvebu/coherency.c|2 b/arch/arm/mm/dma-mapping.c | 649 ++- b/drivers/usb/core/hcd.c | 17 b/drivers/usb/host/ohci-sa.c | 25 18 files changed, 137 insertions(+), 1430 deletions(-) ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Sat, Apr 23, 2022 at 11:27:13AM +0100, Marc Zyngier wrote: >> I think Marc Z has a Netwinder that he can test this on. Marc? >> I have one too, just not much in my office because of parental leave. > > I'm about to travel for a week. Can this wait until I'm back? > This is one of the few boxes that isn't hooked up to the PDU, > so I can't operate it remotely. No rush at all from my side except that I;d love to get it into 5.19. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On 2022-04-22 22:17, Linus Walleij wrote: On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: arm is the last platform not using the dma-direct code for directly mapped DMA. With the dmaboune removal from Arnd we can easily switch arm to always use dma-direct now (it already does for LPAE configs and nommu). I'd love to merge this series through the dma-mapping tree as it gives us the opportunity for additional core dma-mapping improvements. (...) b/arch/arm/mach-footbridge/Kconfig |1 b/arch/arm/mach-footbridge/common.c | 19 b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 b/arch/arm/mach-footbridge/include/mach/memory.h |4 I think Marc Z has a Netwinder that he can test this on. Marc? I have one too, just not much in my office because of parental leave. I'm about to travel for a week. Can this wait until I'm back? This is one of the few boxes that isn't hooked up to the PDU, so I can't operate it remotely. M. -- Jazz is not dead. It just smells funny... ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Thu, Apr 21, 2022 at 9:42 AM Christoph Hellwig wrote: > arm is the last platform not using the dma-direct code for directly > mapped DMA. With the dmaboune removal from Arnd we can easily switch > arm to always use dma-direct now (it already does for LPAE configs > and nommu). I'd love to merge this series through the dma-mapping tree > as it gives us the opportunity for additional core dma-mapping > improvements. (...) > b/arch/arm/mach-footbridge/Kconfig |1 > b/arch/arm/mach-footbridge/common.c | 19 > b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 > b/arch/arm/mach-footbridge/include/mach/memory.h |4 I think Marc Z has a Netwinder that he can test this on. Marc? I have one too, just not much in my office because of parental leave. Yours, Linus Walleij ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Thu, 21 Apr 2022 09:41:57 +0200 Christoph Hellwig wrote: Hi, > arm is the last platform not using the dma-direct code for directly > mapped DMA. With the dmaboune removal from Arnd we can easily switch > arm to always use dma-direct now (it already does for LPAE configs > and nommu). I'd love to merge this series through the dma-mapping tree > as it gives us the opportunity for additional core dma-mapping > improvements. > > Diffstat: > arch/arm/common/dmabounce.c | 582 > --- > arch/arm/include/asm/dma-mapping.h | 128 > b/arch/arm/Kconfig |5 > b/arch/arm/common/Kconfig|6 > b/arch/arm/common/Makefile |1 > b/arch/arm/common/sa.c | 64 -- > b/arch/arm/include/asm/device.h |3 > b/arch/arm/include/asm/dma-direct.h | 49 - > b/arch/arm/include/asm/memory.h |2 > b/arch/arm/mach-footbridge/Kconfig |1 > b/arch/arm/mach-footbridge/common.c | 19 > b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 > b/arch/arm/mach-footbridge/include/mach/memory.h |4 > b/arch/arm/mach-highbank/highbank.c |2 FWIW, I applied this on top of 5.18-rc3 and pushed my Midway (the Highbank successor) a bit with it (scp-ing GBs forth and back to a SATA SSD). Not a really conclusive test, but so far it looks all fine. So for the Highbank part: Acked-by: Andre Przywara Cheers, Andre > b/arch/arm/mach-mvebu/coherency.c|2 > b/arch/arm/mm/dma-mapping.c | 381 > b/drivers/usb/core/hcd.c | 17 > b/drivers/usb/host/ohci-sa.c | 25 > 18 files changed, 84 insertions(+), 1215 deletions(-) ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: fully convert arm to use dma-direct
On Thu, Apr 21, 2022 at 9:41 AM Christoph Hellwig wrote: > > Hi all, > > arm is the last platform not using the dma-direct code for directly > mapped DMA. With the dmaboune removal from Arnd we can easily switch > arm to always use dma-direct now (it already does for LPAE configs > and nommu). I'd love to merge this series through the dma-mapping tree > as it gives us the opportunity for additional core dma-mapping > improvements. Thanks a lot for completing this, it looks all good to me, and I hope that Russell can test my assabet patch to make sure this doesn't break anything. I saw one opportunity for an additional cleanup patch that I commented on, but that does not stop the rest from getting merged. I also made sure that this passes the basic kernelci tests across all arm machines. Arnd ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
fully convert arm to use dma-direct
Hi all, arm is the last platform not using the dma-direct code for directly mapped DMA. With the dmaboune removal from Arnd we can easily switch arm to always use dma-direct now (it already does for LPAE configs and nommu). I'd love to merge this series through the dma-mapping tree as it gives us the opportunity for additional core dma-mapping improvements. Diffstat: arch/arm/common/dmabounce.c | 582 --- arch/arm/include/asm/dma-mapping.h | 128 b/arch/arm/Kconfig |5 b/arch/arm/common/Kconfig|6 b/arch/arm/common/Makefile |1 b/arch/arm/common/sa.c | 64 -- b/arch/arm/include/asm/device.h |3 b/arch/arm/include/asm/dma-direct.h | 49 - b/arch/arm/include/asm/memory.h |2 b/arch/arm/mach-footbridge/Kconfig |1 b/arch/arm/mach-footbridge/common.c | 19 b/arch/arm/mach-footbridge/include/mach/dma-direct.h |8 b/arch/arm/mach-footbridge/include/mach/memory.h |4 b/arch/arm/mach-highbank/highbank.c |2 b/arch/arm/mach-mvebu/coherency.c|2 b/arch/arm/mm/dma-mapping.c | 381 b/drivers/usb/core/hcd.c | 17 b/drivers/usb/host/ohci-sa.c | 25 18 files changed, 84 insertions(+), 1215 deletions(-) ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
