On Fri, Dec 28, 2012 at 9:44 PM, Zdenek Styblik
zdenek.styb...@gmail.com wrote:
On Fri, Dec 28, 2012 at 4:39 PM, jordan_hargr...@dell.com wrote:
Why change the ordering of the arguments in getsysinfo/setsysinfo?
I like it the way it was originally since intf/param/block/set are part of
the input ipmi command and the data/length are the returned data.
--jordan hargrave
Dell Enterprise Linux Engineering
My reasoning behind the change is:
* give these functions same order of common arguments since they're
likely to be used together - easier to remember(?)
* it seemed like a common way, at least within ipmitool
*shrug*
Z.
Jordan,
I would like to commit this one way or another and move to other
issues(there are plenty). In other words, I would like to reach some
conclusion over these changes.
Thanks and happy New Year,
Z.
From: Zdenek Styblik [zdenek.styb...@gmail.com]
Sent: Thursday, December 27, 2012 2:35 PM
To: Hargrave, Jordan
Cc: Jim Mank; ipmitool-devel
Subject: Code review/changes - 'mc getsysinfo|setsysinfo' - IDs #3598203,
#3597782, #3597781
Hello Jordan,
attached is a diff set I'm going to commit sooner or later. This patch
changes some code around 'mc getsysinfo' and 'mc setsysinfo' you've
committed.
This e-mail is meant as a heads-up and also an opportunity for
questions and comments.
*
https://sourceforge.net/tracker/?func=detailaid=3597781group_id=95200atid=610550
*
https://sourceforge.net/tracker/?func=detailaid=3597782group_id=95200atid=610550
*
https://sourceforge.net/tracker/?func=detailaid=3598203group_id=95200atid=610550
Best regards,
Z.
--
Zdenek Styblik
email: zdenek.styb...@gmail.com
jabber: zdenek.styb...@gmail.com
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
___
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
