Re: [ipxe-devel] branding patch

[Michael Brown]

On 23/03/18 02:04, David Yeske wrote:
I recently wanted to build a custom version of the ipxe firmware by 
creating the following file.


% cat src/config/local/uefi/branding.h
#undef PRODUCT_TAG_LINE
#define PRODUCT_TAG_LINE "uefi Network Firmware"

When I compiled and ran ipxe, it did not appear to pick up the change.  
I looked through the source code and I think the branding code is 
missing some information.  I have created a patch as follows which is 
working for me.


It's a deliberate design choice that not all config headers have the 
ability to include a NAMED_CONFIG() portion.  If we were to include this 
in all config headers, then we would basically end up rebuilding the 
entire codebase whenever the value of CONFIG=... changed.


The patch is fine, but we need some kind of justification to include 
config/branding.h within the set of named-config headers.


Michael
___
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel

[ipxe-devel] branding patch

[David Yeske]

I recently wanted to build a custom version of the ipxe firmware by
creating the following file.

% cat src/config/local/uefi/branding.h
#undef PRODUCT_TAG_LINE
#define PRODUCT_TAG_LINE "uefi Network Firmware"

When I compiled and ran ipxe, it did not appear to pick up the change.  I
looked through the source code and I think the branding code is missing
some information.  I have created a patch as follows which is working for
me.

I hope a shar is acceptable in an email body.  If not is there an official
way to submit a patch?

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#   .
#   ./patch-ipxe
#
echo c - .
mkdir -p . > /dev/null 2>&1
echo x - ./patch-ipxe
sed 's/^X//' >./patch-ipxe << '456ea0ae3e660f280fff15ecc6fbcf74'
Xdiff --git a/src/config/branding.h b/src/config/branding.h
Xindex 73f00af9..69fcec62 100644
X--- a/src/config/branding.h
X+++ b/src/config/branding.h
X@@ -169,6 +169,9 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
X  */
X #define PRODUCT_SETTING_URI "http://ipxe.org/cfg/%s;
X
X+#include 
X+#include NAMED_CONFIG(branding.h)
X #include 
X+#include LOCAL_NAMED_CONFIG(branding.h)
X
X #endif /* CONFIG_BRANDING_H */
456ea0ae3e660f280fff15ecc6fbcf74
exit


Regards,
David Yeske
___
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel