[jira] [Reopened] (AMQ-6136) Activemq client OSGi feature should support Spring 4.x

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon reopened AMQ-6136:
-
Regression: Unit Test Broken

Unfortunately, it looks like this commit broke a couple of Karaf tests.  I 
believe the problem is that the Spring OSGi feature (spring dm) has an import 
defined with a version of less than Spring 4.  I think the only way to resolve 
this is to remove the dependency on Spring DM, which is now a dead project.  
There is already a Jira for this here: AMQ-5932 and we should look at fixing 
this for a 5.14.0 release.

> Activemq client OSGi feature should support Spring 4.x
> --
>
> Key: AMQ-6136
> URL: https://issues.apache.org/jira/browse/AMQ-6136
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker, OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.13.1, 5.14.0
>
>
> The features-core.xml file in the activemq-karaf project currently lists a 
> version for Spring as [3.2,4) but this should be [3.2,5) as ActiveMQ 5.13.0 
> upgraded to Spring 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-369) [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123521#comment-15123521
 ] 

ASF GitHub Bot commented on ARTEMIS-369:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/360


> [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode 
> fails
> --
>
> Key: ARTEMIS-369
> URL: https://issues.apache.org/jira/browse/ARTEMIS-369
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
> org.apache.activemq.artemis.api.core.ActiveMQNotConnectedException: 
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
>   at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:777)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.internalTestFailoverOnBridge(BridgeFailoverTest.java:191)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.testFailoverOnBridgeNoRetryOnSameNode(BridgeFailoverTest.java:96)
> {code}
> There is wrong wait condition. In the test we check if backup server started 
> after failover, but we should check whether backup server activated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-368) [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123518#comment-15123518
 ] 

ASF subversion and git services commented on ARTEMIS-368:
-

Commit 3663f4c01e69f315ea806530b78a791789d6a8ee in activemq-artemis's branch 
refs/heads/master from [~eduda]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3663f4c ]

ARTEMIS-368 - [Artemis Testsuite] 
TemporaryQueueTest#testBlockingWithTemporaryQueue fails


> [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails
> ---
>
> Key: ARTEMIS-368
> URL: https://issues.apache.org/jira/browse/ARTEMIS-368
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> expected:<737> but was:<736>
> java.lang.AssertionError: expected:<737> but was:<736>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.integration.client.TemporaryQueueTest.testBlockingWithTemporaryQueue(TemporaryQueueTest.java:600)
> {code}
> There is while cycle which check whether producer is blocked and thus 
> temporary queue is full. Sometimes it can happen that producer spend all his 
> credits too fast and he is blocked because he waits to receive credits from 
> server, but the queue is not full. We have to ensure that the producer is 
> blocked due to full queue and it is not just temporary state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-5932) ActiveMQ-OSGI should not depend on spring-dm

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123541#comment-15123541
 ] 

Christopher L. Shannon commented on AMQ-5932:
-

We should aim to fix this in 5.14.0 to make Spring 4.x fully compatible.  
Another issue was reported with AMQ-6139 that needs this to be fixed.

> ActiveMQ-OSGI should not depend on spring-dm
> 
>
> Key: AMQ-5932
> URL: https://issues.apache.org/jira/browse/AMQ-5932
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Charlie Mordant
> Fix For: 5.14.0
>
>
> Hi,
> Spring-dm is deprecated for a long time, also it has a strong dependency to 
> spring-3, so all newest spring 4 versions are difficult to use, and that is 
> blocker for some other frameworks (i.e. thinking about cxf, spring-data).
> Also amq 5.9 didn't depend on spring-dm so it should be possible to get rid 
> of this dep.
> Regards,
> Charlie



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (AMQ-5932) ActiveMQ-OSGI should not depend on spring-dm

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123541#comment-15123541
 ] 

Christopher L. Shannon edited comment on AMQ-5932 at 1/29/16 2:55 PM:
--

We should aim to fix this in 5.14.0 to make Spring 4.x fully compatible.  
Another issue was reported with AMQ-6136 that needs this to be fixed.


was (Author: christopher.l.shannon):
We should aim to fix this in 5.14.0 to make Spring 4.x fully compatible.  
Another issue was reported with AMQ-6139 that needs this to be fixed.

> ActiveMQ-OSGI should not depend on spring-dm
> 
>
> Key: AMQ-5932
> URL: https://issues.apache.org/jira/browse/AMQ-5932
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Charlie Mordant
> Fix For: 5.14.0
>
>
> Hi,
> Spring-dm is deprecated for a long time, also it has a strong dependency to 
> spring-3, so all newest spring 4 versions are difficult to use, and that is 
> blocker for some other frameworks (i.e. thinking about cxf, spring-data).
> Also amq 5.9 didn't depend on spring-dm so it should be possible to get rid 
> of this dep.
> Regards,
> Charlie



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (AMQ-6136) Activemq client OSGi feature should support Spring 4.x

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon updated AMQ-6136:

Fix Version/s: (was: 5.13.1)

> Activemq client OSGi feature should support Spring 4.x
> --
>
> Key: AMQ-6136
> URL: https://issues.apache.org/jira/browse/AMQ-6136
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker, OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.14.0
>
>
> The features-core.xml file in the activemq-karaf project currently lists a 
> version for Spring as [3.2,4) but this should be [3.2,5) as ActiveMQ 5.13.0 
> upgraded to Spring 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-369) [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123520#comment-15123520
 ] 

ASF subversion and git services commented on ARTEMIS-369:
-

Commit 062a675a5358013c5a5517d130a2b19684c85ba7 in activemq-artemis's branch 
refs/heads/master from [~eduda]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=062a675 ]

ARTEMIS-369 - [Artemis Testsuite] 
BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails


> [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode 
> fails
> --
>
> Key: ARTEMIS-369
> URL: https://issues.apache.org/jira/browse/ARTEMIS-369
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
> org.apache.activemq.artemis.api.core.ActiveMQNotConnectedException: 
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
>   at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:777)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.internalTestFailoverOnBridge(BridgeFailoverTest.java:191)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.testFailoverOnBridgeNoRetryOnSameNode(BridgeFailoverTest.java:96)
> {code}
> There is wrong wait condition. In the test we check if backup server started 
> after failover, but we should check whether backup server activated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (ARTEMIS-369) [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails

[clebert suconic (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic closed ARTEMIS-369.
---
   Resolution: Fixed
Fix Version/s: 1.3.0

> [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode 
> fails
> --
>
> Key: ARTEMIS-369
> URL: https://issues.apache.org/jira/browse/ARTEMIS-369
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
> Fix For: 1.3.0
>
>
> {code}
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
> org.apache.activemq.artemis.api.core.ActiveMQNotConnectedException: 
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
>   at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:777)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.internalTestFailoverOnBridge(BridgeFailoverTest.java:191)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.testFailoverOnBridgeNoRetryOnSameNode(BridgeFailoverTest.java:96)
> {code}
> There is wrong wait condition. In the test we check if backup server started 
> after failover, but we should check whether backup server activated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (AMQ-5932) ActiveMQ-OSGI should not depend on spring-dm

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon updated AMQ-5932:

Affects Version/s: (was: 5.12.0)
   5.13.0
Fix Version/s: 5.14.0

> ActiveMQ-OSGI should not depend on spring-dm
> 
>
> Key: AMQ-5932
> URL: https://issues.apache.org/jira/browse/AMQ-5932
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Charlie Mordant
> Fix For: 5.14.0
>
>
> Hi,
> Spring-dm is deprecated for a long time, also it has a strong dependency to 
> spring-3, so all newest spring 4 versions are difficult to use, and that is 
> blocker for some other frameworks (i.e. thinking about cxf, spring-data).
> Also amq 5.9 didn't depend on spring-dm so it should be possible to get rid 
> of this dep.
> Regards,
> Charlie



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6136) Activemq client OSGi feature should support Spring 4.x

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123544#comment-15123544
 ] 

ASF subversion and git services commented on AMQ-6136:
--

Commit 7eb25ec50bd3af931c6ae876d9f7bef09385ba43 in activemq's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=7eb25ec ]

Revert "https://issues.apache.org/jira/browse/AMQ-6136;

This reverts commit 4ee29c363fbcc754f69ebc57b45f84a549f7d130.

We need to remove the dependency on Spring DM before doing this


> Activemq client OSGi feature should support Spring 4.x
> --
>
> Key: AMQ-6136
> URL: https://issues.apache.org/jira/browse/AMQ-6136
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker, OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.14.0
>
>
> The features-core.xml file in the activemq-karaf project currently lists a 
> version for Spring as [3.2,4) but this should be [3.2,5) as ActiveMQ 5.13.0 
> upgraded to Spring 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6136) Activemq client OSGi feature should support Spring 4.x

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123547#comment-15123547
 ] 

Christopher L. Shannon commented on AMQ-6136:
-

Reverted the commit until the Spring DM dependency is removed.

> Activemq client OSGi feature should support Spring 4.x
> --
>
> Key: AMQ-6136
> URL: https://issues.apache.org/jira/browse/AMQ-6136
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker, OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.14.0
>
>
> The features-core.xml file in the activemq-karaf project currently lists a 
> version for Spring as [3.2,4) but this should be [3.2,5) as ActiveMQ 5.13.0 
> upgraded to Spring 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6136) Activemq client OSGi feature should support Spring 4.x

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123546#comment-15123546
 ] 

ASF subversion and git services commented on AMQ-6136:
--

Commit 0ebc7a4da819d4be2e6c2de6d8681c0dc3500781 in activemq's branch 
refs/heads/activemq-5.13.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=0ebc7a4 ]

Revert "https://issues.apache.org/jira/browse/AMQ-6136;

This reverts commit 4ee29c363fbcc754f69ebc57b45f84a549f7d130.

We need to remove the dependency on Spring DM before doing this

(cherry picked from commit 7eb25ec50bd3af931c6ae876d9f7bef09385ba43)


> Activemq client OSGi feature should support Spring 4.x
> --
>
> Key: AMQ-6136
> URL: https://issues.apache.org/jira/browse/AMQ-6136
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker, OSGi/Karaf
>Affects Versions: 5.13.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.14.0
>
>
> The features-core.xml file in the activemq-karaf project currently lists a 
> version for Spring as [3.2,4) but this should be [3.2,5) as ActiveMQ 5.13.0 
> upgraded to Spring 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (ARTEMIS-368) [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails

[clebert suconic (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic closed ARTEMIS-368.
---
   Resolution: Fixed
Fix Version/s: 1.3.0

> [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails
> ---
>
> Key: ARTEMIS-368
> URL: https://issues.apache.org/jira/browse/ARTEMIS-368
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
> Fix For: 1.3.0
>
>
> {code}
> expected:<737> but was:<736>
> java.lang.AssertionError: expected:<737> but was:<736>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.integration.client.TemporaryQueueTest.testBlockingWithTemporaryQueue(TemporaryQueueTest.java:600)
> {code}
> There is while cycle which check whether producer is blocked and thus 
> temporary queue is full. Sometimes it can happen that producer spend all his 
> credits too fast and he is blocked because he waits to receive credits from 
> server, but the queue is not full. We have to ensure that the producer is 
> blocked due to full queue and it is not just temporary state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-368) [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123519#comment-15123519
 ] 

ASF GitHub Bot commented on ARTEMIS-368:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/359


> [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails
> ---
>
> Key: ARTEMIS-368
> URL: https://issues.apache.org/jira/browse/ARTEMIS-368
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> expected:<737> but was:<736>
> java.lang.AssertionError: expected:<737> but was:<736>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.integration.client.TemporaryQueueTest.testBlockingWithTemporaryQueue(TemporaryQueueTest.java:600)
> {code}
> There is while cycle which check whether producer is blocked and thus 
> temporary queue is full. Sometimes it can happen that producer spend all his 
> credits too fast and he is blocked because he waits to receive credits from 
> server, but the queue is not full. We have to ensure that the producer is 
> blocked due to full queue and it is not just temporary state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-368) [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails

[Erich Duda (JIRA)]

Erich Duda created ARTEMIS-368:
--

 Summary: [Artemis Testsuite] 
TemporaryQueueTest#testBlockingWithTemporaryQueue fails
 Key: ARTEMIS-368
 URL: https://issues.apache.org/jira/browse/ARTEMIS-368
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Erich Duda


{code}
expected:<737> but was:<736>
java.lang.AssertionError: expected:<737> but was:<736>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at 
org.apache.activemq.artemis.tests.integration.client.TemporaryQueueTest.testBlockingWithTemporaryQueue(TemporaryQueueTest.java:600)
{code}

There is while cycle which check whether producer is blocked and thus temporary 
queue is full. Sometimes it can happen that producer spend all his credits too 
fast and he is blocked because he waits to receive credits from server, but the 
queue is not full. We have to ensure that the producer is blocked due to full 
queue and it is not just temporary state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-368) [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123217#comment-15123217
 ] 

ASF GitHub Bot commented on ARTEMIS-368:


GitHub user dudaerich opened a pull request:

https://github.com/apache/activemq-artemis/pull/359

ARTEMIS-368 - [Artemis Testsuite] TemporaryQueueTest#testBlockingWith…

…TemporaryQueue fails

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dudaerich/activemq-artemis ARTEMIS-368

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #359


commit 3663f4c01e69f315ea806530b78a791789d6a8ee
Author: Erich Duda 
Date:   2016-01-29T08:57:49Z

ARTEMIS-368 - [Artemis Testsuite] 
TemporaryQueueTest#testBlockingWithTemporaryQueue fails




> [Artemis Testsuite] TemporaryQueueTest#testBlockingWithTemporaryQueue fails
> ---
>
> Key: ARTEMIS-368
> URL: https://issues.apache.org/jira/browse/ARTEMIS-368
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> expected:<737> but was:<736>
> java.lang.AssertionError: expected:<737> but was:<736>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:743)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:555)
>   at org.junit.Assert.assertEquals(Assert.java:542)
>   at 
> org.apache.activemq.artemis.tests.integration.client.TemporaryQueueTest.testBlockingWithTemporaryQueue(TemporaryQueueTest.java:600)
> {code}
> There is while cycle which check whether producer is blocked and thus 
> temporary queue is full. Sometimes it can happen that producer spend all his 
> credits too fast and he is blocked because he waits to receive credits from 
> server, but the queue is not full. We have to ensure that the producer is 
> blocked due to full queue and it is not just temporary state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-369) [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123431#comment-15123431
 ] 

ASF GitHub Bot commented on ARTEMIS-369:


GitHub user dudaerich opened a pull request:

https://github.com/apache/activemq-artemis/pull/360

ARTEMIS-369 - [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBr…

…idgeNoRetryOnSameNode fails

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dudaerich/activemq-artemis ARTEMIS-369

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #360


commit 1a181ff2c05e91734ad542484c08157b6a558321
Author: Erich Duda 
Date:   2016-01-29T12:41:33Z

ARTEMIS-369 - [Artemis Testsuite] 
BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails




> [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode 
> fails
> --
>
> Key: ARTEMIS-369
> URL: https://issues.apache.org/jira/browse/ARTEMIS-369
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
> org.apache.activemq.artemis.api.core.ActiveMQNotConnectedException: 
> AMQ119007: Cannot connect to server(s). Tried with all available servers.
>   at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:777)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.internalTestFailoverOnBridge(BridgeFailoverTest.java:191)
>   at 
> org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.testFailoverOnBridgeNoRetryOnSameNode(BridgeFailoverTest.java:96)
> {code}
> There is wrong wait condition. In the test we check if backup server started 
> after failover, but we should check whether backup server activated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-369) [Artemis Testsuite] BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails

[Erich Duda (JIRA)]

Erich Duda created ARTEMIS-369:
--

 Summary: [Artemis Testsuite] 
BridgeFailoverTest#testFailoverOnBridgeNoRetryOnSameNode fails
 Key: ARTEMIS-369
 URL: https://issues.apache.org/jira/browse/ARTEMIS-369
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Erich Duda


{code}
AMQ119007: Cannot connect to server(s). Tried with all available servers.
org.apache.activemq.artemis.api.core.ActiveMQNotConnectedException: AMQ119007: 
Cannot connect to server(s). Tried with all available servers.
at 
org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:777)
at 
org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.internalTestFailoverOnBridge(BridgeFailoverTest.java:191)
at 
org.apache.activemq.artemis.tests.integration.cluster.bridge.BridgeFailoverTest.testFailoverOnBridgeNoRetryOnSameNode(BridgeFailoverTest.java:96)
{code}

There is wrong wait condition. In the test we check if backup server started 
after failover, but we should check whether backup server activated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-370) Make JDBC Journal Sync period configurable

[Martyn Taylor (JIRA)]

Martyn Taylor created ARTEMIS-370:
-

 Summary: Make JDBC Journal Sync period configurable
 Key: ARTEMIS-370
 URL: https://issues.apache.org/jira/browse/ARTEMIS-370
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Martyn Taylor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6150) Found (and fixed) 3 instances of impossible casts in the activemq code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123663#comment-15123663
 ] 

ASF GitHub Bot commented on AMQ-6150:
-

GitHub user mbreslow opened a pull request:

https://github.com/apache/activemq/pull/166

Fix AMQ-6150 (Found 3 instances of impossible casts in the activemq code)

Running static analysis on activemq I was able to identify 3 instances of 
impossible casts in the code. This pull request resolves them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DevFactory/activemq 
AMQ-6150-fix-impossible-cast-issues

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #166


commit 364e10d40569042595ec27ae710c2fd687fa2746
Author: Marc Breslow 
Date:   2016-01-28T21:39:29Z

Fix Impossible Cast issues in MemoryTopicSub:
- recoverSubscription()
-- map is defined as LinkedHashMap
-- msg is defined as  entry.getValue() so must be a Message
-- condition if (msg.getClass() == MessageId.class) could never be true
-- no need to cast at all when using generics

- recoverNextMessages()
-- basically same code copy/pasted so same fix

commit 61f951d0c811b8c9dcde306fa7843aadce70d199
Author: Marc Breslow 
Date:   2016-01-29T15:51:18Z

Removed 2 conditions from ServerSessionPoolImpl that would result in 
impossible casts. Conditions removed were trying to cast ActiveMQQueueSession 
and ActiveMQTopicSession to ActiveMQSession which is illegal.

Since it isn't obvious what to do if you get an ActiveMQQueueSession or 
ActiveMQTopicSession from getServerSession() I make it fall back to the else 
condition which raises an async exception. This is better than getting a 
ClassCastException at runtime.

commit f177a52c62336115dc3df7af0694851046ae670c
Author: Marc Breslow 
Date:   2016-01-29T16:00:31Z

Remove impossible cast in MemoryMessageStore

commit 509fe1ce8f3e1a6b5b64be4a027487e9c11737a6
Author: Marc Breslow 
Date:   2016-01-29T16:11:30Z

Merge branch 'master' into AMQ-6150-fix-impossible-cast-issues




> Found (and fixed) 3 instances of impossible casts in the activemq code
> --
>
> Key: AMQ-6150
> URL: https://issues.apache.org/jira/browse/AMQ-6150
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.13.0
>Reporter: Marc Breslow
>Priority: Critical
> Attachments: 0001-Fix-Impossible-Cast-issues-in-MemoryTopicSub.patch, 
> 0002-Removed-2-conditions-from-ServerSessionPoolImpl-that.patch, 
> 0003-Remove-impossible-cast-in-MemoryMessageStore.patch
>
>
> Running static analysis on activemq I was able to identify 3 instances of 
> impossible casts in the code. Attaching patch files to fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (AMQ-6150) Found (and fixed) 3 instances of impossible casts in the activemq code

[Marc Breslow (JIRA)]

Marc Breslow created AMQ-6150:
-

 Summary: Found (and fixed) 3 instances of impossible casts in the 
activemq code
 Key: AMQ-6150
 URL: https://issues.apache.org/jira/browse/AMQ-6150
 Project: ActiveMQ
  Issue Type: Bug
  Components: Broker
Affects Versions: 5.13.0
Reporter: Marc Breslow
Priority: Critical


Running static analysis on activemq I was able to identify 3 instances of 
impossible casts in the code. Attaching patch files to fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (AMQ-6150) Found (and fixed) 3 instances of impossible casts in the activemq code

[Marc Breslow (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marc Breslow updated AMQ-6150:
--
Attachment: 0003-Remove-impossible-cast-in-MemoryMessageStore.patch
0002-Removed-2-conditions-from-ServerSessionPoolImpl-that.patch
0001-Fix-Impossible-Cast-issues-in-MemoryTopicSub.patch

> Found (and fixed) 3 instances of impossible casts in the activemq code
> --
>
> Key: AMQ-6150
> URL: https://issues.apache.org/jira/browse/AMQ-6150
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.13.0
>Reporter: Marc Breslow
>Priority: Critical
> Attachments: 0001-Fix-Impossible-Cast-issues-in-MemoryTopicSub.patch, 
> 0002-Removed-2-conditions-from-ServerSessionPoolImpl-that.patch, 
> 0003-Remove-impossible-cast-in-MemoryMessageStore.patch
>
>
> Running static analysis on activemq I was able to identify 3 instances of 
> impossible casts in the code. Attaching patch files to fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-372) Block sync when sync=true and callback = null in JDBC Journal

[Martyn Taylor (JIRA)]

Martyn Taylor created ARTEMIS-372:
-

 Summary: Block sync when sync=true and callback = null in JDBC 
Journal
 Key: ARTEMIS-372
 URL: https://issues.apache.org/jira/browse/ARTEMIS-372
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Martyn Taylor


The JDBC Journal currently ignores request to sync() when records are added.  
This is OK for Artemis as sync is not used, but would cause problems for anyone 
using a standalone journal in their project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-373) Do not use Thread.sleep() in JDBCTest

[Martyn Taylor (JIRA)]

Martyn Taylor created ARTEMIS-373:
-

 Summary: Do not use Thread.sleep() in JDBCTest
 Key: ARTEMIS-373
 URL: https://issues.apache.org/jira/browse/ARTEMIS-373
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Martyn Taylor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-371) Make JDBC Driver class configurable

[Martyn Taylor (JIRA)]

Martyn Taylor created ARTEMIS-371:
-

 Summary: Make JDBC Driver class configurable
 Key: ARTEMIS-371
 URL: https://issues.apache.org/jira/browse/ARTEMIS-371
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Martyn Taylor


Use Classfor when instantiating driver class.  This allows >1 database driver 
to be on the class path at any one time.

Also, we've seen classes get GC'd when using derby in tests.  This should 
resolve that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-374) Support scheduled messages last-value queue

[Justin Bertram (JIRA)]

Justin Bertram created ARTEMIS-374:
--

 Summary: Support scheduled messages last-value queue
 Key: ARTEMIS-374
 URL: https://issues.apache.org/jira/browse/ARTEMIS-374
 Project: ActiveMQ Artemis
  Issue Type: New Feature
Affects Versions: 1.2.0
Reporter: Justin Bertram
Assignee: Justin Bertram
 Fix For: 1.3.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ARTEMIS-375) When use ./artemis data exp, the xml printed to stdout mixed with logging information

[Howard Nguyen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard Nguyen updated ARTEMIS-375:
--
Attachment: XmlDataExport-improvement.patch

> When use ./artemis data exp, the xml printed to stdout mixed with logging 
> information
> -
>
> Key: ARTEMIS-375
> URL: https://issues.apache.org/jira/browse/ARTEMIS-375
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Howard Nguyen
> Fix For: 1.3.0
>
> Attachments: XmlDataExport-improvement.patch
>
>
> When use ./artemis data exp, the xml printed to stdout mixed with logging 
> information.
> Attached patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-375) When use ./artemis data exp, the xml printed to stdout mixed with logging information

[Howard Nguyen (JIRA)]

Howard Nguyen created ARTEMIS-375:
-

 Summary: When use ./artemis data exp, the xml printed to stdout 
mixed with logging information
 Key: ARTEMIS-375
 URL: https://issues.apache.org/jira/browse/ARTEMIS-375
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Howard Nguyen
 Fix For: 1.3.0
 Attachments: XmlDataExport-improvement.patch

When use ./artemis data exp, the xml printed to stdout mixed with logging 
information.

Attached patch.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-374) Support scheduled messages on last-value queue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124275#comment-15124275
 ] 

ASF GitHub Bot commented on ARTEMIS-374:


GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/362

ARTEMIS-374 support schedule messages on LVQ



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis LVQ2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #362


commit d54739239bac05f82e4599f9e6936d9814ad0c86
Author: jbertram 
Date:   2016-01-27T22:15:59Z

ARTEMIS-374 support schedule messages on LVQ




> Support scheduled messages on last-value queue
> --
>
> Key: ARTEMIS-374
> URL: https://issues.apache.org/jira/browse/ARTEMIS-374
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Affects Versions: 1.2.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (AMQ-6036) Too trivial check in SubQueueSelectorCacheBroker.hasWildcards

[Patrik Dudits (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrik Dudits updated AMQ-6036:
---
Component/s: Broker

Is there anything more I can do to get this merged?

> Too trivial check in SubQueueSelectorCacheBroker.hasWildcards
> -
>
> Key: AMQ-6036
> URL: https://issues.apache.org/jira/browse/AMQ-6036
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.12.1
>Reporter: Patrik Dudits
>
> VirtualSelectorCache plugin cannot be reliably used when message selectors 
> use e. g. literals with underscore like {{notificationType = 
> 'NOTIFY_DELETE'}}.
> Full evaluation would need to walk the parsed selector, however the method 
> should at least check for presence of {{LIKE}} case-insensitevely to return 
> less false positives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ARTEMIS-374) Support scheduled messages on last-value queue

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-374:
---
Summary: Support scheduled messages on last-value queue  (was: Support 
scheduled messages last-value queue)

> Support scheduled messages on last-value queue
> --
>
> Key: ARTEMIS-374
> URL: https://issues.apache.org/jira/browse/ARTEMIS-374
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Affects Versions: 1.2.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124211#comment-15124211
 ] 

ASF subversion and git services commented on AMQ-6113:
--

Commit 186b5d0f305ed63b23a1db712a933aa4896006cf in activemq's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=186b5d0 ]

https://issues.apache.org/jira/browse/AMQ-6113

Properly set the X-FRAME-OPTIONS header on web responses.


> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon updated AMQ-6113:

Fix Version/s: 5.12.3
   5.11.4

> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.11.4, 5.13.1, 5.14.0, 5.12.3
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon updated AMQ-6113:

   Assignee: Christopher L. Shannon
Description: The X-Frame-Options header is missing for the ActiveMQ Web 
Console and it should be added to all responses  (was: ActiveMQ is part of our 
installation.

When I run the Nessus vulnerability scanner on our server it found the 
following vulnerability on ActiveMQ  webconsole:

Web Application Potentially Vulnerable to Clickjacking


Description
The remote web server does not set an X-Frame-Options response header in all 
content responses. This could potentially expose the site to a clickjacking or 
UI Redress attack wherein an attacker can trick a user into clicking an area of 
the vulnerable page that is different than what the user perceives the page to 
be. This can result in a user performing fraudulent or malicious transactions.

X-Frame-Options has been proposed by Microsoft as a way to mitigate 
clickjacking attacks and is currently supported by all major browser vendors.

Note that while the X-Frame-Options response header is not the only mitigation 
for clickjacking, it is currently the most reliable method to detect through 
automation. Therefore, this plugin may produce false positives if other 
mitigation strategies (e.g frame-busting JavaScript) are deployed or if the 
page does not perform any security-sensitive transactions.
Solution
Return the X-Frame-Options HTTP header with the page's response.

This prevents the page's content from being rendered by another site when using 
the frame or iframe HTML tags.
See Also
http://www.nessus.org/u?1bced8d9
https://www.owasp.org/index.php/Clickjacking_Defense_Cheat_Sheet
http://en.wikipedia.org/wiki/Clickjacking
Output

The following pages do not use an X-Frame-Options response header :

  - https://10.100.10.10:8072/

)
Component/s: (was: security)
Summary: Add the X-Frame-Options" header for the WebConsole  (was: 
Security issue: required to add "X-Frame-Options SAMEORIGIN" for web console)

> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved AMQ-6113.
-
   Resolution: Fixed
Fix Version/s: 5.14.0
   5.13.1

> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124215#comment-15124215
 ] 

ASF subversion and git services commented on AMQ-6113:
--

Commit 648d08391d5c4efdbfe0734744f19ed9b8b14276 in activemq's branch 
refs/heads/activemq-5.13.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=648d083 ]

https://issues.apache.org/jira/browse/AMQ-6113

Properly set the X-FRAME-OPTIONS header on web responses.

(cherry picked from commit 186b5d0f305ed63b23a1db712a933aa4896006cf)


> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124220#comment-15124220
 ] 

ASF subversion and git services commented on AMQ-6113:
--

Commit 6bff094f5a0150ccf224f3be7ee0399bbb6eb99f in activemq's branch 
refs/heads/activemq-5.12.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=6bff094 ]

https://issues.apache.org/jira/browse/AMQ-6113

Properly set the X-FRAME-OPTIONS header on web responses.

(cherry picked from commit 186b5d0f305ed63b23a1db712a933aa4896006cf)


> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124231#comment-15124231
 ] 

ASF subversion and git services commented on AMQ-6113:
--

Commit d852615fd950fbf86c11e3c91139a98edec9b895 in activemq's branch 
refs/heads/activemq-5.11.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=d852615 ]

https://issues.apache.org/jira/browse/AMQ-6113

Properly set the X-FRAME-OPTIONS header on web responses.

(cherry picked from commit 186b5d0f305ed63b23a1db712a933aa4896006cf)


> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)