[jira] [Commented] (ARTEMIS-396) [Artemis Testsuite] ReceiveTest#testReceiveImmediate fails

2016-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144530#comment-15144530
 ] 

ASF GitHub Bot commented on ARTEMIS-396:


GitHub user dudaerich opened a pull request:

https://github.com/apache/activemq-artemis/pull/389

ARTEMIS-396 - [Artemis Testsuite] ReceiveTest#testReceiveImmediate fails



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dudaerich/activemq-artemis ARTEMIS-396

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #389


commit 1630e4c919c7a35d16f380fedfe0773a5185b70f
Author: Erich Duda 
Date:   2016-02-12T12:31:25Z

ARTEMIS-396 - [Artemis Testsuite] ReceiveTest#testReceiveImmediate fails




> [Artemis Testsuite] ReceiveTest#testReceiveImmediate fails
> --
>
> Key: ARTEMIS-396
> URL: https://issues.apache.org/jira/browse/ARTEMIS-396
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Erich Duda
>
> {code}
> java.lang.AssertionError: null
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertNotNull(Assert.java:621)
>   at org.junit.Assert.assertNotNull(Assert.java:631)
>   at 
> org.apache.activemq.artemis.tests.integration.client.ReceiveTest.testReceiveImmediate(ReceiveTest.java:152)
> {code}
> Sending nondurable messages is not blocking by default. We have to ensure 
> that all messages were received by server before we start consume them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-396) [Artemis Testsuite] ReceiveTest#testReceiveImmediate fails

2016-02-12 Thread Erich Duda (JIRA) 
Erich Duda created ARTEMIS-396:
--

 Summary: [Artemis Testsuite] ReceiveTest#testReceiveImmediate fails
 Key: ARTEMIS-396
 URL: https://issues.apache.org/jira/browse/ARTEMIS-396
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Erich Duda


{code}
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertNotNull(Assert.java:621)
at org.junit.Assert.assertNotNull(Assert.java:631)
at 
org.apache.activemq.artemis.tests.integration.client.ReceiveTest.testReceiveImmediate(ReceiveTest.java:152)
{code}

Sending nondurable messages is not blocking by default. We have to ensure that 
all messages were received by server before we start consume them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (AMQ-6168) STOMP: Connection should be closed on receiving an invalid STOMP Frame with unknown action value.

2016-02-12 Thread Timothy Bish (JIRA) 
Timothy Bish created AMQ-6168:
-

 Summary: STOMP: Connection should be closed on receiving an 
invalid STOMP Frame with unknown action value.
 Key: AMQ-6168
 URL: https://issues.apache.org/jira/browse/AMQ-6168
 Project: ActiveMQ
  Issue Type: Bug
  Components: stomp
Affects Versions: 5.13.0, 5.13.1
Reporter: Timothy Bish
Assignee: Timothy Bish
 Fix For: 5.14.0


When a STOMP frame comes in and the "action" is not known the transport doesn't 
currently throw a fatal protocol exception.  This can lead to issues if the 
incoming data is corrupt and the transport can continue to try and read more 
commands from the stream and start logging binary data or reading in garbage 
commands.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-5695) KahaDB not cleaning up log files

2016-02-12 Thread Timothy Bish (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144656#comment-15144656
 ] 

Timothy Bish commented on AMQ-5695:
---

Some recent fixes in this area around cleaning out logs files, would be good to 
retest with the v5.13.1 and see how that works out.  A reproducer for the issue 
will really help if you can figure out a test case that can trigger it.  

> KahaDB not cleaning up log files
> 
>
> Key: AMQ-5695
> URL: https://issues.apache.org/jira/browse/AMQ-5695
> Project: ActiveMQ
>  Issue Type: Bug
>Affects Versions: 5.11.1
>Reporter: Stefan Warten
>Priority: Blocker
>
> Since we have upgraded ActiveMQ from 5.10.0 to 5.11.1, KahaDB is not cleaning 
> up log files properly. It seems to keep all of them. It helped once to 
> restart the service and minutes later, ActiveMQ cleaned up 95% of log files 
> but mostly it is not cleaning up at all.
> When partition was full, I stopped ActiveMQ, copied the KahaDB to another 
> host and started it with empty queues again. Then I forwarded all messages 
> from that other host back. Even when all messages were forwarded and all 
> queues were empty, the old KahaDB log files were not cleaned up.
> I stopped ActiveMQ, removed db.data and db.redo to rebuild index which took 
> around 3h (350GB of log files) but still, the log files are not cleaned up.
> [...]
> 2015-03-30 18:21:55,532 | INFO  | @13786:158508, 32130 entries recovered 
> .. | org.apache.activemq.store.kahadb.MessageDatabase | WrapperSimpleAppMain
> 2015-03-30 18:22:02,090 | INFO  | Recovery replayed 321378917 operations from 
> the journal in 9226.159 seconds. | 
> org.apache.activemq.store.kahadb.MessageDatabase | WrapperSimpleAppMain
> 2015-03-30 18:22:02,402 | INFO  | installing runtimeConfiguration plugin | 
> org.apache.activemq.plugin.RuntimeConfigurationPlugin | WrapperSimpleAppMain
> 2015-03-30 18:22:04,576 | INFO  | Apache ActiveMQ 5.11.1 
> (prd-mig-02-sat.example.com, 
> ID:prd-mig-02-sat.example.com-26260-1427730492201-1:1) is starting | 
> org.apache.activemq.broker.BrokerService | WrapperSimpleAppMain
> 2015-03-30 18:22:04,946 | INFO  | pending local transactions: [] | 
> org.apache.activemq.store.kahadb.MultiKahaDBTransactionStore | 
> WrapperSimpleAppMain
> 2015-03-30 18:22:08,488 | INFO  | Configuration class path resource 
> [activemq.xml] | org.apache.activemq.plugin.RuntimeConfigurationBroker | 
> WrapperSimpleAppMain
> 2015-03-30 18:22:12,198 | INFO  | Listening for connections at: 
> nio://prd-mig-02-sat.example.com:61616?transport.reuseAddress=true | 
> org.apache.activemq.transport.TransportServerThreadSupport | 
> WrapperSimpleAppMain
> 2015-03-30 18:22:12,199 | INFO  | Connector openwire started | 
> org.apache.activemq.broker.TransportConnector | WrapperSimpleAppMain
> 2015-03-30 18:22:12,232 | INFO  | Listening for connections at: 
> stomp+nio://prd-mig-02-sat.example.com:61613?transport.closeAsync=false=true
>  | org.apache.activemq.transport.TransportServerThreadSupport | 
> WrapperSimpleAppMain
> 2015-03-30 18:22:12,234 | INFO  | Connector stomp started | 
> org.apache.activemq.broker.TransportConnector | WrapperSimpleAppMain
> 2015-03-30 18:22:12,237 | INFO  | Establishing network connection from 
> vm://prd-mig-02-sat.example.com?async=false=true to 
> tcp://172.42.15.40:61616 | 
> org.apache.activemq.network.DiscoveryNetworkConnector | WrapperSimpleAppMain
> 2015-03-30 18:22:12,286 | INFO  | Connector vm://prd-mig-02-sat.example.com 
> started | org.apache.activemq.broker.TransportConnector | WrapperSimpleAppMain
> 2015-03-30 18:22:12,318 | INFO  | Establishing network connection from 
> vm://prd-mig-02-sat.example.com?async=false=true to 
> tcp://172.42.15.39:61616 | 
> org.apache.activemq.network.DiscoveryNetworkConnector | WrapperSimpleAppMain
> 2015-03-30 18:22:12,321 | INFO  | Network Connector 
> DiscoveryNetworkConnector:FORWARDER:BrokerService[prd-mig-02-sat.example.com] 
> started | org.apache.activemq.network.NetworkConnector | WrapperSimpleAppMain
> 2015-03-30 18:22:12,325 | INFO  | Apache ActiveMQ 5.11.1 
> (prd-mig-02-sat.example.com, 
> ID:prd-mig-02-sat.example.com-26260-1427730492201-1:1) started | 
> org.apache.activemq.broker.BrokerService | WrapperSimpleAppMain
> 2015-03-30 18:22:12,326 | INFO  | For help or more information please see: 
> http://activemq.apache.org | org.apache.activemq.broker.BrokerService | 
> WrapperSimpleAppMain
> 2015-03-30 18:22:12,381 | INFO  | Network connection between 
> vm://prd-mig-02-sat.example.com#0 and tcp:///172.42.15.40:61616@58567 
> (prdvip-amq-01-sat.example.com) has been established. | 
> org.apache.activemq.network.DemandForwardingBridgeSupport | 
> triggerStartAsyncNetworkBridgeCreation: 
> remoteBroker=tcp:///172.42.15.40:61616@58567, localBroker= 
> vm://prd-mig-02-sat.example.com#0
>

[jira] [Commented] (AMQ-6165) Python stompest tests do not work with newer releases

2016-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144835#comment-15144835
 ] 

ASF GitHub Bot commented on AMQ-6165:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq/pull/168


> Python stompest tests do not work with newer releases
> -
>
> Key: AMQ-6165
> URL: https://issues.apache.org/jira/browse/AMQ-6165
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Test Cases
>Affects Versions: 5.13.0
> Environment: Python 2.7
>Reporter: Ingo Weiss
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.14.0
>
>
> The {{listener.py}} from the {{stompest}} API Python example doesn't work 
> with this error message:
> {noformat}
> Unhandled error in Deferred:
> Traceback (most recent call last):
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 393, in callback
> self._startRunCallbacks(result)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 501, in _startRunCallbacks
> self._runCallbacks()
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 588, in _runCallbacks
> current.result = callback(current.result, *args, **kw)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1184, in gotResult
> _inlineCallbacks(r, g, deferred)
> ---  ---
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1128, in _inlineCallbacks
> result = g.send(result)
>   File "listener.py", line 45, in run
> client.subscribe(destination, self.handleFrame, headers={'ack': 'auto', 
> 'id': 'required-for-STOMP-1.1'}, ack=False)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/stompest/util/__init__.py",
>  line 16, in __checkattr
> return f(self, *args, **kwargs)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1265, in unwindGenerator
> gen = f(*args, **kwargs)
> exceptions.TypeError: subscribe() got an unexpected keyword argument 'ack'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6165) Python stompest tests do not work with newer releases

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144834#comment-15144834
 ] 

ASF subversion and git services commented on AMQ-6165:
--

Commit 3e4bf2df7526ac1693d6ec5f162ca9054bd2b61b in activemq's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=3e4bf2d ]

https://issues.apache.org/jira/browse/AMQ-6165

Merging Python Stomp example fixes

This closes #168


> Python stompest tests do not work with newer releases
> -
>
> Key: AMQ-6165
> URL: https://issues.apache.org/jira/browse/AMQ-6165
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Test Cases
>Affects Versions: 5.13.0
> Environment: Python 2.7
>Reporter: Ingo Weiss
>Assignee: Christopher L. Shannon
>Priority: Minor
>
> The {{listener.py}} from the {{stompest}} API Python example doesn't work 
> with this error message:
> {noformat}
> Unhandled error in Deferred:
> Traceback (most recent call last):
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 393, in callback
> self._startRunCallbacks(result)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 501, in _startRunCallbacks
> self._runCallbacks()
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 588, in _runCallbacks
> current.result = callback(current.result, *args, **kw)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1184, in gotResult
> _inlineCallbacks(r, g, deferred)
> ---  ---
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1128, in _inlineCallbacks
> result = g.send(result)
>   File "listener.py", line 45, in run
> client.subscribe(destination, self.handleFrame, headers={'ack': 'auto', 
> 'id': 'required-for-STOMP-1.1'}, ack=False)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/stompest/util/__init__.py",
>  line 16, in __checkattr
> return f(self, *args, **kwargs)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1265, in unwindGenerator
> gen = f(*args, **kwargs)
> exceptions.TypeError: subscribe() got an unexpected keyword argument 'ack'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (AMQ-6165) Python stompest tests do not work with newer releases

2016-02-12 Thread Christopher L. Shannon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved AMQ-6165.
-
   Resolution: Fixed
Fix Version/s: 5.14.0

Patch applied with thanks.

> Python stompest tests do not work with newer releases
> -
>
> Key: AMQ-6165
> URL: https://issues.apache.org/jira/browse/AMQ-6165
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Test Cases
>Affects Versions: 5.13.0
> Environment: Python 2.7
>Reporter: Ingo Weiss
>Assignee: Christopher L. Shannon
>Priority: Minor
> Fix For: 5.14.0
>
>
> The {{listener.py}} from the {{stompest}} API Python example doesn't work 
> with this error message:
> {noformat}
> Unhandled error in Deferred:
> Traceback (most recent call last):
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 393, in callback
> self._startRunCallbacks(result)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 501, in _startRunCallbacks
> self._runCallbacks()
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 588, in _runCallbacks
> current.result = callback(current.result, *args, **kw)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1184, in gotResult
> _inlineCallbacks(r, g, deferred)
> ---  ---
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1128, in _inlineCallbacks
> result = g.send(result)
>   File "listener.py", line 45, in run
> client.subscribe(destination, self.handleFrame, headers={'ack': 'auto', 
> 'id': 'required-for-STOMP-1.1'}, ack=False)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/stompest/util/__init__.py",
>  line 16, in __checkattr
> return f(self, *args, **kwargs)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1265, in unwindGenerator
> gen = f(*args, **kwargs)
> exceptions.TypeError: subscribe() got an unexpected keyword argument 'ack'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (AMQ-6165) Python stompest tests do not work with newer releases

2016-02-12 Thread Christopher L. Shannon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon reassigned AMQ-6165:
---

Assignee: Christopher L. Shannon

> Python stompest tests do not work with newer releases
> -
>
> Key: AMQ-6165
> URL: https://issues.apache.org/jira/browse/AMQ-6165
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Test Cases
>Affects Versions: 5.13.0
> Environment: Python 2.7
>Reporter: Ingo Weiss
>Assignee: Christopher L. Shannon
>Priority: Minor
>
> The {{listener.py}} from the {{stompest}} API Python example doesn't work 
> with this error message:
> {noformat}
> Unhandled error in Deferred:
> Traceback (most recent call last):
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 393, in callback
> self._startRunCallbacks(result)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 501, in _startRunCallbacks
> self._runCallbacks()
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 588, in _runCallbacks
> current.result = callback(current.result, *args, **kw)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1184, in gotResult
> _inlineCallbacks(r, g, deferred)
> ---  ---
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1128, in _inlineCallbacks
> result = g.send(result)
>   File "listener.py", line 45, in run
> client.subscribe(destination, self.handleFrame, headers={'ack': 'auto', 
> 'id': 'required-for-STOMP-1.1'}, ack=False)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/stompest/util/__init__.py",
>  line 16, in __checkattr
> return f(self, *args, **kwargs)
>   File 
> "/Users/iweiss/homebrew/lib/python2.7/site-packages/twisted/internet/defer.py",
>  line 1265, in unwindGenerator
> gen = f(*args, **kwargs)
> exceptions.TypeError: subscribe() got an unexpected keyword argument 'ack'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-5662) Improve web console retry to support all DLQ names

2016-02-12 Thread Christopher L. Shannon (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144737#comment-15144737
 ] 

Christopher L. Shannon commented on AMQ-5662:
-

[~northlander], Do you mind doing a rebase on this and updating your PR now 
that 5.13.1 is out (there were some fixes done on the webconsole recently).  
This seems like a good candidate to be merged into a 5.14.0 release.

> Improve web console retry to support all DLQ names
> --
>
> Key: AMQ-5662
> URL: https://issues.apache.org/jira/browse/AMQ-5662
> Project: ActiveMQ
>  Issue Type: Improvement
>  Components: webconsole
>Affects Versions: 5.10.2, 5.11.1
>Reporter: Petter Nordlander
>Priority: Minor
>  Labels: webconsole
>
> In web console, there is a "retry" link on a message when the name of browsed 
> queue starts with DLQ. or DLT. The retry action in the console moves the 
> letter to a queue named the same as the dead letter queue but without DLQ. or 
> DLT.
> ActiveMQ, however, allows to use any name on a DLQ by using dead letter 
> strategies. A shared strategy is the default, and the original destination is 
> encoded in each message. The current implementation in web console cannot 
> handle the default DLQ strategy in ActiveMQ, which has one single DLQ named 
> ActiveMQ.DLQ.
> The suggested fix is to not rely on "move" to do a retry, but to use the 
> built in retry mechanism instead. The second part of the fix is to only show 
> the retry link when dealing with a real DLQ. A boolean is available through 
> JMX.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (AMQ-6169) STOMP: Invliad frames are logged in warn messages

2016-02-12 Thread Timothy Bish (JIRA) 
Timothy Bish created AMQ-6169:
-

 Summary: STOMP: Invliad frames are logged in warn messages
 Key: AMQ-6169
 URL: https://issues.apache.org/jira/browse/AMQ-6169
 Project: ActiveMQ
  Issue Type: Bug
  Components: stomp
Affects Versions: 5.13.1, 5.13.0, 5.12.1, 5.12.0
Reporter: Timothy Bish
Assignee: Timothy Bish
 Fix For: 5.14.0


When the STOMP protocol converter encounters a frame that is badly encoded it 
logs out a warning that prints the entire frame contents in the warn message.  
This leads to some confusing results or logs of 'null' as the decoder never got 
to creating a full frame instance before failing.  

If the frame happens to get read but contains corrupted data the log can get 
spammed with garbage characters and becomes somewhat unreadable.  

We should not log the frame if there is one at warn level, perhaps allow for 
trace logging it.  We could attempt to log the frame Action if one was read and 
is valid but otherwise should not pollute the logs with entire frames.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (AMQ-6168) STOMP: Connection should be closed on receiving an invalid STOMP Frame with unknown action value.

2016-02-12 Thread Timothy Bish (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved AMQ-6168.
---
Resolution: Fixed

> STOMP: Connection should be closed on receiving an invalid STOMP Frame with 
> unknown action value.
> -
>
> Key: AMQ-6168
> URL: https://issues.apache.org/jira/browse/AMQ-6168
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: stomp
>Affects Versions: 5.13.0, 5.13.1
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 5.14.0
>
>
> When a STOMP frame comes in and the "action" is not known the transport 
> doesn't currently throw a fatal protocol exception.  This can lead to issues 
> if the incoming data is corrupt and the transport can continue to try and 
> read more commands from the stream and start logging binary data or reading 
> in garbage commands.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6168) STOMP: Connection should be closed on receiving an invalid STOMP Frame with unknown action value.

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144920#comment-15144920
 ] 

ASF subversion and git services commented on AMQ-6168:
--

Commit adf70bc08ab4a8c3bfa87e0a7b50476aa5bab779 in activemq's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=adf70bc ]

https://issues.apache.org/jira/browse/AMQ-6168

Disconnect on unkown STOMP Command Action. 

> STOMP: Connection should be closed on receiving an invalid STOMP Frame with 
> unknown action value.
> -
>
> Key: AMQ-6168
> URL: https://issues.apache.org/jira/browse/AMQ-6168
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: stomp
>Affects Versions: 5.13.0, 5.13.1
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 5.14.0
>
>
> When a STOMP frame comes in and the "action" is not known the transport 
> doesn't currently throw a fatal protocol exception.  This can lead to issues 
> if the incoming data is corrupt and the transport can continue to try and 
> read more commands from the stream and start logging binary data or reading 
> in garbage commands.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (AMQ-6169) STOMP: Invliad frames are logged in warn messages

2016-02-12 Thread Timothy Bish (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved AMQ-6169.
---
Resolution: Fixed

> STOMP: Invliad frames are logged in warn messages
> -
>
> Key: AMQ-6169
> URL: https://issues.apache.org/jira/browse/AMQ-6169
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: stomp
>Affects Versions: 5.12.0, 5.12.1, 5.13.0, 5.13.1
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 5.14.0
>
>
> When the STOMP protocol converter encounters a frame that is badly encoded it 
> logs out a warning that prints the entire frame contents in the warn message. 
>  This leads to some confusing results or logs of 'null' as the decoder never 
> got to creating a full frame instance before failing.  
> If the frame happens to get read but contains corrupted data the log can get 
> spammed with garbage characters and becomes somewhat unreadable.  
> We should not log the frame if there is one at warn level, perhaps allow for 
> trace logging it.  We could attempt to log the frame Action if one was read 
> and is valid but otherwise should not pollute the logs with entire frames.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6169) STOMP: Invliad frames are logged in warn messages

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145070#comment-15145070
 ] 

ASF subversion and git services commented on AMQ-6169:
--

Commit b595b8bc12cf58314fb131128184fec92e7d2509 in activemq's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=b595b8b ]

https://issues.apache.org/jira/browse/AMQ-6169

Log actual STOMP frames that cause error at trace level, only log the
command action if it is present and valid.  

> STOMP: Invliad frames are logged in warn messages
> -
>
> Key: AMQ-6169
> URL: https://issues.apache.org/jira/browse/AMQ-6169
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: stomp
>Affects Versions: 5.12.0, 5.12.1, 5.13.0, 5.13.1
>Reporter: Timothy Bish
>Assignee: Timothy Bish
> Fix For: 5.14.0
>
>
> When the STOMP protocol converter encounters a frame that is badly encoded it 
> logs out a warning that prints the entire frame contents in the warn message. 
>  This leads to some confusing results or logs of 'null' as the decoder never 
> got to creating a full frame instance before failing.  
> If the frame happens to get read but contains corrupted data the log can get 
> spammed with garbage characters and becomes somewhat unreadable.  
> We should not log the frame if there is one at warn level, perhaps allow for 
> trace logging it.  We could attempt to log the frame Action if one was read 
> and is valid but otherwise should not pollute the logs with entire frames.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (AMQ-6170) X-Frame-Options are not set for static content

2016-02-12 Thread Christopher L. Shannon (JIRA) 
Christopher L. Shannon created AMQ-6170:
---

 Summary: X-Frame-Options are not set for static content
 Key: AMQ-6170
 URL: https://issues.apache.org/jira/browse/AMQ-6170
 Project: ActiveMQ
  Issue Type: Bug
  Components: Broker
Affects Versions: 5.13.1, 5.12.2, 5.11.4
Reporter: Christopher L. Shannon
Assignee: Christopher L. Shannon


In AMQ-6113, The X-Frame-Options header was added to the web console.  
Unfortunately that patch isn't quite correct because static content is still 
missing this header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145273#comment-15145273
 ] 

ASF subversion and git services commented on AMQ-6113:
--

Commit 028a33ea7d73fabe6161defffdbfc85578328a68 in activemq's branch 
refs/heads/activemq-5.13.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=028a33e ]

https://issues.apache.org/jira/browse/AMQ-6170

Fixing X-Frame-Options header so that is applied for all content served
by Jetty.  The previous patch wasn't correct because it only applied it
to Servlets and JSPs and not static content. This also reverts AMQ-6113

(cherry picked from commit 24ad36778534c5ac888f880837075449169578ad)


> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.11.4, 5.13.1, 5.14.0, 5.12.3
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6162) DLQ'd message does not get DLQ'd again until broker restart

2016-02-12 Thread Timothy Bish (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145546#comment-15145546
 ] 

Timothy Bish commented on AMQ-6162:
---

I dug a little deeper and the issue is that the setup you have were the message 
passes through multiple DLQ's makes it quite tricky to not capture the message 
as a duplicate when it passes through the chain of Queues again.  The move does 
rollback the message from the audit of DLQ2 but the broker doesn't know that 
the message was previously in DLQ1 and so it can't run back through and remove 
the message from the audit of that Queue.  You can work around this by 
disabling the Audit for your dead letter strategies which will prevent the 
tiered DLQ's from filtering out the message on repeated cycles through them.  

> DLQ'd message does not get DLQ'd again until broker restart
> ---
>
> Key: AMQ-6162
> URL: https://issues.apache.org/jira/browse/AMQ-6162
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.13.0
>Reporter: Jo Vandermeeren
>Priority: Critical
> Attachments: AMQ6162Test.java
>
>
> Given the following setup: Q1 -> DLQ1 (dead letter for Q1) -> DLQ2 (dead 
> letter for Q2).
> Sessions are transacted.
> 1. Send message to Q1
> 2. Consume Q1 and rollback
> 3. Message is DLQ'd to DLQ1
> 4. Consume DLQ1 and rollback
> 5. Message is DLQ'd to DLQ2
> 6. Move message via JMX from DLQ2 to Q1 (QueueViewMBean.moveMessageTo())
> 7. Consume Q1 and rollback
> 8. DLQ1 stays empty, message seems lost
> If you restart the broker between step 5 and step 6, the message does get 
> DLQ'd to DLQ1 again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6113) Add the X-Frame-Options" header for the WebConsole

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145271#comment-15145271
 ] 

ASF subversion and git services commented on AMQ-6113:
--

Commit 24ad36778534c5ac888f880837075449169578ad in activemq's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=24ad367 ]

https://issues.apache.org/jira/browse/AMQ-6170

Fixing X-Frame-Options header so that is applied for all content served
by Jetty.  The previous patch wasn't correct because it only applied it
to Servlets and JSPs and not static content. This also reverts AMQ-6113


> Add the X-Frame-Options" header for the WebConsole
> --
>
> Key: AMQ-6113
> URL: https://issues.apache.org/jira/browse/AMQ-6113
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
> Environment: centos 6
>Reporter: Michael Furman
>Assignee: Christopher L. Shannon
> Fix For: 5.11.4, 5.13.1, 5.14.0, 5.12.3
>
>
> The X-Frame-Options header is missing for the ActiveMQ Web Console and it 
> should be added to all responses



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6170) X-Frame-Options are not set for static content

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145270#comment-15145270
 ] 

ASF subversion and git services commented on AMQ-6170:
--

Commit 24ad36778534c5ac888f880837075449169578ad in activemq's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=24ad367 ]

https://issues.apache.org/jira/browse/AMQ-6170

Fixing X-Frame-Options header so that is applied for all content served
by Jetty.  The previous patch wasn't correct because it only applied it
to Servlets and JSPs and not static content. This also reverts AMQ-6113


> X-Frame-Options are not set for static content
> --
>
> Key: AMQ-6170
> URL: https://issues.apache.org/jira/browse/AMQ-6170
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.12.2, 5.11.4, 5.13.1
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>
> In AMQ-6113, The X-Frame-Options header was added to the web console.  
> Unfortunately that patch isn't quite correct because static content is still 
> missing this header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6170) X-Frame-Options are not set for static content

2016-02-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145272#comment-15145272
 ] 

ASF subversion and git services commented on AMQ-6170:
--

Commit 028a33ea7d73fabe6161defffdbfc85578328a68 in activemq's branch 
refs/heads/activemq-5.13.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=028a33e ]

https://issues.apache.org/jira/browse/AMQ-6170

Fixing X-Frame-Options header so that is applied for all content served
by Jetty.  The previous patch wasn't correct because it only applied it
to Servlets and JSPs and not static content. This also reverts AMQ-6113

(cherry picked from commit 24ad36778534c5ac888f880837075449169578ad)


> X-Frame-Options are not set for static content
> --
>
> Key: AMQ-6170
> URL: https://issues.apache.org/jira/browse/AMQ-6170
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.12.2, 5.11.4, 5.13.1
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>
> In AMQ-6113, The X-Frame-Options header was added to the web console.  
> Unfortunately that patch isn't quite correct because static content is still 
> missing this header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (AMQ-6170) X-Frame-Options are not set for static content

2016-02-12 Thread Christopher L. Shannon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved AMQ-6170.
-
   Resolution: Fixed
Fix Version/s: 5.13.2
   5.14.0

Jetty has been configured to set the header for static content as well.

> X-Frame-Options are not set for static content
> --
>
> Key: AMQ-6170
> URL: https://issues.apache.org/jira/browse/AMQ-6170
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.12.2, 5.11.4, 5.13.1
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
> Fix For: 5.14.0, 5.13.2
>
>
> In AMQ-6113, The X-Frame-Options header was added to the web console.  
> Unfortunately that patch isn't quite correct because static content is still 
> missing this header.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)