[jira] [Commented] (AMQ-6118) ActiveMQ SSL CRL Checking via OCSP
[ https://issues.apache.org/jira/browse/AMQ-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158455#comment-15158455 ] Marko Jovanovic commented on AMQ-6118: -- Hey Christopher, thanks for your opinion. The post you linked in above, is from me. Could you tell me how to raise this request into "needs_review" section? Or how to create a feature request? I spent some time on an alternative idea with the static crl list. I could bring in an idea for adding the crl list loadup to the runtime configuration. So it's possible for the users to load it manually without broker restart. That's an alternative way to get client certificates managed. It would be very glad, when this feature would be reviewed in total. > ActiveMQ SSL CRL Checking via OCSP > -- > > Key: AMQ-6118 > URL: https://issues.apache.org/jira/browse/AMQ-6118 > Project: ActiveMQ > Issue Type: Bug > Components: Broker >Affects Versions: 5.12.1 > Environment: Windows Server 2012R2 with ActiveMQ Windows Distribution >Reporter: Marko Jovanovic > Attachments: jvm_args.png > > > For some unknown reason, the CRL Check via OCSP isn't working in Windows > ActiveMQ 5.12.1 > After reviewing the Linux distribution of Activemq there was a configuration > line found in the file bin/env. > The Config in Linux Distribution looked like: > # Set additional JSE arguments > #ACTIVEMQ_SSL_OPTS="-Dcom.sun.security.enableCRLDP=true -Docsp.enable=true > -Docsp.responderURL=http://ocsp.example.net:80"; > Where to set it in Windows file distribution? > Tried to set it in activemq file but no success. I couldn't see any request > going to the responder URL which I configured. > Think there is a general Problem with the code concerning OCSP functionality. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-416) Netty Acceptor allows transfer of connections when paused
[ https://issues.apache.org/jira/browse/ARTEMIS-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157164#comment-15157164 ] ASF subversion and git services commented on ARTEMIS-416: - Commit f6ea511b8ada36d2847a16415ea5fef8f3c71665 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f6ea511 ] ARTEMIS-416 - Netty Acceptor allows transfer of connections when paused Throw an exception if the acceptor is paused or not started https://issues.apache.org/jira/browse/ARTEMIS-416 > Netty Acceptor allows transfer of connections when paused > - > > Key: ARTEMIS-416 > URL: https://issues.apache.org/jira/browse/ARTEMIS-416 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > we should handle this with an exception or something similar -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQ-6179) Broker crashes after a few minutes of reading and writing messages
Jason Morawski created AMQ-6179: --- Summary: Broker crashes after a few minutes of reading and writing messages Key: AMQ-6179 URL: https://issues.apache.org/jira/browse/AMQ-6179 Project: ActiveMQ Issue Type: Bug Components: activemq-leveldb-store Affects Versions: 5.13.1 Environment: RHEL6 Reporter: Jason Morawski Priority: Critical I am using a Replicated Level DB setup of ActiveMQ 5.13.1 The cluster starts successfully, however the broker crashes after a few minutes of reading and writing messages. The log contains either one of the following two stack traces: 2016-02-19 13:56:18,320 [eption handler.] INFO DefaultIOExceptionHandler - Stopping BrokerService[localhost] due to exception, java.io.IOExce ption: Unexpected locator type: null java.io.IOException: Unexpected locator type: null at org.apache.activemq.util.IOExceptionSupport.create(IOExceptionSupport.java:39) at org.apache.activemq.leveldb.LevelDBClient.might_fail(LevelDBClient.scala:552) at org.apache.activemq.leveldb.LevelDBClient.might_fail_using_index(LevelDBClient.scala:1044) at org.apache.activemq.leveldb.LevelDBClient.store(LevelDBClient.scala:1390) at org.apache.activemq.leveldb.DBManager$$anonfun$drainFlushes$1.apply$mcV$sp(DBManager.scala:627) at org.fusesource.hawtdispatch.package$$anon$4.run(hawtdispatch.scala:330) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.RuntimeException: Unexpected locator type: null at org.apache.activemq.leveldb.LevelDBClient$$anonfun$write_uows$1$$anonfun$apply$28$$anonfun$apply$29.apply(LevelDBClient.scala:1444) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$write_uows$1$$anonfun$apply$28$$anonfun$apply$29.apply(LevelDBClient.scala:1436) at scala.collection.immutable.List.foreach(List.scala:383) at scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35) at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$write_uows$1$$anonfun$apply$28.apply(LevelDBClient.scala:1436) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$write_uows$1$$anonfun$apply$28.apply(LevelDBClient.scala:1419) at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:778) at scala.collection.immutable.Map$Map1.foreach(Map.scala:116) at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:777) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$write_uows$1.apply(LevelDBClient.scala:1419) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$write_uows$1.apply(LevelDBClient.scala:1418) at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33) at scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:186) at org.apache.activemq.leveldb.LevelDBClient.write_uows(LevelDBClient.scala:1418) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1$$anonfun$apply$mcV$sp$14$$anonfun$5.apply(LevelDBClient.scala:1393) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1$$anonfun$apply$mcV$sp$14$$anonfun$5.apply(LevelDBClient.scala:1392) at org.apache.activemq.leveldb.LevelDBClient$RichDB.write(LevelDBClient.scala:230) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1$$anonfun$apply$mcV$sp$14.apply(LevelDBClient.scala:1392) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1$$anonfun$apply$mcV$sp$14.apply(LevelDBClient.scala:1391) at org.apache.activemq.leveldb.RecordLog$$anonfun$appender$1.apply(RecordLog.scala:569) at org.apache.activemq.leveldb.util.TimeMetric.apply(TimeMetric.scala:43) at org.apache.activemq.leveldb.RecordLog.appender(RecordLog.scala:568) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1.apply$mcV$sp(LevelDBClient.scala:1391) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1.apply(LevelDBClient.scala:1390) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$store$1.apply(LevelDBClient.scala:1390) at org.apache.activemq.leveldb.LevelDBClient.usingIndex(LevelDBClient.scala:1038) at org.apache.activemq.leveldb.LevelDBClient$$anonfun$might_fail_using_index$1.apply(LevelDBClient.scala:1044) at org.apache.activemq.leveldb.LevelDBClient.might_fail(LevelDBClient.scala:549) ... 7 more or 2016-02-19 13:59:53,886 [eption handler.] INFO DefaultIOExceptionHandler - Stopping BrokerService[localho
[jira] [Commented] (ARTEMIS-416) Netty Acceptor allows transfer of connections when paused
[ https://issues.apache.org/jira/browse/ARTEMIS-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157163#comment-15157163 ] ASF subversion and git services commented on ARTEMIS-416: - Commit f6ea511b8ada36d2847a16415ea5fef8f3c71665 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f6ea511 ] ARTEMIS-416 - Netty Acceptor allows transfer of connections when paused Throw an exception if the acceptor is paused or not started https://issues.apache.org/jira/browse/ARTEMIS-416 > Netty Acceptor allows transfer of connections when paused > - > > Key: ARTEMIS-416 > URL: https://issues.apache.org/jira/browse/ARTEMIS-416 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > we should handle this with an exception or something similar -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-416) Netty Acceptor allows transfer of connections when paused
[ https://issues.apache.org/jira/browse/ARTEMIS-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157165#comment-15157165 ] ASF GitHub Bot commented on ARTEMIS-416: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/399 > Netty Acceptor allows transfer of connections when paused > - > > Key: ARTEMIS-416 > URL: https://issues.apache.org/jira/browse/ARTEMIS-416 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > we should handle this with an exception or something similar -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-415) [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages
[ https://issues.apache.org/jira/browse/ARTEMIS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157144#comment-15157144 ] ASF GitHub Bot commented on ARTEMIS-415: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/398 > [Artemis Testsuite] > NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages > --- > > Key: ARTEMIS-415 > URL: https://issues.apache.org/jira/browse/ARTEMIS-415 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Erich Duda > > {code} > java.lang.AssertionError: expected:<20> but was:<13> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.junit.Assert.assertEquals(Assert.java:542) > at > org.apache.activemq.artemis.tests.integration.paging.PagingSendTest.testPagingDoesNotDuplicateBatchMessages(PagingSendTest.java:242) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55) > at java.lang.reflect.Method.invoke(Method.java:507) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) > at org.junit.runners.ParentRunner.run(ParentRunner.java:309) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:275) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:149) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > {code} > This failure happens when {{Queue.deliverAsync}} is too slow and the iterator > is created before that aforementioned method add references to internal > structures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-415) [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages
[ https://issues.apache.org/jira/browse/ARTEMIS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157142#comment-15157142 ] ASF subversion and git services commented on ARTEMIS-415: - Commit a4c4f811ebf5816ad1152c08c34e559ae08a842a in activemq-artemis's branch refs/heads/master from [~eduda] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a4c4f81 ] ARTEMIS-415 - [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages > [Artemis Testsuite] > NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages > --- > > Key: ARTEMIS-415 > URL: https://issues.apache.org/jira/browse/ARTEMIS-415 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Erich Duda > > {code} > java.lang.AssertionError: expected:<20> but was:<13> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.junit.Assert.assertEquals(Assert.java:542) > at > org.apache.activemq.artemis.tests.integration.paging.PagingSendTest.testPagingDoesNotDuplicateBatchMessages(PagingSendTest.java:242) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55) > at java.lang.reflect.Method.invoke(Method.java:507) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) > at org.junit.runners.ParentRunner.run(ParentRunner.java:309) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:275) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:149) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > {code} > This failure happens when {{Queue.deliverAsync}} is too slow and the iterator > is created before that aforementioned method add references to internal > structures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-416) Netty Acceptor allows transfer of connections when paused
[ https://issues.apache.org/jira/browse/ARTEMIS-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157131#comment-15157131 ] ASF GitHub Bot commented on ARTEMIS-416: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/399 ARTEMIS-416 - Netty Acceptor allows transfer of connections when paused Throw an exception if the acceptor is paused or not started https://issues.apache.org/jira/browse/ARTEMIS-416 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/399.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #399 commit 3e9320a73ea16d8d74dc669b8beb64510fa58307 Author: Andy Taylor Date: 2016-02-22T14:26:59Z ARTEMIS-416 - Netty Acceptor allows transfer of connections when paused Throw an exception if the acceptor is paused or not started https://issues.apache.org/jira/browse/ARTEMIS-416 > Netty Acceptor allows transfer of connections when paused > - > > Key: ARTEMIS-416 > URL: https://issues.apache.org/jira/browse/ARTEMIS-416 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > we should handle this with an exception or something similar -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5876) improve performance of TextFileCertificateLoginModule when many entries are in the "textfiledn.user " file
[ https://issues.apache.org/jira/browse/AMQ-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157023#comment-15157023 ] Torsten Mielke commented on AMQ-5876: - Property reload=true will need more documentation. > improve performance of TextFileCertificateLoginModule when many entries are > in the "textfiledn.user " file > -- > > Key: AMQ-5876 > URL: https://issues.apache.org/jira/browse/AMQ-5876 > Project: ActiveMQ > Issue Type: Improvement > Components: jaas, security >Affects Versions: 5.11.1 >Reporter: Gary Tully >Assignee: Gary Tully > Labels: jaas > Fix For: 5.12.0 > > > With a large number of entries ( 200,000 ) in the > "org.apache.activemq.jaas.textfiledn.user" file the performance seemed to > degrade. > To demonstrate the performance difference; > {code} > 1) for 100 entries and calling initialize,login(),commit 10 times - Time > taken is 73 miliseconds > 2) for 200,000 entries and calling initialize,login(),commit 10 times - Time > taken is 5020 miliseconds > {code} > Suggested improvements: > - avoid loading the org.apache.activemq.jaas.textfiledn.user file each time > - in PropertiesLoginModule.java, the file is only read when it changes, using > the file modification time. > - avoid iterating through the Properties object, using a Map instead to > retrieve the userName -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-416) Netty Acceptor allows transfer of connections when paused
Andy Taylor created ARTEMIS-416: --- Summary: Netty Acceptor allows transfer of connections when paused Key: ARTEMIS-416 URL: https://issues.apache.org/jira/browse/ARTEMIS-416 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Andy Taylor Assignee: Andy Taylor we should handle this with an exception or something similar -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5876) improve performance of TextFileCertificateLoginModule when many entries are in the "textfiledn.user " file
[ https://issues.apache.org/jira/browse/AMQ-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157002#comment-15157002 ] Torsten Mielke commented on AMQ-5876: - Took me quite a bit of debugging to find out, hence summarising it here. With this fix, JAAS LoginModules that load property files such as PropertiesLoginModule and TextFileCertificateLoginModule will not reload from file system by default (not even when file got modified on disk) unless reload=true is explicitly configured. An example for the standard conf/login.config: {code} activemq { org.apache.activemq.jaas.PropertiesLoginModule required org.apache.activemq.jaas.properties.user="users.properties" org.apache.activemq.jaas.properties.group="groups.properties" reload=true; }; {code} Again, reload=true needs to be present in the login module configuration, otherwise these files will only be read at broker startup time. This is a change in behavior from 5.11 and earlier where we would always reload these files. > improve performance of TextFileCertificateLoginModule when many entries are > in the "textfiledn.user " file > -- > > Key: AMQ-5876 > URL: https://issues.apache.org/jira/browse/AMQ-5876 > Project: ActiveMQ > Issue Type: Improvement > Components: jaas, security >Affects Versions: 5.11.1 >Reporter: Gary Tully >Assignee: Gary Tully > Labels: jaas > Fix For: 5.12.0 > > > With a large number of entries ( 200,000 ) in the > "org.apache.activemq.jaas.textfiledn.user" file the performance seemed to > degrade. > To demonstrate the performance difference; > {code} > 1) for 100 entries and calling initialize,login(),commit 10 times - Time > taken is 73 miliseconds > 2) for 200,000 entries and calling initialize,login(),commit 10 times - Time > taken is 5020 miliseconds > {code} > Suggested improvements: > - avoid loading the org.apache.activemq.jaas.textfiledn.user file each time > - in PropertiesLoginModule.java, the file is only read when it changes, using > the file modification time. > - avoid iterating through the Properties object, using a Map instead to > retrieve the userName -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6177) Make ActiveMQ build and test pass in Newfoundland
[ https://issues.apache.org/jira/browse/AMQ-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156855#comment-15156855 ] ASF subversion and git services commented on AMQ-6177: -- Commit 0f445a535f8ec1135d6769a9e7c1503fd7b26121 in activemq's branch refs/heads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=0f445a5 ] https://issues.apache.org/jira/browse/AMQ-6177 Fixing CronParserTest so that it checks 24 hour format properly when using a timezone shifted by 30 minutes Thanks to Jamie Goodyear for the patch > Make ActiveMQ build and test pass in Newfoundland > - > > Key: AMQ-6177 > URL: https://issues.apache.org/jira/browse/AMQ-6177 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.13.1, 5.14.0 >Reporter: Jamie goodyear >Assignee: Christopher L. Shannon > Labels: test > Attachments: amq6177-513xpatch.diff, amq6177-master.diff > > > Certain tests such as org.apache.activemq.broker.scheduler.CronParserTest, > require a build/test to be run on an epoch that is aligned with the hour. In > timezones such as Newfounland, which is shifted by 30 minutes, these tests > fail. > Lets update the build/test suite to work in any time zone. > (Verified by changing timezone from NST to EST -- on EST the test suite > passes) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (AMQ-6177) Make ActiveMQ build and test pass in Newfoundland
[ https://issues.apache.org/jira/browse/AMQ-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon resolved AMQ-6177. - Resolution: Fixed Fix Version/s: 5.13.2 5.14.0 [~jgoodyear], I have applied your patch to both master and 5.13.x, thanks for tracking down the cause of this. > Make ActiveMQ build and test pass in Newfoundland > - > > Key: AMQ-6177 > URL: https://issues.apache.org/jira/browse/AMQ-6177 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.13.1, 5.14.0 >Reporter: Jamie goodyear >Assignee: Christopher L. Shannon > Labels: test > Fix For: 5.14.0, 5.13.2 > > Attachments: amq6177-513xpatch.diff, amq6177-master.diff > > > Certain tests such as org.apache.activemq.broker.scheduler.CronParserTest, > require a build/test to be run on an epoch that is aligned with the hour. In > timezones such as Newfounland, which is shifted by 30 minutes, these tests > fail. > Lets update the build/test suite to work in any time zone. > (Verified by changing timezone from NST to EST -- on EST the test suite > passes) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (AMQ-6177) Make ActiveMQ build and test pass in Newfoundland
[ https://issues.apache.org/jira/browse/AMQ-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon reassigned AMQ-6177: --- Assignee: Christopher L. Shannon > Make ActiveMQ build and test pass in Newfoundland > - > > Key: AMQ-6177 > URL: https://issues.apache.org/jira/browse/AMQ-6177 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.13.1, 5.14.0 >Reporter: Jamie goodyear >Assignee: Christopher L. Shannon > Labels: test > Attachments: amq6177-513xpatch.diff, amq6177-master.diff > > > Certain tests such as org.apache.activemq.broker.scheduler.CronParserTest, > require a build/test to be run on an epoch that is aligned with the hour. In > timezones such as Newfounland, which is shifted by 30 minutes, these tests > fail. > Lets update the build/test suite to work in any time zone. > (Verified by changing timezone from NST to EST -- on EST the test suite > passes) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6177) Make ActiveMQ build and test pass in Newfoundland
[ https://issues.apache.org/jira/browse/AMQ-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156856#comment-15156856 ] ASF subversion and git services commented on AMQ-6177: -- Commit a1f309ea19c3766157566bcef1f3b1a02458a0de in activemq's branch refs/heads/activemq-5.13.x from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=a1f309e ] https://issues.apache.org/jira/browse/AMQ-6177 Fixing CronParserTest so that it checks 24 hour format properly when using a timezone shifted by 30 minutes Thanks to Jamie Goodyear for the patch (cherry picked from commit 0f445a535f8ec1135d6769a9e7c1503fd7b26121) > Make ActiveMQ build and test pass in Newfoundland > - > > Key: AMQ-6177 > URL: https://issues.apache.org/jira/browse/AMQ-6177 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.13.1, 5.14.0 >Reporter: Jamie goodyear >Assignee: Christopher L. Shannon > Labels: test > Attachments: amq6177-513xpatch.diff, amq6177-master.diff > > > Certain tests such as org.apache.activemq.broker.scheduler.CronParserTest, > require a build/test to be run on an epoch that is aligned with the hour. In > timezones such as Newfounland, which is shifted by 30 minutes, these tests > fail. > Lets update the build/test suite to work in any time zone. > (Verified by changing timezone from NST to EST -- on EST the test suite > passes) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (AMQ-6178) AMQP: Update Qpid JMS to 0.8.0
[ https://issues.apache.org/jira/browse/AMQ-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved AMQ-6178. - Resolution: Fixed > AMQP: Update Qpid JMS to 0.8.0 > -- > > Key: AMQ-6178 > URL: https://issues.apache.org/jira/browse/AMQ-6178 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 5.14.0, 5.13.2 > > > Update to use the latest release of Qpid JMS -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6178) AMQP: Update Qpid JMS to 0.8.0
[ https://issues.apache.org/jira/browse/AMQ-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156791#comment-15156791 ] ASF subversion and git services commented on AMQ-6178: -- Commit e81c32f63c854f127fc9d255ba4a214922c6e775 in activemq's branch refs/heads/activemq-5.13.x from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=e81c32f ] AMQ-6178: update to Qpid JMS 0.8.0 (cherry picked from commit f7941a7fbf55137ecdf3430e1846ecee9d9c4b4f) > AMQP: Update Qpid JMS to 0.8.0 > -- > > Key: AMQ-6178 > URL: https://issues.apache.org/jira/browse/AMQ-6178 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 5.14.0, 5.13.2 > > > Update to use the latest release of Qpid JMS -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6178) AMQP: Update Qpid JMS to 0.8.0
[ https://issues.apache.org/jira/browse/AMQ-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156783#comment-15156783 ] ASF subversion and git services commented on AMQ-6178: -- Commit f7941a7fbf55137ecdf3430e1846ecee9d9c4b4f in activemq's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=f7941a7 ] AMQ-6178: update to Qpid JMS 0.8.0 > AMQP: Update Qpid JMS to 0.8.0 > -- > > Key: AMQ-6178 > URL: https://issues.apache.org/jira/browse/AMQ-6178 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 5.14.0, 5.13.2 > > > Update to use the latest release of Qpid JMS -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6178) AMQP: Update Qpid JMS to 0.8.0
[ https://issues.apache.org/jira/browse/AMQ-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated AMQ-6178: Fix Version/s: (was: 5.12.3) 5.13.2 > AMQP: Update Qpid JMS to 0.8.0 > -- > > Key: AMQ-6178 > URL: https://issues.apache.org/jira/browse/AMQ-6178 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 5.14.0, 5.13.2 > > > Update to use the latest release of Qpid JMS -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQ-6178) AMQP: Update Qpid JMS to 0.8.0
Robbie Gemmell created AMQ-6178: --- Summary: AMQP: Update Qpid JMS to 0.8.0 Key: AMQ-6178 URL: https://issues.apache.org/jira/browse/AMQ-6178 Project: ActiveMQ Issue Type: Task Components: AMQP Reporter: Robbie Gemmell Assignee: Robbie Gemmell Priority: Minor Fix For: 5.14.0, 5.12.3 Update to use the latest release of Qpid JMS -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-415) [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages
[ https://issues.apache.org/jira/browse/ARTEMIS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156610#comment-15156610 ] ASF GitHub Bot commented on ARTEMIS-415: GitHub user dudaerich opened a pull request: https://github.com/apache/activemq-artemis/pull/398 ARTEMIS-415 - [Artemis Testsuite] NettyPagingSendTest#testPagingDoesN… …otDuplicateBatchMessages You can merge this pull request into a Git repository by running: $ git pull https://github.com/dudaerich/activemq-artemis ARTEMIS-415 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/398.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #398 commit 4fe11acc2a49358b6ac8da92543591f938dc9585 Author: Erich Duda Date: 2016-02-22T08:23:23Z ARTEMIS-415 - [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages > [Artemis Testsuite] > NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages > --- > > Key: ARTEMIS-415 > URL: https://issues.apache.org/jira/browse/ARTEMIS-415 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Erich Duda > > {code} > java.lang.AssertionError: expected:<20> but was:<13> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.junit.Assert.assertEquals(Assert.java:542) > at > org.apache.activemq.artemis.tests.integration.paging.PagingSendTest.testPagingDoesNotDuplicateBatchMessages(PagingSendTest.java:242) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55) > at java.lang.reflect.Method.invoke(Method.java:507) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) > at org.junit.runners.ParentRunner.run(ParentRunner.java:309) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:275) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:149) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > {code} > This failure happens when {{Queue.deliverAsync}} is too slow and the iterator > is created before that aforementioned method add references to internal > structures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-415) [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages
Erich Duda created ARTEMIS-415: -- Summary: [Artemis Testsuite] NettyPagingSendTest#testPagingDoesNotDuplicateBatchMessages Key: ARTEMIS-415 URL: https://issues.apache.org/jira/browse/ARTEMIS-415 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 1.1.0 Reporter: Erich Duda {code} java.lang.AssertionError: expected:<20> but was:<13> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.activemq.artemis.tests.integration.paging.PagingSendTest.testPagingDoesNotDuplicateBatchMessages(PagingSendTest.java:242) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55) at java.lang.reflect.Method.invoke(Method.java:507) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:275) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:149) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) {code} This failure happens when {{Queue.deliverAsync}} is too slow and the iterator is created before that aforementioned method add references to internal structures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)