[jira] [Resolved] (ARTEMIS-1227) Internal properties not removed from messages
[ https://issues.apache.org/jira/browse/ARTEMIS-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard Gao resolved ARTEMIS-1227. - Resolution: Fixed > Internal properties not removed from messages > - > > Key: ARTEMIS-1227 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1227 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 1.5.6, 2.2.0 > > > In a cluster if a node is shut down (or crashed) when a > message is being routed to a remote binding, a internal > property may be added to the message and persisted. The > name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. > if the node starts back, it will load and reroute this message > and if it goes to a local consumer, this property won't > get removed and goes to the client. > The fix is to remove this internal property before it > is sent to any client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (ARTEMIS-1217) Race condition during session reconnection
[
https://issues.apache.org/jira/browse/ARTEMIS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046933#comment-16046933
]
Justin Bertram edited comment on ARTEMIS-1217 at 6/12/17 7:13 PM:
--
I believe this is happening because your test is creating the server with
persistence disabled. See this line:
{code:java}
server = createServer(false, config);
{code}
Therefore when the server restarts the queue is gone because it wasn't
persisted to disk.
was (Author: jbertram):
I believe this is happening because your test is creating the server with
persistence disabled. See this line:
{code:java}
server = createServer(true, config);
{code}
Therefore when the server restarts the queue is gone because it wasn't
persisted to disk.
> Race condition during session reconnection
> --
>
> Key: ARTEMIS-1217
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1217
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Andrius Dagys
>Priority: Minor
>
> We have the following scenario:
> There's a client and a server. The server runs a broker and creates a session
> with a producer/consumer to monitor the server queue and respond to client
> requests.
> The client establishes a session with the server broker, creates a client
> queue and a producer/consumer to send requests to the server and receive
> responses.
> In one of our tests we check that the client can correctly reconnect when the
> server (and the broker) restarts. The problem is that occasionally after
> reconnecting the client is able to send a request message to the server
> queue, but the server fails to send a response message due to the client
> queue bindings not being set yet.
> It also seems to be caused by the fact that the client uses different
> sessions for consumer & producer. However, this issue started occurring only
> after we updated from 1.5.3 to 2.1.0.
> Here's an excerpt from the logs:
> {code}
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> impl.RemotingConnectionImpl.bufferReceived - handling packet
> PACKET(SessionSendMessage)[type=71, channelID=10,
> packetObject=SessionSendMessage, message=ServerMessage[messageID=0],
> requiresResponse=false]
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.handlePacket -
> ServerSessionPacketHandler::handlePacket,PACKET(SessionSendMessage)[type=71,
> channelID=10, packetObject=SessionSendMessage,
> message=ServerMessage[messageID=0], requiresResponse=false]
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.ServerSessionImpl.send -
> send(message=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329,
> direct=true) being called
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.SecurityStoreImpl.check -
> checking access permissions to rpc.client.user1.5976801431518807802
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Couldn't find any bindings for address=rpc.client.user1.5976801431518807802
> on message=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Message after
> routed=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Message CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> is not going anywhere as it didn't have a binding on
> address:rpc.client.user1.5976801431518807802
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.sendResponse -
> ServerSessionPacketHandler::scheduling response::null
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.done - ServerSessionPacketHandler::regular
> response sent::null
> 16:32:14 [Thread-0
> (ActiveMQ-IO-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$4@2bcc0
[jira] [Commented] (ARTEMIS-1217) Race condition during session reconnection
[
https://issues.apache.org/jira/browse/ARTEMIS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046933#comment-16046933
]
Justin Bertram commented on ARTEMIS-1217:
-
I believe this is happening because your test is creating the server with
persistence disabled. See this line:
{code:java}
server = createServer(true, config);
{code}
Therefore when the server restarts the queue is gone because it wasn't
persisted to disk.
> Race condition during session reconnection
> --
>
> Key: ARTEMIS-1217
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1217
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Andrius Dagys
>Priority: Minor
>
> We have the following scenario:
> There's a client and a server. The server runs a broker and creates a session
> with a producer/consumer to monitor the server queue and respond to client
> requests.
> The client establishes a session with the server broker, creates a client
> queue and a producer/consumer to send requests to the server and receive
> responses.
> In one of our tests we check that the client can correctly reconnect when the
> server (and the broker) restarts. The problem is that occasionally after
> reconnecting the client is able to send a request message to the server
> queue, but the server fails to send a response message due to the client
> queue bindings not being set yet.
> It also seems to be caused by the fact that the client uses different
> sessions for consumer & producer. However, this issue started occurring only
> after we updated from 1.5.3 to 2.1.0.
> Here's an excerpt from the logs:
> {code}
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> impl.RemotingConnectionImpl.bufferReceived - handling packet
> PACKET(SessionSendMessage)[type=71, channelID=10,
> packetObject=SessionSendMessage, message=ServerMessage[messageID=0],
> requiresResponse=false]
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.handlePacket -
> ServerSessionPacketHandler::handlePacket,PACKET(SessionSendMessage)[type=71,
> channelID=10, packetObject=SessionSendMessage,
> message=ServerMessage[messageID=0], requiresResponse=false]
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.ServerSessionImpl.send -
> send(message=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329,
> direct=true) being called
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.SecurityStoreImpl.check -
> checking access permissions to rpc.client.user1.5976801431518807802
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Couldn't find any bindings for address=rpc.client.user1.5976801431518807802
> on message=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Message after
> routed=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Message CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> is not going anywhere as it didn't have a binding on
> address:rpc.client.user1.5976801431518807802
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.sendResponse -
> ServerSessionPacketHandler::scheduling response::null
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.done - ServerSessionPacketHandler::regular
> response sent::null
> 16:32:14 [Thread-0
> (ActiveMQ-IO-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$4@2bcc0ea8)]
> impl.JournalTransaction.commit - no compact commit 22
> 16:32:14 [Thread-4 (activemq-netty-threads)]
> impl.PageCursorProviderImpl.createSubscription -
> rpc.client.user1.5976801431518807802 creating subscription 20 with filter null
> java.lang.Exception: trace
> at
> org.apache.activemq.artemis.core.paging.cursor.i
[jira] [Commented] (ARTEMIS-1224) Journal File Size needs to be multiple of alignment size
[ https://issues.apache.org/jira/browse/ARTEMIS-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046888#comment-16046888 ] ASF subversion and git services commented on ARTEMIS-1224: -- Commit 26d6bb3963a440a7fb1883d9df58886e8b0993e6 in activemq-artemis's branch refs/heads/1.x from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=26d6bb3 ] ARTEMIS-1224 - change the journal file size to nearest multiple https://issues.apache.org/jira/browse/ARTEMIS-1224 > Journal File Size needs to be multiple of alignment size > > > Key: ARTEMIS-1224 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1224 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > > This throws an exception other wise, we auto calculate this but for migrating > users this would cause an issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1224) Journal File Size needs to be multiple of alignment size
[ https://issues.apache.org/jira/browse/ARTEMIS-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046887#comment-16046887 ] ASF subversion and git services commented on ARTEMIS-1224: -- Commit 26d6bb3963a440a7fb1883d9df58886e8b0993e6 in activemq-artemis's branch refs/heads/1.x from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=26d6bb3 ] ARTEMIS-1224 - change the journal file size to nearest multiple https://issues.apache.org/jira/browse/ARTEMIS-1224 > Journal File Size needs to be multiple of alignment size > > > Key: ARTEMIS-1224 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1224 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > > This throws an exception other wise, we auto calculate this but for migrating > users this would cause an issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1208) Do not use reconnect-atempts=-1 in tests
[
https://issues.apache.org/jira/browse/ARTEMIS-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046883#comment-16046883
]
ASF subversion and git services commented on ARTEMIS-1208:
--
Commit 8574f9949f7eed73192423ab1f3d185389c638ec in activemq-artemis's branch
refs/heads/1.x from [~eduda]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8574f99 ]
ARTEMIS-1208 Do not use reconnect-atempts=-1 in tests
(cherry picked from commit 30e8ca656ccc975d35704b3a6c1d676f5e9897ba)
> Do not use reconnect-atempts=-1 in tests
>
>
> Key: ARTEMIS-1208
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1208
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
> Attachments: threaddump.txt
>
>
> If a connection to a broker is configured with parameter reconnect-atempts=-1
> and something goes wrong with the broker, the test may hang indefinitely. It
> happens in cases where the session is created in main test thread.
> Bellow you can see example of stack traces when this situation happens. Main
> thread is waiting for {{failoverLock}} which is held by Thread doing
> reconnection with reconnect-attempts=-1. See attachment for full thread dump.
> {code}
> "main" Id=1 WAITING on
> java.util.concurrent.locks.ReentrantLock$NonfairSync@6e460863 owned by
> "Thread-4 (ActiveMQ-client-global-threads)" Id=5564 (in native)
> at sun.misc.Unsafe.park(Native Method)
> - waiting on
> java.util.concurrent.locks.ReentrantLock$NonfairSync@6e460863
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:847)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:881)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1210)
> at
> java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:220)
> at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:296)
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.lockFailover(ClientSessionFactoryImpl.java:230)
> at
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.lockSessionCreation(ActiveMQClientProtocolManager.java:163)
> at
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.createSessionContext(ActiveMQClientProtocolManager.java:272)
> at
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.createSessionContext(ActiveMQClientProtocolManager.java:237)
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.createSessionChannel(ClientSessionFactoryImpl.java:1284)
> - locked java.lang.Object@18ee7eb5
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.createSessionInternal(ClientSessionFactoryImpl.java:670)
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.createSession(ClientSessionFactoryImpl.java:323)
> at
> org.apache.activemq.artemis.tests.integration.cluster.failover.FailoverTest.createSession(FailoverTest.java:94)
> at
> org.apache.activemq.artemis.tests.integration.cluster.failover.FailoverTest.simpleFailover(FailoverTest.java:693)
> at
> org.apache.activemq.artemis.tests.integration.cluster.failover.FailoverTest.testFailBack(FailoverTest.java:534)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
> at java.lang.reflect.Method.invoke(Method.java:508)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.ExternalResource$1.evaluate(Extern
[jira] [Commented] (ARTEMIS-1208) Do not use reconnect-atempts=-1 in tests
[
https://issues.apache.org/jira/browse/ARTEMIS-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046886#comment-16046886
]
ASF GitHub Bot commented on ARTEMIS-1208:
-
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1329
> Do not use reconnect-atempts=-1 in tests
>
>
> Key: ARTEMIS-1208
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1208
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
> Attachments: threaddump.txt
>
>
> If a connection to a broker is configured with parameter reconnect-atempts=-1
> and something goes wrong with the broker, the test may hang indefinitely. It
> happens in cases where the session is created in main test thread.
> Bellow you can see example of stack traces when this situation happens. Main
> thread is waiting for {{failoverLock}} which is held by Thread doing
> reconnection with reconnect-attempts=-1. See attachment for full thread dump.
> {code}
> "main" Id=1 WAITING on
> java.util.concurrent.locks.ReentrantLock$NonfairSync@6e460863 owned by
> "Thread-4 (ActiveMQ-client-global-threads)" Id=5564 (in native)
> at sun.misc.Unsafe.park(Native Method)
> - waiting on
> java.util.concurrent.locks.ReentrantLock$NonfairSync@6e460863
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:847)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:881)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1210)
> at
> java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:220)
> at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:296)
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.lockFailover(ClientSessionFactoryImpl.java:230)
> at
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.lockSessionCreation(ActiveMQClientProtocolManager.java:163)
> at
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.createSessionContext(ActiveMQClientProtocolManager.java:272)
> at
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQClientProtocolManager.createSessionContext(ActiveMQClientProtocolManager.java:237)
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.createSessionChannel(ClientSessionFactoryImpl.java:1284)
> - locked java.lang.Object@18ee7eb5
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.createSessionInternal(ClientSessionFactoryImpl.java:670)
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.createSession(ClientSessionFactoryImpl.java:323)
> at
> org.apache.activemq.artemis.tests.integration.cluster.failover.FailoverTest.createSession(FailoverTest.java:94)
> at
> org.apache.activemq.artemis.tests.integration.cluster.failover.FailoverTest.simpleFailover(FailoverTest.java:693)
> at
> org.apache.activemq.artemis.tests.integration.cluster.failover.FailoverTest.testFailBack(FailoverTest.java:534)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
> at java.lang.reflect.Method.invoke(Method.java:508)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
[jira] [Commented] (ARTEMIS-1228) Log messages without prefixed id code in artemis-rest
[
https://issues.apache.org/jira/browse/ARTEMIS-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046862#comment-16046862
]
ASF subversion and git services commented on ARTEMIS-1228:
--
Commit e6ba3fbc71cd9e28ba0581dc69b9940a05332466 in activemq-artemis's branch
refs/heads/master from [~ch...@me.com]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e6ba3fb ]
[ARTEMIS-1228] Log messages without prefixed id code in artemis-rest
> Log messages without prefixed id code in artemis-rest
> -
>
> Key: ARTEMIS-1228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1228
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-rest directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-rest]$ find -name "*.java" | grep -i -E
> -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/rest/queue/push/UriStrategy.java:
>ActiveMQRestLogger.LOGGER.warn("failed to push message to " + uri,
> e);
> ./src/main/java/org/apache/activemq/artemis/rest/util/HttpMessageHelper.java:
> ActiveMQRestLogger.LOGGER.warn("Building Message from object",
> e.getMessage(), e);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1228) Log messages without prefixed id code in artemis-rest
[
https://issues.apache.org/jira/browse/ARTEMIS-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046863#comment-16046863
]
ASF GitHub Bot commented on ARTEMIS-1228:
-
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1333
> Log messages without prefixed id code in artemis-rest
> -
>
> Key: ARTEMIS-1228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1228
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-rest directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-rest]$ find -name "*.java" | grep -i -E
> -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/rest/queue/push/UriStrategy.java:
>ActiveMQRestLogger.LOGGER.warn("failed to push message to " + uri,
> e);
> ./src/main/java/org/apache/activemq/artemis/rest/util/HttpMessageHelper.java:
> ActiveMQRestLogger.LOGGER.warn("Building Message from object",
> e.getMessage(), e);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1227) Internal properties not removed from messages
[ https://issues.apache.org/jira/browse/ARTEMIS-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046860#comment-16046860 ] ASF GitHub Bot commented on ARTEMIS-1227: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1332 > Internal properties not removed from messages > - > > Key: ARTEMIS-1227 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1227 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 1.5.6, 2.2.0 > > > In a cluster if a node is shut down (or crashed) when a > message is being routed to a remote binding, a internal > property may be added to the message and persisted. The > name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. > if the node starts back, it will load and reroute this message > and if it goes to a local consumer, this property won't > get removed and goes to the client. > The fix is to remove this internal property before it > is sent to any client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1227) Internal properties not removed from messages
[ https://issues.apache.org/jira/browse/ARTEMIS-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046859#comment-16046859 ] ASF subversion and git services commented on ARTEMIS-1227: -- Commit f465996444fdb6fcf33e1ce2262d6ea2aae0cdb1 in activemq-artemis's branch refs/heads/master from [~gaohoward] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f465996 ] ARTEMIS-1227 Internal properties not removed from messages In a cluster if a node is shut down (or crashed) when a message is being routed to a remote binding, a internal property may be added to the message and persisted. The name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. if the node starts back, it will load and reroute this message and if it goes to a local consumer, this property won't get removed and goes to the client. The fix is to remove this internal property before it is sent to any client. > Internal properties not removed from messages > - > > Key: ARTEMIS-1227 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1227 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 1.5.6, 2.2.0 > > > In a cluster if a node is shut down (or crashed) when a > message is being routed to a remote binding, a internal > property may be added to the message and persisted. The > name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. > if the node starts back, it will load and reroute this message > and if it goes to a local consumer, this property won't > get removed and goes to the client. > The fix is to remove this internal property before it > is sent to any client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
[
https://issues.apache.org/jira/browse/ARTEMIS-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046841#comment-16046841
]
ASF GitHub Bot commented on ARTEMIS-1226:
-
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1331
> Log messages without prefixed id code in artemis-jms-client
> ---
>
> Key: ARTEMIS-1226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-jms-client root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep
> -i -E -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
>ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey()
> + "=" + binding.getValue(), e);
> ./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
>ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(),
> newIOOB);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
[
https://issues.apache.org/jira/browse/ARTEMIS-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046840#comment-16046840
]
ASF subversion and git services commented on ARTEMIS-1226:
--
Commit 6ddeb96a8a8ddf70028973e47cab5df3cb3d3972 in activemq-artemis's branch
refs/heads/master from [~ch...@me.com]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=6ddeb96 ]
[ARTEMIS-1226] Log messages without prefixed id code in artemis-jms-client
> Log messages without prefixed id code in artemis-jms-client
> ---
>
> Key: ARTEMIS-1226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-jms-client root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep
> -i -E -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
>ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey()
> + "=" + binding.getValue(), e);
> ./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
>ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(),
> newIOOB);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1225) Log messages without prefixed id code in artemis-ra
[
https://issues.apache.org/jira/browse/ARTEMIS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046823#comment-16046823
]
ASF GitHub Bot commented on ARTEMIS-1225:
-
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1330
> Log messages without prefixed id code in artemis-ra
> ---
>
> Key: ARTEMIS-1225
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1225
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in Artemis root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
> "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
> ActiveMQRALogger.LOGGER.warn("unable to clear the
> transaction", e1);
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
> ActiveMQRALogger.LOGGER.warn(e);
> ./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
> ActiveMQRALogger.LOGGER.info("Resource adaptor started");
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1225) Log messages without prefixed id code in artemis-ra
[
https://issues.apache.org/jira/browse/ARTEMIS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046822#comment-16046822
]
ASF subversion and git services commented on ARTEMIS-1225:
--
Commit d3010682a4121631d4aef86a1b88008ef21995ed in activemq-artemis's branch
refs/heads/master from [~ch...@me.com]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d301068 ]
[ARTEMIS-1225] Log messages without prefixed id code in artemis-ra
> Log messages without prefixed id code in artemis-ra
> ---
>
> Key: ARTEMIS-1225
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1225
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in Artemis root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
> "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
> ActiveMQRALogger.LOGGER.warn("unable to clear the
> transaction", e1);
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
> ActiveMQRALogger.LOGGER.warn(e);
> ./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
> ActiveMQRALogger.LOGGER.info("Resource adaptor started");
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1205) AMQP Shared Durable Subscriber incorrect behaviour.
[ https://issues.apache.org/jira/browse/ARTEMIS-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046818#comment-16046818 ] ASF GitHub Bot commented on ARTEMIS-1205: - Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1328 Couple of things... * The methods createQueueNameForLegacySubscription and createQueueNameForAmqpCompatibleSubscription in org.apache.activemq.artemis.jms.client.ActiveMQDestination are almost exactly the same. I'd rather not have that kind of code duplication. You could just replace the logic in createQueueNameForSubscription with the logic from createQueueNameForLegacySubscription and refactor escape to take the amqpCompatibleQueues boolean. That's just one way to do; there's lots of ways to avoid the code duplication here. * I know it's tempting to make unrelated but worthwhile changes in a PR (e.g. removing the unused method decomposeQueueNameForDurableSubscription). I've done it myself. However, it makes the diff harder to read and understand since the change isn't clearly related. > AMQP Shared Durable Subscriber incorrect behaviour. > --- > > Key: ARTEMIS-1205 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1205 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.0.0, 2.1.0 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Blocker > Fix For: 2.2.0 > > Attachments: AMQPMissbehaviour.xlsx, JMSDurableConsumerTest2.java, > JMSSharedDurableConsumerTest.java > > > Summary observations : > • There’s different behaviour between AMQP and the Artemis clients > • There's UUID subscription name in the subscription topic when you’re > using the AMQP client, you don’t set the client ID and you’ve selected a > durable & shared subscription. It should just be the subscription name, like > with the Artemis client. > • The AMQP client seems to have a problem if you try to create a new > durable, non-shared subscription on the same topic with the same client ID > and a different subscription name. > > The artemis client doesn’t have a problem with this. > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1224) Journal File Size needs to be multiple of alignment size
[ https://issues.apache.org/jira/browse/ARTEMIS-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046676#comment-16046676 ] ASF GitHub Bot commented on ARTEMIS-1224: - Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1334 I'll raise this on master once its merged > Journal File Size needs to be multiple of alignment size > > > Key: ARTEMIS-1224 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1224 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > > This throws an exception other wise, we auto calculate this but for migrating > users this would cause an issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1224) Journal File Size needs to be multiple of alignment size
[ https://issues.apache.org/jira/browse/ARTEMIS-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046675#comment-16046675 ] ASF GitHub Bot commented on ARTEMIS-1224: - GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1334 ARTEMIS-1224 - change the journal file size to nearest multiple https://issues.apache.org/jira/browse/ARTEMIS-1224 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis 1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1334 commit 337d250cee7fc5032fe23744cf4c5b2db6199ecd Author: Andy Taylor Date: 2017-06-12T15:20:43Z ARTEMIS-1224 - change the journal file size to nearest multiple https://issues.apache.org/jira/browse/ARTEMIS-1224 > Journal File Size needs to be multiple of alignment size > > > Key: ARTEMIS-1224 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1224 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > > This throws an exception other wise, we auto calculate this but for migrating > users this would cause an issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1228) Log messages without prefixed id code in artemis-rest
[
https://issues.apache.org/jira/browse/ARTEMIS-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046584#comment-16046584
]
ASF GitHub Bot commented on ARTEMIS-1228:
-
GitHub user treblereel opened a pull request:
https://github.com/apache/activemq-artemis/pull/1333
[ARTEMIS-1228] Log messages without prefixed id code in artemis-rest
JIRA : https://issues.apache.org/jira/browse/ARTEMIS-1228
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/treblereel/activemq-artemis-wildfly
IMPROVE_LOGGING_REST
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1333
commit 363829cc7152428aa9f1ca30f2719cbbfa3a6af5
Author: Dmitrii Tikhomirov
Date: 2017-06-12T13:50:29Z
[ARTEMIS-1228] Log messages without prefixed id code in artemis-rest
> Log messages without prefixed id code in artemis-rest
> -
>
> Key: ARTEMIS-1228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1228
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-rest directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-rest]$ find -name "*.java" | grep -i -E
> -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/rest/queue/push/UriStrategy.java:
>ActiveMQRestLogger.LOGGER.warn("failed to push message to " + uri,
> e);
> ./src/main/java/org/apache/activemq/artemis/rest/util/HttpMessageHelper.java:
> ActiveMQRestLogger.LOGGER.warn("Building Message from object",
> e.getMessage(), e);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (ARTEMIS-1228) Log messages without prefixed id code in artemis-rest
[
https://issues.apache.org/jira/browse/ARTEMIS-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitrii Tikhomirov updated ARTEMIS-1228:
Description:
Run following command in artemis-rest directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-rest]$ find -name "*.java" | grep -i -E -v
"test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/rest/queue/push/UriStrategy.java:
ActiveMQRestLogger.LOGGER.warn("failed to push message to " + uri, e);
./src/main/java/org/apache/activemq/artemis/rest/util/HttpMessageHelper.java:
ActiveMQRestLogger.LOGGER.warn("Building Message from object",
e.getMessage(), e);
{code}
was:
Run following command in artemis-jms-client root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep -i
-E -v "test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey() +
"=" + binding.getValue(), e);
./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(), newIOOB);
{code}
> Log messages without prefixed id code in artemis-rest
> -
>
> Key: ARTEMIS-1228
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1228
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-rest directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-rest]$ find -name "*.java" | grep -i -E
> -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/rest/queue/push/UriStrategy.java:
>ActiveMQRestLogger.LOGGER.warn("failed to push message to " + uri,
> e);
> ./src/main/java/org/apache/activemq/artemis/rest/util/HttpMessageHelper.java:
> ActiveMQRestLogger.LOGGER.warn("Building Message from object",
> e.getMessage(), e);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (ARTEMIS-1228) Log messages without prefixed id code in artemis-rest
Dmitrii Tikhomirov created ARTEMIS-1228:
---
Summary: Log messages without prefixed id code in artemis-rest
Key: ARTEMIS-1228
URL: https://issues.apache.org/jira/browse/ARTEMIS-1228
Project: ActiveMQ Artemis
Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Dmitrii Tikhomirov
Priority: Minor
Run following command in artemis-jms-client root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep -i
-E -v "test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey() +
"=" + binding.getValue(), e);
./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(), newIOOB);
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
[
https://issues.apache.org/jira/browse/ARTEMIS-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046578#comment-16046578
]
ASF GitHub Bot commented on ARTEMIS-1226:
-
Github user treblereel commented on the issue:
https://github.com/apache/activemq-artemis/pull/1331
retest this please
> Log messages without prefixed id code in artemis-jms-client
> ---
>
> Key: ARTEMIS-1226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-jms-client root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep
> -i -E -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
>ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey()
> + "=" + binding.getValue(), e);
> ./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
>ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(),
> newIOOB);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
[
https://issues.apache.org/jira/browse/ARTEMIS-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046577#comment-16046577
]
ASF GitHub Bot commented on ARTEMIS-1226:
-
Github user treblereel commented on the issue:
https://github.com/apache/activemq-artemis/pull/1331
java.lang.RuntimeException: java.lang.IllegalStateException:
java.lang.IllegalStateException: operation failed when invoking createAddress
on broker: AMQ119204: Address already exists: testJoramTopic
> Log messages without prefixed id code in artemis-jms-client
> ---
>
> Key: ARTEMIS-1226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-jms-client root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep
> -i -E -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
>ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey()
> + "=" + binding.getValue(), e);
> ./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
>ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(),
> newIOOB);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1217) Race condition during session reconnection
[
https://issues.apache.org/jira/browse/ARTEMIS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046536#comment-16046536
]
Andrius Dagys commented on ARTEMIS-1217:
So I tried using a durable queue instead, but am now getting the following
error after the server restarts:
{code:java}
[main] 12:09:18,673 INFO [org.apache.activemq.artemis.core.server] AMQ221007:
Server is now live
[main] 12:09:18,673 INFO [org.apache.activemq.artemis.core.server] AMQ221001:
Apache ActiveMQ Artemis Message Broker version 2.2.0-SNAPSHOT [localhost,
nodeID=944d712e-4f5f-11e7-8072-9801a7ad0af7]
Received from client: ping2
[Thread-2 (activemq-netty-threads)] 12:09:19,676 ERROR
[org.apache.activemq.artemis.core.server] AMQ224016: Caught exception:
ActiveMQNonExistentQueueException[errorType=QUEUE_DOES_NOT_EXIST
message=AMQ119017: Queue QueueA does not exist]
at
org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.createConsumer(ServerSessionImpl.java:432)
[:]
at
org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.createConsumer(ServerSessionImpl.java:417)
[:]
at
org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.handlePacket(ServerSessionPacketHandler.java:242)
[:]
{code}
Updated the code at
https://github.com/corda/activemq-artemis/blob/reconnect-bug/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/RaceConditionTest.java
> Race condition during session reconnection
> --
>
> Key: ARTEMIS-1217
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1217
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Andrius Dagys
>Priority: Minor
>
> We have the following scenario:
> There's a client and a server. The server runs a broker and creates a session
> with a producer/consumer to monitor the server queue and respond to client
> requests.
> The client establishes a session with the server broker, creates a client
> queue and a producer/consumer to send requests to the server and receive
> responses.
> In one of our tests we check that the client can correctly reconnect when the
> server (and the broker) restarts. The problem is that occasionally after
> reconnecting the client is able to send a request message to the server
> queue, but the server fails to send a response message due to the client
> queue bindings not being set yet.
> It also seems to be caused by the fact that the client uses different
> sessions for consumer & producer. However, this issue started occurring only
> after we updated from 1.5.3 to 2.1.0.
> Here's an excerpt from the logs:
> {code}
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> impl.RemotingConnectionImpl.bufferReceived - handling packet
> PACKET(SessionSendMessage)[type=71, channelID=10,
> packetObject=SessionSendMessage, message=ServerMessage[messageID=0],
> requiresResponse=false]
> 16:32:14 [Thread-5 (activemq-netty-threads)]
> core.ServerSessionPacketHandler.handlePacket -
> ServerSessionPacketHandler::handlePacket,PACKET(SessionSendMessage)[type=71,
> channelID=10, packetObject=SessionSendMessage,
> message=ServerMessage[messageID=0], requiresResponse=false]
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.ServerSessionImpl.send -
> send(message=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329,
> direct=true) being called
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.SecurityStoreImpl.check -
> checking access permissions to rpc.client.user1.5976801431518807802
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Couldn't find any bindings for address=rpc.client.user1.5976801431518807802
> on message=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Message after
> routed=CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, durable=false,
> address=rpc.client.user1.5976801431518807802,properties=TypedProperties[tag=0,rpc-id=8487092758120613782,_AMQ_VALIDATED_USER=user1]]@572371329
> 16:32:14 [Thread-5 (activemq-netty-threads)] impl.PostOfficeImpl.route -
> Message CoreMessage[messageID=26,durable=false,userID=null,priority=4,
> timestamp=Mon Jun 05 16:32:14 BST 2017,expiration=0, dura
[jira] [Commented] (ARTEMIS-1227) Internal properties not removed from messages
[ https://issues.apache.org/jira/browse/ARTEMIS-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046503#comment-16046503 ] ASF GitHub Bot commented on ARTEMIS-1227: - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1332 ARTEMIS-1227 Internal properties not removed from messages In a cluster if a node is shut down (or crashed) when a message is being routed to a remote binding, a internal property may be added to the message and persisted. The name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. if the node starts back, it will load and reroute this message and if it goes to a local consumer, this property won't get removed and goes to the client. The fix is to remove this internal property before it is sent to any client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis master_priv_header Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1332 commit 1c86472a99ae474aba7b07e6c03bbc970298c232 Author: Howard Gao Date: 2017-06-12T12:30:41Z ARTEMIS-1227 Internal properties not removed from messages In a cluster if a node is shut down (or crashed) when a message is being routed to a remote binding, a internal property may be added to the message and persisted. The name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. if the node starts back, it will load and reroute this message and if it goes to a local consumer, this property won't get removed and goes to the client. The fix is to remove this internal property before it is sent to any client. > Internal properties not removed from messages > - > > Key: ARTEMIS-1227 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1227 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.5, 2.1.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 1.5.6, 2.2.0 > > > In a cluster if a node is shut down (or crashed) when a > message is being routed to a remote binding, a internal > property may be added to the message and persisted. The > name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. > if the node starts back, it will load and reroute this message > and if it goes to a local consumer, this property won't > get removed and goes to the client. > The fix is to remove this internal property before it > is sent to any client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (ARTEMIS-1227) Internal properties not removed from messages
Howard Gao created ARTEMIS-1227: --- Summary: Internal properties not removed from messages Key: ARTEMIS-1227 URL: https://issues.apache.org/jira/browse/ARTEMIS-1227 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.1.0, 1.5.5 Reporter: Howard Gao Assignee: Howard Gao Fix For: 1.5.6, 2.2.0 In a cluster if a node is shut down (or crashed) when a message is being routed to a remote binding, a internal property may be added to the message and persisted. The name of the property is like _AMQ_ROUTE_TOsf.my-cluster*. if the node starts back, it will load and reroute this message and if it goes to a local consumer, this property won't get removed and goes to the client. The fix is to remove this internal property before it is sent to any client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
[
https://issues.apache.org/jira/browse/ARTEMIS-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046460#comment-16046460
]
ASF GitHub Bot commented on ARTEMIS-1226:
-
GitHub user treblereel opened a pull request:
https://github.com/apache/activemq-artemis/pull/1331
[ARTEMIS-1226] Log messages without prefixed id code in artemis-jms-c…
…lient
JIRA : https://issues.apache.org/jira/browse/ARTEMIS-1226
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/treblereel/activemq-artemis-wildfly
IMPROVE_LOGGING_JMS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1331
commit b8ecdeb19c573289a839f4ce210bc0998bdc68e4
Author: Dmitrii Tikhomirov
Date: 2017-06-12T11:24:57Z
[ARTEMIS-1226] Log messages without prefixed id code in artemis-jms-client
> Log messages without prefixed id code in artemis-jms-client
> ---
>
> Key: ARTEMIS-1226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-jms-client root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep
> -i -E -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
>ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey()
> + "=" + binding.getValue(), e);
> ./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
>ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(),
> newIOOB);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
[
https://issues.apache.org/jira/browse/ARTEMIS-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitrii Tikhomirov updated ARTEMIS-1226:
Description:
Run following command in artemis-jms-client root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep -i
-E -v "test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey() +
"=" + binding.getValue(), e);
./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(), newIOOB);
{code}
was:
Run following command in Artemis root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
"test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
ActiveMQRALogger.LOGGER.warn("unable to clear the
transaction", e1);
./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
ActiveMQRALogger.LOGGER.warn(e);
./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
ActiveMQRALogger.LOGGER.info("Resource adaptor started");
{code}
> Log messages without prefixed id code in artemis-jms-client
> ---
>
> Key: ARTEMIS-1226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in artemis-jms-client root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-jms-client]$ find -name "*.java" | grep
> -i -E -v "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/jndi/ReadOnlyContext.java:
>ActiveMQClientLogger.LOGGER.error("Failed to bind " + binding.getKey()
> + "=" + binding.getValue(), e);
> ./src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageConsumer.java:
>ActiveMQClientLogger.LOGGER.warn(newIOOB.getMessage(),
> newIOOB);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (ARTEMIS-1226) Log messages without prefixed id code in artemis-jms-client
Dmitrii Tikhomirov created ARTEMIS-1226:
---
Summary: Log messages without prefixed id code in
artemis-jms-client
Key: ARTEMIS-1226
URL: https://issues.apache.org/jira/browse/ARTEMIS-1226
Project: ActiveMQ Artemis
Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Dmitrii Tikhomirov
Priority: Minor
Run following command in Artemis root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
"test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
ActiveMQRALogger.LOGGER.warn("unable to clear the
transaction", e1);
./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
ActiveMQRALogger.LOGGER.warn(e);
./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
ActiveMQRALogger.LOGGER.info("Resource adaptor started");
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (ARTEMIS-1225) Log messages without prefixed id code in artemis-ra
[
https://issues.apache.org/jira/browse/ARTEMIS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitrii Tikhomirov updated ARTEMIS-1225:
Priority: Minor (was: Major)
> Log messages without prefixed id code in artemis-ra
> ---
>
> Key: ARTEMIS-1225
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1225
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>Priority: Minor
>
> Run following command in Artemis root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
> "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
> ActiveMQRALogger.LOGGER.warn("unable to clear the
> transaction", e1);
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
> ActiveMQRALogger.LOGGER.warn(e);
> ./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
> ActiveMQRALogger.LOGGER.info("Resource adaptor started");
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1225) Log messages without prefixed id code in artemis-ra
[
https://issues.apache.org/jira/browse/ARTEMIS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046435#comment-16046435
]
ASF GitHub Bot commented on ARTEMIS-1225:
-
GitHub user treblereel opened a pull request:
https://github.com/apache/activemq-artemis/pull/1330
[ARTEMIS-1225] Log messages without prefixed id code in artemis-ra
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1225
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/treblereel/activemq-artemis-wildfly
IMPROVE_LOGGING_RA
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1330
commit 97ed630fc6f8885488e740bbd4bfcdd667b0c290
Author: Dmitrii Tikhomirov
Date: 2017-06-11T20:40:54Z
[ARTEMIS-1225] Log messages without prefixed id code in artemis-ra
> Log messages without prefixed id code in artemis-ra
> ---
>
> Key: ARTEMIS-1225
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1225
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>
> Run following command in Artemis root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
> "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
> ActiveMQRALogger.LOGGER.warn("unable to clear the
> transaction", e1);
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
> ActiveMQRALogger.LOGGER.warn(e);
> ./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
> ActiveMQRALogger.LOGGER.info("Resource adaptor started");
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1225) Log messages without prefixed id code in artemis-ra
[
https://issues.apache.org/jira/browse/ARTEMIS-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046436#comment-16046436
]
Dmitrii Tikhomirov commented on ARTEMIS-1225:
-
https://github.com/apache/activemq-artemis/pull/1330
> Log messages without prefixed id code in artemis-ra
> ---
>
> Key: ARTEMIS-1225
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1225
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Dmitrii Tikhomirov
>
> Run following command in Artemis root directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
> "test|example|junit" | xargs grep -i -E
> "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
> ActiveMQRALogger.LOGGER.warn("unable to clear the
> transaction", e1);
> ./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
> ActiveMQRALogger.LOGGER.warn(e);
> ./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
> ActiveMQRALogger.LOGGER.info("Resource adaptor started");
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (ARTEMIS-1225) Log messages without prefixed id code in artemis-ra
Dmitrii Tikhomirov created ARTEMIS-1225:
---
Summary: Log messages without prefixed id code in artemis-ra
Key: ARTEMIS-1225
URL: https://issues.apache.org/jira/browse/ARTEMIS-1225
Project: ActiveMQ Artemis
Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Dmitrii Tikhomirov
Run following command in Artemis root directory
{code}
[treblereel@dhcp-10-40-4-236 artemis-ra]$ find -name "*.java" | grep -i -E -v
"test|example|junit" | xargs grep -i -E
"LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQMessageHandler.java:
ActiveMQRALogger.LOGGER.warn("unable to clear the
transaction", e1);
./src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivation.java:
ActiveMQRALogger.LOGGER.warn(e);
./src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java:
ActiveMQRALogger.LOGGER.info("Resource adaptor started");
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (ARTEMIS-1224) Journal File Size needs to be multiple of alignment size
Andy Taylor created ARTEMIS-1224: Summary: Journal File Size needs to be multiple of alignment size Key: ARTEMIS-1224 URL: https://issues.apache.org/jira/browse/ARTEMIS-1224 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.1.0, 1.5.5 Reporter: Andy Taylor Assignee: Andy Taylor This throws an exception other wise, we auto calculate this but for migrating users this would cause an issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (AMQ-6700) Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects in JCA
[
https://issues.apache.org/jira/browse/AMQ-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Torsten Mielke resolved AMQ-6700.
-
Resolution: Fixed
Fix Version/s: 5.14.6
Fixed with commit
[a1e595c18fbfb8a21e632b665f180005f1daf053|https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=blobdiff;f=activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQResourceAdapter.java;h=b17674e88a9cec7ea5c95dd229dad5c143215833;hp=fd16603865d90c8f2ded3cfaa268056bca1a3731;hb=a1e595c18fbfb8a21e632b665f180005f1daf053;hpb=a6782443c1695f54176afecfda6c5c423bc18a84].
> Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects
> in JCA
>
>
> Key: AMQ-6700
> URL: https://issues.apache.org/jira/browse/AMQ-6700
> Project: ActiveMQ
> Issue Type: Bug
> Components: JCA Container, RAR
>Affects Versions: 5.14.5
> Environment: JCA
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
> Labels: jca
> Fix For: 5.14.6
>
>
> The ActiveMQ JCA layer may leak threads of name {{"ActiveMQ Connection
> Executor"}} and instances of {{org.apache.activemq.ActiveMQConnection}} when
> there are problems with establishing the connection.
> If the initial openwire connection cannot be established, it may run an
> "ActiveMQ Connection Executor" thread to deal with the error leading to a
> code path that does not close the connection and does not clear up the
> "ActiveMQ Connection Executor" thread.
> Low level details in further comments.
>
> This problem can be reproduced by running
> {{ActiveMQResourceAdapter.TransactionContext.recover()}} but potentially
> other code paths in the resource adapter are effected as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMQ-6700) Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects in JCA
[
https://issues.apache.org/jira/browse/AMQ-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046309#comment-16046309
]
ASF subversion and git services commented on AMQ-6700:
--
Commit a1e595c18fbfb8a21e632b665f180005f1daf053 in activemq's branch
refs/heads/master from [~tmielke]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=a1e595c ]
[AMQ-6700] Leak of ActiveMQ Connection Executor threads and ActiveMQConnection
objects in JCA layer
> Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects
> in JCA
>
>
> Key: AMQ-6700
> URL: https://issues.apache.org/jira/browse/AMQ-6700
> Project: ActiveMQ
> Issue Type: Bug
> Components: JCA Container, RAR
>Affects Versions: 5.14.5
> Environment: JCA
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
> Labels: jca
>
> The ActiveMQ JCA layer may leak threads of name {{"ActiveMQ Connection
> Executor"}} and instances of {{org.apache.activemq.ActiveMQConnection}} when
> there are problems with establishing the connection.
> If the initial openwire connection cannot be established, it may run an
> "ActiveMQ Connection Executor" thread to deal with the error leading to a
> code path that does not close the connection and does not clear up the
> "ActiveMQ Connection Executor" thread.
> Low level details in further comments.
>
> This problem can be reproduced by running
> {{ActiveMQResourceAdapter.TransactionContext.recover()}} but potentially
> other code paths in the resource adapter are effected as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMQ-6700) Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects in JCA
[
https://issues.apache.org/jira/browse/AMQ-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046308#comment-16046308
]
ASF subversion and git services commented on AMQ-6700:
--
Commit a1e595c18fbfb8a21e632b665f180005f1daf053 in activemq's branch
refs/heads/AMQ-6700 from [~tmielke]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=a1e595c ]
[AMQ-6700] Leak of ActiveMQ Connection Executor threads and ActiveMQConnection
objects in JCA layer
> Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects
> in JCA
>
>
> Key: AMQ-6700
> URL: https://issues.apache.org/jira/browse/AMQ-6700
> Project: ActiveMQ
> Issue Type: Bug
> Components: JCA Container, RAR
>Affects Versions: 5.14.5
> Environment: JCA
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
> Labels: jca
>
> The ActiveMQ JCA layer may leak threads of name {{"ActiveMQ Connection
> Executor"}} and instances of {{org.apache.activemq.ActiveMQConnection}} when
> there are problems with establishing the connection.
> If the initial openwire connection cannot be established, it may run an
> "ActiveMQ Connection Executor" thread to deal with the error leading to a
> code path that does not close the connection and does not clear up the
> "ActiveMQ Connection Executor" thread.
> Low level details in further comments.
>
> This problem can be reproduced by running
> {{ActiveMQResourceAdapter.TransactionContext.recover()}} but potentially
> other code paths in the resource adapter are effected as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer
[
https://issues.apache.org/jira/browse/ARTEMIS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046305#comment-16046305
]
Erich Duda commented on ARTEMIS-1223:
-
[~nigro@gmail.com] could you take a look please?
> OutOfDirectMemoryError raised from TimedBuffer
> --
>
> Key: ARTEMIS-1223
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 1.5.5, 2.1.0
> Environment: IBM JDK
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
> IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References
> 20161013_322271 (JIT enabled, AOT enabled)
> J9VM - R28_Java8_SR3_20161013_1635_B322271
> JIT - tr.r14.java.green_20161011_125790
> GC - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
> J9CL - 20161013_322271)
> JCL - 20161018_01 based on Oracle jdk8u111-b14
>Reporter: Erich Duda
>
> I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it
> runs on IBM JDK. I don't see it with Oracle or OpenJDK.
> For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
> \[1\]
> {code}
> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760
> byte(s) of direct memory (used: 66876815, max: 67108864)
> at
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
> at
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
> at
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
> at
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
> at
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
> at
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
> at
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
> at
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
> at
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
> at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
> at
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
> at
> org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
> at
> org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
> at
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
> at
> org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (ARTEMIS-1223) OutOfDirectMemoryError raised from TimedBuffer
Erich Duda created ARTEMIS-1223:
---
Summary: OutOfDirectMemoryError raised from TimedBuffer
Key: ARTEMIS-1223
URL: https://issues.apache.org/jira/browse/ARTEMIS-1223
Project: ActiveMQ Artemis
Issue Type: Bug
Components: Broker
Affects Versions: 2.1.0, 1.5.5
Environment: IBM JDK
java version "1.8.0"
Java(TM) SE Runtime Environment (build pxa6480sr3fp20-20161019_02(SR3 FP20))
IBM J9 VM (build 2.8, JRE 1.8.0 Linux amd64-64 Compressed References
20161013_322271 (JIT enabled, AOT enabled)
J9VM - R28_Java8_SR3_20161013_1635_B322271
JIT - tr.r14.java.green_20161011_125790
GC - R28_Java8_SR3_20161013_1635_B322271_CMPRSS
J9CL - 20161013_322271)
JCL - 20161018_01 based on Oracle jdk8u111-b14
Reporter: Erich Duda
I see a lot of OutOfDirectMemoryError \[1\] in Artemis test suite when it runs
on IBM JDK. I don't see it with Oracle or OpenJDK.
For reproducing the issue run {{LargeMessageCompressTest}} on IBM JDK.
\[1\]
{code}
io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 501760
byte(s) of direct memory (used: 66876815, max: 67108864)
at
io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
at
io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
at
io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
at
io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
at
io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
at
io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
at
io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
at
io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
at
io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
at io.netty.buffer.Unpooled.directBuffer(Unpooled.java:145)
at
org.apache.activemq.artemis.core.io.buffer.TimedBuffer.(TimedBuffer.java:103)
at
org.apache.activemq.artemis.core.io.AbstractSequentialFileFactory.(AbstractSequentialFileFactory.java:78)
at
org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.(AIOSequentialFileFactory.java:78)
at
org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.init(JournalStorageManager.java:136)
at
org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:217)
at
org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:103)
at
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2014)
at
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2151)
at
org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
at
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:517)
at
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:465)
at
org.apache.activemq.artemis.tests.integration.client.LargeMessageCompressTest.testLargeMessageCompression3(LargeMessageCompressTest.java:171)
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMQ-6700) Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects in JCA
[
https://issues.apache.org/jira/browse/AMQ-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046283#comment-16046283
]
Torsten Mielke commented on AMQ-6700:
-
A fix for this bug is to catch and deal with these Exceptions in method
{{ActiveMQResourceAdapter.$2.newConnection()}}
{code:java}
private ActiveMQConnection newConnection() throws
JMSException {
ActiveMQConnection connection = null;
try {
connection = makeConnection();
connection.start();
} catch (JMSException ex) {
if (connection != null) {
try {
connection.close();
} catch (JMSException ignore) { }
}
throw ex;
}
return connection;
}
{code}
> Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects
> in JCA
>
>
> Key: AMQ-6700
> URL: https://issues.apache.org/jira/browse/AMQ-6700
> Project: ActiveMQ
> Issue Type: Bug
> Components: JCA Container, RAR
>Affects Versions: 5.14.5
> Environment: JCA
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
> Labels: jca
>
> The ActiveMQ JCA layer may leak threads of name {{"ActiveMQ Connection
> Executor"}} and instances of {{org.apache.activemq.ActiveMQConnection}} when
> there are problems with establishing the connection.
> If the initial openwire connection cannot be established, it may run an
> "ActiveMQ Connection Executor" thread to deal with the error leading to a
> code path that does not close the connection and does not clear up the
> "ActiveMQ Connection Executor" thread.
> Low level details in further comments.
>
> This problem can be reproduced by running
> {{ActiveMQResourceAdapter.TransactionContext.recover()}} but potentially
> other code paths in the resource adapter are effected as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMQ-6700) Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects in JCA
[
https://issues.apache.org/jira/browse/AMQ-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046282#comment-16046282
]
Torsten Mielke commented on AMQ-6700:
-
Here are the low level details that will lead to leaking ActiveMQConnection
objects and threads:
The Arjuna transaction manager of JBoss EAP runs a periodic recovery and calls
{{ActiveMQResourceAdapter.TransactionContext.recover()}}
{code}
try {
original = setConnection(newConnection());
...
{code}
Note around the same code path would be executed when Arjuna calls {{commit()}}
or {{rollback()}} on the resource adapter.
The call to {{ActiveMQResourceAdapter.newConnection()}} is implemented as
{code}
private ActiveMQConnection newConnection() throws
JMSException {
ActiveMQConnection connection = makeConnection();
connection.start();
return connection;
}
{code}
Method {{makeConnection()}} calls into
{{ActiveMQConnectionFacotry.createActiveMQConnection()}} which contains
{code}
try {
connection = createActiveMQConnection(transport, factoryStats);
...
transport.start();
...
return connection;
} catch (JMSException e) {
// Clean up!
try {
connection.close();
} catch (Throwable ignore) {
}
throw e;
} catch (Exception e) {
// Clean up!
try {
connection.close();
} catch (Throwable ignore) {
}
throw JMSExceptionSupport.create("Could not connect to broker URL:
" + brokerURL + ". Reason: " + e, e);
}
{code}
Now if transport.start() raises an errror, this may not result in an exception
in this method. Instead the "ActiveMQ Connection Executor" thread is used to
call {{ActiveMQConnection.transportFailed()}}. So the handling of the error
happens in a different thread. Meanwhile above method
{{ActiveMQConnectionFacotry.createActiveMQConnection()}} finishes (without
exceptions) and we are back in {{ActiveMQResourceAdapter.$2.newConnection()}}
where we call {{connection.start()}} (See code sample above).
In the meantime the "ActiveMQ Connection Executor" thread has most likely
finished and marked the connection as failed
(ActiveMQConnection.transportFailed = true).
{{ActiveMQConnection.start()}} calls method
{{ActiveMQConnectioncheckClosedOrFailed()}} which checks for the value of
property {{transportFailed}}, which will be true by now and an exception will
be raised.
That exception is only caught in {{ActiveMQResourceAdapter.recover()}} which in
its {{finally}} clause calls
{code}
} finally {
closeConnection(original);
}
{code}
but original is null at this stage, so the ActiveMQConnection instance does not
get closed and the "ActiveMQ Connection Executor" thread is not shut down!
Both, the thread and the instance are leaked!
> Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects
> in JCA
>
>
> Key: AMQ-6700
> URL: https://issues.apache.org/jira/browse/AMQ-6700
> Project: ActiveMQ
> Issue Type: Bug
> Components: JCA Container, RAR
>Affects Versions: 5.14.5
> Environment: JCA
>Reporter: Torsten Mielke
>Assignee: Torsten Mielke
> Labels: jca
>
> The ActiveMQ JCA layer may leak threads of name {{"ActiveMQ Connection
> Executor"}} and instances of {{org.apache.activemq.ActiveMQConnection}} when
> there are problems with establishing the connection.
> If the initial openwire connection cannot be established, it may run an
> "ActiveMQ Connection Executor" thread to deal with the error leading to a
> code path that does not close the connection and does not clear up the
> "ActiveMQ Connection Executor" thread.
> Low level details in further comments.
>
> This problem can be reproduced by running
> {{ActiveMQResourceAdapter.TransactionContext.recover()}} but potentially
> other code paths in the resource adapter are effected as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (AMQ-6700) Leak of "ActiveMQ Connection Executor" threads and ActiveMQConnection objects in JCA
Torsten Mielke created AMQ-6700:
---
Summary: Leak of "ActiveMQ Connection Executor" threads and
ActiveMQConnection objects in JCA
Key: AMQ-6700
URL: https://issues.apache.org/jira/browse/AMQ-6700
Project: ActiveMQ
Issue Type: Bug
Components: JCA Container, RAR
Affects Versions: 5.14.5
Environment: JCA
Reporter: Torsten Mielke
Assignee: Torsten Mielke
The ActiveMQ JCA layer may leak threads of name {{"ActiveMQ Connection
Executor"}} and instances of {{org.apache.activemq.ActiveMQConnection}} when
there are problems with establishing the connection.
If the initial openwire connection cannot be established, it may run an
"ActiveMQ Connection Executor" thread to deal with the error leading to a code
path that does not close the connection and does not clear up the "ActiveMQ
Connection Executor" thread.
Low level details in further comments.
This problem can be reproduced by running
{{ActiveMQResourceAdapter.TransactionContext.recover()}} but potentially other
code paths in the resource adapter are effected as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
