[jira] [Created] (ARTEMIS-1740) Add support for regex based certificate authentication

2018-03-08 Thread Lionel Cons (JIRA)
Lionel Cons created ARTEMIS-1740:


 Summary: Add support for regex based certificate authentication
 Key: ARTEMIS-1740
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1740
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Lionel Cons


The current certificate authentication module 
({{TextFileCertificateLoginModule}}) uses a file mapping user names to DNs.

In some cases, the list of known DNs can be large and dynamic. This is the case 
for instance when using host certificates.

Host certificates could be very dynamic (when new virtual machines get created) 
while keeping a fixed structure such as {{CN=hostxyz.acme.org, OU=computers, 
DC=acme, DC=org}}. It is impractical to generate all the possible DNs and feed 
this to Artemis.

It would be very useful to have regular expression based certificate 
authentication. With the example above, we could have a single line:
{quote}
acme.computers=/^CN=\w+\.acme\.org, OU=computers, DC=acme, DC=org$/
{quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392398#comment-16392398
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1945
  
@michaelandrepearce ^^


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392397#comment-16392397
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1945

ARTEMIS-1737 Fixing WebServer stopped

This is replacing #1940 

#1940 will be closed when this one is merged.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1945.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1945


commit dc096f950d24e47f48883fdd49b27f51914d5783
Author: Stanislav Knot 
Date:   2018-03-08T10:03:37Z

ARTEMIS-1737 fix for inaccessible slave console after failover

commit 6a0f3232c7921e6e67cd8211e4b05d065cffcceb
Author: Clebert Suconic 
Date:   2018-03-08T21:24:38Z

ARTEMIS-1737 Fixing semantic of ServerControl.forceFailover

This closes #1940




> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AMQ-6424) Duplicate dead letter queues

2018-03-08 Thread Jeannine Lee (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392114#comment-16392114
 ] 

Jeannine Lee commented on AMQ-6424:
---

This has been a very painful problem for us - we are on version 5.9.0.

> Duplicate dead letter queues
> 
>
> Key: AMQ-6424
> URL: https://issues.apache.org/jira/browse/AMQ-6424
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker, KahaDB
>Affects Versions: 5.13.0, 5.13.3, 5.14.0
> Environment: JDK 1.8.0_93 , Windows Server 2012 R2
>Reporter: Berge Stillingen
>Priority: Major
>  Labels: database, journal, mssql, paging
>
> In version 5.14 (and 5.13.3) it appears the broker is able to 'occasionally' 
> create extra DLQ-queues holding duplicate messages. 
> Browsing the admin console, you will sometimes see something like this: 
> - DLQ.myEventQueue 
> - DLQ.DLQ.myEventQueue 
> That both hold the samme message ID, eg. 
> ID:ClientABC-61753-1471513949441-1:4:1:3:1   
> The one from DLQ.myEventQueue is a standard entry caused by a client 
> transaction rollback. 
> The (unwanted) one from DLQ.DLQ.myEventQueue has a 
> - dlqDeliveryFailureCause: java.lang.Throwable: duplicate paged in from store 
> for queue://DLQ.myEventQueue
> At some point you can even get a third queue named 
> - DLQ.DLQ.DLQ.myEventQueue holding another message with the samme MessageID 
> and the same dlqDeliveryFailureCause 
> Reproduce: Haven't found a way to provoke the error. It happens occasionally 
> in a semi-active test environment running with Mule 3.6.2. 
> Best guess is that there is some issue with the use of Journaling and 
> synchronization between Kahadb and the MSSQL-database. 
> Configuration can be found at 
> http://activemq.2283324.n4.nabble.com/file/n4715868/activemq-anonymous.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392069#comment-16392069
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@michaelandrepearce will do.. I thought I would be able to do it tonight... 
I'm hitting another issue.. so it will be tomorrow.


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392062#comment-16392062
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@clebertsuconic i assume you will PR your modifications before merge.


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391935#comment-16391935
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
I'm running the testsuite... I will merge a modified patch.. thanks a lot 
@stanlyDoge 


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1739) default module name for artemis-native uses reserved keyword

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391927#comment-16391927
 ] 

ASF GitHub Bot commented on ARTEMIS-1739:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1944


> default module name for artemis-native uses reserved keyword
> 
>
> Key: ARTEMIS-1739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Assignee: Martyn Taylor
>Priority: Major
>
> We can override this in the manifest.  I will rename as artemis.jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1739) default module name for artemis-native uses reserved keyword

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391926#comment-16391926
 ] 

ASF subversion and git services commented on ARTEMIS-1739:
--

Commit e7da61a06f10dc71ce677bd074a2f843a2c1bb56 in activemq-artemis's branch 
refs/heads/master from [~martyntaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e7da61a ]

ARTEMIS-1739 Set automatic module name for native


> default module name for artemis-native uses reserved keyword
> 
>
> Key: ARTEMIS-1739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Assignee: Martyn Taylor
>Priority: Major
>
> We can override this in the manifest.  I will rename as artemis.jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1682) duplicate classes in Artemis jars

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391919#comment-16391919
 ] 

ASF subversion and git services commented on ARTEMIS-1682:
--

Commit fde86c0c3ad1390feba92fcf151558abfacc4a48 in activemq-artemis's branch 
refs/heads/master from [~martyntaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=fde86c0 ]

ARTEMIS-1682 Set packaging jar for artemis-server


> duplicate classes in Artemis jars
> -
>
> Key: ARTEMIS-1682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1682
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Jeff Mesnil
>Assignee: Martyn Taylor
>Priority: Blocker
>
> This is a recent change in Artemis master branch.
> The org.apache.activemq.artemis.utils package whose source files are in 
> artemis-commons are also present in the artemis-server jar.
>  
> {code:java}
> $ find . -name ExecutorFactory.java
> ./artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ExecutorFactory.java
> $ jar tvf artemis-commons/target/artemis-commons-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 2335 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/actors/OrderedExecutorFactory.class
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> $ jar tvf artemis-server/target/artemis-server-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> {code}
>  
> This causes issue when we integrate Artemis on our application server that is 
> using a modular class loader as there are 2 definitions of the 
> ExecutorFactory class and we end up with weird errors such as:
> {code}
> 12:02:16,754 ERROR [org.jboss.msc.service.fail] (ServerService Thread Pool -- 
> 68) MSC01: Failed to start service 
> jboss.messaging-activemq.default.jms.manager: 
> org.jboss.msc.service.StartException in service 
> jboss.messaging-activemq.default.jms.manager: 
> java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:209)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:64)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:99)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> Caused by: java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:222)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:106)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2287)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
> at 
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:392)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:205)
> ... 9 more
> {code}
> This happens because the ActiveMQServerImpl is referencing the 
> ExecutorFactory class from artemis-server jar while the 
> OrderedExecutorFactory class is referencing the ExecutorFactory class from 
> artemis-commons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1682) duplicate classes in Artemis jars

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391920#comment-16391920
 ] 

ASF GitHub Bot commented on ARTEMIS-1682:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1942


> duplicate classes in Artemis jars
> -
>
> Key: ARTEMIS-1682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1682
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Jeff Mesnil
>Assignee: Martyn Taylor
>Priority: Blocker
>
> This is a recent change in Artemis master branch.
> The org.apache.activemq.artemis.utils package whose source files are in 
> artemis-commons are also present in the artemis-server jar.
>  
> {code:java}
> $ find . -name ExecutorFactory.java
> ./artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ExecutorFactory.java
> $ jar tvf artemis-commons/target/artemis-commons-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 2335 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/actors/OrderedExecutorFactory.class
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> $ jar tvf artemis-server/target/artemis-server-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> {code}
>  
> This causes issue when we integrate Artemis on our application server that is 
> using a modular class loader as there are 2 definitions of the 
> ExecutorFactory class and we end up with weird errors such as:
> {code}
> 12:02:16,754 ERROR [org.jboss.msc.service.fail] (ServerService Thread Pool -- 
> 68) MSC01: Failed to start service 
> jboss.messaging-activemq.default.jms.manager: 
> org.jboss.msc.service.StartException in service 
> jboss.messaging-activemq.default.jms.manager: 
> java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:209)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:64)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:99)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> Caused by: java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:222)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:106)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2287)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
> at 
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:392)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:205)
> ... 9 more
> {code}
> This happens because the ActiveMQServerImpl is referencing the 
> ExecutorFactory class from artemis-server jar while the 
> OrderedExecutorFactory class is referencing the ExecutorFactory class from 
> artemis-commons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1682) duplicate classes in Artemis jars

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391918#comment-16391918
 ] 

ASF GitHub Bot commented on ARTEMIS-1682:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1942
  
Agreed.  I just wanted to make a note for posterity's sake before I merged 
it.  :)


> duplicate classes in Artemis jars
> -
>
> Key: ARTEMIS-1682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1682
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Jeff Mesnil
>Assignee: Martyn Taylor
>Priority: Blocker
>
> This is a recent change in Artemis master branch.
> The org.apache.activemq.artemis.utils package whose source files are in 
> artemis-commons are also present in the artemis-server jar.
>  
> {code:java}
> $ find . -name ExecutorFactory.java
> ./artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ExecutorFactory.java
> $ jar tvf artemis-commons/target/artemis-commons-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 2335 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/actors/OrderedExecutorFactory.class
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> $ jar tvf artemis-server/target/artemis-server-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> {code}
>  
> This causes issue when we integrate Artemis on our application server that is 
> using a modular class loader as there are 2 definitions of the 
> ExecutorFactory class and we end up with weird errors such as:
> {code}
> 12:02:16,754 ERROR [org.jboss.msc.service.fail] (ServerService Thread Pool -- 
> 68) MSC01: Failed to start service 
> jboss.messaging-activemq.default.jms.manager: 
> org.jboss.msc.service.StartException in service 
> jboss.messaging-activemq.default.jms.manager: 
> java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:209)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:64)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:99)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> Caused by: java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:222)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:106)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2287)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
> at 
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:392)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:205)
> ... 9 more
> {code}
> This happens because the ActiveMQServerImpl is referencing the 
> ExecutorFactory class from artemis-server jar while the 
> OrderedExecutorFactory class is referencing the ExecutorFactory class from 
> artemis-commons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1682) duplicate classes in Artemis jars

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391916#comment-16391916
 ] 

ASF GitHub Bot commented on ARTEMIS-1682:
-

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1942
  
@jbertram There's actually a seperate "artemis-server-osgi" module that 
should be used for osgi related stuff.  We shouldn't be including classes from 
other modules in our jars.


> duplicate classes in Artemis jars
> -
>
> Key: ARTEMIS-1682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1682
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Jeff Mesnil
>Assignee: Martyn Taylor
>Priority: Blocker
>
> This is a recent change in Artemis master branch.
> The org.apache.activemq.artemis.utils package whose source files are in 
> artemis-commons are also present in the artemis-server jar.
>  
> {code:java}
> $ find . -name ExecutorFactory.java
> ./artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ExecutorFactory.java
> $ jar tvf artemis-commons/target/artemis-commons-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 2335 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/actors/OrderedExecutorFactory.class
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> $ jar tvf artemis-server/target/artemis-server-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> {code}
>  
> This causes issue when we integrate Artemis on our application server that is 
> using a modular class loader as there are 2 definitions of the 
> ExecutorFactory class and we end up with weird errors such as:
> {code}
> 12:02:16,754 ERROR [org.jboss.msc.service.fail] (ServerService Thread Pool -- 
> 68) MSC01: Failed to start service 
> jboss.messaging-activemq.default.jms.manager: 
> org.jboss.msc.service.StartException in service 
> jboss.messaging-activemq.default.jms.manager: 
> java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:209)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:64)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:99)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> Caused by: java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:222)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:106)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2287)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
> at 
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:392)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:205)
> ... 9 more
> {code}
> This happens because the ActiveMQServerImpl is referencing the 
> ExecutorFactory class from artemis-server jar while the 
> OrderedExecutorFactory class is referencing the ExecutorFactory class from 
> artemis-commons.



--
This message was sent by Atlassian JIRA
(v7.6

[jira] [Commented] (ARTEMIS-1676) Allow users to override JAVA_ARGS via environment variables

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391907#comment-16391907
 ] 

ASF GitHub Bot commented on ARTEMIS-1676:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1862#discussion_r173290483
  
--- Diff: 
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile
 ---
@@ -21,14 +21,20 @@ ARTEMIS_INSTANCE='${artemis.instance}'
 # The logging config will need an URI
 # this will be encoded in case you use spaces or special characters
 # on your directory structure
-ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
 
-# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can 
be referenced in broker.xml
-#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 
-Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 
-Dactivemq.remoting.hornetq.port=5446"
+if [ -z "$ARTEMIS_INSTANCE_URI" ]; then
+ARTEMIS_INSTANCE_URI='${artemis.instance.uri}'
+fi
 
+# Cluster Properties: Used to pass arguments to ActiveMQ Artemis which can 
be referenced in broker.xml
+if [ -z "$ARTEMIS_CLUSTER_PROPS" ]; then
+#ARTEMIS_CLUSTER_PROPS="-Dactivemq.remoting.default.port=61617 
-Dactivemq.remoting.amqp.port=5673 -Dactivemq.remoting.stomp.port=61614 
-Dactivemq.remoting.hornetq.port=5446"
--- End diff --

I would be ok with this on ARTEMIS_HOME.. ARTEMIS_INSTANCE is a bit 
dangerous IMO.

Say you went to cd /artemis-servers/server1


and by accident previously you set ARTEMIS-INSTANCE = 
/artemis-server/myOtherServer


You wouldn't be able to figure out easily... I think it's a bit dangerous...


the best way we can do about this is like what we do now.. we figure out 
ARTEMIS-INSTANCE by the location of the executable's. if you do 
/my-other-server/bin/artemis start


then you will know you're starting the right server.


> Allow users to override JAVA_ARGS via environment variables
> ---
>
> Key: ARTEMIS-1676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1676
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Priority: Major
>
> We currently require users to update the artemis.profile file to change 
> JAVA_ARGS options.   However, it's often useful to be able to override 
> certain properties via environment variables.  Typical example is when 
> running in a cloud environment, where customisation is often injected via 
> environment variables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1682) duplicate classes in Artemis jars

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391902#comment-16391902
 ] 

ASF GitHub Bot commented on ARTEMIS-1682:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1942
  
I'm guessing that this will break the stuff committed for 
https://issues.apache.org/jira/browse/ARTEMIS-1630, but at this point I can't 
even get the tests in that commit to run successfully so it might already be 
broken anyway.


> duplicate classes in Artemis jars
> -
>
> Key: ARTEMIS-1682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1682
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Jeff Mesnil
>Assignee: Martyn Taylor
>Priority: Blocker
>
> This is a recent change in Artemis master branch.
> The org.apache.activemq.artemis.utils package whose source files are in 
> artemis-commons are also present in the artemis-server jar.
>  
> {code:java}
> $ find . -name ExecutorFactory.java
> ./artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ExecutorFactory.java
> $ jar tvf artemis-commons/target/artemis-commons-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 2335 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/actors/OrderedExecutorFactory.class
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> $ jar tvf artemis-server/target/artemis-server-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> {code}
>  
> This causes issue when we integrate Artemis on our application server that is 
> using a modular class loader as there are 2 definitions of the 
> ExecutorFactory class and we end up with weird errors such as:
> {code}
> 12:02:16,754 ERROR [org.jboss.msc.service.fail] (ServerService Thread Pool -- 
> 68) MSC01: Failed to start service 
> jboss.messaging-activemq.default.jms.manager: 
> org.jboss.msc.service.StartException in service 
> jboss.messaging-activemq.default.jms.manager: 
> java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:209)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:64)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:99)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> Caused by: java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:222)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:106)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2287)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
> at 
> org.apache.activemq.artemis.jms.server.impl.JMSServerManagerImpl.start(JMSServerManagerImpl.java:392)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:205)
> ... 9 more
> {code}
> This happens because the ActiveMQServerImpl is referencing the 
> ExecutorFactory class from artemis-server jar while the 
> OrderedExecutorFactory class is referencing the ExecutorFactory class from 
> artemis-commons.

[jira] [Commented] (ARTEMIS-1739) default module name for artemis-native uses reserved keyword

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391901#comment-16391901
 ] 

ASF GitHub Bot commented on ARTEMIS-1739:
-

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1944

ARTEMIS-1739 Set automatic module name for native



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1739

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1944


commit c5efe6eb0c1ff3bf4ac8c2e693e1405ebbe61d00
Author: Martyn Taylor 
Date:   2018-03-08T20:57:46Z

ARTEMIS-1739 Set automatic module name for native




> default module name for artemis-native uses reserved keyword
> 
>
> Key: ARTEMIS-1739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Assignee: Martyn Taylor
>Priority: Major
>
> We can override this in the manifest.  I will rename as artemis.jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARTEMIS-1739) default module name for artemis-native uses reserved keyword

2018-03-08 Thread Martyn Taylor (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martyn Taylor updated ARTEMIS-1739:
---
Summary: default module name for artemis-native uses reserved keyword  
(was: Automatic module name for artemis-native uses reserved keyword)

> default module name for artemis-native uses reserved keyword
> 
>
> Key: ARTEMIS-1739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Priority: Major
>
> We can override this in the manifest.  I will rename as artemis-jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARTEMIS-1739) default module name for artemis-native uses reserved keyword

2018-03-08 Thread Martyn Taylor (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martyn Taylor updated ARTEMIS-1739:
---
Description: We can override this in the manifest.  I will rename as 
artemis.jni  (was: We can override this in the manifest.  I will rename as 
artemis-jni)

> default module name for artemis-native uses reserved keyword
> 
>
> Key: ARTEMIS-1739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Priority: Major
>
> We can override this in the manifest.  I will rename as artemis.jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARTEMIS-1739) default module name for artemis-native uses reserved keyword

2018-03-08 Thread Martyn Taylor (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martyn Taylor reassigned ARTEMIS-1739:
--

Assignee: Martyn Taylor

> default module name for artemis-native uses reserved keyword
> 
>
> Key: ARTEMIS-1739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Martyn Taylor
>Assignee: Martyn Taylor
>Priority: Major
>
> We can override this in the manifest.  I will rename as artemis.jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARTEMIS-1739) Automatic module name for artemis-native uses reserved keyword

2018-03-08 Thread Martyn Taylor (JIRA)
Martyn Taylor created ARTEMIS-1739:
--

 Summary: Automatic module name for artemis-native uses reserved 
keyword
 Key: ARTEMIS-1739
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1739
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Martyn Taylor


We can override this in the manifest.  I will rename as artemis-jni



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AMQ-6781) The ActiveMQ Web Console doesn’t support a plus (+) sign in the ClientID

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391883#comment-16391883
 ] 

ASF GitHub Bot commented on AMQ-6781:
-

Github user snurmine closed the pull request at:

https://github.com/apache/activemq/pull/269


> The ActiveMQ Web Console doesn’t support a plus (+) sign in the ClientID
> 
>
> Key: AMQ-6781
> URL: https://issues.apache.org/jira/browse/AMQ-6781
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: webconsole
>Affects Versions: 5.14.1, 5.15.0
>Reporter: Patrick Vansevenant
>Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> I’m trying to use an ISO 8601 date/time as part of the ClientID. 
> For example : connection.setClientID(" id>|2017-08-01T09:20:18.936+03:00"); 
> !screenshot-1.png!
> The following error is generated when clicked on the url in the Web Console | 
> Connections page : 
> !screenshot-2.png!
> I see that the ‘+’ sign isn’t correct encoded in the URL. 
> It is : *{color:red}+{color}* 
> http://testactivemq:8161/admin/connection.jsp?connectionID=%3Cmy%20unique%20id%3E|2017-08-01T09:20:18.936{color:red}*+*{color}03:00
>  
> And it should perhaps be : *{color:red}%2B {color}*
> http://testactivemq:8161/admin/connection.jsp?connectionID=%3Cmy%20unique%20id%3E|2017-08-01T09:20:18.936{color:red}*%2B*{color}03:00
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1682) duplicate classes in Artemis jars

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391871#comment-16391871
 ] 

ASF GitHub Bot commented on ARTEMIS-1682:
-

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1942

ARTEMIS-1682 Set packaging jar for artemis-server



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1682

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1942


commit fde86c0c3ad1390feba92fcf151558abfacc4a48
Author: Martyn Taylor 
Date:   2018-03-08T20:07:41Z

ARTEMIS-1682 Set packaging jar for artemis-server




> duplicate classes in Artemis jars
> -
>
> Key: ARTEMIS-1682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1682
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Jeff Mesnil
>Assignee: Martyn Taylor
>Priority: Blocker
>
> This is a recent change in Artemis master branch.
> The org.apache.activemq.artemis.utils package whose source files are in 
> artemis-commons are also present in the artemis-server jar.
>  
> {code:java}
> $ find . -name ExecutorFactory.java
> ./artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ExecutorFactory.java
> $ jar tvf artemis-commons/target/artemis-commons-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 2335 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/actors/OrderedExecutorFactory.class
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> $ jar tvf artemis-server/target/artemis-server-2.5.0-SNAPSHOT.jar | grep 
> ExecutorFactory
> 230 Wed Feb 14 09:30:54 CET 2018 
> org/apache/activemq/artemis/utils/ExecutorFactory.class
> {code}
>  
> This causes issue when we integrate Artemis on our application server that is 
> using a modular class loader as there are 2 definitions of the 
> ExecutorFactory class and we end up with weird errors such as:
> {code}
> 12:02:16,754 ERROR [org.jboss.msc.service.fail] (ServerService Thread Pool -- 
> 68) MSC01: Failed to start service 
> jboss.messaging-activemq.default.jms.manager: 
> org.jboss.msc.service.StartException in service 
> jboss.messaging-activemq.default.jms.manager: 
> java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.doStart(JMSService.java:209)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService.access$000(JMSService.java:64)
> at 
> org.wildfly.extension.messaging.activemq.jms.JMSService$1.run(JMSService.java:99)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1979)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1481)
> at 
> org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:485)
> Caused by: java.lang.IncompatibleClassChangeError: Class 
> org.apache.activemq.artemis.utils.actors.OrderedExecutorFactory does not 
> implement the requested interface 
> org.apache.activemq.artemis.utils.ExecutorFactory
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.(AbstractJournalStorageManager.java:222)
> at 
> org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager.(JournalStorageManager.java:106)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createStorageManager(ActiveMQServerImpl.java:2151)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart1(ActiveMQServerImpl.java:2287)
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:63)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
> at 
> org.apache.activemq.artemis.jms.server.i

[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391844#comment-16391844
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@stanlyDoge nice test though!! What ever the fix worth making sure it gets 
added in :)


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391838#comment-16391838
 ] 

ASF GitHub Bot commented on ARTEMIS-1714:
-

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1941


> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391837#comment-16391837
 ] 

ASF GitHub Bot commented on ARTEMIS-1714:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1941
  
@jbertram great. Closing


> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391833#comment-16391833
 ] 

ASF GitHub Bot commented on ARTEMIS-1714:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1941
  
I've got a bunch of other doc updates coming ASAP, and I'll include this 
one so you can just close this so I don't have to merge and rebase.


> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391817#comment-16391817
 ] 

ASF GitHub Bot commented on ARTEMIS-1714:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1941
  
Was just reviewing the other pr when it got merged, as such just raising 
the only comment I was adding as a PR as easiest


> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391810#comment-16391810
 ] 

ASF GitHub Bot commented on ARTEMIS-1714:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1941

ARTEMIS-1714 update link

Link to dedicate page about exclusive queue feature

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis patch-5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1941


commit 3f9d9d390b647f68917fa7a43fb92321d8729466
Author: Michael André Pearce 
Date:   2018-03-08T19:35:42Z

ARTEMIS-1714 update link

Link to dedicate page about exclusive queue feature




> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread Justin Bertram (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1714.
-
Resolution: Fixed

> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391800#comment-16391800
 ] 

ASF subversion and git services commented on ARTEMIS-1714:
--

Commit 66f8d984215fbc10a3f8d43169fee8bdaafecb4d in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=66f8d98 ]

ARTEMIS-1714 version notes + upgrade procedures


> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1714) Provide release summary & upgrade details

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391799#comment-16391799
 ] 

ASF subversion and git services commented on ARTEMIS-1714:
--

Commit a79dea088516bc44f4452b576f2acf8f5f97360f in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a79dea0 ]

ARTEMIS-1714 remove out-of-date release details


> Provide release summary & upgrade details
> -
>
> Key: ARTEMIS-1714
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1714
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>
> It seems that there is only one place in the Artemis sources that contains 
> "release information". It is {{docs/README.md}} and the information there is 
> outdated since it only documents the releases 1.0.0, 1.1.0 and 1.2.0.
> Please keep the "release information" up to date with the new releases.
> It would probably make sense to put this information in the main GitBook 
> guide. A "release" or "changes" page listing all the versions with their 
> major changes (and a link to Jira for the complete list of changes) would be 
> very useful.
> FWIW, ActiveMQ has something similar at 
> http://activemq.apache.org/new-features.html. Kafka documents the "notable 
> changes", see for instance 
> https://kafka.apache.org/documentation/#upgrade_100_notable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1286) Server stops responding and throws OutOfDirectMemoryError when sending & receiving lots of 2MB messages.

2018-03-08 Thread Phillip Jenkins (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391653#comment-16391653
 ] 

Phillip Jenkins commented on ARTEMIS-1286:
--

[~clebertsuconic] and [~jbertram],

I was using the default global-max-size which comes out at around 500MB. I 
found that by increasing the memory I could delay the error. However, it was 
just a delay and eventually the error would appear. I can suggest increasing 
the loop count to 500 to see if it will appear. Something to run over lunch so 
it doesn't impact you too much. Until you reproduce you're stuck which means 
I'm stuck. 

It's a big deal here so I must brainstorm with others for possible next steps. 
Any suggestions from you would be most welcome indeed. 

> Server stops responding and throws OutOfDirectMemoryError when sending & 
> receiving lots of 2MB messages.
> 
>
> Key: ARTEMIS-1286
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1286
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker, MQTT
>Affects Versions: 2.1.0
>Reporter: Phillip Jenkins
>Assignee: Martyn Taylor
>Priority: Blocker
> Fix For: unscheduled
>
> Attachments: MQTTBasicPubSubExample2.zip, artemis log showing v2.4 
> still having trouble handling large messages.log, broker.xml, 
> image-2018-02-24-19-54-00-892.png, mqtt.zip
>
>
> Originally seen in v2.1 and present in v2.2.
> If you send and receive a lot of 2MB messages in short time thru Artemis via 
> Netty connector, the server throws the following OutOfDirectMemoryError 
> exception. The server stops responding and will not (any longer) accept 
> connections without throwing exceptions in an infinite loop.
> {code:java}
> 11:24:07,434 INFO  [org.apache.activemq.artemis] AMQ241001: HTTP Server 
> started at http://localhost:8161
> 11:24:07,434 INFO  [org.apache.activemq.artemis] AMQ241002: Artemis Jolokia 
> REST API available at http://localhost:8161/jolokia
> 11:58:35,991 WARN  [org.apache.activemq.artemis.core.server] AMQ222151: 
> removing consumer which did not handle a message, consumer=ServerConsumerImpl 
> [id=2229, filter=null, binding=LocalQueueBinding 
> [address=SOAP.S.PRN.ACBCAF6238234680, 
> queue=QueueImpl[name=ACBCAF6238234680.SOAP.S.PRN.ACBCAF6238234680, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=afa7de73-67e7-11e7-a231-54ee7505882d], 
> temp=false]@46adc2a5, filter=FilterImpl [sfilterString=NOT ((AMQAddress = 
> 'activemq.management') OR (AMQAddress = 'activemq.notifications'))], 
> name=ACBCAF6238234680.SOAP.S.PRN.ACBCAF6238234680, 
> clusterName=ACBCAF6238234680.SOAP.S.PRN.ACBCAF6238234680afa7de73-67e7-11e7-a231-54ee7505882d]],
>  
> message=Reference[3551]:NON-RELIABLE:CoreMessage[messageID=3551,durable=false,userID=null,priority=0,
>  timestamp=0,expiration=0, durable=false, 
> address=SOAP.S.PRN.ACBCAF6238234680,properties=TypedProperties[mqtt.message.retain=false,mqtt.qos.level=0]]@1305748199:
>  io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 3729415 
> byte(s) of direct memory (used: 1070952692, max: 1073741824)
>   at 
> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:585)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:539)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledUnsafeNoCleanerDirectByteBuf.java:30)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.allocateDirect(UnpooledByteBufAllocator.java:169)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:68)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.UnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledUnsafeNoCleanerDirectByteBuf.java:25)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeNoCleanerDirectByteBuf.(UnpooledByteBufAllocator.java:164)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:73)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:181)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at 
> io.netty.buffer.AbstractByteBufAllocator.buffer(AbstractByteBufAllocator.java:117)
>  [netty-all-4.1.9.Final.jar:4.1.9.Final]
>   at io.netty.buffer.AbstractByt

[jira] [Commented] (ARTEMIS-1736) management role access methods not ordered

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391535#comment-16391535
 ] 

ASF subversion and git services commented on ARTEMIS-1736:
--

Commit e849471c832b7475939bfe969aef99ba6aa828a7 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e849471 ]

ARTEMIS-1736 - make sure access methods are ordered when used

https://issues.apache.org/jira/browse/ARTEMIS-1736


> management role access methods not ordered
> --
>
> Key: ARTEMIS-1736
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1736
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Priority: Major
>
> in the management.xml the access elements are not us3d in order meaning * can 
> be selected every time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1736) management role access methods not ordered

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391537#comment-16391537
 ] 

ASF GitHub Bot commented on ARTEMIS-1736:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1939


> management role access methods not ordered
> --
>
> Key: ARTEMIS-1736
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1736
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Priority: Major
>
> in the management.xml the access elements are not us3d in order meaning * can 
> be selected every time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1736) management role access methods not ordered

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391536#comment-16391536
 ] 

ASF subversion and git services commented on ARTEMIS-1736:
--

Commit e849471c832b7475939bfe969aef99ba6aa828a7 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e849471 ]

ARTEMIS-1736 - make sure access methods are ordered when used

https://issues.apache.org/jira/browse/ARTEMIS-1736


> management role access methods not ordered
> --
>
> Key: ARTEMIS-1736
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1736
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Priority: Major
>
> in the management.xml the access elements are not us3d in order meaning * can 
> be selected every time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1736) management role access methods not ordered

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391453#comment-16391453
 ] 

ASF GitHub Bot commented on ARTEMIS-1736:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1939
  
@andytaylor  rebase please?


> management role access methods not ordered
> --
>
> Key: ARTEMIS-1736
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1736
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Priority: Major
>
> in the management.xml the access elements are not us3d in order meaning * can 
> be selected every time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1345) Concurrent Modification Exceptions after Message.copy

2018-03-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391432#comment-16391432
 ] 

ASF subversion and git services commented on ARTEMIS-1345:
--

Commit 9ae059baebffbdb16f22b830dda0e545ac80d3bc in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9ae059b ]

ARTEMIS-1345 Making TestProperties a little easier on slow CIs

using less iterations, making it less risky on slow hypervisors


> Concurrent Modification Exceptions after Message.copy
> -
>
> Key: ARTEMIS-1345
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1345
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.3.0
>Reporter: Jiri Daněk
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>
> Consider tests
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.AutoCreateQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TemporaryQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TopicClusterTest}}
> When they are adapted to run through multiple JMS ConnectionFactories in 
> turn, these test are always passing with Core, one test method fails with 
> OpenWire (reported as ARTEMIS-1344), but all fail with AMQP.
> The broker prints the following error (every time)
> {noformat}
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,380 WARN  [org.apache.activemq.artemis.core.server] AMQ222151: 
> removing consumer which did not handle a message, 
> consumer=org.apache.activemq.artemis.core.server.cluster.impl.Redistributor@6c72718c,
>  
> message=Reference[28]:RELIABLE:org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage@799ad5a1:
>  java.lang.UnsupportedOperationException
>   at java.util.AbstractMap.put(AbstractMap.java:209) [rt.jar:1.8.0_131]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:690)
>  [:]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:743)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.addRouteContextToMessage(RemoteQueueBindingImpl.java:334)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.route(RemoteQueueBindingImpl.java:175)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl.redistribute(BindingsImpl.java:222)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.redistribute(PostOfficeImpl.java:868)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.Redistributor.handle(Redistributor.java:150)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.handle(QueueImpl.java:2802)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2187)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$ExecutorTask.run(ProcessorBase.java:53)
>  [:]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_131]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [rt.jar:1.8.0_131]
>   at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_131]
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,381 ERROR [org.apache.activemq.artemis.core.server] AMQ224041: 
> Failed to deliver: java.util.NoSuchElementException
>   at 
> org.apache.activemq.artemis.utils.collections.PriorityLinkedListImpl$PriorityLinkedListIterator.repeat(PriorityLinkedListImpl.java:161)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2205)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(Ordered

[jira] [Created] (ARTEMIS-1738) Reserved keyword (native) are not allowed for module name in Java 9

2018-03-08 Thread Martyn Taylor (JIRA)
Martyn Taylor created ARTEMIS-1738:
--

 Summary: Reserved keyword (native) are not allowed for module name 
in Java 9
 Key: ARTEMIS-1738
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1738
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Martyn Taylor


Unable to derive module descriptor for artemis-native-1.5.5.jar
Caused by: java.lang.IllegalArgumentException: artemis.native: Invalid module 
name: 'native' is not a Java identifier

At first glance, reserved keyword (native) are not allowed for module name.
Solution: Add Automatic-Module-Name to artemis-native artifact to work around



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (AMQ-6923) Reserved keyword (native) are not allowed for module name in Java 9

2018-03-08 Thread Martyn Taylor (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMQ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martyn Taylor closed AMQ-6923.
--
Resolution: Not A Bug

Opened in Wrong JIRA.

> Reserved keyword (native) are not allowed for module name in Java 9
> ---
>
> Key: AMQ-6923
> URL: https://issues.apache.org/jira/browse/AMQ-6923
> Project: ActiveMQ
>  Issue Type: Bug
>Reporter: Martyn Taylor
>Priority: Major
>
> Unable to derive module descriptor for .\artemis-native-1.5.5.jbossorg-009.jar
> Caused by: java.lang.IllegalArgumentException: artemis.native: Invalid module 
> name: 'native' is not a Java identifier
> At first glance, reserved keyword (native) are not allowed for module name.
> Solution: Add Automatic-Module-Name to artemis-native artifact to work around



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AMQ-6923) Reserved keyword (native) are not allowed for module name in Java 9

2018-03-08 Thread Martyn Taylor (JIRA)
Martyn Taylor created AMQ-6923:
--

 Summary: Reserved keyword (native) are not allowed for module name 
in Java 9
 Key: AMQ-6923
 URL: https://issues.apache.org/jira/browse/AMQ-6923
 Project: ActiveMQ
  Issue Type: Bug
Reporter: Martyn Taylor


Unable to derive module descriptor for .\artemis-native-1.5.5.jbossorg-009.jar
Caused by: java.lang.IllegalArgumentException: artemis.native: Invalid module 
name: 'native' is not a Java identifier

At first glance, reserved keyword (native) are not allowed for module name.
Solution: Add Automatic-Module-Name to artemis-native artifact to work around



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ARTEMIS-797) Add client based advisory messages

2018-03-08 Thread Christopher L. Shannon (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon closed ARTEMIS-797.
--
Resolution: Won't Fix

> Add client based advisory messages
> --
>
> Key: ARTEMIS-797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-797
> Project: ActiveMQ Artemis
>  Issue Type: Sub-task
>  Components: Broker
>Reporter: Christopher L. Shannon
>Priority: Major
>
> This task is for adding client based advisories (new connections, new 
> consumers and new producers).  Connections and consumers are straight forward 
> but not all protocols tracker producers.  With OpenWire and AMQP producers 
> are tracked so this is easy.  STOMP and MQTT do not track producers and 
> ActiveMQ 5.x just handles this by sending a producer advisory for any new 
> connection.  We could also just not send producer advisories for STOMP/MQTT.
> For the CORE protocol, producers are not currently tracked but I think we 
> should add a new packet type so the broker can keep track of new producers 
> and send advisories and keep statistics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ARTEMIS-798) Add destination based advisory messages

2018-03-08 Thread Christopher L. Shannon (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon closed ARTEMIS-798.
--
Resolution: Won't Fix

> Add destination based advisory messages
> ---
>
> Key: ARTEMIS-798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-798
> Project: ActiveMQ Artemis
>  Issue Type: Sub-task
>  Components: Broker
>Reporter: Christopher L. Shannon
>Priority: Major
>
> Add advisory messages for destination and temp destination create/destroy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391264#comment-16391264
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
Ah, I see. Yeah, it seem to be changed in 
[ARTEMIS-1440](https://issues.apache.org/jira/browse/ARTEMIS-1440). 
@clebertsuconic can you take a look?


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391254#comment-16391254
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
@stanlyDoge its not just the console affected. the root cause of the issue 
you are seeing was that actually fail() method called prior to your change used 
to have the isExit flag to false, there are actually a few places that can be 
invoked as well, as such whilst the negative effect of this change that ive 
called out, is most visible with the console, there are more serious bits seen 
that also look like they're affected such as Network Pinger. 

This really needs to have @clebertsuconic look over his original change, as 
it seems that it is what caused this, also others in my opinion. And any fix 
needs to not just care about the console.


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391251#comment-16391251
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
Yes, it is. I used this conf: https://pastebin.com/2G0c341X
If I am not wrong, restaring logic is implemented as 
[this](https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedNothingLiveActivation.java#L194).
I am not sure if it would be ok to iterate all ExternalComponents here and 
if it is web one, just start it again. What do you think?


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391237#comment-16391237
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1940
  
Is this on fail back to master? With restart enabled?

If so shouldn’t the console be in the restarting logic with the other 
components?


> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (AMQ-6911) Constraint violation on failover (Postgresql)

2018-03-08 Thread Maciej Miklas (JIRA)

 [ 
https://issues.apache.org/jira/browse/AMQ-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maciej Miklas closed AMQ-6911.
--
Resolution: Not A Bug

Out JDBC configuration was incorrect - autocommit was set to false, and in 
result messages were propagated in DB with delay.

> Constraint violation on failover (Postgresql)
> -
>
> Key: AMQ-6911
> URL: https://issues.apache.org/jira/browse/AMQ-6911
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: JDBC
>Affects Versions: 5.15.2
>Reporter: Maciej Miklas
>Priority: Major
>
> We have ActiveMq 5.15.2 in following configuration:
>  * PostgreSQL for persistance
>  * two nodes, one in standby
>  * JDBC master slave with shared database
>  * static cluster discovery
> Everything seams to be fine, failover works as expected, but sometimes during 
> failover we are observing following exception:
> {code:java}
>  28.02.2018 09:28:54,207 WARN  [ActiveMQ NIO Worker 6] 
> org.apache.activemq.transaction.LocalTransaction  - Store COMMIT 
> FAILED:java.io.IOException: Batch entry 2 INSERT INTO ACTIVEMQ_MSGS(ID, 
> MSGID_PROD, MSGID_SEQ, CONTAINER, EXPIRATION, PRIORITY, MSG, XID) VALUES 
> (7095330, 'xxx-1-1519303952070-3:862:8:1', 15, 'queue://abc', 1520411334073, 
> 4, ?, NULL) was aborted: FEHLER: doppelter Schl▒sselwert verletzt 
> Unique-Constraint ▒activemq_msgs_pkey▒  Detail: Schl▒ssel ▒(id)=(7095330)▒ 
> existiert bereits.  Call getNextException to see other errors in the batch.   
>  at 
> org.apache.activemq.util.IOExceptionSupport.create(IOExceptionSupport.java:46)
>     at 
> org.apache.activemq.store.jdbc.TransactionContext.commit(TransactionContext.java:209)
>     at 
> org.apache.activemq.store.jdbc.JDBCPersistenceAdapter.commitTransaction(JDBCPersistenceAdapter.java:516)
>     at 
> org.apache.activemq.store.memory.MemoryTransactionStore$Tx.commit(MemoryTransactionStore.java:113)
>     at 
> org.apache.activemq.store.memory.MemoryTransactionStore.commit(MemoryTransactionStore.java:270){code}
> ActiveMQ propagates this exception directly to the client.
> I am assuming, that due to a failover some clients did not get acknowledgment 
> and message has been resent to a new node.
> If I am correct ActiveMq should just ignore duplicated message, or both 
> messages should be stored in database. But latest it's not possible, because  
> ACTIVEMQ_MSGS#ID is a PK
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391012#comment-16391012
 ] 

ASF GitHub Bot commented on ARTEMIS-1737:
-

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1940

ARTEMIS-1737 fix for inaccessible slave console after failover

Can anybody review this? I will try to write some tests meanwhile. Thank 
you.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E1018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1940


commit 81d6328850b77b3d314aa64ea61a24bbb1baf055
Author: Stanislav Knot 
Date:   2018-03-08T10:03:37Z

ARTEMIS-1737 fix for inaccessible slave console after failover




> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread Stanislav Knot (JIRA)

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanislav Knot reassigned ARTEMIS-1737:
---

Assignee: Stanislav Knot

> When live-slave fails-back to master, it turns off everything down, even its 
> console
> 
>
> Key: ARTEMIS-1737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> 1) Set up HA pair with slave {{true}}
> 2) Kill master
> 3) Make sure slave becomes live
> 4) Start master again, slave gives control to master and becomes a slave
> 5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARTEMIS-1737) When live-slave fails-back to master, it turns off everything down, even its console

2018-03-08 Thread Stanislav Knot (JIRA)
Stanislav Knot created ARTEMIS-1737:
---

 Summary: When live-slave fails-back to master, it turns off 
everything down, even its console
 Key: ARTEMIS-1737
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1737
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Stanislav Knot


1) Set up HA pair with slave {{true}}
2) Kill master
3) Make sure slave becomes live
4) Start master again, slave gives control to master and becomes a slave
5) Console of slave (backup now) becomes inaccessible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1736) management role access methods not ordered

2018-03-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390985#comment-16390985
 ] 

ASF GitHub Bot commented on ARTEMIS-1736:
-

GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1939

ARTEMIS-1736 - make sure access methods are ordered when used

https://issues.apache.org/jira/browse/ARTEMIS-1736

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis ARTEMIS-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1939.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1939


commit 56c2e2b29984fa6c637921517e8deff71c5f648f
Author: andytaylor 
Date:   2018-03-08T09:49:56Z

ARTEMIS-1736 - make sure access methods are ordered when used

https://issues.apache.org/jira/browse/ARTEMIS-1736




> management role access methods not ordered
> --
>
> Key: ARTEMIS-1736
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1736
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Priority: Major
>
> in the management.xml the access elements are not us3d in order meaning * can 
> be selected every time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARTEMIS-1736) management role access methods not ordered

2018-03-08 Thread Andy Taylor (JIRA)
Andy Taylor created ARTEMIS-1736:


 Summary: management role access methods not ordered
 Key: ARTEMIS-1736
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1736
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Andy Taylor


in the management.xml the access elements are not us3d in order meaning * can 
be selected every time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARTEMIS-1734) Unable to access to AMQ7.1 Management Console in read-only mode

2018-03-08 Thread Jose Roman Martin Gil (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390920#comment-16390920
 ] 

Jose Roman Martin Gil commented on ARTEMIS-1734:


Maybe this is not the right place for this ticket. 

Opened other one here: [https://issues.jboss.org/browse/ENTMQBR-1060]

Close this ticket?

> Unable to access to AMQ7.1 Management Console in read-only mode
> ---
>
> Key: ARTEMIS-1734
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1734
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Web Console
>Affects Versions: 2.4.0
> Environment: RHEL 7.3
> OpenJDK 1.8.0 (latest rpm)
>Reporter: Jose Roman Martin Gil
>Priority: Major
> Attachments: amq-monitor-user.png
>
>
> As administrator I want to create a monitor role to allow access to 
> Management Console only to view and read the status of any objects.
>  
> As administrator I am using roles to manage queues and topics successfully 
> but I would like to have users to monitor the broker with the Management 
> Console.
>  
> At this moment I created a role and I updated the following files as: 
>  
> *etc/artemis.profile*: Changed the roles allowed to access:
> {code:java}
> -Dhawtio.roles=amq,monitor{code}
>  
> *etc/management.xml*: Allowed methods for each method:
> {code:java}
> 
>  
>  
>  
>  
>  
> 
> 
>  
>  
>  
>  
>  
>  
>  
> {code}
> With these changes I could login as monitor user however I found a lot of 
> errors as:
>  
> {code:java}
> ERROR: Insufficient roles/credentials for operation (class 
> java.lang.SecurityException){code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)