[jira] [Closed] (AMQ-7186) Network bridge failing after authentication-plugin use

2020-06-23 Thread Pratibha (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pratibha closed AMQ-7186.
-
Resolution: Fixed

This resolution has been provided

> Network bridge failing after authentication-plugin use
> --
>
> Key: AMQ-7186
> URL: https://issues.apache.org/jira/browse/AMQ-7186
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 5.15.8
>Reporter: Pratibha
>Priority: Major
> Fix For: 5.15.8
>
>
> We are using Apache *ActiveMQ version 5.15.8.*
>  
> We have created Broker to Broker ActiveMQ  network using ssh tunneling.
> *Broker-A is enqueuing messages & messages are getting dequeued at Broker-B 
> end.*
> We have added below configuration to restrict the Broker-A from creating new 
> queues other than specified one.
>  
> *Below is configuration at Broker-B:*
>  # Contents added in activemq.xml
> |    
>     
>     
>     
>      password="testpassword " groups="admins,all" />
>     
>     
>     
>     
>   
>     
>   
>      write="admins" admin="admins" />
>      read="admins" write="admins" admin="admins"/>
>   
>     
>   
>     
>     |
>  
>  # Contents of users.properties
> |admin= adminpassword
> test= testpassword|
>  
>  # Contents of groups.properties
> |admins=admin,test
> all=admin,test|
>  
>  # Contents of credentials.properties
> |activemq.username=admin
> activemq.password= adminpassword|
>  
>  # Contents of jetty-realm.properties
> |admin: adminpassword, admin
> test: testpassword, admin|
>  
> *Below is configuration at Broker-A:*
>  # Contents added in activemq.xml
> |   
>      password=" adminpassword " 
> uri="static:(tcp://127.0.0.1:61618)?connection.useCompression=true" 
> staticBridge="true">
>     
>    
>     
>     |
>  
>  
> If we just add ** plugin in Broker-B 
> configuration then bridge connection is working between Broker-A to Broker-B.
>  
> But when are adding *, 
> * and ** Broker-B 
> configuration then bridge connection is not working.
> We are getting below error at Broker-A end.
>  
> |2019-04-18 05:04:20,932 \| INFO  \| localhost bridge to localhost stopped \| 
> org.apache.activemq.network.DemandForwardingBridgeSupport \| ActiveMQ 
> BrokerService[localhost] Task-2263
> 2019-04-18 05:04:50,930 \| INFO  \| Establishing network connection from 
> vm://localhost to tcp://127.0.0.1:61618 \| 
> org.apache.activemq.network.DiscoveryNetworkConnector \| ActiveMQ Task-2
> 2019-04-18 05:04:50,973 \| INFO  \| Network connection between 
> vm://localhost#4146 and tcp:///127.0.0.1:61618@37514 (localhost) has been 
> established. \| org.apache.activemq.network.DemandForwardingBridgeSupport \| 
> triggerStartAsyncNetworkBridgeCreation: 
> remoteBroker=tcp:///127.0.0.1:61618@37514, localBroker= vm://localhost#4146
> 2019-04-18 05:04:50,977 \| ERROR \| Network connection between 
> vm://localhost#4146 and tcp:///127.0.0.1:61618@37514 shutdown due to a remote 
> error: {} \| org.apache.activemq.network.DemandForwardingBridgeSupport \| 
> ActiveMQ Transport: tcp:///127.0.0.1:61618@37514
> java.lang.SecurityException: User name [admin] or password is invalid.
>     at 
> org.apache.activemq.security.JaasAuthenticationBroker.authenticate(JaasAuthenticationBroker.java:97)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.security.JaasAuthenticationBroker.addConnection(JaasAuthenticationBroker.java:68)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.broker.TransportConnection.processAddConnection(TransportConnection.java:843)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.broker.jmx.ManagedTransportConnection.processAddConnection(ManagedTransportConnection.java:77)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.command.ConnectionInfo.visit(ConnectionInfo.java:139)[activemq-client-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:330)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:194)[activemq-broker-5.15.8.jar:5.15.8]
>     at 
> org.apache.activemq.transport.MutexTransport.onCommand(MutexTransport.java:50)[activemq-client-5.15.8.jar:5.15.8]
>  

[jira] [Commented] (AMQ-7503) Comment code with issue numbers

2020-06-23 Thread ackelcn (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143513#comment-17143513
 ] 

ackelcn commented on AMQ-7503:
--

[https://github.com/apache/activemq/pull/547] I created a pull request to 
highlight my added comments.

> Comment code with issue numbers
> ---
>
> Key: AMQ-7503
> URL: https://issues.apache.org/jira/browse/AMQ-7503
> Project: ActiveMQ
>  Issue Type: Improvement
>Reporter: ackelcn
>Priority: Major
>
> When I read the code of activemq, I find some comments with issue numbers. 
> One of them comes from TopicSubscription.java:
> {code:java}
> public void add(MessageReference node) throws Exception {
>...
>while (active) {
> while (matched.isFull()) {
> if (getContext().getStopping().get()) {
> LOG.warn("{}: stopped waiting for space in 
> pendingMessage cursor for: {}", toString(), node.getMessageId());
>
> getSubscriptionStatistics().getEnqueues().decrement();
> return;
> }
> if (!warnedAboutWait) {
> LOG.info("{}: Pending message cursor [{}] is 
> full, temp usag ({}%) or memory usage ({}%) limit reached, blocking message 
> add() pending the release of resources.",
> new Object[]{
> toString(),
> matched,
> 
> matched.getSystemUsage().getTempUsage().getPercentUsage(),
> 
> matched.getSystemUsage().getMemoryUsage().getPercentUsage()
> });
> warnedAboutWait = true;
> }
> matchedListMutex.wait(20);
> }
> // Temporary storage could be full - so just try to 
> add the message
> // see 
> https://issues.apache.org/activemq/browse/AMQ-2475
> if (matched.tryAddMessageLast(node, 10)) {
> break;
> }
> }{code}
> These comments are quite useful for other programmers and me to understand 
> the code, but I notice that not all issue numbers are written in code 
> comments. It can be already quite tedious to write them into commit messages 
> :)
>  
> To handle the problem, I implemented a tool to automatically instrument issue 
> numbers into code comments. I tried my tool on activemq, and the instrumented 
> version is [https://github.com/ackelcn/activemq] 
>  
> To avoid confusion, if there is already an issue number in code comments, my 
> tool ignored the issue number. All my generated comments start from //IC, so 
> it is easy to find them.
>  
> Would you please some feedbacks to my tool? Please feel free to merge my 
> generated comments in your code, if you feel that some are useful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AMQ-7503) Comment code with issue numbers

2020-06-23 Thread ackelcn (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ackelcn updated AMQ-7503:
-
Description: 
When I read the code of activemq, I find some comments with issue numbers. One 
of them comes from TopicSubscription.java:
{code:java}
public void add(MessageReference node) throws Exception {
   ...
   while (active) {
while (matched.isFull()) {
if (getContext().getStopping().get()) {
LOG.warn("{}: stopped waiting for space in 
pendingMessage cursor for: {}", toString(), node.getMessageId());
   
getSubscriptionStatistics().getEnqueues().decrement();
return;
}
if (!warnedAboutWait) {
LOG.info("{}: Pending message cursor [{}] is 
full, temp usag ({}%) or memory usage ({}%) limit reached, blocking message 
add() pending the release of resources.",
new Object[]{
toString(),
matched,

matched.getSystemUsage().getTempUsage().getPercentUsage(),

matched.getSystemUsage().getMemoryUsage().getPercentUsage()
});
warnedAboutWait = true;
}
matchedListMutex.wait(20);
}
// Temporary storage could be full - so just try to add 
the message
// see 
https://issues.apache.org/activemq/browse/AMQ-2475
if (matched.tryAddMessageLast(node, 10)) {
break;
}
}{code}
These comments are quite useful for other programmers and me to understand the 
code, but I notice that not all issue numbers are written in code comments. It 
can be already quite tedious to write them into commit messages :)

 

To handle the problem, I implemented a tool to automatically instrument issue 
numbers into code comments. I tried my tool on activemq, and the instrumented 
version is [https://github.com/ackelcn/activemq] 

 

To avoid confusion, if there is already an issue number in code comments, my 
tool ignored the issue number. All my generated comments start from //IC, so it 
is easy to find them.

 

Would you please some feedbacks to my tool? Please feel free to merge my 
generated comments in your code, if you feel that some are useful.

  was:
When I read the code of activemq, I find some comments with issue numbers. One 
of them comes from TopicSubscription.java:
{code:java}
public void add(MessageReference node) throws Exception {
   ...
   while (active) {
while (matched.isFull()) {
if (getContext().getStopping().get()) {
LOG.warn("{}: stopped waiting for space in 
pendingMessage cursor for: {}", toString(), node.getMessageId());
   
getSubscriptionStatistics().getEnqueues().decrement();
return;
}
if (!warnedAboutWait) {
LOG.info("{}: Pending message cursor [{}] is 
full, temp usag ({}%) or memory usage ({}%) limit reached, blocking message 
add() pending the release of resources.",
new Object[]{
toString(),
matched,

matched.getSystemUsage().getTempUsage().getPercentUsage(),

matched.getSystemUsage().getMemoryUsage().getPercentUsage()
});
warnedAboutWait = true;
}
matchedListMutex.wait(20);
}
// Temporary storage could be full - so just try to add 
the message
// see 
https://issues.apache.org/activemq/browse/AMQ-2475
if (matched.tryAddMessageLast(node, 10)) {
break;
}
}{code}
These comments are quite useful for other programmers and me to understand the 
code, but I notice that not all issue numbers are written in code comments. It 
can be already quite tedious to write them into commit messages :)

 

To handle the problem, I implemented a tool to automatically instrument issue 
numbers into code comments. I tried my tool on activemq, and the instrumented 

[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=450187=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450187
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 24/Jun/20 02:22
Start Date: 24/Jun/20 02:22
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce edited a comment on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648539664


   Regarding async send and ordering for persistent will test that might be 
manual at first. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 450187)
Time Spent: 8h 10m  (was: 8h)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=450185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450185
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 24/Jun/20 02:21
Start Date: 24/Jun/20 02:21
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce edited a comment on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648537915


   Non persistent does not need to wait for confirmation from broker. By spec 
there is no gaurentee of delivery.  Qpid actually does the same as well as 
Artemis jms client. You actually had same logic earlier in 1.8 e.g. when non 
persistent it just sent and returned immediately, just renamed the variable a 
bit more appropriately.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 450185)
Time Spent: 8h  (was: 7h 50m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 8h
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=450184=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450184
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 24/Jun/20 02:20
Start Date: 24/Jun/20 02:20
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce edited a comment on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648537915


   Non persistent does not need to wait for confirmation from broker. By spec 
there is no gaurentee of delivery.  Qpid actually does the same as well as 
Artemis jms client. You actually had same logic earlier in 1.8 just renamed the 
variable a bit more appropriately.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 450184)
Time Spent: 7h 50m  (was: 7h 40m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7h 50m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=450183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450183
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 24/Jun/20 02:19
Start Date: 24/Jun/20 02:19
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648541767


   @Havret thanks merged that last bit. Quick question do we want to make 
receive async before we cut a release, like wise do we want add async create 
session producer etc. Or do we leave for 2.1?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 450183)
Time Spent: 7h 40m  (was: 7.5h)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=450181=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450181
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 24/Jun/20 02:11
Start Date: 24/Jun/20 02:11
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648539664


   Regarding async sent that and ordering for persistent will test that might 
be manual at first



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 450181)
Time Spent: 7.5h  (was: 7h 20m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7.5h
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=450179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450179
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 24/Jun/20 02:05
Start Date: 24/Jun/20 02:05
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648537915


   Non persistent does not need to wait for confirmation from broker. By spec 
there is no gaurentee of delivery.  Qpid actually does the same as well as 
Artemis jms client.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 450179)
Time Spent: 7h 20m  (was: 7h 10m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=449993=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449993
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 23/Jun/20 19:44
Start Date: 23/Jun/20 19:44
Worklog Time Spent: 10m 
  Work Description: Havret edited a comment on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648378968


   @cjwmorgan-sol So sends are fire and forget in AmqpNetLite. To be precise 
all IO operations are fire and forget. You do not actually await any IO 
operation. Take a look at this --> 
https://github.com/Azure/amqpnetlite/issues/415. All you can await for in sync 
or async way is a reply from the broker itself. I'm not sure what it has to do 
with the order of messages, though. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449993)
Time Spent: 7h 10m  (was: 7h)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=449992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449992
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 23/Jun/20 19:43
Start Date: 23/Jun/20 19:43
Worklog Time Spent: 10m 
  Work Description: Havret commented on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648378968


   @cjwmorgan-sol So sends are fire and forget in AmqpNetLite. Actually all 
operations are fire and forget. You do not actually await any IO operation. 
Take a look at this --> https://github.com/Azure/amqpnetlite/issues/415. All 
you can await for in sync or async way is a reply from the broker itself. I'm 
not sure what it has to do with the order of messages, though. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449992)
Time Spent: 7h  (was: 6h 50m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 7h
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=449986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449986
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 23/Jun/20 19:26
Start Date: 23/Jun/20 19:26
Worklog Time Spent: 10m 
  Work Description: cjwmorgan-sol commented on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648370488


   The only concerns I have is for the order of execution of the async send and 
application network send vs send result notifications. 
   
   This might just be my naiveté towards the C# async patterns. Wouldn't the 
async sends potentially get out of order as the task executor would be on a 
thread pool that is system default based? I do not see how the send tasks 
execution order is synchronized internal in the provider to ensure send order 
from the application thread. Perhaps I'm missing something? This might also be 
a concept for the completion result signal, sounds like above the async 
implementation might deviate a bit from JMS spec perhaps I'm missing some 
rationale behind that as well. Right now my view on a NMS async send would be 
the nio equivalent (or something close to) of the JMS 2.0 send.
   
   Also the async send seems to produce different tasks depending on delivery 
mode (persistent vs non-persistent) having the task complete on network io 
complete for non-persistent and outcome result for persistent. This also leaves 
the application is a state where its unware of the messages send state. 
Although thinking about it with amqpnetlite "send" might mean buffered instead 
of io complete. However removing the capabilities of the application of 
separating network io complete vs response complete might be problematic back 
at the NMS api level should application require both network io complete and 
send outcome completion as separate events. Would such a  capability be out of 
scope for the NMS 2.0 improvements? Or is there some rationale I'm missing for 
the decide to combine the event of network io completion and send request 
completion?
   
   I also tried the unit tests using the NMS 2.0 api from @michaelpearce-gain 
pull request they all passed. Are there any tests for the ordering of messages 
sent and received I'd image so I have not found them. (I'm pretty sure they 
should be somewhere).
   I still need to try to update my testing tool a bit before I test any of the 
new significant changes done in NMS 2.0. Not sure when or if I'll be able to do 
that. I'll be relying heavily on testing in the meantime. :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449986)
Time Spent: 6h 50m  (was: 6h 40m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=449983=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449983
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 23/Jun/20 19:21
Start Date: 23/Jun/20 19:21
Worklog Time Spent: 10m 
  Work Description: Havret edited a comment on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648367678


   @michaelandrepearce Check 
[this](https://github.com/michaelandrepearce/activemq-nms-amqp/pull/2) PR out. 
It should be fine now. It should complete the fixes we were making yesterday. 
Besides that, LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449983)
Time Spent: 6h 40m  (was: 6.5h)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=449982=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449982
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 23/Jun/20 19:21
Start Date: 23/Jun/20 19:21
Worklog Time Spent: 10m 
  Work Description: Havret edited a comment on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648367678


   @michaelandrepearce Check 
[this](https://github.com/michaelandrepearce/activemq-nms-amqp/pull/2) PR out. 
It should be fine now. It should complete the fixes we were making yesterday. 
Besides that LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449982)
Time Spent: 6.5h  (was: 6h 20m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQNET-637) NMS 2.0

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-637?focusedWorklogId=449981=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449981
 ]

ASF GitHub Bot logged work on AMQNET-637:
-

Author: ASF GitHub Bot
Created on: 23/Jun/20 19:20
Start Date: 23/Jun/20 19:20
Worklog Time Spent: 10m 
  Work Description: Havret commented on pull request #56:
URL: https://github.com/apache/activemq-nms-amqp/pull/56#issuecomment-648367678


   @michaelandrepearce Check 
[this](https://github.com/michaelandrepearce/activemq-nms-amqp/pull/2) PR out. 
It should be fine now. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449981)
Time Spent: 6h 20m  (was: 6h 10m)

> NMS 2.0
> ---
>
> Key: AMQNET-637
> URL: https://issues.apache.org/jira/browse/AMQNET-637
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: NMS
>Affects Versions: 1.8.0
>Reporter: Michael Andre Pearce
>Priority: Major
> Fix For: 2.0.0
>
>  Time Spent: 6h 20m
>  Remaining Estimate: 0h
>
> NMS API is still at JMS 1.1 api level, this is to update the NMS api to the 
> latest JMS 2.0 api 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?focusedWorklogId=449964=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449964
 ]

ASF GitHub Bot logged work on ARTEMIS-2819:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 18:33
Start Date: 23/Jun/20 18:33
Worklog Time Spent: 10m 
  Work Description: k-wall commented on a change in pull request #3199:
URL: https://github.com/apache/activemq-artemis/pull/3199#discussion_r26546



##
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
##
@@ -1309,6 +1309,265 @@ public void testAddressSettings() throws Exception {
 
}
 
+   @Test
+   public void testRemoveAddressSettingsEffective() throws Exception {
+  ActiveMQServerControl serverControl = createManagementControl();
+  String addr = "test";
+  String root = "#";
+
+  String DLA = "someDLA";
+  String expiryAddress = "someExpiry";
+  long expiryDelay = RandomUtil.randomPositiveLong();
+  long minExpiryDelay = 1;
+  long maxExpiryDelay = 2;
+  boolean lastValueQueue = true;
+  int deliveryAttempts = 1;
+  long maxSizeBytes = 20;
+  int pageSizeBytes = 10;
+  int pageMaxCacheSize = 7;
+  long redeliveryDelay = 4;
+  double redeliveryMultiplier = 1;
+  long maxRedeliveryDelay = 1000;
+  long redistributionDelay = 5;
+  boolean sendToDLAOnNoRoute = true;
+  String addressFullMessagePolicy = "PAGE";
+  long slowConsumerThreshold = 5;
+  long slowConsumerCheckPeriod = 10;
+  String slowConsumerPolicy = 
SlowConsumerPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  boolean autoCreateJmsQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsQueues = RandomUtil.randomBoolean();
+  boolean autoCreateJmsTopics = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsTopics = RandomUtil.randomBoolean();
+  boolean autoCreateQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteQueues = RandomUtil.randomBoolean();
+  boolean autoCreateAddresses = RandomUtil.randomBoolean();
+  boolean autoDeleteAddresses = RandomUtil.randomBoolean();
+  String configDeleteQueues = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  String configDeleteAddresses = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  long maxSizeBytesRejectThreshold = RandomUtil.randomPositiveLong();
+  String defaultLastValueKey = RandomUtil.randomString();
+  boolean defaultNonDestructive = RandomUtil.randomBoolean();
+  boolean defaultExclusiveQueue = RandomUtil.randomBoolean();
+  boolean defaultGroupRebalance = RandomUtil.randomBoolean();
+  int defaultGroupBuckets = RandomUtil.randomPositiveInt();
+  String defaultGroupFirstKey = RandomUtil.randomString();
+  int defaultMaxConsumers = RandomUtil.randomPositiveInt();
+  boolean defaultPurgeOnNoConsumers = RandomUtil.randomBoolean();
+  int defaultConsumersBeforeDispatch = RandomUtil.randomPositiveInt();
+  long defaultDelayBeforeDispatch = RandomUtil.randomPositiveLong();
+  String defaultQueueRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  String defaultAddressRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  int defaultConsumerWindowSize = RandomUtil.randomPositiveInt();
+  long defaultRingSize = RandomUtil.randomPositiveLong();
+  boolean autoDeleteCreatedQueues = RandomUtil.randomBoolean();
+  long autoDeleteQueuesDelay = RandomUtil.randomPositiveLong();
+  long autoDeleteQueuesMessageCount = RandomUtil.randomPositiveLong();
+  long autoDeleteAddressesDelay = RandomUtil.randomPositiveLong();
+  double redeliveryCollisionAvoidanceFactor = RandomUtil.randomDouble();
+  long retroactiveMessageCount = RandomUtil.randomPositiveLong();
+  boolean autoCreateDeadLetterResources = RandomUtil.randomBoolean();
+  String deadLetterQueuePrefix = RandomUtil.randomString();
+  String deadLetterQueueSuffix = RandomUtil.randomString();
+  boolean autoCreateExpiryResources = RandomUtil.randomBoolean();
+  String expiryQueuePrefix = RandomUtil.randomString();
+  String expiryQueueSuffix = RandomUtil.randomString();
+  boolean enableMetrics = RandomUtil.randomBoolean();
+
+  serverControl.addAddressSettings(root,
+  DLA,
+  expiryAddress,
+  expiryDelay,
+  lastValueQueue,
+  deliveryAttempts,
+  maxSizeBytes,
+  pageSizeBytes,
+  pageMaxCacheSize,
+  redeliveryDelay,
+  redeliveryMultiplier,
+  maxRedeliveryDelay,
+  redistributionDelay,

[jira] [Work logged] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?focusedWorklogId=449953=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449953
 ]

ASF GitHub Bot logged work on ARTEMIS-2819:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 18:14
Start Date: 23/Jun/20 18:14
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on a change in pull request 
#3199:
URL: https://github.com/apache/activemq-artemis/pull/3199#discussion_r16390



##
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
##
@@ -1309,6 +1309,265 @@ public void testAddressSettings() throws Exception {
 
}
 
+   @Test
+   public void testRemoveAddressSettingsEffective() throws Exception {
+  ActiveMQServerControl serverControl = createManagementControl();
+  String addr = "test";
+  String root = "#";
+
+  String DLA = "someDLA";
+  String expiryAddress = "someExpiry";
+  long expiryDelay = RandomUtil.randomPositiveLong();
+  long minExpiryDelay = 1;
+  long maxExpiryDelay = 2;
+  boolean lastValueQueue = true;
+  int deliveryAttempts = 1;
+  long maxSizeBytes = 20;
+  int pageSizeBytes = 10;
+  int pageMaxCacheSize = 7;
+  long redeliveryDelay = 4;
+  double redeliveryMultiplier = 1;
+  long maxRedeliveryDelay = 1000;
+  long redistributionDelay = 5;
+  boolean sendToDLAOnNoRoute = true;
+  String addressFullMessagePolicy = "PAGE";
+  long slowConsumerThreshold = 5;
+  long slowConsumerCheckPeriod = 10;
+  String slowConsumerPolicy = 
SlowConsumerPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  boolean autoCreateJmsQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsQueues = RandomUtil.randomBoolean();
+  boolean autoCreateJmsTopics = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsTopics = RandomUtil.randomBoolean();
+  boolean autoCreateQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteQueues = RandomUtil.randomBoolean();
+  boolean autoCreateAddresses = RandomUtil.randomBoolean();
+  boolean autoDeleteAddresses = RandomUtil.randomBoolean();
+  String configDeleteQueues = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  String configDeleteAddresses = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  long maxSizeBytesRejectThreshold = RandomUtil.randomPositiveLong();
+  String defaultLastValueKey = RandomUtil.randomString();
+  boolean defaultNonDestructive = RandomUtil.randomBoolean();
+  boolean defaultExclusiveQueue = RandomUtil.randomBoolean();
+  boolean defaultGroupRebalance = RandomUtil.randomBoolean();
+  int defaultGroupBuckets = RandomUtil.randomPositiveInt();
+  String defaultGroupFirstKey = RandomUtil.randomString();
+  int defaultMaxConsumers = RandomUtil.randomPositiveInt();
+  boolean defaultPurgeOnNoConsumers = RandomUtil.randomBoolean();
+  int defaultConsumersBeforeDispatch = RandomUtil.randomPositiveInt();
+  long defaultDelayBeforeDispatch = RandomUtil.randomPositiveLong();
+  String defaultQueueRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  String defaultAddressRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  int defaultConsumerWindowSize = RandomUtil.randomPositiveInt();
+  long defaultRingSize = RandomUtil.randomPositiveLong();
+  boolean autoDeleteCreatedQueues = RandomUtil.randomBoolean();
+  long autoDeleteQueuesDelay = RandomUtil.randomPositiveLong();
+  long autoDeleteQueuesMessageCount = RandomUtil.randomPositiveLong();
+  long autoDeleteAddressesDelay = RandomUtil.randomPositiveLong();
+  double redeliveryCollisionAvoidanceFactor = RandomUtil.randomDouble();
+  long retroactiveMessageCount = RandomUtil.randomPositiveLong();
+  boolean autoCreateDeadLetterResources = RandomUtil.randomBoolean();
+  String deadLetterQueuePrefix = RandomUtil.randomString();
+  String deadLetterQueueSuffix = RandomUtil.randomString();
+  boolean autoCreateExpiryResources = RandomUtil.randomBoolean();
+  String expiryQueuePrefix = RandomUtil.randomString();
+  String expiryQueueSuffix = RandomUtil.randomString();
+  boolean enableMetrics = RandomUtil.randomBoolean();
+
+  serverControl.addAddressSettings(root,
+  DLA,
+  expiryAddress,
+  expiryDelay,
+  lastValueQueue,
+  deliveryAttempts,
+  maxSizeBytes,
+  pageSizeBytes,
+  pageMaxCacheSize,
+  redeliveryDelay,
+  redeliveryMultiplier,
+  maxRedeliveryDelay,
+  

[jira] [Work logged] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?focusedWorklogId=449948=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449948
 ]

ASF GitHub Bot logged work on ARTEMIS-2819:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 18:09
Start Date: 23/Jun/20 18:09
Worklog Time Spent: 10m 
  Work Description: k-wall commented on a change in pull request #3199:
URL: https://github.com/apache/activemq-artemis/pull/3199#discussion_r13620



##
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
##
@@ -1309,6 +1309,265 @@ public void testAddressSettings() throws Exception {
 
}
 
+   @Test
+   public void testRemoveAddressSettingsEffective() throws Exception {
+  ActiveMQServerControl serverControl = createManagementControl();
+  String addr = "test";
+  String root = "#";
+
+  String DLA = "someDLA";
+  String expiryAddress = "someExpiry";
+  long expiryDelay = RandomUtil.randomPositiveLong();
+  long minExpiryDelay = 1;
+  long maxExpiryDelay = 2;
+  boolean lastValueQueue = true;
+  int deliveryAttempts = 1;
+  long maxSizeBytes = 20;
+  int pageSizeBytes = 10;
+  int pageMaxCacheSize = 7;
+  long redeliveryDelay = 4;
+  double redeliveryMultiplier = 1;
+  long maxRedeliveryDelay = 1000;
+  long redistributionDelay = 5;
+  boolean sendToDLAOnNoRoute = true;
+  String addressFullMessagePolicy = "PAGE";
+  long slowConsumerThreshold = 5;
+  long slowConsumerCheckPeriod = 10;
+  String slowConsumerPolicy = 
SlowConsumerPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  boolean autoCreateJmsQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsQueues = RandomUtil.randomBoolean();
+  boolean autoCreateJmsTopics = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsTopics = RandomUtil.randomBoolean();
+  boolean autoCreateQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteQueues = RandomUtil.randomBoolean();
+  boolean autoCreateAddresses = RandomUtil.randomBoolean();
+  boolean autoDeleteAddresses = RandomUtil.randomBoolean();
+  String configDeleteQueues = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  String configDeleteAddresses = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  long maxSizeBytesRejectThreshold = RandomUtil.randomPositiveLong();
+  String defaultLastValueKey = RandomUtil.randomString();
+  boolean defaultNonDestructive = RandomUtil.randomBoolean();
+  boolean defaultExclusiveQueue = RandomUtil.randomBoolean();
+  boolean defaultGroupRebalance = RandomUtil.randomBoolean();
+  int defaultGroupBuckets = RandomUtil.randomPositiveInt();
+  String defaultGroupFirstKey = RandomUtil.randomString();
+  int defaultMaxConsumers = RandomUtil.randomPositiveInt();
+  boolean defaultPurgeOnNoConsumers = RandomUtil.randomBoolean();
+  int defaultConsumersBeforeDispatch = RandomUtil.randomPositiveInt();
+  long defaultDelayBeforeDispatch = RandomUtil.randomPositiveLong();
+  String defaultQueueRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  String defaultAddressRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  int defaultConsumerWindowSize = RandomUtil.randomPositiveInt();
+  long defaultRingSize = RandomUtil.randomPositiveLong();
+  boolean autoDeleteCreatedQueues = RandomUtil.randomBoolean();
+  long autoDeleteQueuesDelay = RandomUtil.randomPositiveLong();
+  long autoDeleteQueuesMessageCount = RandomUtil.randomPositiveLong();
+  long autoDeleteAddressesDelay = RandomUtil.randomPositiveLong();
+  double redeliveryCollisionAvoidanceFactor = RandomUtil.randomDouble();
+  long retroactiveMessageCount = RandomUtil.randomPositiveLong();
+  boolean autoCreateDeadLetterResources = RandomUtil.randomBoolean();
+  String deadLetterQueuePrefix = RandomUtil.randomString();
+  String deadLetterQueueSuffix = RandomUtil.randomString();
+  boolean autoCreateExpiryResources = RandomUtil.randomBoolean();
+  String expiryQueuePrefix = RandomUtil.randomString();
+  String expiryQueueSuffix = RandomUtil.randomString();
+  boolean enableMetrics = RandomUtil.randomBoolean();
+
+  serverControl.addAddressSettings(root,
+  DLA,
+  expiryAddress,
+  expiryDelay,
+  lastValueQueue,
+  deliveryAttempts,
+  maxSizeBytes,
+  pageSizeBytes,
+  pageMaxCacheSize,
+  redeliveryDelay,
+  redeliveryMultiplier,
+  maxRedeliveryDelay,
+  redistributionDelay,

[jira] [Work logged] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?focusedWorklogId=449949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449949
 ]

ASF GitHub Bot logged work on ARTEMIS-2819:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 18:09
Start Date: 23/Jun/20 18:09
Worklog Time Spent: 10m 
  Work Description: k-wall commented on a change in pull request #3199:
URL: https://github.com/apache/activemq-artemis/pull/3199#discussion_r13620



##
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
##
@@ -1309,6 +1309,265 @@ public void testAddressSettings() throws Exception {
 
}
 
+   @Test
+   public void testRemoveAddressSettingsEffective() throws Exception {
+  ActiveMQServerControl serverControl = createManagementControl();
+  String addr = "test";
+  String root = "#";
+
+  String DLA = "someDLA";
+  String expiryAddress = "someExpiry";
+  long expiryDelay = RandomUtil.randomPositiveLong();
+  long minExpiryDelay = 1;
+  long maxExpiryDelay = 2;
+  boolean lastValueQueue = true;
+  int deliveryAttempts = 1;
+  long maxSizeBytes = 20;
+  int pageSizeBytes = 10;
+  int pageMaxCacheSize = 7;
+  long redeliveryDelay = 4;
+  double redeliveryMultiplier = 1;
+  long maxRedeliveryDelay = 1000;
+  long redistributionDelay = 5;
+  boolean sendToDLAOnNoRoute = true;
+  String addressFullMessagePolicy = "PAGE";
+  long slowConsumerThreshold = 5;
+  long slowConsumerCheckPeriod = 10;
+  String slowConsumerPolicy = 
SlowConsumerPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  boolean autoCreateJmsQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsQueues = RandomUtil.randomBoolean();
+  boolean autoCreateJmsTopics = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsTopics = RandomUtil.randomBoolean();
+  boolean autoCreateQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteQueues = RandomUtil.randomBoolean();
+  boolean autoCreateAddresses = RandomUtil.randomBoolean();
+  boolean autoDeleteAddresses = RandomUtil.randomBoolean();
+  String configDeleteQueues = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  String configDeleteAddresses = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  long maxSizeBytesRejectThreshold = RandomUtil.randomPositiveLong();
+  String defaultLastValueKey = RandomUtil.randomString();
+  boolean defaultNonDestructive = RandomUtil.randomBoolean();
+  boolean defaultExclusiveQueue = RandomUtil.randomBoolean();
+  boolean defaultGroupRebalance = RandomUtil.randomBoolean();
+  int defaultGroupBuckets = RandomUtil.randomPositiveInt();
+  String defaultGroupFirstKey = RandomUtil.randomString();
+  int defaultMaxConsumers = RandomUtil.randomPositiveInt();
+  boolean defaultPurgeOnNoConsumers = RandomUtil.randomBoolean();
+  int defaultConsumersBeforeDispatch = RandomUtil.randomPositiveInt();
+  long defaultDelayBeforeDispatch = RandomUtil.randomPositiveLong();
+  String defaultQueueRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  String defaultAddressRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  int defaultConsumerWindowSize = RandomUtil.randomPositiveInt();
+  long defaultRingSize = RandomUtil.randomPositiveLong();
+  boolean autoDeleteCreatedQueues = RandomUtil.randomBoolean();
+  long autoDeleteQueuesDelay = RandomUtil.randomPositiveLong();
+  long autoDeleteQueuesMessageCount = RandomUtil.randomPositiveLong();
+  long autoDeleteAddressesDelay = RandomUtil.randomPositiveLong();
+  double redeliveryCollisionAvoidanceFactor = RandomUtil.randomDouble();
+  long retroactiveMessageCount = RandomUtil.randomPositiveLong();
+  boolean autoCreateDeadLetterResources = RandomUtil.randomBoolean();
+  String deadLetterQueuePrefix = RandomUtil.randomString();
+  String deadLetterQueueSuffix = RandomUtil.randomString();
+  boolean autoCreateExpiryResources = RandomUtil.randomBoolean();
+  String expiryQueuePrefix = RandomUtil.randomString();
+  String expiryQueueSuffix = RandomUtil.randomString();
+  boolean enableMetrics = RandomUtil.randomBoolean();
+
+  serverControl.addAddressSettings(root,
+  DLA,
+  expiryAddress,
+  expiryDelay,
+  lastValueQueue,
+  deliveryAttempts,
+  maxSizeBytes,
+  pageSizeBytes,
+  pageMaxCacheSize,
+  redeliveryDelay,
+  redeliveryMultiplier,
+  maxRedeliveryDelay,
+  redistributionDelay,

[jira] [Work logged] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?focusedWorklogId=449942=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449942
 ]

ASF GitHub Bot logged work on ARTEMIS-2819:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 17:53
Start Date: 23/Jun/20 17:53
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on a change in pull request 
#3199:
URL: https://github.com/apache/activemq-artemis/pull/3199#discussion_r04630



##
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java
##
@@ -1309,6 +1309,265 @@ public void testAddressSettings() throws Exception {
 
}
 
+   @Test
+   public void testRemoveAddressSettingsEffective() throws Exception {
+  ActiveMQServerControl serverControl = createManagementControl();
+  String addr = "test";
+  String root = "#";
+
+  String DLA = "someDLA";
+  String expiryAddress = "someExpiry";
+  long expiryDelay = RandomUtil.randomPositiveLong();
+  long minExpiryDelay = 1;
+  long maxExpiryDelay = 2;
+  boolean lastValueQueue = true;
+  int deliveryAttempts = 1;
+  long maxSizeBytes = 20;
+  int pageSizeBytes = 10;
+  int pageMaxCacheSize = 7;
+  long redeliveryDelay = 4;
+  double redeliveryMultiplier = 1;
+  long maxRedeliveryDelay = 1000;
+  long redistributionDelay = 5;
+  boolean sendToDLAOnNoRoute = true;
+  String addressFullMessagePolicy = "PAGE";
+  long slowConsumerThreshold = 5;
+  long slowConsumerCheckPeriod = 10;
+  String slowConsumerPolicy = 
SlowConsumerPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  boolean autoCreateJmsQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsQueues = RandomUtil.randomBoolean();
+  boolean autoCreateJmsTopics = RandomUtil.randomBoolean();
+  boolean autoDeleteJmsTopics = RandomUtil.randomBoolean();
+  boolean autoCreateQueues = RandomUtil.randomBoolean();
+  boolean autoDeleteQueues = RandomUtil.randomBoolean();
+  boolean autoCreateAddresses = RandomUtil.randomBoolean();
+  boolean autoDeleteAddresses = RandomUtil.randomBoolean();
+  String configDeleteQueues = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  String configDeleteAddresses = 
DeletionPolicy.getType(RandomUtil.randomPositiveInt() % 2).toString();
+  long maxSizeBytesRejectThreshold = RandomUtil.randomPositiveLong();
+  String defaultLastValueKey = RandomUtil.randomString();
+  boolean defaultNonDestructive = RandomUtil.randomBoolean();
+  boolean defaultExclusiveQueue = RandomUtil.randomBoolean();
+  boolean defaultGroupRebalance = RandomUtil.randomBoolean();
+  int defaultGroupBuckets = RandomUtil.randomPositiveInt();
+  String defaultGroupFirstKey = RandomUtil.randomString();
+  int defaultMaxConsumers = RandomUtil.randomPositiveInt();
+  boolean defaultPurgeOnNoConsumers = RandomUtil.randomBoolean();
+  int defaultConsumersBeforeDispatch = RandomUtil.randomPositiveInt();
+  long defaultDelayBeforeDispatch = RandomUtil.randomPositiveLong();
+  String defaultQueueRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  String defaultAddressRoutingType = RoutingType.getType((byte) 
(RandomUtil.randomPositiveInt() % 2)).toString();
+  int defaultConsumerWindowSize = RandomUtil.randomPositiveInt();
+  long defaultRingSize = RandomUtil.randomPositiveLong();
+  boolean autoDeleteCreatedQueues = RandomUtil.randomBoolean();
+  long autoDeleteQueuesDelay = RandomUtil.randomPositiveLong();
+  long autoDeleteQueuesMessageCount = RandomUtil.randomPositiveLong();
+  long autoDeleteAddressesDelay = RandomUtil.randomPositiveLong();
+  double redeliveryCollisionAvoidanceFactor = RandomUtil.randomDouble();
+  long retroactiveMessageCount = RandomUtil.randomPositiveLong();
+  boolean autoCreateDeadLetterResources = RandomUtil.randomBoolean();
+  String deadLetterQueuePrefix = RandomUtil.randomString();
+  String deadLetterQueueSuffix = RandomUtil.randomString();
+  boolean autoCreateExpiryResources = RandomUtil.randomBoolean();
+  String expiryQueuePrefix = RandomUtil.randomString();
+  String expiryQueueSuffix = RandomUtil.randomString();
+  boolean enableMetrics = RandomUtil.randomBoolean();
+
+  serverControl.addAddressSettings(root,
+  DLA,
+  expiryAddress,
+  expiryDelay,
+  lastValueQueue,
+  deliveryAttempts,
+  maxSizeBytes,
+  pageSizeBytes,
+  pageMaxCacheSize,
+  redeliveryDelay,
+  redeliveryMultiplier,
+  maxRedeliveryDelay,
+  

[jira] [Work logged] (ARTEMIS-2810) Support all address-settings via management

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2810?focusedWorklogId=449935=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449935
 ]

ASF GitHub Bot logged work on ARTEMIS-2810:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 17:41
Start Date: 23/Jun/20 17:41
Worklog Time Spent: 10m 
  Work Description: k-wall opened a new pull request #3200:
URL: https://github.com/apache/activemq-artemis/pull/3200


   
   (These names don't follow the key names used in getAddressSettingsAsJSON).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449935)
Time Spent: 0.5h  (was: 20m)

> Support all address-settings via management
> ---
>
> Key: ARTEMIS-2810
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2810
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently not all address-settings (e.g. {{min-expiry-delay}}, 
> {{max-expiry-delay}}, {{enable-metrics}}) can be set and/or retrieved via 
> management.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread Keith Wall (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated ARTEMIS-2819:

Affects Version/s: 2.13.0

> Removal of address setting (exact match) ineffective
> 
>
> Key: ARTEMIS-2819
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2819
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.13.0
>Reporter: Keith Wall
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If, dynamically through management, I add a settings for an address (exact 
> match) then later remove those settings, on re-reading the settings record 
> for the same address, I expect to see the settings from higher in the 
> hierarchy (or the root).  This does not occur.  It behaves as if the removal 
> did not take case.
> I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
> the code, it appears the HierarchicalObjectRepository does not remove its 
> copy from the cache in the exact match case.  Candidate PR raised.
> [https://github.com/apache/activemq-artemis/pull/3199]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread Keith Wall (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated ARTEMIS-2819:

Description: 
If, dynamically through management, I add a settings for an address (exact 
match) then later remove those settings, on re-reading the settings record for 
the same address, I expect to see the settings from higher in the hierarchy (or 
the root).  This does not occur.  It behaves as if the removal did not take 
case.

I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
the code, it appears the HierarchicalObjectRepository does not remove its copy 
from the cache in the exact match case.  Candidate PR raised.

https://github.com/apache/activemq-artemis/pull/3199

 

  was:
If, dynamically through management, I add a settings for an address (exact 
match) then later remove those settings, on re-reading the settings record for 
the address, I expect to see the settings from higher in the hierarchy (or the 
root).  This does not occur.  It behaves as if the removal did not take case.

I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
the code, it appears the HierarchicalObjectRepository does not remove its copy 
from the cache.  Candidate PR raised.

 


> Removal of address setting (exact match) ineffective
> 
>
> Key: ARTEMIS-2819
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2819
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Keith Wall
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If, dynamically through management, I add a settings for an address (exact 
> match) then later remove those settings, on re-reading the settings record 
> for the same address, I expect to see the settings from higher in the 
> hierarchy (or the root).  This does not occur.  It behaves as if the removal 
> did not take case.
> I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
> the code, it appears the HierarchicalObjectRepository does not remove its 
> copy from the cache in the exact match case.  Candidate PR raised.
> https://github.com/apache/activemq-artemis/pull/3199
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?focusedWorklogId=449914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449914
 ]

ASF GitHub Bot logged work on ARTEMIS-2819:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 17:06
Start Date: 23/Jun/20 17:06
Worklog Time Spent: 10m 
  Work Description: k-wall opened a new pull request #3199:
URL: https://github.com/apache/activemq-artemis/pull/3199


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449914)
Remaining Estimate: 0h
Time Spent: 10m

> Removal of address setting (exact match) ineffective
> 
>
> Key: ARTEMIS-2819
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2819
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Keith Wall
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If, dynamically through management, I add a settings for an address (exact 
> match) then later remove those settings, on re-reading the settings record 
> for the address, I expect to see the settings from higher in the hierarchy 
> (or the root).  This does not occur.  It behaves as if the removal did not 
> take case.
> I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
> the code, it appears the HierarchicalObjectRepository does not remove its 
> copy from the cache.  Candidate PR raised.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARTEMIS-2819) Removal of address setting (exact match) ineffective

2020-06-23 Thread Keith Wall (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated ARTEMIS-2819:

Summary: Removal of address setting (exact match) ineffective  (was: 
Removal of ActiveMQServerControl#removeAddressSettings ineffective)

> Removal of address setting (exact match) ineffective
> 
>
> Key: ARTEMIS-2819
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2819
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Keith Wall
>Priority: Major
>
> If, dynamically through management, I add a settings for an address (exact 
> match) then later remove those settings, on re-reading the settings record 
> for the address, I expect to see the settings from higher in the hierarchy 
> (or the root).  This does not occur.  It behaves as if the removal did not 
> take case.
> I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
> the code, it appears the HierarchicalObjectRepository does not remove its 
> copy from the cache.  Candidate PR raised.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARTEMIS-2819) Removal of ActiveMQServerControl#removeAddressSettings ineffective

2020-06-23 Thread Keith Wall (Jira)
Keith Wall created ARTEMIS-2819:
---

 Summary: Removal of ActiveMQServerControl#removeAddressSettings 
ineffective
 Key: ARTEMIS-2819
 URL: https://issues.apache.org/jira/browse/ARTEMIS-2819
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Keith Wall


If, dynamically through management, I add a settings for an address (exact 
match) then later remove those settings, on re-reading the settings record for 
the address, I expect to see the settings from higher in the hierarchy (or the 
root).  This does not occur.  It behaves as if the removal did not take case.

I wrote a ActiveMQServerControlTest that demonstrates the problem. Looking at 
the code, it appears the HierarchicalObjectRepository does not remove its copy 
from the cache.  Candidate PR raised.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AMQ-7351) Update to Apache pom parent 21

2020-06-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143005#comment-17143005
 ] 

ASF subversion and git services commented on AMQ-7351:
--

Commit 23f285a627d32be3dca92bfa34b3ab95deacd250 in activemq's branch 
refs/heads/master from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=23f285a ]

[AMQ-7351] Downgrade to Apache POM 18 to avoid javadoc generation issue during 
release


> Update to Apache pom parent 21
> --
>
> Key: AMQ-7351
> URL: https://issues.apache.org/jira/browse/AMQ-7351
> Project: ActiveMQ
>  Issue Type: Task
>Reporter: Francois Papon
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 5.16.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (AMQ-7351) Update to Apache pom parent 21

2020-06-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/AMQ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré updated AMQ-7351:
--
Fix Version/s: (was: 5.16.0)
   5.16.1

> Update to Apache pom parent 21
> --
>
> Key: AMQ-7351
> URL: https://issues.apache.org/jira/browse/AMQ-7351
> Project: ActiveMQ
>  Issue Type: Task
>Reporter: Francois Papon
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 5.16.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AMQ-7351) Update to Apache pom parent 21

2020-06-23 Thread Jira


[ 
https://issues.apache.org/jira/browse/AMQ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143002#comment-17143002
 ] 

Jean-Baptiste Onofré commented on AMQ-7351:
---

This change breaks the javadoc generation at release. I will fix that for 
5.16.1.

> Update to Apache pom parent 21
> --
>
> Key: AMQ-7351
> URL: https://issues.apache.org/jira/browse/AMQ-7351
> Project: ActiveMQ
>  Issue Type: Task
>Reporter: Francois Papon
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 5.16.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (AMQ-7351) Update to Apache pom parent 21

2020-06-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/AMQ-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré reopened AMQ-7351:
---

> Update to Apache pom parent 21
> --
>
> Key: AMQ-7351
> URL: https://issues.apache.org/jira/browse/AMQ-7351
> Project: ActiveMQ
>  Issue Type: Task
>Reporter: Francois Papon
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 5.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARTEMIS-2261) Management response messages are lost when Broker exceeds global-max-size limit and dynamic response queues are in use

2020-06-23 Thread Keith Wall (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142946#comment-17142946
 ] 

Keith Wall commented on ARTEMIS-2261:
-

I verified that issue still exists on master today (I've rebased the test I 
added to [https://github.com/k-wall/activemq-artemis/tree/ARTEMIS-2261)] 

> Management response messages are lost when Broker exceeds global-max-size 
> limit and dynamic response queues are in use
> --
>
> Key: ARTEMIS-2261
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2261
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.6.4
>Reporter: Keith Wall
>Priority: Major
>
> Use case: {{global-max-size}} is set to some limit to prevent the broker from 
> falling over. The broker is configured with N queues which are all blocked by 
> this limit.
>  If this limit is reached and you attempt to control the Broker with 
> Management (over AMQP), whilst the management requests now processed by the 
> Broker (owing to the work of ARTEMIS-1710), the management responses are lost 
> if the response queue was created as a [dynamic 
> node|http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#type-source].
>   This is because the dynamically created node's name means that the 
> management response is not special cased and is stored (which fails).
> One can workaround the problem by establishing (non temporary) response 
> queues that have a name prefixed with {{activemq.management}} e.g. 
> {{activemq.management.reply.<>}} but this gives the application more 
> work to do to ensure the response queues are lifecycle properly.
> 2019-02-19T20:38:43.356Z WARN [ProtonServerReceiverContext] AMQ229102: 
> Address "54111434-5686-4dbb-8a94-dd0182dbe7eb" is full.: 
> ActiveMQAddressFullException[errorType=ADDRESS_FULL message=AMQ229102: 
> Address "54111434-5686-4dbb-8a94-dd0182dbe7eb" is full.]
>  at 
> org.apache.activemq.artemis.core.paging.impl.PagingStoreImpl.page(PagingStoreImpl.java:780)
>  at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.addToPage(AbstractJournalStorageManager.java:2019)
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.processRoute(PostOfficeImpl.java:1203)
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.route(PostOfficeImpl.java:904)
>  at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.route(PostOfficeImpl.java:799)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.doSend(ServerSessionImpl.java:1801)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.handleManagementMessage(ServerSessionImpl.java:1698)
>  at 
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1458)
>  at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPSessionCallback.serverSend(AMQPSessionCallback.java:550)
>  at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPSessionCallback.serverSend(AMQPSessionCallback.java:509)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.ProtonServerReceiverContext.onMessage(ProtonServerReceiverContext.java:284)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.AMQPConnectionContext.onDelivery(AMQPConnectionContext.java:519)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.handler.Events.dispatch(Events.java:92)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.handler.ProtonHandler.dispatch(ProtonHandler.java:479)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.handler.ProtonHandler.flush(ProtonHandler.java:292)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.handler.ProtonHandler.inputBuffer(ProtonHandler.java:257)
>  at 
> org.apache.activemq.artemis.protocol.amqp.proton.AMQPConnectionContext.inputBuffer(AMQPConnectionContext.java:158)
>  at 
> org.apache.activemq.artemis.protocol.amqp.broker.ActiveMQProtonRemotingConnection.bufferReceived(ActiveMQProtonRemotingConnection.java:148)
>  at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl$DelegatingBufferHandler.bufferReceived(RemotingServiceImpl.java:643)
>  at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:73)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>  at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>  at io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1407)
>  at 

[jira] [Commented] (ARTEMIS-2811) Component org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0

2020-06-23 Thread daves (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142854#comment-17142854
 ] 

daves commented on ARTEMIS-2811:


[~jbertram] Thanks for your comment. I will look at the documentation.

 I think the problem with the windows service is that the service is not 
running the java process directly but uses a service wrapper called 
"artemis-service.exe".  I've used such wrappers before. My favorite is nssm 
[https://nssm.cc/] which as far as is know detects if the "hosted" process 
existed an is able to signal this exit to the service manager.

Sadly the broker is hosted in an environment not controlled by us. I don't have 
any option to change the monitoring or check if everything is ok with the 
filestystem… I know you can't do anything neither but maybe it would be an 
option to take a look at "artemis-service.exe" and check if there is an option 
to detect a stopped java process?

 

> Component org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired 
> on path 0
> -
>
> Key: ARTEMIS-2811
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2811
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
> Environment: * Windows Server 2016
>  * Artemis running as Windows Service
>Reporter: daves
>Assignee: Justin Bertram
>Priority: Major
> Attachments: broker.xml
>
>
> We run Artemis 2.11.0 on Windows Server 2016 as Windows Service. Suddenly 
> Artemis stopped working. The Artemis process stopped but the Windows 
> Service/Service wrapper was still running. We monitor all Services if they 
> are running, but since the Artemis-Service was still running our monitoring 
> did not detect that Artemis was not running anymore.
>  
>  # Is it possible to kill the Windows-Service together with the Artemis 
> process? (would be very nice for monitoring etc.)
>  # Is there a fix for this issue maybe in a newer version?
> Please see below stacktrace for more details. Please let me know if you need 
> any additional information.
>   
> {code:java}
> 2020-06-18 11:06:20,865 WARN  
> [org.apache.activemq.artemis.utils.critical.CriticalMeasure] Component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0
> 2020-06-18 11:06:20,865 WARN  
> [org.apache.activemq.artemis.utils.critical.CriticalMeasure] Component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0
> 2020-06-18 11:06:20,865 ERROR [org.apache.activemq.artemis.core.server] 
> AMQ224079: The process for the virtual machine will be killed, as component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer@37d4349f is not 
> responsive
> 2020-06-18 11:06:21,146 WARN  [org.apache.activemq.artemis.core.server] 
> AMQ222199: Thread dump: 
> ***Complete
>  Thread dump "qtp140224-69441" Id=69441 TIMED_WAITING on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@5b811449
>  at sun.misc.Unsafe.park(Native Method) -  waiting on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@5b811449
>  at java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source) at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown
>  Source) at 
> org.eclipse.jetty.util.BlockingArrayQueue.poll(BlockingArrayQueue.java:392) 
> at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.idleJobPoll(QueuedThreadPool.java:564)
>  at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.access$800(QueuedThreadPool.java:49)
>  at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:627)
>  at java.lang.Thread.run(Unknown Source)"Thread-11562 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@3cc1435c)"
>  Id=69440 TIMED_WAITING on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1e83815d
>  at sun.misc.Unsafe.park(Native Method) -  waiting on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1e83815d
>  at java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source) at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown
>  Source) at java.util.concurrent.LinkedBlockingQueue.poll(Unknown Source) at 
> org.apache.activemq.artemis.utils.ActiveMQThreadPoolExecutor$ThreadPoolQueue.poll(ActiveMQThreadPoolExecutor.java:112)
>  at 
> org.apache.activemq.artemis.utils.ActiveMQThreadPoolExecutor$ThreadPoolQueue.poll(ActiveMQThreadPoolExecutor.java:45)
>  at java.util.concurrent.ThreadPoolExecutor.getTask(Unknown Source) at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at 
> 

[jira] [Comment Edited] (ARTEMIS-2811) Component org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0

2020-06-23 Thread daves (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142854#comment-17142854
 ] 

daves edited comment on ARTEMIS-2811 at 6/23/20, 11:32 AM:
---

[~jbertram] Thanks for your comment. I will look at the documentation.

 I think the problem with the windows service is that the service is not 
running the java process directly but uses a service wrapper called 
"artemis-service.exe".  I've used such wrappers before. My favorite is nssm 
[https://nssm.cc/] which as far as is know detects if the "hosted" process 
existed an is able to signal this exit to the service manager.

Sadly the broker is hosted in an environment not controlled by us. I don't have 
any option to change the monitoring or check if everything is ok with the 
filestystem… I know you can't do anything neither but maybe it would be an 
option to take a look at "artemis-service.exe" and check if there is an option 
to detect a stopped java process?

 

I’ve also attached our broker.xml file (if you want to take a look at the 
content…)


was (Author: daves):
[~jbertram] Thanks for your comment. I will look at the documentation.

 I think the problem with the windows service is that the service is not 
running the java process directly but uses a service wrapper called 
"artemis-service.exe".  I've used such wrappers before. My favorite is nssm 
[https://nssm.cc/] which as far as is know detects if the "hosted" process 
existed an is able to signal this exit to the service manager.

Sadly the broker is hosted in an environment not controlled by us. I don't have 
any option to change the monitoring or check if everything is ok with the 
filestystem… I know you can't do anything neither but maybe it would be an 
option to take a look at "artemis-service.exe" and check if there is an option 
to detect a stopped java process?

 

> Component org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired 
> on path 0
> -
>
> Key: ARTEMIS-2811
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2811
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
> Environment: * Windows Server 2016
>  * Artemis running as Windows Service
>Reporter: daves
>Assignee: Justin Bertram
>Priority: Major
> Attachments: broker.xml
>
>
> We run Artemis 2.11.0 on Windows Server 2016 as Windows Service. Suddenly 
> Artemis stopped working. The Artemis process stopped but the Windows 
> Service/Service wrapper was still running. We monitor all Services if they 
> are running, but since the Artemis-Service was still running our monitoring 
> did not detect that Artemis was not running anymore.
>  
>  # Is it possible to kill the Windows-Service together with the Artemis 
> process? (would be very nice for monitoring etc.)
>  # Is there a fix for this issue maybe in a newer version?
> Please see below stacktrace for more details. Please let me know if you need 
> any additional information.
>   
> {code:java}
> 2020-06-18 11:06:20,865 WARN  
> [org.apache.activemq.artemis.utils.critical.CriticalMeasure] Component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0
> 2020-06-18 11:06:20,865 WARN  
> [org.apache.activemq.artemis.utils.critical.CriticalMeasure] Component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0
> 2020-06-18 11:06:20,865 ERROR [org.apache.activemq.artemis.core.server] 
> AMQ224079: The process for the virtual machine will be killed, as component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer@37d4349f is not 
> responsive
> 2020-06-18 11:06:21,146 WARN  [org.apache.activemq.artemis.core.server] 
> AMQ222199: Thread dump: 
> ***Complete
>  Thread dump "qtp140224-69441" Id=69441 TIMED_WAITING on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@5b811449
>  at sun.misc.Unsafe.park(Native Method) -  waiting on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@5b811449
>  at java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source) at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown
>  Source) at 
> org.eclipse.jetty.util.BlockingArrayQueue.poll(BlockingArrayQueue.java:392) 
> at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.idleJobPoll(QueuedThreadPool.java:564)
>  at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.access$800(QueuedThreadPool.java:49)
>  at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:627)
>  at java.lang.Thread.run(Unknown Source)"Thread-11562 
> 

[jira] [Updated] (ARTEMIS-2811) Component org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0

2020-06-23 Thread daves (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

daves updated ARTEMIS-2811:
---
Attachment: broker.xml

> Component org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired 
> on path 0
> -
>
> Key: ARTEMIS-2811
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2811
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
> Environment: * Windows Server 2016
>  * Artemis running as Windows Service
>Reporter: daves
>Assignee: Justin Bertram
>Priority: Major
> Attachments: broker.xml
>
>
> We run Artemis 2.11.0 on Windows Server 2016 as Windows Service. Suddenly 
> Artemis stopped working. The Artemis process stopped but the Windows 
> Service/Service wrapper was still running. We monitor all Services if they 
> are running, but since the Artemis-Service was still running our monitoring 
> did not detect that Artemis was not running anymore.
>  
>  # Is it possible to kill the Windows-Service together with the Artemis 
> process? (would be very nice for monitoring etc.)
>  # Is there a fix for this issue maybe in a newer version?
> Please see below stacktrace for more details. Please let me know if you need 
> any additional information.
>   
> {code:java}
> 2020-06-18 11:06:20,865 WARN  
> [org.apache.activemq.artemis.utils.critical.CriticalMeasure] Component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0
> 2020-06-18 11:06:20,865 WARN  
> [org.apache.activemq.artemis.utils.critical.CriticalMeasure] Component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer is expired on path 0
> 2020-06-18 11:06:20,865 ERROR [org.apache.activemq.artemis.core.server] 
> AMQ224079: The process for the virtual machine will be killed, as component 
> org.apache.activemq.artemis.core.io.buffer.TimedBuffer@37d4349f is not 
> responsive
> 2020-06-18 11:06:21,146 WARN  [org.apache.activemq.artemis.core.server] 
> AMQ222199: Thread dump: 
> ***Complete
>  Thread dump "qtp140224-69441" Id=69441 TIMED_WAITING on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@5b811449
>  at sun.misc.Unsafe.park(Native Method) -  waiting on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@5b811449
>  at java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source) at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown
>  Source) at 
> org.eclipse.jetty.util.BlockingArrayQueue.poll(BlockingArrayQueue.java:392) 
> at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.idleJobPoll(QueuedThreadPool.java:564)
>  at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.access$800(QueuedThreadPool.java:49)
>  at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:627)
>  at java.lang.Thread.run(Unknown Source)"Thread-11562 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@3cc1435c)"
>  Id=69440 TIMED_WAITING on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1e83815d
>  at sun.misc.Unsafe.park(Native Method) -  waiting on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1e83815d
>  at java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source) at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown
>  Source) at java.util.concurrent.LinkedBlockingQueue.poll(Unknown Source) at 
> org.apache.activemq.artemis.utils.ActiveMQThreadPoolExecutor$ThreadPoolQueue.poll(ActiveMQThreadPoolExecutor.java:112)
>  at 
> org.apache.activemq.artemis.utils.ActiveMQThreadPoolExecutor$ThreadPoolQueue.poll(ActiveMQThreadPoolExecutor.java:45)
>  at java.util.concurrent.ThreadPoolExecutor.getTask(Unknown Source) at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at 
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)"Thread-11561
>  
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@3cc1435c)"
>  Id=69439 TIMED_WAITING on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1e83815d
>  at sun.misc.Unsafe.park(Native Method) -  waiting on 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject@1e83815d
>  at java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source) at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown
>  Source) at java.util.concurrent.LinkedBlockingQueue.poll(Unknown Source) at 
> 

[jira] [Resolved] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread Michael Andre Pearce (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce resolved ARTEMIS-2797.
---
Resolution: Fixed

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARTEMIS-2815) Null pointer exception on queue update

2020-06-23 Thread Michael Andre Pearce (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce resolved ARTEMIS-2815.
---
Resolution: Fixed

> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: 2.14.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created 
> without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is 
> no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
>   .setAddress(address)
>   .setId(id)
>   .setRoutingType(routingType)
>   .setFilterString(filter.getFilterString())
>   .setDurable(isDurable())
>   .setUser(user)
>   .setMaxConsumers(maxConsumers)
>   .setExclusive(exclusive)
>   .setGroupRebalance(groupRebalance)
>   .setGroupBuckets(groupBuckets)
>   .setGroupFirstKey(groupFirstKey)
>   .setLastValue(false)
>   .setLastValue(null)
>   .setNonDestructive(nonDestructive)
>   .setPurgeOnNoConsumers(purgeOnNoConsumers)
>   .setConsumersBeforeDispatch(consumersBeforeDispatch)
>   .setDelayBeforeDispatch(delayBeforeDispatch)
>   .setAutoDelete(autoDelete)
>   .setAutoDeleteDelay(autoDeleteDelay)
>   .setAutoDeleteMessageCount(autoDeleteMessageCount)
>   .setRingSize(ringSize)
>   .setConfigurationManaged(configurationManaged)
>   .setTemporary(temporary)
>   .setInternal(internalQueue)
>   .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>   .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARTEMIS-2815) Null pointer exception on queue update

2020-06-23 Thread Michael Andre Pearce (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce updated ARTEMIS-2815:
--
Fix Version/s: 2.14.0

> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: 2.14.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created 
> without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is 
> no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
>   .setAddress(address)
>   .setId(id)
>   .setRoutingType(routingType)
>   .setFilterString(filter.getFilterString())
>   .setDurable(isDurable())
>   .setUser(user)
>   .setMaxConsumers(maxConsumers)
>   .setExclusive(exclusive)
>   .setGroupRebalance(groupRebalance)
>   .setGroupBuckets(groupBuckets)
>   .setGroupFirstKey(groupFirstKey)
>   .setLastValue(false)
>   .setLastValue(null)
>   .setNonDestructive(nonDestructive)
>   .setPurgeOnNoConsumers(purgeOnNoConsumers)
>   .setConsumersBeforeDispatch(consumersBeforeDispatch)
>   .setDelayBeforeDispatch(delayBeforeDispatch)
>   .setAutoDelete(autoDelete)
>   .setAutoDeleteDelay(autoDeleteDelay)
>   .setAutoDeleteMessageCount(autoDeleteMessageCount)
>   .setRingSize(ringSize)
>   .setConfigurationManaged(configurationManaged)
>   .setTemporary(temporary)
>   .setInternal(internalQueue)
>   .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>   .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARTEMIS-2337) federated queues not working correctly with wildcards or defaults

2020-06-23 Thread Michael Andre Pearce (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce updated ARTEMIS-2337:
--
Priority: Minor  (was: Critical)

> federated queues not working correctly with wildcards or defaults
> -
>
> Key: ARTEMIS-2337
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2337
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.8.0
> Environment: RHEL 
>Reporter: Thomas Wood
>Priority: Minor
>
> artemis1 upstream federated to artemis2.
> clients consume artemis2 messages from artemis1.
> client connects to artemis1 and messages are routed from artemis2 as 
> expected, but any new messages that land on artemis2 are not routed to 
> artemis1 until the client reconnects.
> It seems that the issue is related to wildcards:
>  include-federated="false">
>  
>  
> The following config works as expected with the client receiving message 
> prior to and during the life of client connection:
>  include-federated="false">
>  
>  
> also noticed that the following causes the issue too:
>  include-federated="false">
>  
>  
>  
> but this works:
>  include-federated="false">
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449722=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449722
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 10:20
Start Date: 23/Jun/20 10:20
Worklog Time Spent: 10m 
  Work Description: asfgit closed pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449722)
Time Spent: 5h  (was: 4h 50m)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449723=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449723
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 10:20
Start Date: 23/Jun/20 10:20
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain commented on pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#issuecomment-648050524


   @jsmucr thanks for the contribution.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449723)
Time Spent: 5h 10m  (was: 5h)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142817#comment-17142817
 ] 

ASF subversion and git services commented on ARTEMIS-2797:
--

Commit 5070e7a72c84552c342d1f2da84c35650469e82f in activemq-artemis's branch 
refs/heads/master from Jan Šmucr
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=5070e7a ]

ARTEMIS-2797 - Reset queue properties by unsetting them in broker.xml

Now it is possible to reset queue parameters to their defaults by removing them
from broker.xml and redeploying the configuration.

Originally this PR covered the "filter" parameter only.


> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449691=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449691
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:47
Start Date: 23/Jun/20 08:47
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain commented on pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#issuecomment-648002327


   @jsmucr can you rebase and squash commits



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449691)
Time Spent: 4h 50m  (was: 4h 40m)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449690=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449690
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:46
Start Date: 23/Jun/20 08:46
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain commented on a change in pull 
request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r444062892



##
File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##
@@ -3954,7 +3954,7 @@ public QueueConfiguration getQueueConfiguration() {
  .setAddress(address)
  .setId(id)
  .setRoutingType(routingType)
- .setFilterString(filter.getFilterString())
+ .setFilterString(filter == null ? null : filter.getFilterString())

Review comment:
   can you rebase, this is already fixed in master





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449690)
Time Spent: 4h 40m  (was: 4.5h)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449687=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449687
 ]

ASF GitHub Bot logged work on ARTEMIS-2815:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:38
Start Date: 23/Jun/20 08:38
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647997888


   @Havret merged thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449687)
Time Spent: 2h 50m  (was: 2h 40m)

> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created 
> without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is 
> no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
>   .setAddress(address)
>   .setId(id)
>   .setRoutingType(routingType)
>   .setFilterString(filter.getFilterString())
>   .setDurable(isDurable())
>   .setUser(user)
>   .setMaxConsumers(maxConsumers)
>   .setExclusive(exclusive)
>   .setGroupRebalance(groupRebalance)
>   .setGroupBuckets(groupBuckets)
>   .setGroupFirstKey(groupFirstKey)
>   .setLastValue(false)
>   .setLastValue(null)
>   .setNonDestructive(nonDestructive)
>   .setPurgeOnNoConsumers(purgeOnNoConsumers)
>   .setConsumersBeforeDispatch(consumersBeforeDispatch)
>   .setDelayBeforeDispatch(delayBeforeDispatch)
>   .setAutoDelete(autoDelete)
>   .setAutoDeleteDelay(autoDeleteDelay)
>   .setAutoDeleteMessageCount(autoDeleteMessageCount)
>   .setRingSize(ringSize)
>   .setConfigurationManaged(configurationManaged)
>   .setTemporary(temporary)
>   .setInternal(internalQueue)
>   .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>   .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449686
 ]

ASF GitHub Bot logged work on ARTEMIS-2815:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:37
Start Date: 23/Jun/20 08:37
Worklog Time Spent: 10m 
  Work Description: asfgit closed pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449686)
Time Spent: 2h 40m  (was: 2.5h)

> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created 
> without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is 
> no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
>   .setAddress(address)
>   .setId(id)
>   .setRoutingType(routingType)
>   .setFilterString(filter.getFilterString())
>   .setDurable(isDurable())
>   .setUser(user)
>   .setMaxConsumers(maxConsumers)
>   .setExclusive(exclusive)
>   .setGroupRebalance(groupRebalance)
>   .setGroupBuckets(groupBuckets)
>   .setGroupFirstKey(groupFirstKey)
>   .setLastValue(false)
>   .setLastValue(null)
>   .setNonDestructive(nonDestructive)
>   .setPurgeOnNoConsumers(purgeOnNoConsumers)
>   .setConsumersBeforeDispatch(consumersBeforeDispatch)
>   .setDelayBeforeDispatch(delayBeforeDispatch)
>   .setAutoDelete(autoDelete)
>   .setAutoDeleteDelay(autoDeleteDelay)
>   .setAutoDeleteMessageCount(autoDeleteMessageCount)
>   .setRingSize(ringSize)
>   .setConfigurationManaged(configurationManaged)
>   .setTemporary(temporary)
>   .setInternal(internalQueue)
>   .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>   .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARTEMIS-2815) Null pointer exception on queue update

2020-06-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142737#comment-17142737
 ] 

ASF subversion and git services commented on ARTEMIS-2815:
--

Commit 3e394b45e92a012b2d060ffae37918a840ce0dd2 in activemq-artemis's branch 
refs/heads/master from Havret
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=3e394b4 ]

ARTEMIS-2815: Fix null pointer exception on attempt to update queue without 
filter


> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created 
> without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is 
> no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
>   .setAddress(address)
>   .setId(id)
>   .setRoutingType(routingType)
>   .setFilterString(filter.getFilterString())
>   .setDurable(isDurable())
>   .setUser(user)
>   .setMaxConsumers(maxConsumers)
>   .setExclusive(exclusive)
>   .setGroupRebalance(groupRebalance)
>   .setGroupBuckets(groupBuckets)
>   .setGroupFirstKey(groupFirstKey)
>   .setLastValue(false)
>   .setLastValue(null)
>   .setNonDestructive(nonDestructive)
>   .setPurgeOnNoConsumers(purgeOnNoConsumers)
>   .setConsumersBeforeDispatch(consumersBeforeDispatch)
>   .setDelayBeforeDispatch(delayBeforeDispatch)
>   .setAutoDelete(autoDelete)
>   .setAutoDeleteDelay(autoDeleteDelay)
>   .setAutoDeleteMessageCount(autoDeleteMessageCount)
>   .setRingSize(ringSize)
>   .setConfigurationManaged(configurationManaged)
>   .setTemporary(temporary)
>   .setInternal(internalQueue)
>   .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>   .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2770) Update diverts using the management API

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2770?focusedWorklogId=449682=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449682
 ]

ASF GitHub Bot logged work on ARTEMIS-2770:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:28
Start Date: 23/Jun/20 08:28
Worklog Time Spent: 10m 
  Work Description: jsmucr commented on pull request #3148:
URL: https://github.com/apache/activemq-artemis/pull/3148#issuecomment-647992605


   Thank you for the update. A documentation to this is missing though.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449682)
Time Spent: 0.5h  (was: 20m)

> Update diverts using the management API
> ---
>
> Key: ARTEMIS-2770
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2770
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Domenico Bruscino
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The diverts can already be created and destroyed using the management API but 
> there isn't a way to reconfigure a non-exclusive divert without duplicating 
> or losing messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449680=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449680
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:17
Start Date: 23/Jun/20 08:17
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain edited a comment on pull request 
#3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#issuecomment-647986368


   @jsmucr LGTM, if you get docs done, then we can merge i think. Not sure if 
you're following the mail thread but @clebertsuconic is aiming to cut a release 
today/tomorrow so if you get it done in time hopefully it can make it in for 
you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449680)
Time Spent: 4.5h  (was: 4h 20m)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449678
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:16
Start Date: 23/Jun/20 08:16
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain commented on pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#issuecomment-647986368


   @jsmucr LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449678)
Time Spent: 4h 10m  (was: 4h)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (ARTEMIS-2797) Reset queue properties by unsetting them in broker.xml

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=449679=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449679
 ]

ASF GitHub Bot logged work on ARTEMIS-2797:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 08:16
Start Date: 23/Jun/20 08:16
Worklog Time Spent: 10m 
  Work Description: michaelpearce-gain edited a comment on pull request 
#3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#issuecomment-647986368


   @jsmucr LGTM, if you get docs done, then we can merge i think.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449679)
Time Spent: 4h 20m  (was: 4h 10m)

> Reset queue properties by unsetting them in broker.xml
> --
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.13.0
>Reporter: Jan Šmucr
>Priority: Major
>  Labels: pull-request-available
> Fix For: 2.14.0
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Currently the queue properties cannot be removed because of property new 
> value null checks leading to quitting the PostOfficeImpl#updateQueue() 
> instead of resetting the properties to their default values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (AMQ-7087) Add Java 11 Support (runtime)

2020-06-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/AMQ-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Baptiste Onofré resolved AMQ-7087.
---
Resolution: Fixed

I added JVM args specifically for JDK 9+ (to avoid warnings at startup). I will 
work on JDK 11 full support at build for 5.17.0.

> Add Java 11 Support (runtime)
> -
>
> Key: AMQ-7087
> URL: https://issues.apache.org/jira/browse/AMQ-7087
> Project: ActiveMQ
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 5.15.6
> Environment: Windows 10 with the OpenJDK 11 "bin" directory on the 
> path.
>Reporter: Jeff Gullett
>Assignee: Jean-Baptiste Onofré
>Priority: Critical
> Fix For: 5.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Java 8 support is ending in January, 2019 (in 2 months).  Currently, the 
> ActiveMQ Broker only supports Java 8.  When I try to start the broker using 
> Java 11 (the latest long-term-support version), I get the following error:
> Unable to execute Java command.  The system cannot find the file specified. 
> (0x2)
> Critical error: wait for JVM process failed
> Since both Java 9 and Java 10 are already EOL, support for Java 11 needs to 
> be added by January 2019.  The issue to add Java 9 support (AMQ-6864) is OBE, 
> and should be replaced by this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AMQ-7087) Add Java 11 Support (runtime)

2020-06-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142667#comment-17142667
 ] 

ASF subversion and git services commented on AMQ-7087:
--

Commit 0f92f2cabb379559b504c034ab096a89c3b61b77 in activemq's branch 
refs/heads/master from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=0f92f2c ]

Merge pull request #546 from jbonofre/AMQ-7087

[AMQ-7087] Add JDK 9+ specific JVM args to avoid warnings

> Add Java 11 Support (runtime)
> -
>
> Key: AMQ-7087
> URL: https://issues.apache.org/jira/browse/AMQ-7087
> Project: ActiveMQ
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 5.15.6
> Environment: Windows 10 with the OpenJDK 11 "bin" directory on the 
> path.
>Reporter: Jeff Gullett
>Assignee: Jean-Baptiste Onofré
>Priority: Critical
> Fix For: 5.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Java 8 support is ending in January, 2019 (in 2 months).  Currently, the 
> ActiveMQ Broker only supports Java 8.  When I try to start the broker using 
> Java 11 (the latest long-term-support version), I get the following error:
> Unable to execute Java command.  The system cannot find the file specified. 
> (0x2)
> Critical error: wait for JVM process failed
> Since both Java 9 and Java 10 are already EOL, support for Java 11 needs to 
> be added by January 2019.  The issue to add Java 9 support (AMQ-6864) is OBE, 
> and should be replaced by this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AMQ-7087) Add Java 11 Support (runtime)

2020-06-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142665#comment-17142665
 ] 

ASF subversion and git services commented on AMQ-7087:
--

Commit 7db424758f9a3b04bde3dfe6319345049651e617 in activemq's branch 
refs/heads/master from jbonofre
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=7db4247 ]

[AMQ-7087] Add JDK 9+ specific JVM args to avoid warnings


> Add Java 11 Support (runtime)
> -
>
> Key: AMQ-7087
> URL: https://issues.apache.org/jira/browse/AMQ-7087
> Project: ActiveMQ
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 5.15.6
> Environment: Windows 10 with the OpenJDK 11 "bin" directory on the 
> path.
>Reporter: Jeff Gullett
>Assignee: Jean-Baptiste Onofré
>Priority: Critical
> Fix For: 5.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Java 8 support is ending in January, 2019 (in 2 months).  Currently, the 
> ActiveMQ Broker only supports Java 8.  When I try to start the broker using 
> Java 11 (the latest long-term-support version), I get the following error:
> Unable to execute Java command.  The system cannot find the file specified. 
> (0x2)
> Critical error: wait for JVM process failed
> Since both Java 9 and Java 10 are already EOL, support for Java 11 needs to 
> be added by January 2019.  The issue to add Java 9 support (AMQ-6864) is OBE, 
> and should be replaced by this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (AMQ-7087) Add Java 11 Support (runtime)

2020-06-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7087?focusedWorklogId=449662=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449662
 ]

ASF GitHub Bot logged work on AMQ-7087:
---

Author: ASF GitHub Bot
Created on: 23/Jun/20 06:52
Start Date: 23/Jun/20 06:52
Worklog Time Spent: 10m 
  Work Description: jbonofre merged pull request #546:
URL: https://github.com/apache/activemq/pull/546


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 449662)
Time Spent: 20m  (was: 10m)

> Add Java 11 Support (runtime)
> -
>
> Key: AMQ-7087
> URL: https://issues.apache.org/jira/browse/AMQ-7087
> Project: ActiveMQ
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 5.15.6
> Environment: Windows 10 with the OpenJDK 11 "bin" directory on the 
> path.
>Reporter: Jeff Gullett
>Assignee: Jean-Baptiste Onofré
>Priority: Critical
> Fix For: 5.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Java 8 support is ending in January, 2019 (in 2 months).  Currently, the 
> ActiveMQ Broker only supports Java 8.  When I try to start the broker using 
> Java 11 (the latest long-term-support version), I get the following error:
> Unable to execute Java command.  The system cannot find the file specified. 
> (0x2)
> Critical error: wait for JVM process failed
> Since both Java 9 and Java 10 are already EOL, support for Java 11 needs to 
> be added by January 2019.  The issue to add Java 9 support (AMQ-6864) is OBE, 
> and should be replaced by this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (AMQ-7087) Add Java 11 Support (runtime)

2020-06-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142666#comment-17142666
 ] 

ASF subversion and git services commented on AMQ-7087:
--

Commit 0f92f2cabb379559b504c034ab096a89c3b61b77 in activemq's branch 
refs/heads/master from Jean-Baptiste Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=0f92f2c ]

Merge pull request #546 from jbonofre/AMQ-7087

[AMQ-7087] Add JDK 9+ specific JVM args to avoid warnings

> Add Java 11 Support (runtime)
> -
>
> Key: AMQ-7087
> URL: https://issues.apache.org/jira/browse/AMQ-7087
> Project: ActiveMQ
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 5.15.6
> Environment: Windows 10 with the OpenJDK 11 "bin" directory on the 
> path.
>Reporter: Jeff Gullett
>Assignee: Jean-Baptiste Onofré
>Priority: Critical
> Fix For: 5.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Java 8 support is ending in January, 2019 (in 2 months).  Currently, the 
> ActiveMQ Broker only supports Java 8.  When I try to start the broker using 
> Java 11 (the latest long-term-support version), I get the following error:
> Unable to execute Java command.  The system cannot find the file specified. 
> (0x2)
> Critical error: wait for JVM process failed
> Since both Java 9 and Java 10 are already EOL, support for Java 11 needs to 
> be added by January 2019.  The issue to add Java 9 support (AMQ-6864) is OBE, 
> and should be replaced by this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)