[jira] [Assigned] (AMQ-9233) NPE in SubQueueSelectorCacheBroker.removeConsumer
[
https://issues.apache.org/jira/browse/AMQ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich reassigned AMQ-9233:
---
Assignee: Matt Pavlovich
> NPE in SubQueueSelectorCacheBroker.removeConsumer
> -
>
> Key: AMQ-9233
> URL: https://issues.apache.org/jira/browse/AMQ-9233
> Project: ActiveMQ
> Issue Type: Bug
>Affects Versions: 5.16.4
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Fix For: 5.19.0, 5.18.1
>
>
> This NPE occurs after a number of cascading errors. Probably, the
> _selectors.size()_ needs a null check.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
> at
> org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9233) NPE in SubQueueSelectorCacheBroker.removeConsumer
[
https://issues.apache.org/jira/browse/AMQ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich updated AMQ-9233:
Fix Version/s: 5.19.0
5.18.1
> NPE in SubQueueSelectorCacheBroker.removeConsumer
> -
>
> Key: AMQ-9233
> URL: https://issues.apache.org/jira/browse/AMQ-9233
> Project: ActiveMQ
> Issue Type: Bug
>Affects Versions: 5.16.4
>Reporter: Matt Pavlovich
>Priority: Major
> Fix For: 5.19.0, 5.18.1
>
>
> This NPE occurs after a number of cascading errors. Probably, the
> _selectors.size()_ needs a null check.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
> at
> org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9233) NPE in SubQueueSelectorCacheBroker.removeConsumer
[
https://issues.apache.org/jira/browse/AMQ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Pavlovich updated AMQ-9233:
Description:
This NPE occurs after a number of cascading errors. Probably, the
_selectors.size()_ needs a null check.
{noformat}
java.lang.NullPointerException
at
org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
at
org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
{noformat}
was:
{noformat}
java.lang.NullPointerException
at
org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
at
org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
{noformat}
> NPE in SubQueueSelectorCacheBroker.removeConsumer
> -
>
> Key: AMQ-9233
> URL: https://issues.apache.org/jira/browse/AMQ-9233
> Project: ActiveMQ
> Issue Type: Bug
>Affects Versions: 5.16.4
>Reporter: Matt Pavlovich
>Priority: Major
>
> This NPE occurs after a number of cascading errors. Probably, the
> _selectors.size()_ needs a null check.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
> at
> org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (AMQ-9233) NPE in SubQueueSelectorCacheBroker.removeConsumer
Matt Pavlovich created AMQ-9233:
---
Summary: NPE in SubQueueSelectorCacheBroker.removeConsumer
Key: AMQ-9233
URL: https://issues.apache.org/jira/browse/AMQ-9233
Project: ActiveMQ
Issue Type: Bug
Affects Versions: 5.16.4
Reporter: Matt Pavlovich
{noformat}
java.lang.NullPointerException
at
org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
at
org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4217) AMQ111005: Failed to convert message. Sending it to Dead Letter Address.
[
https://issues.apache.org/jira/browse/ARTEMIS-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704606#comment-17704606
]
daves commented on ARTEMIS-4217:
Thanks for the minLargeMessageSize idea. i will try this.
> AMQ111005: Failed to convert message. Sending it to Dead Letter Address.
>
>
> Key: ARTEMIS-4217
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4217
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.28.0
> Environment: Windows Server 2022 21H2
> openjdk 19.0.1 2022-10-18
> OpenJDK Runtime Environment (build 19.0.1+10-21)
> OpenJDK 64-Bit Server VM (build 19.0.1+10-21, mixed mode, sharing)
>Reporter: daves
>Priority: Major
> Attachments: artemis-service.wrapper.log, artemis.log,
> artemis.log.2023-03-23-1.log.gz, artemis.log.2023-03-23-10.log.gz,
> artemis.log.2023-03-23-100.log.gz, artemis.log.2023-03-23-11.log.gz,
> artemis.log.2023-03-23-12.log.gz, artemis.log.2023-03-23-13.log.gz,
> artemis.log.2023-03-23-14.log.gz, artemis.log.2023-03-23-15.log.gz,
> artemis.log.2023-03-23-16.log.gz, artemis.log.2023-03-23-17.log.gz,
> artemis.log.2023-03-23-18.log.gz, artemis.log.2023-03-23-19.log.gz,
> artemis.log.2023-03-23-2.log.gz, artemis.log.2023-03-23-20.log.gz,
> artemis.log.2023-03-23-21.log.gz, artemis.log.2023-03-23-22.log.gz,
> artemis.log.2023-03-23-23.log.gz, artemis.log.2023-03-23-24.log.gz,
> artemis.log.2023-03-23-25.log.gz, artemis.log.2023-03-23-26.log.gz,
> artemis.log.2023-03-23-27.log.gz, artemis.log.2023-03-23-28.log.gz,
> artemis.log.2023-03-23-29.log.gz, artemis.log.2023-03-23-3.log.gz,
> artemis.log.2023-03-23-30.log.gz, artemis.log.2023-03-23-31.log.gz,
> artemis.log.2023-03-23-32.log.gz, artemis.log.2023-03-23-33.log.gz,
> artemis.log.2023-03-23-34.log.gz, artemis.log.2023-03-23-35.log.gz,
> artemis.log.2023-03-23-36.log.gz, artemis.log.2023-03-23-37.log.gz,
> artemis.log.2023-03-23-38.log.gz, artemis.log.2023-03-23-39.log.gz,
> artemis.log.2023-03-23-4.log.gz, artemis.log.2023-03-23-40.log.gz,
> artemis.log.2023-03-23-41.log.gz, artemis.log.2023-03-23-42.log.gz,
> artemis.log.2023-03-23-43.log.gz, artemis.log.2023-03-23-44.log.gz,
> artemis.log.2023-03-23-45.log.gz, artemis.log.2023-03-23-46.log.gz,
> artemis.log.2023-03-23-47.log.gz, artemis.log.2023-03-23-48.log.gz,
> artemis.log.2023-03-23-49.log.gz, artemis.log.2023-03-23-5.log.gz,
> artemis.log.2023-03-23-50.log.gz, artemis.log.2023-03-23-51.log.gz,
> artemis.log.2023-03-23-52.log.gz, artemis.log.2023-03-23-53.log.gz,
> artemis.log.2023-03-23-54.log.gz, artemis.log.2023-03-23-55.log.gz,
> artemis.log.2023-03-23-56.log.gz, artemis.log.2023-03-23-57.log.gz,
> artemis.log.2023-03-23-58.log.gz, artemis.log.2023-03-23-59.log.gz,
> artemis.log.2023-03-23-6.log.gz, artemis.log.2023-03-23-60.log.gz,
> artemis.log.2023-03-23-61.log.gz, artemis.log.2023-03-23-62.log.gz,
> artemis.log.2023-03-23-63.log.gz, artemis.log.2023-03-23-64.log.gz,
> artemis.log.2023-03-23-65.log.gz, artemis.log.2023-03-23-66.log.gz,
> artemis.log.2023-03-23-67.log.gz, artemis.log.2023-03-23-68.log.gz,
> artemis.log.2023-03-23-69.log.gz, artemis.log.2023-03-23-7.log.gz,
> artemis.log.2023-03-23-70.log.gz, artemis.log.2023-03-23-71.log.gz,
> artemis.log.2023-03-23-72.log.gz, artemis.log.2023-03-23-73.log.gz,
> artemis.log.2023-03-23-74.log.gz, artemis.log.2023-03-23-75.log.gz,
> artemis.log.2023-03-23-76.log.gz, artemis.log.2023-03-23-77.log.gz,
> artemis.log.2023-03-23-78.log.gz, artemis.log.2023-03-23-79.log.gz,
> artemis.log.2023-03-23-8.log.gz, artemis.log.2023-03-23-80.log.gz,
> artemis.log.2023-03-23-81.log.gz, artemis.log.2023-03-23-82.log.gz,
> artemis.log.2023-03-23-83.log.gz, artemis.log.2023-03-23-84.log.gz,
> artemis.log.2023-03-23-85.log.gz, artemis.log.2023-03-23-86.log.gz,
> artemis.log.2023-03-23-87.log.gz, artemis.log.2023-03-23-88.log.gz,
> artemis.log.2023-03-23-89.log.gz, artemis.log.2023-03-23-9.log.gz,
> artemis.log.2023-03-23-90.log.gz, artemis.log.2023-03-23-91.log.gz,
> artemis.log.2023-03-23-92.log.gz, artemis.log.2023-03-23-93.log.gz,
> artemis.log.2023-03-23-94.log.gz, artemis.log.2023-03-23-95.log.gz,
> artemis.log.2023-03-23-96.log.gz, artemis.log.2023-03-23-97.log.gz,
> artemis.log.2023-03-23-98.log.gz, artemis.log.2023-03-23-99.log.gz
>
>
> Some of the AMQP messages sent by my client never arrive at the consumer. In
> the Artemis log I found the following exception:
>
>
> {code:java}
> 2023-03-23 18:06:58,084 WARN
> [org.apache.activemq.artemis.protocol.amqp.logger] AMQ111005: Failed to
> convert message. Sending it to Dead Letter Address.
> org.apache.activemq.artemis.protocol.amqp.converter.coreWrapper.ConversionException:
> java.nio.channels.ClosedChannelException at
>
[jira] [Work logged] (ARTEMIS-4215) JournalFlush might never happen when journal-sync-* is false
[ https://issues.apache.org/jira/browse/ARTEMIS-4215?focusedWorklogId=852778=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852778 ] ASF GitHub Bot logged work on ARTEMIS-4215: --- Author: ASF GitHub Bot Created on: 24/Mar/23 08:22 Start Date: 24/Mar/23 08:22 Worklog Time Spent: 10m Work Description: AntonRoskvist opened a new pull request, #4413: URL: https://github.com/apache/activemq-artemis/pull/4413 …alse I'm very open to the idea that this might not be the right solution but if nothing else the test works to demonstrate the issue. Can also very easily be demonstrated by: configuring false false Starting the broker Sending some messages i.e: bin/artemis producer --destination queue://TEST.1 --message-count 100 Wait _any_ amount of time kill -9 artemisPID Start broker Messages are gone This is new behavior since broker version 2.18.0 I have run some local performance tests between this change and an unchanged broker and can see no meaningful difference in terms of resource utilization or overall throughput. I have tested with sync=true and false, paging 50% of the messages Running all message production in transacted batches of 10 messages each Running all message production with AUTO_ACK Results of the tests: ``` 1M messages max-messages=500k sync=false batch PR: 231995 ms ORG: 234791 ms AUTO_ACK PR: 33627 ms ORG: 31928 ms sync=true batch PR: 254064 ms ORG: 247203 ms AUTO_ACK PR: 2438805 ms ORG: 2439546 ms ``` Issue Time Tracking --- Worklog Id: (was: 852778) Remaining Estimate: 0h Time Spent: 10m > JournalFlush might never happen when journal-sync-* is false > > > Key: ARTEMIS-4215 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4215 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Anton Roskvist >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When journal-sync-* is false then flushes to journal will only ever happen > once the buffer is full or when the broker is cleanly shut down, regardless > of how much time passes. This means that if the broker is started with these > settings a crash/kill -9 will for sure loose messages, regardless of how much > time passes since the messages where sent. > This started with version 2.18.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
