[jira] [Comment Edited] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread Liviu Citu (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720787#comment-17720787
 ] 

Liviu Citu edited comment on ARTEMIS-2824 at 5/9/23 5:28 AM:
-

Seems good. Thank you!

If not too much effort I think we will need the same change also for the 
initial reported notification type (SESSION_CLOSED)

I would say the client  id should be also set for the following notification 
types (at least):
 * SESSION_CREATED
 * SESSION_CLOSED

Nice to have:
 * BINDING_REMOVED
 * BINDING_ADDED

But again if too much effort then no need. As far as I am concerned, what you 
have done is sufficient.

Thanks again.


was (Author: JIRAUSER300236):
Seems good. Thank you!

If not too much effort I think we will need the same change also for the 
initial reported notification type (SESSION_CLOSED)

I would say the client  id should be also set for the following notification 
types (at least):
 * SESSION_CREATED
 * SESSION_CLOSED

Nice to have:
 * BINDING_REMOVED
 * BINDING_ADDED

But again if too much effort then no need. As far as I am concern, what you 
have done is sufficient.

Thanks again.

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread Liviu Citu (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720787#comment-17720787
 ] 

Liviu Citu edited comment on ARTEMIS-2824 at 5/9/23 5:28 AM:
-

Seems good. Thank you!

If not too much effort I think we will need the same change also for the 
initial reported notification type (SESSION_CLOSED)

I would say the client  id should be also set for the following notification 
types (at least):
 * SESSION_CREATED
 * SESSION_CLOSED

Nice to have:
 * BINDING_REMOVED
 * BINDING_ADDED

But again if too much effort then no need. As far as I am concern, what you 
have done is sufficient.

Thanks again.


was (Author: JIRAUSER300236):
Seems good. Thank you!

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread Liviu Citu (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720787#comment-17720787
 ] 

Liviu Citu commented on ARTEMIS-2824:
-

Seems good. Thank you!

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4274) Push masked credential support into core client

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4274?focusedWorklogId=861095=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861095
 ]

ASF GitHub Bot logged work on ARTEMIS-4274:
---

Author: ASF GitHub Bot
Created on: 09/May/23 00:59
Start Date: 09/May/23 00:59
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4470:
URL: https://github.com/apache/activemq-artemis/pull/4470

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 861095)
Remaining Estimate: 0h
Time Spent: 10m

> Push masked credential support into core client
> ---
>
> Key: ARTEMIS-4274
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4274
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently masked credentials are only supported in the core JMS client. This 
> support should be pushed down into the core client itself so things like CLI 
> utilities (e.g. {{queue stat}}, {{check node}}) can use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ARTEMIS-4274) Push masked credential support into core client

2023-05-08 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-4274:

Description: Currently masked credentials are only supported in the core 
JMS client. This support should be pushed down into the core client itself so 
things like CLI utilities (e.g. {{queue stat}}, {{check node}}) can use it.

> Push masked credential support into core client
> ---
>
> Key: ARTEMIS-4274
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4274
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> Currently masked credentials are only supported in the core JMS client. This 
> support should be pushed down into the core client itself so things like CLI 
> utilities (e.g. {{queue stat}}, {{check node}}) can use it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ARTEMIS-3790) Support masked passwords when creating JMS connections

2023-05-08 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-3790:

Summary: Support masked passwords when creating JMS connections  (was: 
Support masked passwords when creating connections)

> Support masked passwords when creating JMS connections
> --
>
> Key: ARTEMIS-3790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: API
>Affects Versions: 2.19.1
>Reporter: Apache Dev
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.28.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> ActiveMQConnectionFactory#createConnection and similar APIs could accept 
> "masked" passwords.
> This would improve usability in cases where connection password is already 
> stored in masked format.
> For example, a client using TLS and username/password authentication would 
> need to configure the "trustStorePassword" in the brokerURL - which accepts 
> the ENC(...) form - and the connection password - currently not accepting the 
> ENC(...) form.
> Accepting the masked password even for connection creation would improve 
> usability for clients storing masked passwords in configuration files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4274) Push masked credential support into core client

2023-05-08 Thread Justin Bertram (Jira)
Justin Bertram created ARTEMIS-4274:
---

 Summary: Push masked credential support into core client
 Key: ARTEMIS-4274
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4274
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4258) delayBeforeDispatch not working with OpenWire

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4258?focusedWorklogId=861074=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861074
 ]

ASF GitHub Bot logged work on ARTEMIS-4258:
---

Author: ASF GitHub Bot
Created on: 08/May/23 20:11
Start Date: 08/May/23 20:11
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4451:
URL: https://github.com/apache/activemq-artemis/pull/4451




Issue Time Tracking
---

Worklog Id: (was: 861074)
Remaining Estimate: 0h
Time Spent: 10m

> delayBeforeDispatch not working with OpenWire
> -
>
> Key: ARTEMIS-4258
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4258
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4258) delayBeforeDispatch not working with OpenWire

2023-05-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720659#comment-17720659
 ] 

ASF subversion and git services commented on ARTEMIS-4258:
--

Commit 6ba54964bd447e9f536d905af27de6504e79f066 in activemq-artemis's branch 
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=6ba54964bd ]

ARTEMIS-4258 delayBeforeDispatch not working with OpenWire


> delayBeforeDispatch not working with OpenWire
> -
>
> Key: ARTEMIS-4258
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4258
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ARTEMIS-4239) use StandardCharsets.UTF_8

2023-05-08 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-4239.
-
Fix Version/s: 2.29.0
   Resolution: Fixed

> use StandardCharsets.UTF_8
> --
>
> Key: ARTEMIS-4239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4239
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.28.0
>Reporter: Alexey Markevich
>Priority: Minor
> Fix For: 2.29.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> avoid UnsupportedEncodingException handling



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4239) use StandardCharsets.UTF_8

2023-05-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720658#comment-17720658
 ] 

ASF subversion and git services commented on ARTEMIS-4239:
--

Commit 383345a4f602d79c415f72b8ad66b8218cbac467 in activemq-artemis's branch 
refs/heads/main from Alexey Markevich
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=383345a4f6 ]

ARTEMIS-4239 use StandardCharsets.UTF_8

> use StandardCharsets.UTF_8
> --
>
> Key: ARTEMIS-4239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4239
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.28.0
>Reporter: Alexey Markevich
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> avoid UnsupportedEncodingException handling



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4239) use StandardCharsets.UTF_8

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4239?focusedWorklogId=861073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861073
 ]

ASF GitHub Bot logged work on ARTEMIS-4239:
---

Author: ASF GitHub Bot
Created on: 08/May/23 20:10
Start Date: 08/May/23 20:10
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4431:
URL: https://github.com/apache/activemq-artemis/pull/4431




Issue Time Tracking
---

Worklog Id: (was: 861073)
Time Spent: 0.5h  (was: 20m)

> use StandardCharsets.UTF_8
> --
>
> Key: ARTEMIS-4239
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4239
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.28.0
>Reporter: Alexey Markevich
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> avoid UnsupportedEncodingException handling



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ARTEMIS-4273) Mask command not picking up codec properties

2023-05-08 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-4273:

Description: The properties set for {{password-codec}} in {{broker.xml}} 
are being ignored by the {{mask}} command when using {{--password-codec}} (i.e. 
the directive to read the config from {{broker.xml}}).

> Mask command not picking up codec properties
> 
>
> Key: ARTEMIS-4273
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4273
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The properties set for {{password-codec}} in {{broker.xml}} are being ignored 
> by the {{mask}} command when using {{--password-codec}} (i.e. the directive 
> to read the config from {{broker.xml}}).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4273) Mask command not picking up codec properties

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4273?focusedWorklogId=861072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861072
 ]

ASF GitHub Bot logged work on ARTEMIS-4273:
---

Author: ASF GitHub Bot
Created on: 08/May/23 19:39
Start Date: 08/May/23 19:39
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4469:
URL: https://github.com/apache/activemq-artemis/pull/4469

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 861072)
Remaining Estimate: 0h
Time Spent: 10m

> Mask command not picking up codec properties
> 
>
> Key: ARTEMIS-4273
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4273
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4273) Mask command not picking up codec properties

2023-05-08 Thread Justin Bertram (Jira)
Justin Bertram created ARTEMIS-4273:
---

 Summary: Mask command not picking up codec properties
 Key: ARTEMIS-4273
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4273
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4265) Make more web console tabs conditional on permission

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4265?focusedWorklogId=861061=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861061
 ]

ASF GitHub Bot logged work on ARTEMIS-4265:
---

Author: ASF GitHub Bot
Created on: 08/May/23 17:38
Start Date: 08/May/23 17:38
Worklog Time Spent: 10m 
  Work Description: brusdev merged PR #4460:
URL: https://github.com/apache/activemq-artemis/pull/4460




Issue Time Tracking
---

Worklog Id: (was: 861061)
Time Spent: 1h 20m  (was: 1h 10m)

> Make more web console tabs conditional on permission
> 
>
> Key: ARTEMIS-4265
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4265
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Many of the tabs on the web console show up even though the user doesn't have 
> permission to execute the command corresponding to the tab. For example the 
> "Connections" tab shows up even though the user can't execute the 
> {{listConnections}} management operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4265) Make more web console tabs conditional on permission

2023-05-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720624#comment-17720624
 ] 

ASF subversion and git services commented on ARTEMIS-4265:
--

Commit bc0b75d25a67c814313f8303df537708fd795b0c in activemq-artemis's branch 
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=bc0b75d25a ]

ARTEMIS-4265 make more web console tabs conditional on permission

Many of the tabs on the web console show up even though the user doesn't
have permission to execute the command corresponding to the tab. For
example the "Connections" tab shows up even though the user can't
execute the `listConnections` management operation.


> Make more web console tabs conditional on permission
> 
>
> Key: ARTEMIS-4265
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4265
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Many of the tabs on the web console show up even though the user doesn't have 
> permission to execute the command corresponding to the tab. For example the 
> "Connections" tab shows up even though the user can't execute the 
> {{listConnections}} management operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread Justin Bertram (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720623#comment-17720623
 ] 

Justin Bertram commented on ARTEMIS-2824:
-

[~livicitu], I just sent [a 
PR|https://github.com/apache/activemq-artemis/pull/4468] to resolve the issue. 
Please give it a review and let me know what you think.

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?focusedWorklogId=861060=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861060
 ]

ASF GitHub Bot logged work on ARTEMIS-2824:
---

Author: ASF GitHub Bot
Created on: 08/May/23 17:35
Start Date: 08/May/23 17:35
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4468:
URL: https://github.com/apache/activemq-artemis/pull/4468

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 861060)
Remaining Estimate: 0h
Time Spent: 10m

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread Liviu Citu (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720608#comment-17720608
 ] 

Liviu Citu commented on ARTEMIS-2824:
-

We were using advisory messages for service discovery in such a way that when a 
server is up it will create a connection with a specific client ID (which is 
{*}ServerName{*}). Server will then create a consumer (main) on a specific hear 
beat topic (topic shared by other servers as well) so that this will trigger a 
notification message.  On the application (client) side,  we listen to 
notification messages and when we receive a consumer create/close message we 
need to know which server went up or down. However, currently it is impossible 
to tell this because we are missing in the notification message the client ID 
information about the consumer (as we had in case of advisory message).

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram reassigned ARTEMIS-2824:
---

Assignee: Justin Bertram

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Assignee: Justin Bertram
>Priority: Major
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4267) Original exception lost for NoCacheLoginException

2023-05-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720542#comment-17720542
 ] 

ASF subversion and git services commented on ARTEMIS-4267:
--

Commit c2bada6a770d9b0f6d19e5f3e137020c64954888 in activemq-artemis's branch 
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c2bada6a77 ]

ARTEMIS-4267 original exception lost for NoCacheLoginException

When skipping the authentication cache details for the original
exception are not logged.

This commit ensures these details are logged and adopts the
ExceptionUtils class from Apache Commons Lang in lieu of the previous
custom implementation.


> Original exception lost for NoCacheLoginException
> -
>
> Key: ARTEMIS-4267
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4267
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> When skipping the authentication cache the _original_ exception is not logged.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4267) Original exception lost for NoCacheLoginException

2023-05-08 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4267?focusedWorklogId=861035=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861035
 ]

ASF GitHub Bot logged work on ARTEMIS-4267:
---

Author: ASF GitHub Bot
Created on: 08/May/23 15:01
Start Date: 08/May/23 15:01
Worklog Time Spent: 10m 
  Work Description: brusdev merged PR #4461:
URL: https://github.com/apache/activemq-artemis/pull/4461




Issue Time Tracking
---

Worklog Id: (was: 861035)
Time Spent: 3h 10m  (was: 3h)

> Original exception lost for NoCacheLoginException
> -
>
> Key: ARTEMIS-4267
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4267
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> When skipping the authentication cache the _original_ exception is not logged.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-2824) _AMQ_Client_ID on SESSION_CLOSED notification is always null

2023-05-08 Thread k (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720514#comment-17720514
 ] 

k commented on ARTEMIS-2824:


Hello,

We are currently working on transitioning from ActiveMQ Classic to Artemis (we 
use 2.28.0 for development). 

We encountered the same issue for CONSUMER_CREATED / CONSUMER_CLOSED 
notification types. This is a regression compared to ActiveMQ Classic which 
included this info on ConsumerInfo/RemoveInfo advisory messages. As we're using 
this feature in a critical component of our software, it's a showstopper for 
the migration.

Do you have any updates on whether you would address this issue soon?

Thanks,

Claudiu

> _AMQ_Client_ID on SESSION_CLOSED notification is always null
> 
>
> Key: ARTEMIS-2824
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2824
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.11.0
>Reporter: Tim Daly
>Priority: Major
>
> When a JMS client with a clientId set closes the session a notification 
> (_AMQ_NotifType=SESSION_CLOSED) is sent by the broker but the _AMQ_Client_ID 
> is always set to null.  The JMS Client Id has been verified as being set via 
> the web UI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)