[jira] [Work logged] (ARTEMIS-1230) Create Maven Bill of Materials (BOM)
[ https://issues.apache.org/jira/browse/ARTEMIS-1230?focusedWorklogId=903973=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903973 ] ASF GitHub Bot logged work on ARTEMIS-1230: --- Author: ASF GitHub Bot Created on: 06/Feb/24 22:50 Start Date: 06/Feb/24 22:50 Worklog Time Spent: 10m Work Description: amarkevich commented on code in PR #4782: URL: https://github.com/apache/activemq-artemis/pull/4782#discussion_r1480631721 ## artemis-parent/pom.xml: ## @@ -0,0 +1,2074 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + org.apache.activemq + artemis-pom + 2.33.0-SNAPSHOT + + + artemis-parent + pom + ActiveMQ Artemis Parent POM + + + 11 + 11 + + false + log4j2-tests-config.properties + --add-modules java.sql,jdk.unsupported + + 2.0.0 + 4.4.4 + 4.13.5 + 2.9.0 + 3.14.0 + 5.18.3 + 10.15.2.0 + 1.9.4 + 1.3.0 + 2.11.0 + 2.12.0 + 3.2.2 + 1.10.0 + 2.15.1 + 1.16.0 + 1.16 + 3.1.8 + 33.0.0-jre + 2.17.7 + 3.0.2 + 10.0.20 + 4.0.6 + 5.3.2.Final + 2.24.1 + 5.1.9 + 3.3.2 + 2.16.1 + 1.44.1 + 10.12.7 + 5.10.0 + 4.0.2 + 4.1.106.Final + 2.1.12 + 5.6.0 + 3.9.1 + 4.4.0 + 2.3.0 + Create Maven Bill of Materials (BOM) > > > Key: ARTEMIS-1230 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1230 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Daniel Siviter >Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > > It's frustrating having to deal with dependency versions so the creation of a > Bill of Materials will assist with this. > I'm currently battling with Wildfly Swarm 2017.6.0 overriding to > v1.1.0.wildfly017. To override the version of Artemis I have to have an entry > in my POM for every single dependency which is arduous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-1230) Create Maven Bill of Materials (BOM)
[ https://issues.apache.org/jira/browse/ARTEMIS-1230?focusedWorklogId=903971=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903971 ] ASF GitHub Bot logged work on ARTEMIS-1230: --- Author: ASF GitHub Bot Created on: 06/Feb/24 22:45 Start Date: 06/Feb/24 22:45 Worklog Time Spent: 10m Work Description: amarkevich commented on code in PR #4782: URL: https://github.com/apache/activemq-artemis/pull/4782#discussion_r1480628544 ## artemis-parent/pom.xml: ## @@ -0,0 +1,2074 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> + 4.0.0 + + org.apache.activemq + artemis-pom + 2.33.0-SNAPSHOT + + + artemis-parent + pom + ActiveMQ Artemis Parent POM + + + 11 + 11 + + false + log4j2-tests-config.properties + --add-modules java.sql,jdk.unsupported + + 2.0.0 + 4.4.4 + 4.13.5 + 2.9.0 + 3.14.0 + 5.18.3 + 10.15.2.0 + 1.9.4 + 1.3.0 + 2.11.0 + 2.12.0 + 3.2.2 + 1.10.0 + 2.15.1 + 1.16.0 + 1.16 + 3.1.8 + 33.0.0-jre + 2.17.7 + 3.0.2 + 10.0.20 + 4.0.6 + 5.3.2.Final + 2.24.1 + 5.1.9 + 3.3.2 + 2.16.1 + 1.44.1 + 10.12.7 + 5.10.0 + 4.0.2 + 4.1.106.Final + 2.1.12 + 5.6.0 + 3.9.1 + 4.4.0 + 2.3.0 + Create Maven Bill of Materials (BOM) > > > Key: ARTEMIS-1230 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1230 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Daniel Siviter >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > It's frustrating having to deal with dependency versions so the creation of a > Bill of Materials will assist with this. > I'm currently battling with Wildfly Swarm 2017.6.0 overriding to > v1.1.0.wildfly017. To override the version of Artemis I have to have an entry > in my POM for every single dependency which is arduous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4636) Upgrade OpenWebBeans to 2.0.27
[ https://issues.apache.org/jira/browse/ARTEMIS-4636?focusedWorklogId=903951=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903951 ] ASF GitHub Bot logged work on ARTEMIS-4636: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:25 Start Date: 06/Feb/24 19:25 Worklog Time Spent: 10m Work Description: jbertram merged PR #4809: URL: https://github.com/apache/activemq-artemis/pull/4809 Issue Time Tracking --- Worklog Id: (was: 903951) Time Spent: 20m (was: 10m) > Upgrade OpenWebBeans to 2.0.27 > -- > > Key: ARTEMIS-4636 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4636 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4636) Upgrade OpenWebBeans to 2.0.27
[ https://issues.apache.org/jira/browse/ARTEMIS-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814974#comment-17814974 ] ASF subversion and git services commented on ARTEMIS-4636: -- Commit d418a5c00ed23f0b6a1cb20543a4632236158c18 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d418a5c00e ] ARTEMIS-4636 upgrade OpenWebBeans to 2.0.27 > Upgrade OpenWebBeans to 2.0.27 > -- > > Key: ARTEMIS-4636 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4636 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4635) Upgrade Arquillian & Weld dependencies
[ https://issues.apache.org/jira/browse/ARTEMIS-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814971#comment-17814971 ] ASF subversion and git services commented on ARTEMIS-4635: -- Commit 62432ee32397837488486a7a1891f5e6152d8789 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=62432ee323 ] ARTEMIS-4635 upgrade Arquillian & Weld dependencies > Upgrade Arquillian & Weld dependencies > -- > > Key: ARTEMIS-4635 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4635 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4635) Upgrade Arquillian & Weld dependencies
[ https://issues.apache.org/jira/browse/ARTEMIS-4635?focusedWorklogId=903949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903949 ] ASF GitHub Bot logged work on ARTEMIS-4635: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:22 Start Date: 06/Feb/24 19:22 Worklog Time Spent: 10m Work Description: jbertram merged PR #4808: URL: https://github.com/apache/activemq-artemis/pull/4808 Issue Time Tracking --- Worklog Id: (was: 903949) Time Spent: 20m (was: 10m) > Upgrade Arquillian & Weld dependencies > -- > > Key: ARTEMIS-4635 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4635 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4634) Upgrade Maven Plugin Annotations to 3.11.0
[ https://issues.apache.org/jira/browse/ARTEMIS-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814969#comment-17814969 ] ASF subversion and git services commented on ARTEMIS-4634: -- Commit 5f0902cfe94a0fb8527e1c8a01e47ef598b5a282 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=5f0902cfe9 ] ARTEMIS-4634 upgrade Maven Plugin Annotations to 3.11.0 > Upgrade Maven Plugin Annotations to 3.11.0 > -- > > Key: ARTEMIS-4634 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4634 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4633) Upgrade Apache HTTP Core to 4.4.16
[ https://issues.apache.org/jira/browse/ARTEMIS-4633?focusedWorklogId=903947=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903947 ] ASF GitHub Bot logged work on ARTEMIS-4633: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:21 Start Date: 06/Feb/24 19:21 Worklog Time Spent: 10m Work Description: jbertram merged PR #4806: URL: https://github.com/apache/activemq-artemis/pull/4806 Issue Time Tracking --- Worklog Id: (was: 903947) Time Spent: 20m (was: 10m) > Upgrade Apache HTTP Core to 4.4.16 > -- > > Key: ARTEMIS-4633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4633 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4633) Upgrade Apache HTTP Core to 4.4.16
[ https://issues.apache.org/jira/browse/ARTEMIS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814968#comment-17814968 ] ASF subversion and git services commented on ARTEMIS-4633: -- Commit 983bb71ad093a25e1364118cc1c1e27b098fcd92 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=983bb71ad0 ] ARTEMIS-4633 upgrade Apache HTTP Core to 4.4.16 > Upgrade Apache HTTP Core to 4.4.16 > -- > > Key: ARTEMIS-4633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4633 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4634) Upgrade Maven Plugin Annotations to 3.11.0
[ https://issues.apache.org/jira/browse/ARTEMIS-4634?focusedWorklogId=903948=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903948 ] ASF GitHub Bot logged work on ARTEMIS-4634: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:21 Start Date: 06/Feb/24 19:21 Worklog Time Spent: 10m Work Description: jbertram merged PR #4807: URL: https://github.com/apache/activemq-artemis/pull/4807 Issue Time Tracking --- Worklog Id: (was: 903948) Time Spent: 20m (was: 10m) > Upgrade Maven Plugin Annotations to 3.11.0 > -- > > Key: ARTEMIS-4634 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4634 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[ https://issues.apache.org/jira/browse/ARTEMIS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-4187. - Fix Version/s: 2.33.0 Resolution: Fixed > SizeAwareMetric attribute inconsistency > --- > > Key: ARTEMIS-4187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4187 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0 >Reporter: Jelmer Marinus >Assignee: Jelmer Marinus >Priority: Major > Fix For: 2.33.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The SizeAwareMetric can be in an inconsistent state due to conflicting > attribute values. > [maxSize vs.sizeEnabled] > sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize > is set to -1 sizeEnabled is going to be set to false to indicate that no size > checking is required. However because of the two seperate attributes they are > inconsistent for a short period of time. This is most prevelant in the follow > code from the SizeAwareMetric itself: > {code:java} > public void setMax(long maxSize, long lowerMarkSize, long maxElements, long > lowerMarkElements) { >this.maxSize = maxSize; >this.lowerMarkSize = lowerMarkSize; >this.maxElements = maxElements; >this.lowerMarkElements = lowerMarkElements; >long currentSize = sizeUpdater.get(this); >long currentElements = elementsUpdater.get(this); >checkOver(currentElements, currentSize); >checkUnder(currentElements, currentSize); > } {code} > This code sets the maxSize but leaves sizeEnabled as it is. As a consequence > the checkOver and checkUnder can be executed with maxSize and sizeEnabled in > an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected > over/under conditions and unexpected paging behaviour. > The same is true for maxElement vs. elementsEnabled. > [maxSize vs. lowerMarkSize] > MaxSize is checked >= to the current size and lowerMarkSize is check <= > current size. When maxSize = lowerMarkSize = current size it is a bit > "unclear" if there is and under or over situation. > The same is true for maxElements vs. lowerMarkElements I believe. > This is a minor/cosmetic issue. > > I will issue a PR for both. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4631) Upgrade Spring to 5.3.31
[ https://issues.apache.org/jira/browse/ARTEMIS-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814964#comment-17814964 ] ASF subversion and git services commented on ARTEMIS-4631: -- Commit e3ce9afbb9eb6596026354584f4df90de3eed8a0 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=e3ce9afbb9 ] ARTEMIS-4631 upgrade Spring to 5.3.31 > Upgrade Spring to 5.3.31 > > > Key: ARTEMIS-4631 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4631 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4632) Upgrade Apache HTTP Client to 4.5.14
[ https://issues.apache.org/jira/browse/ARTEMIS-4632?focusedWorklogId=903946=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903946 ] ASF GitHub Bot logged work on ARTEMIS-4632: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:18 Start Date: 06/Feb/24 19:18 Worklog Time Spent: 10m Work Description: jbertram merged PR #4805: URL: https://github.com/apache/activemq-artemis/pull/4805 Issue Time Tracking --- Worklog Id: (was: 903946) Time Spent: 20m (was: 10m) > Upgrade Apache HTTP Client to 4.5.14 > > > Key: ARTEMIS-4632 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4632 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4631) Upgrade Spring to 5.3.31
[ https://issues.apache.org/jira/browse/ARTEMIS-4631?focusedWorklogId=903945=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903945 ] ASF GitHub Bot logged work on ARTEMIS-4631: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:18 Start Date: 06/Feb/24 19:18 Worklog Time Spent: 10m Work Description: jbertram merged PR #4804: URL: https://github.com/apache/activemq-artemis/pull/4804 Issue Time Tracking --- Worklog Id: (was: 903945) Time Spent: 20m (was: 10m) > Upgrade Spring to 5.3.31 > > > Key: ARTEMIS-4631 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4631 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4632) Upgrade Apache HTTP Client to 4.5.14
[ https://issues.apache.org/jira/browse/ARTEMIS-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814965#comment-17814965 ] ASF subversion and git services commented on ARTEMIS-4632: -- Commit a17037bc9e82a008d283ea459a3dd6801ff201d6 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a17037bc9e ] ARTEMIS-4632 upgrade Apache HTTP client to 4.5.14 > Upgrade Apache HTTP Client to 4.5.14 > > > Key: ARTEMIS-4632 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4632 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[ https://issues.apache.org/jira/browse/ARTEMIS-4187?focusedWorklogId=903944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903944 ] ASF GitHub Bot logged work on ARTEMIS-4187: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:17 Start Date: 06/Feb/24 19:17 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4387: URL: https://github.com/apache/activemq-artemis/pull/4387#issuecomment-1930599311 @Maverick19841972, sorry it took so long to get this merged. Thanks for the contribution! I added a small test called `testConsistency` to `org.apache.activemq.artemis.utils.SizeAwareMetricTest` because I noticed that none of the modified tests actually failed without your fix. This test validates your fix directly. Issue Time Tracking --- Worklog Id: (was: 903944) Time Spent: 40m (was: 0.5h) > SizeAwareMetric attribute inconsistency > --- > > Key: ARTEMIS-4187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4187 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0 >Reporter: Jelmer Marinus >Assignee: Jelmer Marinus >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The SizeAwareMetric can be in an inconsistent state due to conflicting > attribute values. > [maxSize vs.sizeEnabled] > sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize > is set to -1 sizeEnabled is going to be set to false to indicate that no size > checking is required. However because of the two seperate attributes they are > inconsistent for a short period of time. This is most prevelant in the follow > code from the SizeAwareMetric itself: > {code:java} > public void setMax(long maxSize, long lowerMarkSize, long maxElements, long > lowerMarkElements) { >this.maxSize = maxSize; >this.lowerMarkSize = lowerMarkSize; >this.maxElements = maxElements; >this.lowerMarkElements = lowerMarkElements; >long currentSize = sizeUpdater.get(this); >long currentElements = elementsUpdater.get(this); >checkOver(currentElements, currentSize); >checkUnder(currentElements, currentSize); > } {code} > This code sets the maxSize but leaves sizeEnabled as it is. As a consequence > the checkOver and checkUnder can be executed with maxSize and sizeEnabled in > an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected > over/under conditions and unexpected paging behaviour. > The same is true for maxElement vs. elementsEnabled. > [maxSize vs. lowerMarkSize] > MaxSize is checked >= to the current size and lowerMarkSize is check <= > current size. When maxSize = lowerMarkSize = current size it is a bit > "unclear" if there is and under or over situation. > The same is true for maxElements vs. lowerMarkElements I believe. > This is a minor/cosmetic issue. > > I will issue a PR for both. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[ https://issues.apache.org/jira/browse/ARTEMIS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814961#comment-17814961 ] ASF subversion and git services commented on ARTEMIS-4187: -- Commit 89c3a627e9ca2b1ef48a6411d372c32f90a6f9ed in activemq-artemis's branch refs/heads/main from Maverick19841972 [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=89c3a627e9 ] ARTEMIS-4187 made SizeAware attributes consistent > SizeAwareMetric attribute inconsistency > --- > > Key: ARTEMIS-4187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4187 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0 >Reporter: Jelmer Marinus >Assignee: Jelmer Marinus >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The SizeAwareMetric can be in an inconsistent state due to conflicting > attribute values. > [maxSize vs.sizeEnabled] > sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize > is set to -1 sizeEnabled is going to be set to false to indicate that no size > checking is required. However because of the two seperate attributes they are > inconsistent for a short period of time. This is most prevelant in the follow > code from the SizeAwareMetric itself: > {code:java} > public void setMax(long maxSize, long lowerMarkSize, long maxElements, long > lowerMarkElements) { >this.maxSize = maxSize; >this.lowerMarkSize = lowerMarkSize; >this.maxElements = maxElements; >this.lowerMarkElements = lowerMarkElements; >long currentSize = sizeUpdater.get(this); >long currentElements = elementsUpdater.get(this); >checkOver(currentElements, currentSize); >checkUnder(currentElements, currentSize); > } {code} > This code sets the maxSize but leaves sizeEnabled as it is. As a consequence > the checkOver and checkUnder can be executed with maxSize and sizeEnabled in > an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected > over/under conditions and unexpected paging behaviour. > The same is true for maxElement vs. elementsEnabled. > [maxSize vs. lowerMarkSize] > MaxSize is checked >= to the current size and lowerMarkSize is check <= > current size. When maxSize = lowerMarkSize = current size it is a bit > "unclear" if there is and under or over situation. > The same is true for maxElements vs. lowerMarkElements I believe. > This is a minor/cosmetic issue. > > I will issue a PR for both. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[ https://issues.apache.org/jira/browse/ARTEMIS-4187?focusedWorklogId=903943=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903943 ] ASF GitHub Bot logged work on ARTEMIS-4187: --- Author: ASF GitHub Bot Created on: 06/Feb/24 19:14 Start Date: 06/Feb/24 19:14 Worklog Time Spent: 10m Work Description: asfgit closed pull request #4387: ARTEMIS-4187 made SizeAwareMetrics attributes consistent URL: https://github.com/apache/activemq-artemis/pull/4387 Issue Time Tracking --- Worklog Id: (was: 903943) Time Spent: 0.5h (was: 20m) > SizeAwareMetric attribute inconsistency > --- > > Key: ARTEMIS-4187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4187 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0 >Reporter: Jelmer Marinus >Assignee: Jelmer Marinus >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The SizeAwareMetric can be in an inconsistent state due to conflicting > attribute values. > [maxSize vs.sizeEnabled] > sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize > is set to -1 sizeEnabled is going to be set to false to indicate that no size > checking is required. However because of the two seperate attributes they are > inconsistent for a short period of time. This is most prevelant in the follow > code from the SizeAwareMetric itself: > {code:java} > public void setMax(long maxSize, long lowerMarkSize, long maxElements, long > lowerMarkElements) { >this.maxSize = maxSize; >this.lowerMarkSize = lowerMarkSize; >this.maxElements = maxElements; >this.lowerMarkElements = lowerMarkElements; >long currentSize = sizeUpdater.get(this); >long currentElements = elementsUpdater.get(this); >checkOver(currentElements, currentSize); >checkUnder(currentElements, currentSize); > } {code} > This code sets the maxSize but leaves sizeEnabled as it is. As a consequence > the checkOver and checkUnder can be executed with maxSize and sizeEnabled in > an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected > over/under conditions and unexpected paging behaviour. > The same is true for maxElement vs. elementsEnabled. > [maxSize vs. lowerMarkSize] > MaxSize is checked >= to the current size and lowerMarkSize is check <= > current size. When maxSize = lowerMarkSize = current size it is a bit > "unclear" if there is and under or over situation. > The same is true for maxElements vs. lowerMarkElements I believe. > This is a minor/cosmetic issue. > > I will issue a PR for both. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4167) Enhance deserialization filter beyond black/whitelist functionality
[ https://issues.apache.org/jira/browse/ARTEMIS-4167?focusedWorklogId=903940=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903940 ] ASF GitHub Bot logged work on ARTEMIS-4167: --- Author: ASF GitHub Bot Created on: 06/Feb/24 18:55 Start Date: 06/Feb/24 18:55 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4368: URL: https://github.com/apache/activemq-artemis/pull/4368#issuecomment-1930565717 FWIW, you can update your branch, push -f, and then re-open this PR when you're ready. Issue Time Tracking --- Worklog Id: (was: 903940) Time Spent: 2h 20m (was: 2h 10m) > Enhance deserialization filter beyond black/whitelist functionality > --- > > Key: ARTEMIS-4167 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4167 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Scott Werner >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > Now that Artemis is Java 11+ compatible, there is now the ability to set an > ObjectInputFilter on an ObjectInputStream. There are also built in methods to > generate filters similar to the current syntax and offers many other features > out of the box. A global jvm property (jdk.serialFilter) can be set, but this > is quite restrictive. I suggest adding a new serial filter pattern and class > name of an ObjectInputFilter implementation, everywhere blacklist/whitelist > exist today. In time we can look into converting the existing black/whitelist > to the new format or just deprecating as the semantics are a bit different > and may not be able to make it 100% compatible. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4167) Enhance deserialization filter beyond black/whitelist functionality
[ https://issues.apache.org/jira/browse/ARTEMIS-4167?focusedWorklogId=903937=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903937 ] ASF GitHub Bot logged work on ARTEMIS-4167: --- Author: ASF GitHub Bot Created on: 06/Feb/24 18:39 Start Date: 06/Feb/24 18:39 Worklog Time Spent: 10m Work Description: swerner0 commented on PR #4368: URL: https://github.com/apache/activemq-artemis/pull/4368#issuecomment-1930541840 No worries, I saw the renames under the latest release and figured would cause conflicts. I'll revisit in the future and open a new PR. Thanks Issue Time Tracking --- Worklog Id: (was: 903937) Time Spent: 2h 10m (was: 2h) > Enhance deserialization filter beyond black/whitelist functionality > --- > > Key: ARTEMIS-4167 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4167 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Scott Werner >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > Now that Artemis is Java 11+ compatible, there is now the ability to set an > ObjectInputFilter on an ObjectInputStream. There are also built in methods to > generate filters similar to the current syntax and offers many other features > out of the box. A global jvm property (jdk.serialFilter) can be set, but this > is quite restrictive. I suggest adding a new serial filter pattern and class > name of an ObjectInputFilter implementation, everywhere blacklist/whitelist > exist today. In time we can look into converting the existing black/whitelist > to the new format or just deprecating as the semantics are a bit different > and may not be able to make it 100% compatible. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (ARTEMIS-4167) Enhance deserialization filter beyond black/whitelist functionality
[ https://issues.apache.org/jira/browse/ARTEMIS-4167 ] Scott Werner deleted comment on ARTEMIS-4167: --- was (Author: swerner): No worries, I saw the renames under the latest release and figured would cause conflicts. I'll revisit in the future and open a new PR. Thanks > Enhance deserialization filter beyond black/whitelist functionality > --- > > Key: ARTEMIS-4167 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4167 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Scott Werner >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > Now that Artemis is Java 11+ compatible, there is now the ability to set an > ObjectInputFilter on an ObjectInputStream. There are also built in methods to > generate filters similar to the current syntax and offers many other features > out of the box. A global jvm property (jdk.serialFilter) can be set, but this > is quite restrictive. I suggest adding a new serial filter pattern and class > name of an ObjectInputFilter implementation, everywhere blacklist/whitelist > exist today. In time we can look into converting the existing black/whitelist > to the new format or just deprecating as the semantics are a bit different > and may not be able to make it 100% compatible. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4167) Enhance deserialization filter beyond black/whitelist functionality
[ https://issues.apache.org/jira/browse/ARTEMIS-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814945#comment-17814945 ] Scott Werner commented on ARTEMIS-4167: --- No worries, I saw the renames under the latest release and figured would cause conflicts. I'll revisit in the future and open a new PR. Thanks > Enhance deserialization filter beyond black/whitelist functionality > --- > > Key: ARTEMIS-4167 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4167 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Scott Werner >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > Now that Artemis is Java 11+ compatible, there is now the ability to set an > ObjectInputFilter on an ObjectInputStream. There are also built in methods to > generate filters similar to the current syntax and offers many other features > out of the box. A global jvm property (jdk.serialFilter) can be set, but this > is quite restrictive. I suggest adding a new serial filter pattern and class > name of an ObjectInputFilter implementation, everywhere blacklist/whitelist > exist today. In time we can look into converting the existing black/whitelist > to the new format or just deprecating as the semantics are a bit different > and may not be able to make it 100% compatible. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4167) Enhance deserialization filter beyond black/whitelist functionality
[ https://issues.apache.org/jira/browse/ARTEMIS-4167?focusedWorklogId=903933=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903933 ] ASF GitHub Bot logged work on ARTEMIS-4167: --- Author: ASF GitHub Bot Created on: 06/Feb/24 18:15 Start Date: 06/Feb/24 18:15 Worklog Time Spent: 10m Work Description: jbertram closed pull request #4368: ARTEMIS-4167 Enhanced deserialization filter URL: https://github.com/apache/activemq-artemis/pull/4368 Issue Time Tracking --- Worklog Id: (was: 903933) Time Spent: 1h 50m (was: 1h 40m) > Enhance deserialization filter beyond black/whitelist functionality > --- > > Key: ARTEMIS-4167 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4167 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Scott Werner >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > Now that Artemis is Java 11+ compatible, there is now the ability to set an > ObjectInputFilter on an ObjectInputStream. There are also built in methods to > generate filters similar to the current syntax and offers many other features > out of the box. A global jvm property (jdk.serialFilter) can be set, but this > is quite restrictive. I suggest adding a new serial filter pattern and class > name of an ObjectInputFilter implementation, everywhere blacklist/whitelist > exist today. In time we can look into converting the existing black/whitelist > to the new format or just deprecating as the semantics are a bit different > and may not be able to make it 100% compatible. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4167) Enhance deserialization filter beyond black/whitelist functionality
[ https://issues.apache.org/jira/browse/ARTEMIS-4167?focusedWorklogId=903934=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903934 ] ASF GitHub Bot logged work on ARTEMIS-4167: --- Author: ASF GitHub Bot Created on: 06/Feb/24 18:15 Start Date: 06/Feb/24 18:15 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4368: URL: https://github.com/apache/activemq-artemis/pull/4368#issuecomment-1930505801 At this point it appears this PR has been abandoned. Furthermore, it has numerous conflicts. Therefore, I will go ahead and close this PR. @swerner0, please re-open it with updates if you want it to be considered again. Thanks! Issue Time Tracking --- Worklog Id: (was: 903934) Time Spent: 2h (was: 1h 50m) > Enhance deserialization filter beyond black/whitelist functionality > --- > > Key: ARTEMIS-4167 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4167 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Scott Werner >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > Now that Artemis is Java 11+ compatible, there is now the ability to set an > ObjectInputFilter on an ObjectInputStream. There are also built in methods to > generate filters similar to the current syntax and offers many other features > out of the box. A global jvm property (jdk.serialFilter) can be set, but this > is quite restrictive. I suggest adding a new serial filter pattern and class > name of an ObjectInputFilter implementation, everywhere blacklist/whitelist > exist today. In time we can look into converting the existing black/whitelist > to the new format or just deprecating as the semantics are a bit different > and may not be able to make it 100% compatible. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4638) Remove bashism from install validation script
[ https://issues.apache.org/jira/browse/ARTEMIS-4638?focusedWorklogId=903931=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903931 ] ASF GitHub Bot logged work on ARTEMIS-4638: --- Author: ASF GitHub Bot Created on: 06/Feb/24 17:59 Start Date: 06/Feb/24 17:59 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4812: URL: https://github.com/apache/activemq-artemis/pull/4812 (no comment) Issue Time Tracking --- Worklog Id: (was: 903931) Remaining Estimate: 0h Time Spent: 10m > Remove bashism from install validation script > - > > Key: ARTEMIS-4638 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4638 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The {{validate-instalation.sh}} script in > {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies > this shebang: > {noformat} > #!/usr/bin/env sh{noformat} > However, it also uses the {{[[}} bashism which makes it fail on Debian based > distributions (e.g. Ubuntu) since those distributions use > [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather > than bash. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4638) Remove bashism from install validation script
[ https://issues.apache.org/jira/browse/ARTEMIS-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4638: Description: The {{validate-instalation.sh}} script in {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies this shebang: {noformat} #!/usr/bin/env sh{noformat} However, it also uses the {{[[}} bashism which makes it fail on Debian based distributions (e.g. Ubuntu) since those distributions use [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather than bash. was: The {{validate-instalation.sh}} script in {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies this shebang: {noformat} {{#!/usr/bin/env sh}}{noformat} However, it also uses the {{[[}} bashism which makes it fail on Debian based distributions (e.g. Ubuntu) since those distributions use [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather than bash. > Remove bashism from install validation script > - > > Key: ARTEMIS-4638 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4638 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > > The {{validate-instalation.sh}} script in > {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies > this shebang: > {noformat} > #!/usr/bin/env sh{noformat} > However, it also uses the {{[[}} bashism which makes it fail on Debian based > distributions (e.g. Ubuntu) since those distributions use > [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather > than bash. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4638) Remove bashism from install validation script
[ https://issues.apache.org/jira/browse/ARTEMIS-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4638: Description: The {{validate-instalation.sh}} script in {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies this shebang: {noformat} {{#!/usr/bin/env sh}}{noformat} However, it also uses the {{[[}} bashism which makes it fail on Debian based distributions (e.g. Ubuntu) since those distributions use [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather than bash. was:The {{validate-instalation.sh}} script in {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies {{#!/usr/bin/env sh}} but then it uses the {{[[}} bashism which makes it fail on Debian based distributions (e.g. Ubuntu) since those use [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather than bash. > Remove bashism from install validation script > - > > Key: ARTEMIS-4638 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4638 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > > The {{validate-instalation.sh}} script in > {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies > this shebang: > {noformat} > {{#!/usr/bin/env sh}}{noformat} > However, it also uses the {{[[}} bashism which makes it fail on Debian based > distributions (e.g. Ubuntu) since those distributions use > [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather > than bash. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4638) Remove bashism from install validation script
[ https://issues.apache.org/jira/browse/ARTEMIS-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4638: Description: The {{validate-instalation.sh}} script in {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies {{#!/usr/bin/env sh}} but then it uses the {{[[}} bashism which makes it fail on Debian based distributions (e.g. Ubuntu) since those use [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather than bash. > Remove bashism from install validation script > - > > Key: ARTEMIS-4638 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4638 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > > The {{validate-instalation.sh}} script in > {{artemis-distribution/src/test/scripts/validate-instalation.sh}} specifies > {{#!/usr/bin/env sh}} but then it uses the {{[[}} bashism which makes it fail > on Debian based distributions (e.g. Ubuntu) since those use > [dash|https://en.wikipedia.org/wiki/Almquist_shell#dash] by default rather > than bash. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4638) Remove bashism from install validation script
Justin Bertram created ARTEMIS-4638: --- Summary: Remove bashism from install validation script Key: ARTEMIS-4638 URL: https://issues.apache.org/jira/browse/ARTEMIS-4638 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Justin Bertram Assignee: Justin Bertram -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?focusedWorklogId=903923=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903923 ] ASF GitHub Bot logged work on ARTEMIS-4630: --- Author: ASF GitHub Bot Created on: 06/Feb/24 17:21 Start Date: 06/Feb/24 17:21 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4811: URL: https://github.com/apache/activemq-artemis/pull/4811#issuecomment-1930411947 These commits have been reverted. @angelogalvao, I think if we want to address this problem we need to determine _how_ the wrong pid made it into `artemis.pid` in the first place. Issue Time Tracking --- Worklog Id: (was: 903923) Time Spent: 2h (was: 1h 50m) > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Fix For: 2.33.0 > > Time Spent: 2h > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814902#comment-17814902 ] ASF subversion and git services commented on ARTEMIS-4630: -- Commit 968ef74cd7104cf0f906d268f18723be2df1ab0b in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=968ef74cd7 ] Revert "ARTEMIS-4630 Fix a typo in earlier commit 7ac6f4e99cc8349b378b4ae9d9ecc0970ac5b2b4" This reverts commit 306b192e80e0477c837e2dbfcefe555b2bfafe51. > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Fix For: 2.33.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814903#comment-17814903 ] ASF subversion and git services commented on ARTEMIS-4630: -- Commit 9bb19f6eb0a480abfb56879cfaa86c4f117c8c82 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=9bb19f6eb0 ] Revert "ARTEMIS-4630 Validate if the pid is really from Artemis" This reverts commit 7ac6f4e99cc8349b378b4ae9d9ecc0970ac5b2b4. > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Fix For: 2.33.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4637) Allow unordered xml conf elements for clusters and bridges
[ https://issues.apache.org/jira/browse/ARTEMIS-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814897#comment-17814897 ] ASF subversion and git services commented on ARTEMIS-4637: -- Commit c4c2a9e7182f41cf086eee27e619aea7afbc6ca7 in activemq-artemis's branch refs/heads/main from a181321 [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c4c2a9e718 ] ARTEMIS-4637 - Allow unordered xml conf elements for clusters and bridges > Allow unordered xml conf elements for clusters and bridges > -- > > Key: ARTEMIS-4637 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4637 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > This allows any order of xml configuration elements within cluster and > core-bridge config blocks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4637) Allow unordered xml conf elements for clusters and bridges
[ https://issues.apache.org/jira/browse/ARTEMIS-4637?focusedWorklogId=903915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903915 ] ASF GitHub Bot logged work on ARTEMIS-4637: --- Author: ASF GitHub Bot Created on: 06/Feb/24 16:59 Start Date: 06/Feb/24 16:59 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4810: URL: https://github.com/apache/activemq-artemis/pull/4810 Issue Time Tracking --- Worklog Id: (was: 903915) Time Spent: 0.5h (was: 20m) > Allow unordered xml conf elements for clusters and bridges > -- > > Key: ARTEMIS-4637 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4637 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > This allows any order of xml configuration elements within cluster and > core-bridge config blocks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4637) Allow unordered xml conf elements for clusters and bridges
[ https://issues.apache.org/jira/browse/ARTEMIS-4637?focusedWorklogId=903914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903914 ] ASF GitHub Bot logged work on ARTEMIS-4637: --- Author: ASF GitHub Bot Created on: 06/Feb/24 16:58 Start Date: 06/Feb/24 16:58 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4810: URL: https://github.com/apache/activemq-artemis/pull/4810#issuecomment-1930364154 this LGTM. Thanks a lot for this! Issue Time Tracking --- Worklog Id: (was: 903914) Time Spent: 20m (was: 10m) > Allow unordered xml conf elements for clusters and bridges > -- > > Key: ARTEMIS-4637 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4637 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > This allows any order of xml configuration elements within cluster and > core-bridge config blocks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?focusedWorklogId=903907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903907 ] ASF GitHub Bot logged work on ARTEMIS-4630: --- Author: ASF GitHub Bot Created on: 06/Feb/24 16:11 Start Date: 06/Feb/24 16:11 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4811: URL: https://github.com/apache/activemq-artemis/pull/4811#issuecomment-1930180134 (I actually only cherry-picked the second commit earlier, I thought the first was the same as yesterdays.) Reverting seems reasonable based on what you just said. FWIW past 'check the process' stuff I have seen tended to just add something as a marker to the command run originally, so it could be looked for later. Issue Time Tracking --- Worklog Id: (was: 903907) Time Spent: 1h 50m (was: 1h 40m) > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Fix For: 2.33.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?focusedWorklogId=903897=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903897 ] ASF GitHub Bot logged work on ARTEMIS-4630: --- Author: ASF GitHub Bot Created on: 06/Feb/24 15:27 Start Date: 06/Feb/24 15:27 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4811: URL: https://github.com/apache/activemq-artemis/pull/4811#issuecomment-1930048938 After further investigation I don't think this solution is valid. The problem is that `lsof -a -d cwd -p ` will report the directory from which the `artemis-service` script _was executed_. However, this script can be invoked from *any* directory. Therefore, it's very easy to break the script with this change such that it actually starts the broker but reports that it didn't and then continues to report the wrong status. I will revert these commits soon. Issue Time Tracking --- Worklog Id: (was: 903897) Time Spent: 1h 40m (was: 1.5h) > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Fix For: 2.33.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved ARTEMIS-4630. - Fix Version/s: 2.33.0 Resolution: Fixed > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Fix For: 2.33.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?focusedWorklogId=903852=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903852 ] ASF GitHub Bot logged work on ARTEMIS-4630: --- Author: ASF GitHub Bot Created on: 06/Feb/24 13:33 Start Date: 06/Feb/24 13:33 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4811: URL: https://github.com/apache/activemq-artemis/pull/4811#issuecomment-1929623659 I cherry-picked the fix and pushed it since the PR had conflicts. Issue Time Tracking --- Worklog Id: (was: 903852) Time Spent: 1.5h (was: 1h 20m) > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?focusedWorklogId=903851=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903851 ] ASF GitHub Bot logged work on ARTEMIS-4630: --- Author: ASF GitHub Bot Created on: 06/Feb/24 13:29 Start Date: 06/Feb/24 13:29 Worklog Time Spent: 10m Work Description: asfgit closed pull request #4811: ARTEMIS-4630 Validate if the pid is really from Artemis URL: https://github.com/apache/activemq-artemis/pull/4811 Issue Time Tracking --- Worklog Id: (was: 903851) Time Spent: 1h 20m (was: 1h 10m) > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814806#comment-17814806 ] ASF subversion and git services commented on ARTEMIS-4630: -- Commit 306b192e80e0477c837e2dbfcefe555b2bfafe51 in activemq-artemis's branch refs/heads/main from Ângelo Galvão [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=306b192e80 ] ARTEMIS-4630 Fix a typo in earlier commit 7ac6f4e99cc8349b378b4ae9d9ecc0970ac5b2b4 This closes #4811 > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4592) Detect possible dependency updates
[ https://issues.apache.org/jira/browse/ARTEMIS-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814802#comment-17814802 ] ASF subversion and git services commented on ARTEMIS-4592: -- Commit 6c251eaa782fb27f7b5e20ac1a46ec55453eb7e5 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=6c251eaa78 ] ARTEMIS-4592 ignore more currently-invalid potential upgrades > Detect possible dependency updates > -- > > Key: ARTEMIS-4592 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4592 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The [Versions Maven > Plugin|https://www.mojohaus.org/versions/versions-maven-plugin/index.html] is > a useful plugin for discovering dependencies that can be upgraded. One can > generate a report about what upgrades are possible simply by using: > {noformat} > mvn versions:display-dependency-updates{noformat} > The plugin also supports exclusions so we can ignore irrelevant or invalid > upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4592) Detect possible dependency updates
[ https://issues.apache.org/jira/browse/ARTEMIS-4592?focusedWorklogId=903848=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903848 ] ASF GitHub Bot logged work on ARTEMIS-4592: --- Author: ASF GitHub Bot Created on: 06/Feb/24 13:23 Start Date: 06/Feb/24 13:23 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4803: URL: https://github.com/apache/activemq-artemis/pull/4803 Issue Time Tracking --- Worklog Id: (was: 903848) Time Spent: 0.5h (was: 20m) > Detect possible dependency updates > -- > > Key: ARTEMIS-4592 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4592 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The [Versions Maven > Plugin|https://www.mojohaus.org/versions/versions-maven-plugin/index.html] is > a useful plugin for discovering dependencies that can be upgraded. One can > generate a report about what upgrades are possible simply by using: > {noformat} > mvn versions:display-dependency-updates{noformat} > The plugin also supports exclusions so we can ignore irrelevant or invalid > upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4586) Auto reload web binding SSL stores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4586?focusedWorklogId=903846=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903846 ] ASF GitHub Bot logged work on ARTEMIS-4586: --- Author: ASF GitHub Bot Created on: 06/Feb/24 13:21 Start Date: 06/Feb/24 13:21 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4760: URL: https://github.com/apache/activemq-artemis/pull/4760#discussion_r1479757997 ## docs/user-manual/web-server.adoc: ## @@ -43,6 +43,8 @@ The minimum number of threads the embedded web server will hold to service HTTP Default is `8` or the value of `maxThreads` if it is lower. idleThreadTimeout:: The time to wait before terminating an idle thread from the embedded web server. Measured in milliseconds. Default is `6`. +scanPeriod:: +How often to scan for file changes. Measured in seconds. Default is `5`. Review Comment: Think this could be clearer. The TLS reload it only happens if the other setting is enabled, which it isnt by default, but this reads like scanning is always happening...though it doesnt say what is being scanned. I think its likely to be interpreted as being other files to do with the web stuff, so I think it needs spelled out here if TLS reload is all this setting currently governs, and also mention to the other config option given the 2 are documented so far apart yet it is really the other setting that is more important (and the other setting does reference this one). ## artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java: ## @@ -258,6 +277,10 @@ private ServerConnector createServerConnector(HttpConfiguration httpConfiguratio } } } + if (binding.getSslAutoReload() != null && binding.getSslAutoReload() == true) { Review Comment: Perhaps replace the 2 checks with simply Boolean.TRUE.equals(binding.getSslAutoReload()) ? Issue Time Tracking --- Worklog Id: (was: 903846) Time Spent: 20m (was: 10m) > Auto reload web binding SSL stores on change > > > Key: ARTEMIS-4586 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4586 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Add the web binding attribute `sslAutoReload` to enable auto reload of the > SSL stores related to a binding when they are updated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4630) AMQ Service status is not validating if the pid is from Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-4630?focusedWorklogId=903821=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903821 ] ASF GitHub Bot logged work on ARTEMIS-4630: --- Author: ASF GitHub Bot Created on: 06/Feb/24 11:42 Start Date: 06/Feb/24 11:42 Worklog Time Spent: 10m Work Description: angelogalvao opened a new pull request, #4811: URL: https://github.com/apache/activemq-artemis/pull/4811 Fix a typo in the orignial commit. In rare cases the status is returning 'running' to a process that is not Artemis. It was create a extra level of verification by validating if the running process working directory is the same of ${ARTEMIS_INSTANCE}. Issue Time Tracking --- Worklog Id: (was: 903821) Time Spent: 1h 10m (was: 1h) > AMQ Service status is not validating if the pid is from Artemis > --- > > Key: ARTEMIS-4630 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4630 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Configuration >Affects Versions: 2.32.0 >Reporter: Angelo Galvão >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > In a rare condition, an old artemis.pid file is pointing to an existing > process that is not Artemis, causing the provisioning tools to believe that > Artemis process is running. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4637) Allow unordered xml conf elements for clusters and bridges
[ https://issues.apache.org/jira/browse/ARTEMIS-4637?focusedWorklogId=903800=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903800 ] ASF GitHub Bot logged work on ARTEMIS-4637: --- Author: ASF GitHub Bot Created on: 06/Feb/24 09:36 Start Date: 06/Feb/24 09:36 Worklog Time Spent: 10m Work Description: AntonRoskvist opened a new pull request, #4810: URL: https://github.com/apache/activemq-artemis/pull/4810 …dges I hope this change makes sense as it's a little bit outside of my comfort zone... it's purpose is to fix a minor annoyance of mine and something Ive seen confuse some other users as well, where moving or adding a configuration element in the wrong place causes the config to be invalidated. A side effect of this change is that the cluster property/attribute `allow-direct-connections-only` in `static-connectors` would pass validation even on core-bridges... setting this property has no effect on the core-bridges either way so I'm hoping it's not a cause for concern. I made it that way to have current configurations validate as before this change instead if adding it as a separate element within the cluster config or similar. Ideas on how to make this better if it's an issue are welcome. Ideally this would apply to all configuration at some point but I believe that would require moving to xsd version 1.1 which is not scoped in this change. Issue Time Tracking --- Worklog Id: (was: 903800) Remaining Estimate: 0h Time Spent: 10m > Allow unordered xml conf elements for clusters and bridges > -- > > Key: ARTEMIS-4637 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4637 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Anton Roskvist >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > This allows any order of xml configuration elements within cluster and > core-bridge config blocks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4637) Allow unordered xml conf elements for clusters and bridges
Anton Roskvist created ARTEMIS-4637: --- Summary: Allow unordered xml conf elements for clusters and bridges Key: ARTEMIS-4637 URL: https://issues.apache.org/jira/browse/ARTEMIS-4637 Project: ActiveMQ Artemis Issue Type: Improvement Reporter: Anton Roskvist This allows any order of xml configuration elements within cluster and core-bridge config blocks -- This message was sent by Atlassian Jira (v8.20.10#820010)