[jira] [Work logged] (ARTEMIS-4628) Upgrade vertx version to 4.5.3
[ https://issues.apache.org/jira/browse/ARTEMIS-4628?focusedWorklogId=904689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904689 ] ASF GitHub Bot logged work on ARTEMIS-4628: --- Author: ASF GitHub Bot Created on: 13/Feb/24 07:52 Start Date: 13/Feb/24 07:52 Worklog Time Spent: 10m Work Description: brusdev opened a new pull request, #4818: URL: https://github.com/apache/activemq-artemis/pull/4818 (no comment) Issue Time Tracking --- Worklog Id: (was: 904689) Time Spent: 0.5h (was: 20m) > Upgrade vertx version to 4.5.3 > -- > > Key: ARTEMIS-4628 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4628 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Fix For: 2.33.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4628) Upgrade vertx version to 4.5.3
[ https://issues.apache.org/jira/browse/ARTEMIS-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domenico Francesco Bruscino updated ARTEMIS-4628: - Summary: Upgrade vertx version to 4.5.3 (was: Upgrade vertx-proton test dep to 4.5.2) > Upgrade vertx version to 4.5.3 > -- > > Key: ARTEMIS-4628 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4628 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Fix For: 2.33.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (ARTEMIS-4628) Upgrade vertx-proton test dep to 4.5.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domenico Francesco Bruscino reopened ARTEMIS-4628: -- > Upgrade vertx-proton test dep to 4.5.2 > -- > > Key: ARTEMIS-4628 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4628 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Fix For: 2.33.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4641) Allow AMQP federation to recover from missing or removed resources
[ https://issues.apache.org/jira/browse/ARTEMIS-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved ARTEMIS-4641. - Resolution: Fixed > Allow AMQP federation to recover from missing or removed resources > -- > > Key: ARTEMIS-4641 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4641 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: AMQP >Affects Versions: 2.32.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.33.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When an AMQP federation instance attempts to federate an address or queue it > can fail if the remote address or queue is not present or cannot be created > based on broker policy. A federation link can also closed if the federated > resource is removed from the remote broker by management etc. In those cases > the remote broker should note the resources that were targets of federation > and send alerts to the source federation broker to notify it that these > resources become available for federation and the source should attempt again > to create federation links if demand still exists. This allows an AMQP > federation instance to heal itself based on updates from the remote. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4641) Allow AMQP federation to recover from missing or removed resources
[ https://issues.apache.org/jira/browse/ARTEMIS-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816688#comment-17816688 ] ASF subversion and git services commented on ARTEMIS-4641: -- Commit 94b6c0ec6e47cf04a54e5a41c18618873bdae3b0 in activemq-artemis's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=94b6c0ec6e ] ARTEMIS-4641 Support events for add of missing federation resources When an AMQP federation instance attempts to federate an address or queue it can fail if the remote address or queue is not present or cannot be created based on broker policy. A federation link can also closed if the federated resource is removed from the remote broker by management etc. In those cases the remote broker should note the resources that were targets of federation and send alerts to the source federation broker to notify it that these resources become available for federation and the source should attempt again to create federation links if demand still exists. This allows an AMQP federation instance to heal itself based on updates from the remote. > Allow AMQP federation to recover from missing or removed resources > -- > > Key: ARTEMIS-4641 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4641 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: AMQP >Affects Versions: 2.32.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.33.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When an AMQP federation instance attempts to federate an address or queue it > can fail if the remote address or queue is not present or cannot be created > based on broker policy. A federation link can also closed if the federated > resource is removed from the remote broker by management etc. In those cases > the remote broker should note the resources that were targets of federation > and send alerts to the source federation broker to notify it that these > resources become available for federation and the source should attempt again > to create federation links if demand still exists. This allows an AMQP > federation instance to heal itself based on updates from the remote. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4641) Allow AMQP federation to recover from missing or removed resources
[ https://issues.apache.org/jira/browse/ARTEMIS-4641?focusedWorklogId=904627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904627 ] ASF GitHub Bot logged work on ARTEMIS-4641: --- Author: ASF GitHub Bot Created on: 12/Feb/24 17:54 Start Date: 12/Feb/24 17:54 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4817: URL: https://github.com/apache/activemq-artemis/pull/4817 Issue Time Tracking --- Worklog Id: (was: 904627) Time Spent: 50m (was: 40m) > Allow AMQP federation to recover from missing or removed resources > -- > > Key: ARTEMIS-4641 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4641 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: AMQP >Affects Versions: 2.32.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.33.0 > > Time Spent: 50m > Remaining Estimate: 0h > > When an AMQP federation instance attempts to federate an address or queue it > can fail if the remote address or queue is not present or cannot be created > based on broker policy. A federation link can also closed if the federated > resource is removed from the remote broker by management etc. In those cases > the remote broker should note the resources that were targets of federation > and send alerts to the source federation broker to notify it that these > resources become available for federation and the source should attempt again > to create federation links if demand still exists. This allows an AMQP > federation instance to heal itself based on updates from the remote. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4641) Allow AMQP federation to recover from missing or removed resources
[ https://issues.apache.org/jira/browse/ARTEMIS-4641?focusedWorklogId=904626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904626 ] ASF GitHub Bot logged work on ARTEMIS-4641: --- Author: ASF GitHub Bot Created on: 12/Feb/24 17:37 Start Date: 12/Feb/24 17:37 Worklog Time Spent: 10m Work Description: tabish121 commented on PR #4817: URL: https://github.com/apache/activemq-artemis/pull/4817#issuecomment-1939215599 Made the cleanups requested and rebased. Ran all AMQP federation tests again and all passed. Issue Time Tracking --- Worklog Id: (was: 904626) Time Spent: 40m (was: 0.5h) > Allow AMQP federation to recover from missing or removed resources > -- > > Key: ARTEMIS-4641 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4641 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: AMQP >Affects Versions: 2.32.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.33.0 > > Time Spent: 40m > Remaining Estimate: 0h > > When an AMQP federation instance attempts to federate an address or queue it > can fail if the remote address or queue is not present or cannot be created > based on broker policy. A federation link can also closed if the federated > resource is removed from the remote broker by management etc. In those cases > the remote broker should note the resources that were targets of federation > and send alerts to the source federation broker to notify it that these > resources become available for federation and the source should attempt again > to create federation links if demand still exists. This allows an AMQP > federation instance to heal itself based on updates from the remote. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4641) Allow AMQP federation to recover from missing or removed resources
[
https://issues.apache.org/jira/browse/ARTEMIS-4641?focusedWorklogId=904622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904622
]
ASF GitHub Bot logged work on ARTEMIS-4641:
---
Author: ASF GitHub Bot
Created on: 12/Feb/24 16:59
Start Date: 12/Feb/24 16:59
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4817:
URL: https://github.com/apache/activemq-artemis/pull/4817#discussion_r1486082922
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java:
##
@@ -294,14 +315,232 @@ protected boolean interceptLinkClosedEvent(Link link) {
return false;
}
+ private void asyncCreateTargetEventsSender(AMQPFederationCommandDispatcher
commandLink) {
+ // If no remote policies configured then we don't need an events sender
link
+ // currently, if some other use is added for this link this code must be
+ // removed and tests updated to expect this link to always be created.
+ if (remoteAddressMatchPolicies.isEmpty() &&
remoteQueueMatchPolicies.isEmpty()) {
+ return;
+ }
+
+ // Schedule the outgoing event link creation on the connection event
loop thread.
+ //
+ // Eventual establishment of the outgoing events link or refusal informs
this side
+ // of the connection as to whether the remote side supports receiving
events for
+ // resources that it attempted to federate but they did not exist at the
time and
+ // were subsequently added or for resources that might have been later
removed via
+ // management and then subsequently re-added.
+ //
+ // Once the outcome of the event link is known then send any remote
address or queue
+ // federation policies so that the remote can start federation of local
addresses or
+ // queues to itself. This ordering prevents and race on creation of the
events link
+ // and any federation consumer creation from the remote.
+ connection.runLater(() -> {
+ if (!isStarted()) {
+return;
+ }
+
+ try {
+final Sender sender = session.getSession().sender(
+ "Federation-events-sender:" + getName() + ":" +
UUIDGenerator.getInstance().generateStringUUID());
+final Target target = new Target();
+final Source source = new Source();
+
+target.setDynamic(true);
+target.setCapabilities(new Symbol[]
{Symbol.valueOf("temporary-topic")});
Review Comment:
AmqpSupport.TEMP_TOPIC_CAPABILITY
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java:
##
@@ -294,14 +315,232 @@ protected boolean interceptLinkClosedEvent(Link link) {
return false;
}
+ private void asyncCreateTargetEventsSender(AMQPFederationCommandDispatcher
commandLink) {
+ // If no remote policies configured then we don't need an events sender
link
+ // currently, if some other use is added for this link this code must be
+ // removed and tests updated to expect this link to always be created.
+ if (remoteAddressMatchPolicies.isEmpty() &&
remoteQueueMatchPolicies.isEmpty()) {
+ return;
+ }
+
+ // Schedule the outgoing event link creation on the connection event
loop thread.
+ //
+ // Eventual establishment of the outgoing events link or refusal informs
this side
+ // of the connection as to whether the remote side supports receiving
events for
+ // resources that it attempted to federate but they did not exist at the
time and
+ // were subsequently added or for resources that might have been later
removed via
+ // management and then subsequently re-added.
+ //
+ // Once the outcome of the event link is known then send any remote
address or queue
+ // federation policies so that the remote can start federation of local
addresses or
+ // queues to itself. This ordering prevents and race on creation of the
events link
+ // and any federation consumer creation from the remote.
+ connection.runLater(() -> {
+ if (!isStarted()) {
+return;
+ }
+
+ try {
+final Sender sender = session.getSession().sender(
+ "Federation-events-sender:" + getName() + ":" +
UUIDGenerator.getInstance().generateStringUUID());
+final Target target = new Target();
+final Source source = new Source();
+
+target.setDynamic(true);
+target.setCapabilities(new Symbol[]
{Symbol.valueOf("temporary-topic")});
+target.setDurable(TerminusDurability.NONE);
+target.setExpiryPolicy(TerminusExpiryPolicy.LINK_DETACH);
+// Set th
[jira] [Updated] (AMQ-9434) Unable to start ActiveMQ on Linux when there is space in the folder path
[
https://issues.apache.org/jira/browse/AMQ-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liviu Carausu updated AMQ-9434:
---
Description:
When installed in a folder containing a space, the broker cannot start on a
Linux system.
On Windows it works.
{noformat}
~/data/programs/apache-activemq 5.18.3/bin> ./activemq start
INFO: Using default configuration
Configurations are loaded in the following order: /etc/default/activemq
/home/johndoe/.activemqrc /home/johndoe/data/programs/apache-activemq
5.18.3//bin/env
INFO: Using java '/home/johndoe/data/programs/java/jdk-11.0.17+8//bin/java'
./activemq: line 492: [: /home/johndoe/data/programs/apache-activemq: binary
operator expected
INFO: Starting - inspect logfiles specified in logging.properties and
log4j2.properties to get details
{noformat}
was:
When installed in a folder containing a space, the broker cannot start on a
Linux system.
On Windows it works.
{noformat}
~/data/programs/apache-activemq 5.18.3/bin> ./activemq start
INFO: Using default configuration
Configurations are loaded in the following order: /etc/default/activemq
/home/johndoe/.activemqrc /home/johndoe/data/programs/apache-activemq
5.18.3//bin/env
INFO: Using java '/home/johndoe/data/programs/java/jdk-11.0.17+8//bin/java'
./activemq: line 492: [: /home/johndoe/data/programs/apache-activemq: binary
operator expected
INFO: Starting - inspect logfiles specified in logging.properties and
log4j2.properties to get details
{noformat}
> Unable to start ActiveMQ on Linux when there is space in the folder path
>
>
> Key: AMQ-9434
> URL: https://issues.apache.org/jira/browse/AMQ-9434
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
>Affects Versions: 5.18.3, 5.17.6
> Environment: OpenSuse 15.5
> jdk-11.0.17+8
>Reporter: Liviu Carausu
>Priority: Major
>
> When installed in a folder containing a space, the broker cannot start on a
> Linux system.
> On Windows it works.
> {noformat}
> ~/data/programs/apache-activemq 5.18.3/bin> ./activemq start
> INFO: Using default configuration
> Configurations are loaded in the following order: /etc/default/activemq
> /home/johndoe/.activemqrc /home/johndoe/data/programs/apache-activemq
> 5.18.3//bin/env
> INFO: Using java '/home/johndoe/data/programs/java/jdk-11.0.17+8//bin/java'
> ./activemq: line 492: [: /home/johndoe/data/programs/apache-activemq: binary
> operator expected
> INFO: Starting - inspect logfiles specified in logging.properties and
> log4j2.properties to get details
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (AMQ-9434) Unable to start ActiveMQ on Linux when there is space in the folder path
Liviu Carausu created AMQ-9434:
--
Summary: Unable to start ActiveMQ on Linux when there is space in
the folder path
Key: AMQ-9434
URL: https://issues.apache.org/jira/browse/AMQ-9434
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Affects Versions: 5.17.6, 5.18.3
Environment: OpenSuse 15.5
jdk-11.0.17+8
Reporter: Liviu Carausu
When installed in a folder containing a space, the broker cannot start on a
Linux system.
On Windows it works.
{noformat}
~/data/programs/apache-activemq 5.18.3/bin> ./activemq start
INFO: Using default configuration
Configurations are loaded in the following order: /etc/default/activemq
/home/johndoe/.activemqrc /home/johndoe/data/programs/apache-activemq
5.18.3//bin/env
INFO: Using java '/home/johndoe/data/programs/java/jdk-11.0.17+8//bin/java'
./activemq: line 492: [: /home/johndoe/data/programs/apache-activemq: binary
operator expected
INFO: Starting - inspect logfiles specified in logging.properties and
log4j2.properties to get details
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4586) Auto reload web binding SSL stores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domenico Francesco Bruscino resolved ARTEMIS-4586. -- Fix Version/s: 2.33.0 Resolution: Fixed > Auto reload web binding SSL stores on change > > > Key: ARTEMIS-4586 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4586 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Fix For: 2.33.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Add the web binding attribute `sslAutoReload` to enable auto reload of the > SSL stores related to a binding when they are updated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
