[jira] [Work logged] (ARTEMIS-4675) Add replication status metrics

2024-03-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4675?focusedWorklogId=911665=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911665
 ]

ASF GitHub Bot logged work on ARTEMIS-4675:
---

Author: ASF GitHub Bot
Created on: 26/Mar/24 18:29
Start Date: 26/Mar/24 18:29
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4844:
URL: 
https://github.com/apache/activemq-artemis/pull/4844#issuecomment-2021186434

   > With the current state of this PR the synchronizing is returning 0 and the 
replica sync is returning 1.
   
   I see the replica sync metric, but I don't see the "synchronizing" metric 
you're referring to. Can you clarify which metrics you're inspecting?
   
   The replica sync metric indicates whether the initial synchronization has 
completed. Once the initial synchronization is done the primary is guaranteed 
to be in sync with the backup unless the replication connection between the 
brokers fails for some reason. It's not clear to me at this point if the 
replication manager actually exposes metrics to track the current status 
properly.




Issue Time Tracking
---

Worklog Id: (was: 911665)
Time Spent: 1h  (was: 50m)

> Add replication status metrics
> --
>
> Key: ARTEMIS-4675
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4675
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Clustering
>Affects Versions: 2.32.0
>Reporter: Alvin Kwekel
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Add metrics to be able to monitor the cluster replication status.
> Somewhat related to feature request ARTEMIS-4479.
> I've created a PR for this: 
> https://github.com/apache/activemq-artemis/pull/4844



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4701) Update to Netty 4.1.108

2024-03-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4701?focusedWorklogId=911652=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911652
 ]

ASF GitHub Bot logged work on ARTEMIS-4701:
---

Author: ASF GitHub Bot
Created on: 26/Mar/24 17:33
Start Date: 26/Mar/24 17:33
Worklog Time Spent: 10m 
  Work Description: brusdev merged PR #4866:
URL: https://github.com/apache/activemq-artemis/pull/4866




Issue Time Tracking
---

Worklog Id: (was: 911652)
Time Spent: 0.5h  (was: 20m)

> Update to Netty 4.1.108
> ---
>
> Key: ARTEMIS-4701
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4701
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-4701) Update to Netty 4.1.108

2024-03-26 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831018#comment-17831018
 ] 

ASF subversion and git services commented on ARTEMIS-4701:
--

Commit 19d77011de953ead80f17a6628280054d08f3363 in activemq-artemis's branch 
refs/heads/main from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=19d77011de ]

ARTEMIS-4701: update to Netty 4.1.108 (and netty-tcnative test dep to 2.0.65)


> Update to Netty 4.1.108
> ---
>
> Key: ARTEMIS-4701
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4701
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4701) Update to Netty 4.1.108

2024-03-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4701?focusedWorklogId=911638=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911638
 ]

ASF GitHub Bot logged work on ARTEMIS-4701:
---

Author: ASF GitHub Bot
Created on: 26/Mar/24 16:45
Start Date: 26/Mar/24 16:45
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #4866:
URL: 
https://github.com/apache/activemq-artemis/pull/4866#issuecomment-2020962266

   Ran the full build+tests, passed.




Issue Time Tracking
---

Worklog Id: (was: 911638)
Time Spent: 20m  (was: 10m)

> Update to Netty 4.1.108
> ---
>
> Key: ARTEMIS-4701
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4701
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4701) Update to Netty 4.1.108

2024-03-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4701?focusedWorklogId=911637=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911637
 ]

ASF GitHub Bot logged work on ARTEMIS-4701:
---

Author: ASF GitHub Bot
Created on: 26/Mar/24 16:45
Start Date: 26/Mar/24 16:45
Worklog Time Spent: 10m 
  Work Description: gemmellr opened a new pull request, #4866:
URL: https://github.com/apache/activemq-artemis/pull/4866

   ARTEMIS-4701: update to Netty 4.1.108 (and netty-tcnative test dep to 2.0.65)




Issue Time Tracking
---

Worklog Id: (was: 911637)
Remaining Estimate: 0h
Time Spent: 10m

> Update to Netty 4.1.108
> ---
>
> Key: ARTEMIS-4701
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4701
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>Reporter: Robbie Gemmell
>Priority: Major
> Fix For: 2.34.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

2024-03-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=911635=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911635
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 26/Mar/24 16:32
Start Date: 26/Mar/24 16:32
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #3:
URL: 
https://github.com/apache/activemq-artemis-console-plugin/pull/3#discussion_r1539396574


##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).

Review Comment:
   ActiveMQ again. Would probably add a link to the website.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin

Review Comment:
   ActiveMQ rather than Activemq. I'd probably go with Apache ActiveMQ.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The War file created by this project is consumed by ActiveMQ-Artemis but can 
be developled and run standalone.

Review Comment:
   WAR rather than War. ActiveMQ Artemis rather than ActiveMQ-Artemis.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The War file created by this project is consumed by ActiveMQ-Artemis but can 
be developled and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project can take time, so if you build it once and make 
no changes on the project afterwards, you 
+can speed up the whole build by skipping the frontend part next time.
+
+```console
+mvn install -Dskip.yarn
+```
+
+### Test run
+
+You can quickly run and test the console by using `jetty-maven-plugin` 
configured in `pom.xml`. It launches an embedded 
+Jetty server and deploy the plugin WAR application, as well as the main 
`hawtio.war`.
+
+```console
+mvn jetty:run -Dskip.yarn
+```
+
+You can access the Artemis console with the sample plugin at: 

+
+## Faster plugin development
+
+You could run `mvn install` or `mvn jetty:run` every time to incrementally 
develop the `activemq-artemis-console-plugin` 
+frontend project while checking its behaviour in the browser. But this is not 
suitable for running the fast development feedback cycle.
+
+As shown below, a faster development cycle can be achieved by directly running 
the `activemq-artemis-console-plugin` 
+frontend project itself in development mode with `yarn start`,
+
+### Development
+Start the plugin project in development mode:
+
+```console
+cd artemis-plugin
+yarn start
+```
+
+Now you should be able to preview the plugins under development at 
. However, since it still 
+hasn't been connected to a backend JVM, You can then connect to a running 
Artemis instance using the connect tab using for 

Review Comment:
   "You" shouldn't be capitalised.



##
README.md:
##
@@ -1 +1,61 @@
-# activemq-artemis-console-plugin
+# Activemq Artemis Console Plugin
+
+
+The Activemq Artemis Console Plugin is written using [Hawtio 
v4](https://github.com/hawtio/hawtio).
+The plugin is written in TypeScript. Since a Hawtio plugin is based on React 
and [Webpack Module Federation](https://module-federation.github.io/),
+this project uses Yarn v3 and [CRACO](https://craco.js.org/) as the build 
tools.
+
+The War file created by this project is consumed by ActiveMQ-Artemis but can 
be developled and run standalone.
+
+
+### Build
+
+The following command first builds the `activemq-artemis-console-plugin` 
frontend project and then compiles and packages 
+the main Java project together.
+
+```console
+mvn clean install
+```
+
+Building the frontend project can take time, so if you build it once and make 
no changes on the project afterwards, you 
+can speed up the whole build by skipping

[jira] [Commented] (ARTEMIS-4700) Support address-level disk limit

2024-03-26 Thread Justin Bertram (Jira) 


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830991#comment-17830991
 ] 

Justin Bertram commented on ARTEMIS-4700:
-

[~subhidh], yes, I believe it is. Thanks for the heads-up!

> Support address-level disk limit
> 
>
> Key: ARTEMIS-4700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4700
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Priority: Major
>
> Currently ActiveMQ Artemis only restricts normal messages from paging at the 
> address level using {{page-limit-bytes}}, and whenever any address exceeds 
> this limit we are able to block producers from sending messages to the 
> address by setting the {{page-full-policy}} to {{FAIL}}. 
> However, this {{page-limit-bytes}} does not cover the {{large-messages}} 
> directory in the {{data}} directory due to which there is no track for large 
> messages. If any consumer for a queue is down for sometime for which large 
> messages are being sent, the storage is getting full impacting other 
> customers hosted in the broker. Ideally it should only impact the particular 
> tenant. 
> We have {{max-disk-usage}} in place, but it's at global level and impacting 
> other customers if disk usage is beyond this limit. Could you please check if 
> there is any parameter to restrict large messages. We tested and seems the 
> destination parameter "Persistent Size" is the sum of the disk used by 
> paging, large messages, journals and bindings, but I don't see any 
> restriction based on this parameter. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (ARTEMIS-4700) Support address-level disk limit

2024-03-26 Thread Justin Bertram (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-4700.
-
Resolution: Duplicate

> Support address-level disk limit
> 
>
> Key: ARTEMIS-4700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4700
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Priority: Major
>
> Currently ActiveMQ Artemis only restricts normal messages from paging at the 
> address level using {{page-limit-bytes}}, and whenever any address exceeds 
> this limit we are able to block producers from sending messages to the 
> address by setting the {{page-full-policy}} to {{FAIL}}. 
> However, this {{page-limit-bytes}} does not cover the {{large-messages}} 
> directory in the {{data}} directory due to which there is no track for large 
> messages. If any consumer for a queue is down for sometime for which large 
> messages are being sent, the storage is getting full impacting other 
> customers hosted in the broker. Ideally it should only impact the particular 
> tenant. 
> We have {{max-disk-usage}} in place, but it's at global level and impacting 
> other customers if disk usage is beyond this limit. Could you please check if 
> there is any parameter to restrict large messages. We tested and seems the 
> destination parameter "Persistent Size" is the sum of the disk used by 
> paging, large messages, journals and bindings, but I don't see any 
> restriction based on this parameter. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ARTEMIS-4701) Update to Netty 4.1.108

2024-03-26 Thread Robbie Gemmell (Jira) 
Robbie Gemmell created ARTEMIS-4701:
---

 Summary: Update to Netty 4.1.108
 Key: ARTEMIS-4701
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4701
 Project: ActiveMQ Artemis
  Issue Type: Dependency upgrade
Reporter: Robbie Gemmell
 Fix For: 2.34.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-4700) Support address-level disk limit

2024-03-26 Thread Subhidh Agarwal (Jira) 


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830986#comment-17830986
 ] 

Subhidh Agarwal commented on ARTEMIS-4700:
--

Duplicate of [ARTEMIS-4562|https://issues.apache.org/jira/browse/ARTEMIS-4562]?

> Support address-level disk limit
> 
>
> Key: ARTEMIS-4700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4700
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Priority: Major
>
> Currently ActiveMQ Artemis only restricts normal messages from paging at the 
> address level using {{page-limit-bytes}}, and whenever any address exceeds 
> this limit we are able to block producers from sending messages to the 
> address by setting the {{page-full-policy}} to {{FAIL}}. 
> However, this {{page-limit-bytes}} does not cover the {{large-messages}} 
> directory in the {{data}} directory due to which there is no track for large 
> messages. If any consumer for a queue is down for sometime for which large 
> messages are being sent, the storage is getting full impacting other 
> customers hosted in the broker. Ideally it should only impact the particular 
> tenant. 
> We have {{max-disk-usage}} in place, but it's at global level and impacting 
> other customers if disk usage is beyond this limit. Could you please check if 
> there is any parameter to restrict large messages. We tested and seems the 
> destination parameter "Persistent Size" is the sum of the disk used by 
> paging, large messages, journals and bindings, but I don't see any 
> restriction based on this parameter. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ARTEMIS-4562) Limit messages per queue based on size/count

2024-03-26 Thread Subhidh Agarwal (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Subhidh Agarwal updated ARTEMIS-4562:
-
Summary: Limit messages per queue based on size/count  (was: Limit large 
messages per queue based on size/count)

> Limit messages per queue based on size/count
> 
>
> Key: ARTEMIS-4562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4562
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Subhidh Agarwal
>Priority: Major
>
> I need to limit the number of large messages per queue by message size & 
> count just like paged messages are limited by {{page-limit-bytes}} & 
> {{page-limit-messages}} respectively.
> Why is it required? If a consumer is down for some queue(s), or not picking 
> up large messages, the {{max-disk-usage}} will be reached, impacting the 
> whole broker. Having a limit per queue for large-messages will prevent a 
> single queue from filling the disk. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (ARTEMIS-4700) Support address-level disk limit

2024-03-26 Thread Justin Bertram (Jira) 
Justin Bertram created ARTEMIS-4700:
---

 Summary: Support address-level disk limit
 Key: ARTEMIS-4700
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4700
 Project: ActiveMQ Artemis
  Issue Type: New Feature
Reporter: Justin Bertram


Currently ActiveMQ Artemis only restricts normal messages from paging at the 
address level using {{page-limit-bytes}}, and whenever any address exceeds this 
limit we are able to block producers from sending messages to the address by 
setting the {{page-full-policy}} to {{FAIL}}. 

However, this {{page-limit-bytes}} does not cover the {{large-messages}} 
directory in the {{data}} directory due to which there is no track for large 
messages. If any consumer for a queue is down for sometime for which large 
messages are being sent, the storage is getting full impacting other customers 
hosted in the broker. Ideally it should only impact the particular tenant. 

We have {{max-disk-usage}} in place, but it's at global level and impacting 
other customers if disk usage is beyond this limit. Could you please check if 
there is any parameter to restrict large messages. We tested and seems the 
destination parameter "Persistent Size" is the sum of the disk used by paging, 
large messages, journals and bindings, but I don't see any restriction based on 
this parameter. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (ARTEMIS-4700) Support address-level disk limit

2024-03-26 Thread Justin Bertram (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-4700:

External issue ID: 
https://stackoverflow.com/questions/78223265/restrict-large-messages-to-activemq-artemis

> Support address-level disk limit
> 
>
> Key: ARTEMIS-4700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4700
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Priority: Major
>
> Currently ActiveMQ Artemis only restricts normal messages from paging at the 
> address level using {{page-limit-bytes}}, and whenever any address exceeds 
> this limit we are able to block producers from sending messages to the 
> address by setting the {{page-full-policy}} to {{FAIL}}. 
> However, this {{page-limit-bytes}} does not cover the {{large-messages}} 
> directory in the {{data}} directory due to which there is no track for large 
> messages. If any consumer for a queue is down for sometime for which large 
> messages are being sent, the storage is getting full impacting other 
> customers hosted in the broker. Ideally it should only impact the particular 
> tenant. 
> We have {{max-disk-usage}} in place, but it's at global level and impacting 
> other customers if disk usage is beyond this limit. Could you please check if 
> there is any parameter to restrict large messages. We tested and seems the 
> destination parameter "Persistent Size" is the sum of the disk used by 
> paging, large messages, journals and bindings, but I don't see any 
> restriction based on this parameter. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4

2024-03-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=911584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911584
 ]

ASF GitHub Bot logged work on ARTEMIS-4680:
---

Author: ASF GitHub Bot
Created on: 26/Mar/24 13:48
Start Date: 26/Mar/24 13:48
Worklog Time Spent: 10m 
  Work Description: andytaylor opened a new pull request, #3:
URL: https://github.com/apache/activemq-artemis-console-plugin/pull/3

   https://issues.apache.org/jira/browse/ARTEMIS-4680




Issue Time Tracking
---

Worklog Id: (was: 911584)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on 
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>  
> This improvement is to migrate the current console to use HawtIO 4 which i 
> based on Typescript, react and Patternfly.
>  
> A WIP can be found 
> [here|https://github.com/andytaylor/activemq-artemis/tree/artemis-console-ng]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)