[jira] [Updated] (AMQ-9502) Unable to upgrade activemq from 5.11.2 to 5.12.0
[
https://issues.apache.org/jira/browse/AMQ-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sowjanya updated AMQ-9502:
--
Priority: Critical (was: Major)
> Unable to upgrade activemq from 5.11.2 to 5.12.0
>
>
> Key: AMQ-9502
> URL: https://issues.apache.org/jira/browse/AMQ-9502
> Project: ActiveMQ Classic
> Issue Type: Bug
>Reporter: sowjanya
>Priority: Critical
>
> We are trying to upgrade from activemq 5.11.2 to 5.12.0, New version of
> activemq is being reflected but unfortunately not able to access any module
> in our application, Below are the logs we saw.
> {code:java}
> 2024-05-09 09:12:15,549 WARN [com.adtran.mvc.view.ViewJSONServiceImpl] JSON
> View failed due to com.adtran.common.services.Ser
> viceSpecificException: 'java.lang.NoSuchMethodError:
> org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String
> ;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V' {code}
> Can you please help in sorting out this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9502) Unable to upgrade activemq from 5.11.2 to 5.12.0
[
https://issues.apache.org/jira/browse/AMQ-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sowjanya updated AMQ-9502:
--
Description:
We are trying to upgrade from activemq 5.11.2 to 5.12.0, New version of
activemq is being reflected but unfortunately not able to access any module in
our application, Below are the logs we are getting.
{code:java}
2024-05-09 09:12:15,549 WARN [com.adtran.mvc.view.ViewJSONServiceImpl] JSON
View failed due to com.adtran.common.services.Ser
viceSpecificException: 'java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String
;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V' {code}
Can you please help in sorting out this.
was:
We are trying to upgrade from activemq 5.11.2 to 5.12.0, New version of
activemq is being reflected but unfortunately not able to access any module in
our application, Below are the logs we saw.
{code:java}
2024-05-09 09:12:15,549 WARN [com.adtran.mvc.view.ViewJSONServiceImpl] JSON
View failed due to com.adtran.common.services.Ser
viceSpecificException: 'java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String
;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V' {code}
Can you please help in sorting out this.
> Unable to upgrade activemq from 5.11.2 to 5.12.0
>
>
> Key: AMQ-9502
> URL: https://issues.apache.org/jira/browse/AMQ-9502
> Project: ActiveMQ Classic
> Issue Type: Bug
>Reporter: sowjanya
>Priority: Critical
>
> We are trying to upgrade from activemq 5.11.2 to 5.12.0, New version of
> activemq is being reflected but unfortunately not able to access any module
> in our application, Below are the logs we are getting.
> {code:java}
> 2024-05-09 09:12:15,549 WARN [com.adtran.mvc.view.ViewJSONServiceImpl] JSON
> View failed due to com.adtran.common.services.Ser
> viceSpecificException: 'java.lang.NoSuchMethodError:
> org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String
> ;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V' {code}
> Can you please help in sorting out this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (AMQ-9502) Unable to upgrade activemq from 5.11.2 to 5.12.0
sowjanya created AMQ-9502:
-
Summary: Unable to upgrade activemq from 5.11.2 to 5.12.0
Key: AMQ-9502
URL: https://issues.apache.org/jira/browse/AMQ-9502
Project: ActiveMQ Classic
Issue Type: Bug
Reporter: sowjanya
We are trying to upgrade from activemq 5.11.2 to 5.12.0, New version of
activemq is being reflected but unfortunately not able to access any module in
our application, Below are the logs we saw.
{code:java}
2024-05-09 09:12:15,549 WARN [com.adtran.mvc.view.ViewJSONServiceImpl] JSON
View failed due to com.adtran.common.services.Ser
viceSpecificException: 'java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String
;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V' {code}
Can you please help in sorting out this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4765) Target Mirror is setting wrong size on duplicate cache
[ https://issues.apache.org/jira/browse/ARTEMIS-4765?focusedWorklogId=918589=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918589 ] ASF GitHub Bot logged work on ARTEMIS-4765: --- Author: ASF GitHub Bot Created on: 09/May/24 19:02 Start Date: 09/May/24 19:02 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4928: URL: https://github.com/apache/activemq-artemis/pull/4928 Issue Time Tracking --- Worklog Id: (was: 918589) Time Spent: 1h (was: 50m) > Target Mirror is setting wrong size on duplicate cache > -- > > Key: ARTEMIS-4765 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4765 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.33.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.34.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Duplicate cache on Mirror target is keeping 20_000 records, even if it's only > supposed to keep 1000 due to AMQP credits. > a Workaround is to set the addressSettings.#.iDCacheSize=1000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4765) Target Mirror is setting wrong size on duplicate cache
[ https://issues.apache.org/jira/browse/ARTEMIS-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845104#comment-17845104 ] ASF subversion and git services commented on ARTEMIS-4765: -- Commit cd563b49add3c046ae7b2400d9c5342016a21829 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=cd563b49ad ] ARTEMIS-4765 DuplicateIDCache on Mirror Target is using 20K elements instead of amqpCredits in this commit I'm storing a binding record with the address-settings for the correct size this is also validating eventual merges of the AddressSettings in the same namespace. > Target Mirror is setting wrong size on duplicate cache > -- > > Key: ARTEMIS-4765 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4765 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.33.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.34.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Duplicate cache on Mirror target is keeping 20_000 records, even if it's only > supposed to keep 1000 due to AMQP credits. > a Workaround is to set the addressSettings.#.iDCacheSize=1000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4759) Restore compatibility with LiveOnlyPolicyConfiguration
[
https://issues.apache.org/jira/browse/ARTEMIS-4759?focusedWorklogId=918582=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918582
]
ASF GitHub Bot logged work on ARTEMIS-4759:
---
Author: ASF GitHub Bot
Created on: 09/May/24 18:03
Start Date: 09/May/24 18:03
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #4922:
URL: https://github.com/apache/activemq-artemis/pull/4922
Issue Time Tracking
---
Worklog Id: (was: 918582)
Time Spent: 20m (was: 10m)
> Restore compatibility with LiveOnlyPolicyConfiguration
> --
>
> Key: ARTEMIS-4759
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4759
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> During the work for ARTEMIS-3474
> {{org.apache.activemq.artemis.core.config.ha.LiveOnlyPolicyConfiguration}}
> was deprecated for removal. However, one of the changes broke compatibility
> so that folks who were embedding the broker and using
> {{LiveOnlyPolicyConfiguration}} for their configuration started receiving a
> {{ClassCastException}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4759) Restore compatibility with LiveOnlyPolicyConfiguration
[
https://issues.apache.org/jira/browse/ARTEMIS-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845086#comment-17845086
]
ASF subversion and git services commented on ARTEMIS-4759:
--
Commit 2a43c53bb25c3115a23388db523abaa089e5ba3d in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=2a43c53bb2 ]
ARTEMIS-4759 restore compatibility with LiveOnlyPolicyConfiguration
> Restore compatibility with LiveOnlyPolicyConfiguration
> --
>
> Key: ARTEMIS-4759
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4759
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> During the work for ARTEMIS-3474
> {{org.apache.activemq.artemis.core.config.ha.LiveOnlyPolicyConfiguration}}
> was deprecated for removal. However, one of the changes broke compatibility
> so that folks who were embedding the broker and using
> {{LiveOnlyPolicyConfiguration}} for their configuration started receiving a
> {{ClassCastException}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4765) Target Mirror is setting wrong size on duplicate cache
[
https://issues.apache.org/jira/browse/ARTEMIS-4765?focusedWorklogId=918580=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918580
]
ASF GitHub Bot logged work on ARTEMIS-4765:
---
Author: ASF GitHub Bot
Created on: 09/May/24 17:30
Start Date: 09/May/24 17:30
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4928:
URL: https://github.com/apache/activemq-artemis/pull/4928#discussion_r1595763408
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##
@@ -1467,6 +1476,22 @@ public DuplicateIDCache getDuplicateIDCache(final
SimpleString address, int cach
return cache;
}
+ private void registerCacheSize(SimpleString address, int cacheSizeToUse) {
+ AbstractPersistedAddressSetting recordedSetting =
storageManager.recoverAddressSettings(address);
+ if (recordedSetting == null ||
recordedSetting.getSetting().getIDCacheSize() == null ||
recordedSetting.getSetting().getIDCacheSize().intValue() != cacheSizeToUse) {
+ AddressSettings settings = recordedSetting != null ?
recordedSetting.getSetting() : new AddressSettings();
+ settings.setIDCacheSize(cacheSizeToUse);
+ server.getAddressSettingsRepository().addMatch(address.toString(),
settings);
+ try {
+storageManager.storeAddressSetting(new
PersistedAddressSettingJSON(address, settings, settings.toJSON()));
+ } catch (Exception e) {
+// nothing could be done here, we just log
+// if an exception is happening, if IO is compromised the server
will eventually shutdown
+logger.warn(e.getMessage(), e);
Review Comment:
I'm adding a loggerID.. thanks
Issue Time Tracking
---
Worklog Id: (was: 918580)
Time Spent: 50m (was: 40m)
> Target Mirror is setting wrong size on duplicate cache
> --
>
> Key: ARTEMIS-4765
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4765
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Duplicate cache on Mirror target is keeping 20_000 records, even if it's only
> supposed to keep 1000 due to AMQP credits.
> a Workaround is to set the addressSettings.#.iDCacheSize=1000
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4420) User authentication leaks into non-Artemis servlets
[
https://issues.apache.org/jira/browse/ARTEMIS-4420?focusedWorklogId=918552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918552
]
ASF GitHub Bot logged work on ARTEMIS-4420:
---
Author: ASF GitHub Bot
Created on: 09/May/24 14:29
Start Date: 09/May/24 14:29
Worklog Time Spent: 10m
Work Description: gtully commented on PR #4897:
URL:
https://github.com/apache/activemq-artemis/pull/4897#issuecomment-2102777907
Using a thread local to propagate the session subject is fine, but it needs
to be scoped to the user of that thread for the request, and cleared on
response. so set every time.
Issue Time Tracking
---
Worklog Id: (was: 918552)
Time Spent: 0.5h (was: 20m)
> User authentication leaks into non-Artemis servlets
> ---
>
> Key: ARTEMIS-4420
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4420
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.30.0
>Reporter: Dries Harnie
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ActiveMQ Artemis supports audit logs, which log all administrative actions
> that happen on the broker.
> These logs identify the "current user" for an administrative access [by one
> of two
> methods|https://github.com/apache/activemq-artemis/blob/main/artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AuditLogger.java#L67-L73]:
> # The {{Subject}} associated with the current security manager context, or
> # A {{{}ThreadLocal{}}}, which is set by JolokiaFilter as part of
> interaction with the admin console.
> For a non-Artemis servlet such as [the metrics
> plugin|https://github.com/rh-messaging/artemis-prometheus-metrics-plugin],
> this {{ThreadLocal}} is set to whatever {{Subject}} made the previous request
> on this thread. This leads to situations where metric accesses are logged as
> being done by ghost users.
> To reproduce the issue:
> # Set up Artemis with the default admin/admin user and [the metrics
> plugin|https://github.com/rh-messaging/artemis-prometheus-metrics-plugin].
> # Enable audit logging ({{{}logger.audit_base{}}} should be at {{INFO}}
> level)
> # Tail -f the audit log and start the server
> # Log in to the admin console
> # Observe that a lot of audit logs fly by for {*}admin(amq)@127.0.0.1{*}.
> # Access the metrics with eg {{{}curl http://localhost:8161/metrics/{}}}.
> # Observe that a lot of audit logs fly by for {*}admin(amq)@127.0.0.1{*},
> even though these requests are completely anonymous.
>
> I think the solution involves a modification to
> {{org.apache.activemq.artemis.component.JolokiaFilter}} but I do not
> understand the purpose of the code after the {{doFilter}} invocation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4763) properties config - support metrics plugin, conversion of .class for non string attributes and empty init
[ https://issues.apache.org/jira/browse/ARTEMIS-4763?focusedWorklogId=918527=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918527 ] ASF GitHub Bot logged work on ARTEMIS-4763: --- Author: ASF GitHub Bot Created on: 09/May/24 12:08 Start Date: 09/May/24 12:08 Worklog Time Spent: 10m Work Description: gtully commented on PR #4924: URL: https://github.com/apache/activemq-artemis/pull/4924#issuecomment-2102540122 > I agree w/ @cshannon here. There should be a setting to support honoring a valid list of package names Issue Time Tracking --- Worklog Id: (was: 918527) Time Spent: 1h 50m (was: 1h 40m) > properties config - support metrics plugin, conversion of .class for non > string attributes and empty init > -- > > Key: ARTEMIS-4763 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4763 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Configuration >Affects Versions: 2.33.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > the metrics plugin is not a broker plugin, so cannot be initialised via the > broker plugins collection. We can only add .class instances to collections. > The metrics instance is an attribute that needs a class type argument on the > metrics configuration. > supporting a conversion to any non string scalar type using a .class value > will work nicely. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4765) Target Mirror is setting wrong size on duplicate cache
[
https://issues.apache.org/jira/browse/ARTEMIS-4765?focusedWorklogId=918525=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918525
]
ASF GitHub Bot logged work on ARTEMIS-4765:
---
Author: ASF GitHub Bot
Created on: 09/May/24 11:29
Start Date: 09/May/24 11:29
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4928:
URL: https://github.com/apache/activemq-artemis/pull/4928#discussion_r1595327380
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##
@@ -1467,6 +1476,22 @@ public DuplicateIDCache getDuplicateIDCache(final
SimpleString address, int cach
return cache;
}
+ private void registerCacheSize(SimpleString address, int cacheSizeToUse) {
+ AbstractPersistedAddressSetting recordedSetting =
storageManager.recoverAddressSettings(address);
+ if (recordedSetting == null ||
recordedSetting.getSetting().getIDCacheSize() == null ||
recordedSetting.getSetting().getIDCacheSize().intValue() != cacheSizeToUse) {
+ AddressSettings settings = recordedSetting != null ?
recordedSetting.getSetting() : new AddressSettings();
+ settings.setIDCacheSize(cacheSizeToUse);
+ server.getAddressSettingsRepository().addMatch(address.toString(),
settings);
+ try {
+storageManager.storeAddressSetting(new
PersistedAddressSettingJSON(address, settings, settings.toJSON()));
+ } catch (Exception e) {
+// nothing could be done here, we just log
+// if an exception is happening, if IO is compromised the server
will eventually shutdown
+logger.warn(e.getMessage(), e);
Review Comment:
better say what the context here is, "error storing an address setting,
reason: " + e.getMessage()
Issue Time Tracking
---
Worklog Id: (was: 918525)
Time Spent: 40m (was: 0.5h)
> Target Mirror is setting wrong size on duplicate cache
> --
>
> Key: ARTEMIS-4765
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4765
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.33.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.34.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Duplicate cache on Mirror target is keeping 20_000 records, even if it's only
> supposed to keep 1000 due to AMQP credits.
> a Workaround is to set the addressSettings.#.iDCacheSize=1000
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARTEMIS-4766) gate every newInstance call with a type check on the class to ensure we only call static initialisers of the expected type
[ https://issues.apache.org/jira/browse/ARTEMIS-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully reassigned ARTEMIS-4766: --- Assignee: Gary Tully > gate every newInstance call with a type check on the class to ensure we only > call static initialisers of the expected type > -- > > Key: ARTEMIS-4766 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4766 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.33.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > > On our extension points, where configuration provides the implementation > class name, like plugins or transformers, we need to create an instance of > the configured class at runtime. > We typically know the interface type we are expecting, so we can enforce this > check before we create in instance, in that way we won't every call static > initialises on the wrong type in error. In cases where some gadget can be > injected into our configuration, it will need to be specialised for our > interfaces to be effective, which creates one additional hurdle to jump over. -- This message was sent by Atlassian Jira (v8.20.10#820010)
