[jira] [Work logged] (ARTEMIS-4771) NPE between AMQPLargeMessageWriter::tryDelivering and resetClose
[
https://issues.apache.org/jira/browse/ARTEMIS-4771?focusedWorklogId=919965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919965
]
ASF GitHub Bot logged work on ARTEMIS-4771:
---
Author: ASF GitHub Bot
Created on: 20/May/24 02:29
Start Date: 20/May/24 02:29
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4932:
URL: https://github.com/apache/activemq-artemis/pull/4932#discussion_r1606177252
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageWriter.java:
##
@@ -170,16 +170,26 @@ private void resume() {
}
private void tryDelivering() {
+
+ final Delivery localDelivery = delivery;
+ final MessageReference localReference = reference;
+ final LargeBodyReader localBodyReader = largeBodyReader;
+
+ if (localDelivery == null || localReference == null || localBodyReader
== null) {
+ logger.debug("Write got closed before tryDelivering was called");
+ return;
+ }
Review Comment:
@gemmellr the exception is a network disconnect. Client disconnects and a
network failure is transmitted. Close is called.
For that we need to either use a cached local variable or add
synchronization.
I suggest we add a local cache as it doesn't really matter if we just send
stuff on the already closed session. Adding synchronization on the write may
risk deadlocks.
I'm not able to fix it this week as I'm going out for a week. if you desire
to pick up this issue please close my PR and open a new one.
I will keep my as draft until I can come back into this.
Issue Time Tracking
---
Worklog Id: (was: 919965)
Time Spent: 2h 10m (was: 2h)
> NPE between AMQPLargeMessageWriter::tryDelivering and resetClose
>
>
> Key: ARTEMIS-4771
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4771
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Clebert Suconic
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This is using RedHat's bits:
> java.lang.NullPointerException: Cannot invoke
> "org.apache.qpid.proton.engine.Delivery.getTag()" because "this.delivery" is
> null
> at
> org.apache.activemq.artemis.protocol.amqp.proton.AMQPLargeMessageWriter.tryDelivering(AMQPLargeMessageWriter.java:174)
> ~[artemis-amqp-protocol-2.33.0.redhat-9.jar:2.33.0.redhat-9]
> at
> io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
> ~[netty-common-4.1.108.Final-redhat-1.jar:4.1.108.Final-redhat-1]
> at
> io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
> [netty-common-4.1.108.Final-redhat-1.jar:4.1.108.Final-redhat-1]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
> [netty-common-4.1.108.Final-redhat-1.jar:4.1.108.Final-redhat-1]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:413)
> [netty-transport-classes-epoll-4.1.108.Final-redhat-1.jar:4.1.108.Final-redhat-1]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
> [netty-common-4.1.108.Final-redhat-1.jar:4.1.108.Final-redhat-1]
> at
> io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> [netty-common-4.1.108.Final-redhat-1.jar:4.1.108.Final-redhat-1]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.33.0.redhat-9.jar:2.33.0.redhat-9]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4776) Replicated Paged Files may leak as open on replica target
[ https://issues.apache.org/jira/browse/ARTEMIS-4776?focusedWorklogId=919964=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919964 ] ASF GitHub Bot logged work on ARTEMIS-4776: --- Author: ASF GitHub Bot Created on: 20/May/24 02:09 Start Date: 20/May/24 02:09 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4939: URL: https://github.com/apache/activemq-artemis/pull/4939 Issue Time Tracking --- Worklog Id: (was: 919964) Time Spent: 20m (was: 10m) > Replicated Paged Files may leak as open on replica target > - > > Key: ARTEMIS-4776 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4776 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.33.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.34.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4776) Replicated Paged Files may leak as open on replica target
[ https://issues.apache.org/jira/browse/ARTEMIS-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847753#comment-17847753 ] ASF subversion and git services commented on ARTEMIS-4776: -- Commit 49189cd7e63a64fcda947dbd72fd7849348b71c9 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=49189cd7e6 ] ARTEMIS-4776 Pages may leak as open on Replicated Target PagingStore is supposed to send an event to replica on every file that is closed. There are a few situation where the sendClose is being missed and that could generate leaks on the target > Replicated Paged Files may leak as open on replica target > - > > Key: ARTEMIS-4776 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4776 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.33.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.34.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4776) Replicated Paged Files may leak as open on replica target
[ https://issues.apache.org/jira/browse/ARTEMIS-4776?focusedWorklogId=919963=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-919963 ] ASF GitHub Bot logged work on ARTEMIS-4776: --- Author: ASF GitHub Bot Created on: 20/May/24 01:03 Start Date: 20/May/24 01:03 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4939: URL: https://github.com/apache/activemq-artemis/pull/4939 PagingStore is supposed to send an event to replica on every file that is closed. There are a few situation where the sendClose is being missed and that could generate leaks on the target Issue Time Tracking --- Worklog Id: (was: 919963) Remaining Estimate: 0h Time Spent: 10m > Replicated Paged Files may leak as open on replica target > - > > Key: ARTEMIS-4776 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4776 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.33.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.34.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4776) Replicated Paged Files may leak as open on replica target
Clebert Suconic created ARTEMIS-4776: Summary: Replicated Paged Files may leak as open on replica target Key: ARTEMIS-4776 URL: https://issues.apache.org/jira/browse/ARTEMIS-4776 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 2.33.0 Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.34.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9482) Broker crashes after runaway threads spawn
[
https://issues.apache.org/jira/browse/AMQ-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847737#comment-17847737
]
Christopher L. Shannon commented on AMQ-9482:
-
It seems like maybe one of the connections is stuck and not reading (although
there should be a timeout). I also wonder if the burst of connections just
happens so quickly it exhausts the memory, if the broker runs out of memory
then it will just get into a weird state so you may need to bump memory to
handle the spike.
You could try tweaking some settings with the transport:
[https://activemq.apache.org/components/classic/documentation/tcp-transport-reference]
I would try setting the {{soTimeout}} and {{soWriteTimeout}} which would
hopefully prevent issues with connections blocking forever on a read/write to a
socket.
You could also try tuning things for the SelectorManager:
https://activemq.apache.org/components/classic/documentation/nio-transport-reference
> Broker crashes after runaway threads spawn
> --
>
> Key: AMQ-9482
> URL: https://issues.apache.org/jira/browse/AMQ-9482
> Project: ActiveMQ Classic
> Issue Type: Bug
> Components: Broker
>Affects Versions: 5.17.6, 6.0.1
> Environment: Bitnami created AMI in AWS
>Reporter: Tom Tichy
>Priority: Major
> Attachments: activemq.tdump, brokerInfo-after-crash-redacted.json
>
>
> Running on Bitnami created AMI in AWS. The broker has about 7000 devices
> connected via MQTT. Each devices has its own topic name.
> Broker stays up for about 4-5 days before being hobbled and unable to create
> any new tasks/accept any new connections.
> (There is identical setup for staging environment with about 100 devices
> connected. It runs without any issues.)
> I have troubleshot the cause to be the systemd task limit. The current
> `TasksMax` is 18100. When running normally, the number of tasks is about 300.
> Then (every 4-5 days) there is a quick spike to the max 18100 tasks and it
> stays there never coming back down. The result is that the broker just sits
> there, does nothing useful and keeps logging the following message
>
> {code:java}
> [659914.788s][warning][os,thread] Failed to start thread "Unknown thread" -
> pthread_create failed (EAGAIN) for attributes: stacksize: 1024k, g
> uardsize: 0k, detached.
> [659914.788s][warning][os,thread] Failed to start the native thread for
> java.lang.Thread "ActiveMQ BrokerService[localhost] Task-281805"
> ERROR | Scheduled task error
> java.lang.OutOfMemoryError: unable to create native thread: possibly out of
> memory or process/resource limits reached
> at java.lang.Thread.start0(Native Method) ~[?:?]
> at java.lang.Thread.start(Thread.java:809) ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:945)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1364)
> ~[?:?]
> at
> org.apache.activemq.thread.TaskRunnerFactory.execute(TaskRunnerFactory.java:173)
> ~[activemq-client-6.0.1.jar:6.0.1]
> at
> org.apache.activemq.thread.TaskRunnerFactory.execute(TaskRunnerFactory.java:165)
> ~[activemq-client-6.0.1.jar:6.0.1]
> at org.apache.activemq.broker.region.Topic$7.run(Topic.java:820)
> ~[activemq-broker-6.0.1.jar:6.0.1]
> at
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:39)
> ~[activemq-client-6.0.1.jar:6.0.1]
> at java.util.TimerThread.mainLoop(Timer.java:566) ~[?:?]
> at java.util.TimerThread.run(Timer.java:516) ~[?:?]
> Exception in thread "ActiveMQ Broker[localhost] Scheduler"
> java.lang.OutOfMemoryError: unable to create native thread: possibly out of
> memory or process/resource limits reached
> at java.base/java.lang.Thread.start0(Native Method)
> at java.base/java.lang.Thread.start(Thread.java:809)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:945)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1364)
> at
> org.apache.activemq.thread.TaskRunnerFactory.execute(TaskRunnerFactory.java:173)
> at
> org.apache.activemq.thread.TaskRunnerFactory.execute(TaskRunnerFactory.java:165)
> at org.apache.activemq.broker.region.Topic$7.run(Topic.java:820)
> at
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:39)
> at java.base/java.util.TimerThread.mainLoop(Timer.java:566)
> at java.base/java.util.TimerThread.run(Timer.java:516)
> {code}
>
> The start command is
> {code:java}
> /opt/bitnami/java/bin/java -Xms2G -Xmx4G
> -Djava.util.logging.config.file=logging.properties
>
[jira] [Updated] (ARTEMIS-4775) SIMILAR_BRANCHES.SWITCH Identical branches in switch node
[ https://issues.apache.org/jira/browse/ARTEMIS-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Slepykh updated ARTEMIS-4775: Description: in method: [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L229] the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) was: in [class |#L220]the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) > SIMILAR_BRANCHES.SWITCH Identical branches in switch node > - > > Key: ARTEMIS-4775 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4775 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.25.0 >Reporter: Andrey Slepykh >Priority: Major > Attachments: image-2024-05-19-17-18-16-355.png > > > in method: > [https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L229] > the switch/case method contains extra code that could have been shortened > !image-2024-05-19-17-18-16-355.png! > > Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. > Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4775) SIMILAR_BRANCHES.SWITCH Identical branches in switch node
[ https://issues.apache.org/jira/browse/ARTEMIS-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Slepykh updated ARTEMIS-4775: Description: in [class|#L220]] the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) was: in [class|[https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220]|https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220]the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) > SIMILAR_BRANCHES.SWITCH Identical branches in switch node > - > > Key: ARTEMIS-4775 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4775 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.25.0 >Reporter: Andrey Slepykh >Priority: Major > Attachments: image-2024-05-19-17-18-16-355.png > > > in [class|#L220]] the switch/case method contains extra code that could have > been shortened > !image-2024-05-19-17-18-16-355.png! > > Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. > Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4775) SIMILAR_BRANCHES.SWITCH Identical branches in switch node
[ https://issues.apache.org/jira/browse/ARTEMIS-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Slepykh updated ARTEMIS-4775: Description: in [class|[https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220]|https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220]the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) was: in (class|[https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220])the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) > SIMILAR_BRANCHES.SWITCH Identical branches in switch node > - > > Key: ARTEMIS-4775 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4775 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.25.0 >Reporter: Andrey Slepykh >Priority: Major > Attachments: image-2024-05-19-17-18-16-355.png > > > in > [class|[https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220]|https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220]the > switch/case method contains extra code that could have been shortened > !image-2024-05-19-17-18-16-355.png! > > Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. > Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4775) SIMILAR_BRANCHES.SWITCH Identical branches in switch node
[ https://issues.apache.org/jira/browse/ARTEMIS-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Slepykh updated ARTEMIS-4775: Description: in [class |#L220]the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) was: in [class|#L220]] the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) > SIMILAR_BRANCHES.SWITCH Identical branches in switch node > - > > Key: ARTEMIS-4775 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4775 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.25.0 >Reporter: Andrey Slepykh >Priority: Major > Attachments: image-2024-05-19-17-18-16-355.png > > > in [class |#L220]the switch/case method contains extra code that could have > been shortened > !image-2024-05-19-17-18-16-355.png! > > Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. > Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4775) SIMILAR_BRANCHES.SWITCH Identical branches in switch node
[ https://issues.apache.org/jira/browse/ARTEMIS-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Slepykh updated ARTEMIS-4775: Description: in (class|[https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220])the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) was: in [class](https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220) the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) > SIMILAR_BRANCHES.SWITCH Identical branches in switch node > - > > Key: ARTEMIS-4775 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4775 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.25.0 >Reporter: Andrey Slepykh >Priority: Major > Attachments: image-2024-05-19-17-18-16-355.png > > > in > (class|[https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220])the > switch/case method contains extra code that could have been shortened > !image-2024-05-19-17-18-16-355.png! > > Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. > Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4775) SIMILAR_BRANCHES.SWITCH Identical branches in switch node
Andrey Slepykh created ARTEMIS-4775: --- Summary: SIMILAR_BRANCHES.SWITCH Identical branches in switch node Key: ARTEMIS-4775 URL: https://issues.apache.org/jira/browse/ARTEMIS-4775 Project: ActiveMQ Artemis Issue Type: Bug Components: JMS Affects Versions: 2.25.0 Reporter: Andrey Slepykh Attachments: image-2024-05-19-17-18-16-355.png in [class](https://github.com/apache/activemq-artemis/blob/fb1b362b473cad51ae5d05a897be02b1fa8461d4/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/JMSFactoryType.java#L220) the switch/case method contains extra code that could have been shortened !image-2024-05-19-17-18-16-355.png! Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author: Firsov Vladimir, BMSTU (fvv22u...@student.bmstu.ru) -- This message was sent by Atlassian Jira (v8.20.10#820010)
