[jira] [Created] (AMQNET-622) IConnection event listeners are not invoke on reconnect

2019-10-09 Thread Chris Morgan (Jira)
Chris Morgan created AMQNET-622:
---

 Summary: IConnection event listeners are not invoke on reconnect
 Key: AMQNET-622
 URL: https://issues.apache.org/jira/browse/AMQNET-622
 Project: ActiveMQ .Net
  Issue Type: Bug
  Components: AMQP
Reporter: Chris Morgan


I found the Apache.NMS.AMQP.NMSConnection allows applications to add 
ConnectionInterruptedListeners and ConnectionResumedListeners however these 
event callbacks are never invoked even during failover/reconnect.

The NMS AMQP provider does have a INmsConnectionListener to handle the 
interrupted and resumed connection events so its unclear whether 
ConnectionInterruptedListeners and ConnectionResumedListeners are not supported 
in favour for the INmsConnectionListener or if the 
ConnectionInterruptedListeners and ConnectionResumedListeners need to be 
invoked in addition to the INmsConnectionListener events.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (AMQNET-611) Apache.NMS.IllegalStateException is throw on transport thread

2019-09-13 Thread Chris Morgan (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Morgan closed AMQNET-611.
---
Resolution: Fixed

PR 30 fixes the issue.

> Apache.NMS.IllegalStateException is throw on transport thread
> -
>
> Key: AMQNET-611
> URL: https://issues.apache.org/jira/browse/AMQNET-611
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP, NMS
>Reporter: Chris Morgan
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Found this while looking at changes for AMQNET-610. While trying to shutdown 
> a connection the NMS amqp provider throws an exception on the transport 
> thread.
>  Havret has proposed a solution in PR 29, see 
> https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530123108
> Here is the exception:
> {noformat}
> Exception occurred: Apache.NMS.IllegalStateException: The Session is closed
> at Apache.NMS.AMQP.NmsSession.CheckClosed()
> at Apache.NMS.AMQP.NmsSession.get_AcknowledgementMode()
> at 
> Apache.NMS.AMQP.NmsMessageConsumer.SetAcknowledgeCallback(InboundMessageDispatch
>  envelope)
> at Apache.NMS.AMQP.NmsMessageConsumer.OnInboundMessage(InboundMessageDispatch 
> envelope)
> at Apache.NMS.AMQP.NmsSession.OnInboundMessage(InboundMessageDispatch 
> envelope)
> at Apache.NMS.AMQP.NmsConnection.OnInboundMessage(InboundMessageDispatch 
> envelope)
> at 
> Apache.NMS.AMQP.Provider.Failover.FailoverProvider.OnInboundMessage(InboundMessageDispatch
>  envelope)
> at Apache.NMS.AMQP.Provider.Amqp.AmqpConsumer.OnMessage(IReceiverLink 
> receiver, Message amqpMessage)
> at Amqp.ReceiverLink.OnTransfer(Delivery delivery, Transfer transfer, 
> ByteBuffer buffer)
> at Amqp.Session.OnTransfer(Transfer transfer, ByteBuffer buffer)
> at Amqp.Connection.OnFrame(ByteBuffer buffer)
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (AMQNET-611) Apache.NMS.IllegalStateException is throw on transport thread

2019-09-11 Thread Chris Morgan (Jira)
Chris Morgan created AMQNET-611:
---

 Summary: Apache.NMS.IllegalStateException is throw on transport 
thread
 Key: AMQNET-611
 URL: https://issues.apache.org/jira/browse/AMQNET-611
 Project: ActiveMQ .Net
  Issue Type: Bug
  Components: AMQP, NMS
Reporter: Chris Morgan


Found this while looking at changes for AMQNET-610. While trying to shutdown a 
connection the NMS amqp provider throws an exception on the transport thread.

 Havret has proposed a solution in PR 29, see 
https://github.com/apache/activemq-nms-amqp/pull/29#issuecomment-530123108

Here is the exception:
{noformat}
Exception occurred: Apache.NMS.IllegalStateException: The Session is closed
at Apache.NMS.AMQP.NmsSession.CheckClosed()
at Apache.NMS.AMQP.NmsSession.get_AcknowledgementMode()
at 
Apache.NMS.AMQP.NmsMessageConsumer.SetAcknowledgeCallback(InboundMessageDispatch
 envelope)
at Apache.NMS.AMQP.NmsMessageConsumer.OnInboundMessage(InboundMessageDispatch 
envelope)
at Apache.NMS.AMQP.NmsSession.OnInboundMessage(InboundMessageDispatch envelope)
at Apache.NMS.AMQP.NmsConnection.OnInboundMessage(InboundMessageDispatch 
envelope)
at 
Apache.NMS.AMQP.Provider.Failover.FailoverProvider.OnInboundMessage(InboundMessageDispatch
 envelope)
at Apache.NMS.AMQP.Provider.Amqp.AmqpConsumer.OnMessage(IReceiverLink receiver, 
Message amqpMessage)
at Amqp.ReceiverLink.OnTransfer(Delivery delivery, Transfer transfer, 
ByteBuffer buffer)
at Amqp.Session.OnTransfer(Transfer transfer, ByteBuffer buffer)
at Amqp.Connection.OnFrame(ByteBuffer buffer)
{noformat}
 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Closed] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP

2019-08-30 Thread Chris Morgan (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Morgan closed AMQNET-596.
---
Resolution: Fixed

Agreed.

> Support LocalMessageExpiry property for NMS AMQP
> 
>
> Key: AMQNET-596
> URL: https://issues.apache.org/jira/browse/AMQNET-596
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: AMQP, NMS
>Reporter: Chris Morgan
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The 
> nms amqp provider should support this property as some amqp brokers do not 
> support LocalMessageExpiry at the protocol level over amqp.
>  
> This property should be added to the NmsConnectionFactory, along with the 
> ConnectionInfo Class and the ConsumerInfo Class and applied at consumer 
> message receive.
>  
> The default value in qpid jms is true to have the nms amqp provider should 
> have the same default.
>  
> The string name of the property will be "nms.localMessagePriority".



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (AMQNET-603) AmqpProvider shouldn't signal exception when connection is explicitly closed

2019-08-28 Thread Chris Morgan (Jira)


[ 
https://issues.apache.org/jira/browse/AMQNET-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917905#comment-16917905
 ] 

Chris Morgan commented on AMQNET-603:
-

This might be as simple as checking the Error parameter for the amqpnetlite 
closed callback. To my knowledge at the connection the error parameter for the 
closed callback is null when an explicit amqpnetlite connection is closed 
without error.

> AmqpProvider shouldn't signal exception when connection is explicitly closed
> 
>
> Key: AMQNET-603
> URL: https://issues.apache.org/jira/browse/AMQNET-603
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP, NMS
>Affects Versions: 1.8.0
>Reporter: Krzysztof Porebski
>Priority: Major
>
> AmqpProvider shouldn't signal exception when connection is explicitly closed. 
> It may lead to deadlocks when provider is used with Spring 
> SimpleMessageListenerContainer.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP

2019-08-09 Thread Chris Morgan (JIRA)
Chris Morgan created AMQNET-596:
---

 Summary: Support LocalMessageExpiry property for NMS AMQP
 Key: AMQNET-596
 URL: https://issues.apache.org/jira/browse/AMQNET-596
 Project: ActiveMQ .Net
  Issue Type: Improvement
  Components: AMQP, NMS
Reporter: Chris Morgan


Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The 
nms amqp provider should support this property as some amqp brokers do not 
support LocalMessageExpiry at the protocol level over amqp.

 

This property should be added to the NmsConnectionFactory, along with the 
ConnectionInfo Class and the ConsumerInfo Class and applied at consumer message 
receive.

 

The default value in qpid jms is true to have the nms amqp provider should have 
the same default.

 

The string name of the property will be "nms.localMessagePriority".



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (AMQNET-578) Add Apache license files and License Headers to all source and relevant files

2018-01-19 Thread Chris Morgan (JIRA)
Chris Morgan created AMQNET-578:
---

 Summary: Add Apache license files and License Headers to all 
source and relevant files
 Key: AMQNET-578
 URL: https://issues.apache.org/jira/browse/AMQNET-578
 Project: ActiveMQ .Net
  Issue Type: Sub-task
Reporter: Chris Morgan


The current code base for the new NMS AMQP client, see git repo 
[https://github.com/cjwmorgan-sol-sys/nms-amqp], does not include the proper 
apache license files or the apache license headers in the source and relevant 
other files. See 
[http://www.apache.org/legal/src-headers.html#headers|http://www.apache.org/legal/src-headers.html#headers,],
 for contents of files and headers. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AMQNET-577) Update Build System

2018-01-19 Thread Chris Morgan (JIRA)
Chris Morgan created AMQNET-577:
---

 Summary: Update Build System
 Key: AMQNET-577
 URL: https://issues.apache.org/jira/browse/AMQNET-577
 Project: ActiveMQ .Net
  Issue Type: Sub-task
Reporter: Chris Morgan


The new NMS AMQP client, once committed, should be integrated into nightly 
builds and other build systems. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AMQNET-576) Clean out old code base for NMS AMQP client provider

2018-01-19 Thread Chris Morgan (JIRA)
Chris Morgan created AMQNET-576:
---

 Summary: Clean out old code base for NMS AMQP client provider
 Key: AMQNET-576
 URL: https://issues.apache.org/jira/browse/AMQNET-576
 Project: ActiveMQ .Net
  Issue Type: Sub-task
Reporter: Chris Morgan


Remove old code base in, [https://github.com/apache/activemq-nms-amqp,] mirror. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AMQNET-575) NMS AMQP Client Rework

2018-01-19 Thread Chris Morgan (JIRA)
Chris Morgan created AMQNET-575:
---

 Summary: NMS AMQP Client Rework
 Key: AMQNET-575
 URL: https://issues.apache.org/jira/browse/AMQNET-575
 Project: ActiveMQ .Net
  Issue Type: Task
  Components: AMQP, NMS
Reporter: Chris Morgan


This is a root Jira task to cover all work related to the proposal discussed in 
the thread, 
[http://activemq.2283324.n4.nabble.com/DISCUSS-Rework-NMS-AMQP-tc4721986.html#a4723793.]
 More specific work items should be created as subtasks of this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)