[jira] [Commented] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933631#comment-16933631
]
Jonathan S Fisher commented on AMQ-6391:
One more point of followup, earlier you mentioned rmIdFromConnectionId. I
noticed the dire warning in this article:
[https://access.redhat.com/documentation/en-us/red_hat_jboss_a-mq/6.1/html-single/integrating_with_jboss_enterprise_application_platform/index]
However, I can't seem to find any documentation around this property. Could you
possibly share your thoughts on how you arrived at that conclusion? Does that
setting have side affects?
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931526#comment-16931526
]
Jonathan S Fisher commented on AMQ-6391:
Thank you
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931504#comment-16931504
]
Jonathan S Fisher commented on AMQ-6391:
Gary thank you for taking the time to answer earlier, if you don't mind, can
you comment above? Thank you!
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928514#comment-16928514
]
Jonathan S Fisher commented on AMQ-6391:
Say you have a network of brokers and you restart the one your container is
connected to.
We _do_ want it to reconnect on a connection failure, but we're willing to have
an error thrown in any "in-flight" (non completed) transaction. We would hope
that any open JMSSessions/Listeners would be routed through to the new broker
after reconnect without issue.
Does this {code}stateTracker.setTrackTransactions(false);{code} accomplish this
end? We tried it out and it seems to work but I just want to make sure I
understand all the side effects :)
Our URL is:
{code}ACTIVEMQ_URL=failover:(ssl://activemq-1.example.com:61616?keepAlive=true,ssl://activemq-3.example.com:61616?keepAlive=true)?randomize=false{code}
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928514#comment-16928514
]
Jonathan S Fisher edited comment on AMQ-6391 at 9/12/19 1:18 PM:
-
Say you have a network of brokers and you restart the one your container is
connected to.
We _do_ want it to reconnect on a connection failure, AND we're willing to have
an error thrown in any "in-flight" (non completed) transaction. We would hope
that any open JMSSessions/Listeners would be routed through to the new broker
after reconnect without issue.
Does this
{code:java}
stateTracker.setTrackTransactions(false);{code}
accomplish this end? We tried it out and it seems to work but I just want to
make sure I understand all the side effects :)
Our URL is:
{code:java}
ACTIVEMQ_URL=failover:(ssl://activemq-1.example.com:61616?keepAlive=true,ssl://activemq-3.example.com:61616?keepAlive=true)?randomize=false{code}
was (Author: exabrial):
Say you have a network of brokers and you restart the one your container is
connected to.
We _do_ want it to reconnect on a connection failure, but we're willing to have
an error thrown in any "in-flight" (non completed) transaction. We would hope
that any open JMSSessions/Listeners would be routed through to the new broker
after reconnect without issue.
Does this {code}stateTracker.setTrackTransactions(false);{code} accomplish this
end? We tried it out and it seems to work but I just want to make sure I
understand all the side effects :)
Our URL is:
{code}ACTIVEMQ_URL=failover:(ssl://activemq-1.example.com:61616?keepAlive=true,ssl://activemq-3.example.com:61616?keepAlive=true)?randomize=false{code}
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927959#comment-16927959
]
Jonathan S Fisher edited comment on AMQ-6391 at 9/11/19 9:34 PM:
-
I just ran into this bug, bummer.
Would this method be sufficient? or were there problems with this approach?
{code:java}
stateTracker.setTrackTransactions(false);
{code}
For an MDB where we'll retry the message on disconnect, so I'm not to worried
about restoring state
was (Author: exabrial):
I just ran into this bug, bummer.
Would this method be sufficient? or were there problems with this approach?
{code:java}
stateTracker.setTrackTransactions(true);
{code}
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (AMQ-6391) Memory leak with FailoverTransport when sending TX messages from MDB
[
https://issues.apache.org/jira/browse/AMQ-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927959#comment-16927959
]
Jonathan S Fisher commented on AMQ-6391:
I just ran into this bug, bummer.
Would this method be sufficient? or were there problems with this approach?
{code:java}
stateTracker.setTrackTransactions(true);
{code}
> Memory leak with FailoverTransport when sending TX messages from MDB
>
>
> Key: AMQ-6391
> URL: https://issues.apache.org/jira/browse/AMQ-6391
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Patrik Dudits
>Priority: Major
> Attachments: 0001-AMQ-6391-test.patch
>
>
> We observe memory leak in
> {{FailoverTransport.stateTracker.connectionStates.transactions}} when using
> XA Transactions in activemq-rar, sending message within same transaction and
> not using {{useInboundSession}}.
> In such constellation there are two connections enlisted within same
> transaction. During commit the transaction manager will execute commit on one
> of the resources, per JTA 1.2 section 3.3.1 ("(TransactionManager) ensures
> that the same resource manager only receives one set of prepare-commit calls
> for completing the target global transaction ".)
> [TransactionContext|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L478]
> will propagate the afterCommit to all contexts participating in same
> transaction. However, this is not enough for {{ConnectionStateTracker}},
> which only reacts to [TransactionInfo
> command|https://github.com/apache/activemq/blob/a65f5e7c2077e048a2664339f6425d73948d71ce/activemq-client/src/main/java/org/apache/activemq/TransactionContext.java#L469].
> In effect, when two connection are enlisted in same transaction, just
> commands of one of them is cleared upon commit, leading to memory leak.
> Since I presume the {{TransactionInfo}} should be sent only once for commit
> of single transaction, {{ConnectionStateTracker}} needs to clear state for
> the acknowledged transactions regardless of connection id in the transaction
> command.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264341#comment-15264341 ] Jonathan S. Fisher commented on ARTEMIS-245: I'm fairly certain from the discussions last year, it's because ActiveMQRASession is a concrete final class with no interface, and it allows TomEE to cleanup resources that might be held by the developer. I'm trying a much more brutal method, which is to make ActiveMQRASession an interface, have a ActiveMQRASessionDefault concrete implementation. The consequence of this is you can't have protected methods on an interface, so things like _lock()_ and _unlock()_ will have to be public methods. > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263104#comment-15263104 ] Jonathan S. Fisher commented on ARTEMIS-245: The real problem is a problem with the spec :( cm.allocateConnection returns an Object... Forcing a unsafe cast. TomEE returns a proxy, but it's not the type your connection expects > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263090#comment-15263090 ] Jonathan S. Fisher commented on ARTEMIS-245: According to the spec, the only way a container would know to do that is if the LazyEnlistableConnectionManager interface was implemented... > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262670#comment-15262670 ] Jonathan S. Fisher commented on ARTEMIS-245: hmm... actually after reading this: http://docs.oracle.com/cd/B25221_04/web.1013/b14436/trmgcont.htm "...through its implementation of the SPI LazyEnlistableConnectionManager interface, so you can use lazy enlistment with any resource adapter that implements the LazyEnlistableManagedConnection interface for its managed connections" I suspect everything is just fine, but it's up to you... Here's my thoughts: 1) It only says this implementation's interface, not the whole RA 2) The connection manager doesn't implement LazyEnlistableConnectionManager anyway 3) The goal was just to allow TomEE to do connection tracking, not enable the lazy optimization. But even with that, if you uncomfortable with the change, I can implement the Lazy Optimization per the directions on the API, but I would have no idea how to test it and that'd leave me a little uneasy. > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262651#comment-15262651 ] Jonathan S. Fisher commented on ARTEMIS-245: Reading the Docs here, it would imply that the optimizations can be implemented singly: https://docs.jboss.org/jbossas/javadoc/4.0.4/j2ee/javax/resource/spi/package-summary.html Given that most of these are marker interfaces anyway, I could probably implement all of them if you want me to > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262433#comment-15262433 ] Jonathan S. Fisher commented on ARTEMIS-245: Ah, you're thinking the _entire_ RA must support it? Let me look at some other implementations and see what they're doing. The wording is a bit ambiguous here. > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262421#comment-15262421 ] Jonathan S. Fisher commented on ARTEMIS-245: Not, not yet, I'm still screwing around with the configuration. This is just one step. I'll file separate bugs as I go > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262414#comment-15262414 ] Jonathan S. Fisher commented on ARTEMIS-245: Yah :) Can I do that via github? > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: clebert suconic > Fix For: 1.3.0 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan S. Fisher updated ARTEMIS-245: --- Attachment: patch.txt > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: clebert suconic > Fix For: 1.1.1 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-245) Change resource adapter to work with Tomee
[ https://issues.apache.org/jira/browse/ARTEMIS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262399#comment-15262399 ] Jonathan S. Fisher commented on ARTEMIS-245: Attached a patch, thanks > Change resource adapter to work with Tomee > -- > > Key: ARTEMIS-245 > URL: https://issues.apache.org/jira/browse/ARTEMIS-245 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: clebert suconic > Fix For: 1.1.1 > > Attachments: patch.txt > > > It seems that Tomee requires a JMS interface to be returned. We should try > changing the RA to be compatible with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
