[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649642#comment-14649642 ] ASF subversion and git services commented on AMQ-5857: -- Commit 310c2bb05916811a25b84d76f11fb84b40087914 in activemq's branch refs/heads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=310c2bb ] https://issues.apache.org/jira/browse/AMQ-5857 Fixing a potential race condition in the storeContent method of ActiveMQTextMessage Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf Assignee: Christopher L. Shannon Fix For: 5.12.0 The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648020#comment-14648020 ] ASF subversion and git services commented on AMQ-5857: -- Commit 84ec047d2ffdee9630f74bf939746cd5ff2d0e12 in activemq's branch refs/heads/master from [~christopher.l.shannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=84ec047 ] https://issues.apache.org/jira/browse/AMQ-5857 Changing ActiveMQTextMessage to clear out the text field on marshal to a ByteSequence to prevent the data from being stored in memory twice. Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf Assignee: Christopher L. Shannon The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648024#comment-14648024 ] ASF GitHub Bot commented on AMQ-5857: - Github user cshannon closed the pull request at: https://github.com/apache/activemq/pull/134 Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf Assignee: Christopher L. Shannon The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625086#comment-14625086 ] Christopher L. Shannon commented on AMQ-5857: - [~tabish121], I pushed up this small change so you can either test it or apply it and see what happens with the full CI build. Something seems to be up with the PR Jenkins build though. It failed again for this PR (while working locally) and someone else pushed a minor PR up today and the same thing happened. It took 3 tries to get it to pass the tests. I'll probably ping Gary to give him a heads up. Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624792#comment-14624792 ] Timothy Bish commented on AMQ-5857: --- I think that should show if there is an impact. I think the change is safe other than the risk that the broker logs a message an causes the content to become unmarshaled which could cause compressed content to no longer be compressed but that seems unlikely. Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624853#comment-14624853 ] ASF GitHub Bot commented on AMQ-5857: - GitHub user cshannon opened a pull request: https://github.com/apache/activemq/pull/134 https://issues.apache.org/jira/browse/AMQ-5857 Changing ActiveMQTextMessage to clear out the text field on marshal to a ByteSequence to prevent the data from being stored in memory twice. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cshannon/activemq AMQ-5857 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 4e10e046d42a2b794ef830517bfaf651562c970a Author: Christopher L. Shannon (cshannon) christopher.l.shan...@gmail.com Date: 2015-07-13T15:31:14Z https://issues.apache.org/jira/browse/AMQ-5857 Changing ActiveMQTextMessage to clear out the text field on marshal to a ByteSequence to prevent the data from being stored in memory twice. Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623966#comment-14623966 ] Benjamin Graf commented on AMQ-5857: Any test results yet? Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-5857) Message content stored twice while sending
[ https://issues.apache.org/jira/browse/AMQ-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606015#comment-14606015 ] Benjamin Graf commented on AMQ-5857: Well, do you think anyone would call getText() anymore after calling setText()? I think calling storeContentAndClear() is not a good solution esspecially if your using JMS API (eg. camel-jms) and do not want to depend on ActiveMQ proprietary API. Message content stored twice while sending -- Key: AMQ-5857 URL: https://issues.apache.org/jira/browse/AMQ-5857 Project: ActiveMQ Issue Type: Bug Components: JMS client Affects Versions: 5.7.0, 5.8.0, 5.9.0, 5.10.0, 5.11.0 Reporter: Benjamin Graf The storeContent method in ActiveMQTextMessage does not clean text field after storing content. Therefor the message temporary exists twice which can lead to OOM problems for large or many text messages concurrently processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
