[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-10 Thread Gary Tully (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861541#comment-15861541
 ] 

Gary Tully commented on AMQ-6587:
-

note: the root cause could result in a wildcard sub missing a newly created 
destination, one created by an *anonymous* publish that coincides with the 
subscription creation. the check in destination gc exposed this window.

> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861230#comment-15861230
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit 727000f112b81aa3ca34087ee44a641b1d5088f6 in activemq's branch 
refs/heads/activemq-5.14.x from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=727000f ]

[AMQ-6587] - fix root cause of deletion candidate seeing sub. contention 
between adding sub to dests and adding dests to sub, also removing sub from 
dests twice could leave dest stat negative allowing invalid candidate for gc

(cherry picked from commit d86c98a68772aaa879e6a573fed1ab8382568c9e)


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861157#comment-15861157
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit d86c98a68772aaa879e6a573fed1ab8382568c9e in activemq's branch 
refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=d86c98a ]

[AMQ-6587] - fix root cause of deletion candidate seeing sub. contention 
between adding sub to dests and adding dests to sub, also removing sub from 
dests twice could leave dest stat negative allowing invalid candidate for gc


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-07 Thread Christopher L. Shannon (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856166#comment-15856166
 ] 

Christopher L. Shannon commented on AMQ-6587:
-

[~gtully], got it, thanks for the heads up.

> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856165#comment-15856165
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit 2d4fb4cbabb27f7fbb9ef5a86fa310d9741393c3 in activemq's branch 
refs/heads/activemq-5.14.x from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=2d4fb4c ]

[AMQ-6587] additional contention window with new sub while gc is in progress - 
need to verify new sub is actually subscribed to the candidate for deletion. 
Fix and test

(cherry picked from commit 0ee4f5b84302daf8901363556d038e274c2defd5)


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856030#comment-15856030
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit 0ee4f5b84302daf8901363556d038e274c2defd5 in activemq's branch 
refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=0ee4f5b ]

[AMQ-6587] additional contention window with new sub while gc is in progress - 
need to verify new sub is actually subscribed to the candidate for deletion. 
Fix and test


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854048#comment-15854048
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit 95dc0eba2b93232c60a1f4aa7ed319eff69d6a1d in activemq's branch 
refs/heads/activemq-5.14.x from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=95dc0eb ]

[AMQ-6587] ensure subs added to new destination before destination is exposed 
in the destination map. sort gc contention with wildcard subs and anonymous 
publish. fix and test

(cherry picked from commit e415d2921ec7eabeccdf7db4d1850caa68486de3)


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854049#comment-15854049
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit 8af72c2157dd570172acb744c56602b8b0a786ef in activemq's branch 
refs/heads/activemq-5.14.x from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=8af72c2 ]

[AMQ-6587] - fix typo in test that needs 1.7 final

(cherry picked from commit 64b3203713161ee0dd5d8d1dbd74f4c4602f546c)


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0, 5.14.4
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848601#comment-15848601
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit 64b3203713161ee0dd5d8d1dbd74f4c4602f546c in activemq's branch 
refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=64b3203 ]

[AMQ-6587] - fix typo in test that needs 1.7 final


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 5.15.0
>
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848473#comment-15848473
 ] 

ASF subversion and git services commented on AMQ-6587:
--

Commit e415d2921ec7eabeccdf7db4d1850caa68486de3 in activemq's branch 
refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=e415d29 ]

[AMQ-6587] ensure subs added to new destination before destination is exposed 
in the destination map. sort gc contention with wildcard subs and anonymous 
publish. fix and test


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Reporter: Gary Tully
>Assignee: Gary Tully
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-01 Thread Gary Tully (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848249#comment-15848249
 ] 

Gary Tully commented on AMQ-6587:
-

The fix for AMQ-6188  which resets lastActiveTime on publish/send helps 
mitigate the problem but does not fully resolve it.

> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Reporter: Gary Tully
>Assignee: Gary Tully
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AMQ-6587) Failed to remove inactive destination Topic: Destination still has an active subscription

2017-02-01 Thread Gary Tully (JIRA)

[ 
https://issues.apache.org/jira/browse/AMQ-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848247#comment-15848247
 ] 

Gary Tully commented on AMQ-6587:
-

There is some locking in RegionBroker using inactiveDestinationsPurgeLock. This 
does not cover addDestination which is probably intentional b/c it uses the 
shared destination map which allows for concurrent access. However new 
destinations are added to the map before matching subs are added. Which causes 
a race between gc and the addition of wildcard subscriptions. Adding subs 
before adding to the destination map looks like the simplest fix.


> Failed to remove inactive destination Topic: Destination still has an active 
> subscription
> -
>
> Key: AMQ-6587
> URL: https://issues.apache.org/jira/browse/AMQ-6587
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Reporter: Gary Tully
>Assignee: Gary Tully
>
> broker setSchedulePeriodForDestinationPurge, wildcard topic subscriber and 
> anonymous publishers to new destinations. 
> Race between addDestination and markForGc and canGc
> {code}
> ERROR region.RegionBroker: Failed to remove inactive destination Topic: 
> destination=A.4725, subscriptions=1
> javax.jms.JMSException: Destination still has an active subscription: 
> topic://A.4725
>   at 
> org.apache.activemq.broker.region.AbstractRegion.removeDestination(AbstractRegion.java:271)
>   at 
> org.apache.activemq.broker.region.RegionBroker.removeDestination(RegionBroker.java:354)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.BrokerFilter.removeDestination(BrokerFilter.java:179)
>   at 
> org.apache.activemq.broker.region.RegionBroker.purgeInactiveDestinations(RegionBroker.java:897)
>   at 
> org.apache.activemq.broker.region.RegionBroker$1.run(RegionBroker.java:118)
>   at 
> org.apache.activemq.thread.SchedulerTimerTask.run(SchedulerTimerTask.java:33)
>   at java.util.TimerThread.mainLoop(Timer.java:555)
>   at java.util.TimerThread.run(Timer.java:505)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)