[jira] [Commented] (AMQ-7086) KahaDB - don't perform expensive gc run on shutdown
[ https://issues.apache.org/jira/browse/AMQ-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670173#comment-16670173 ] ASF subversion and git services commented on AMQ-7086: -- Commit bf8eb08acaeec653d04daa0b8b6dd889ef990bed in activemq's branch refs/heads/master from gtully [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=bf8eb08 ] AMQ-7086 - make kahadb gc/cleanup on shutdown optional to trade availability over disk usage for fast failover > KahaDB - don't perform expensive gc run on shutdown > --- > > Key: AMQ-7086 > URL: https://issues.apache.org/jira/browse/AMQ-7086 > Project: ActiveMQ > Issue Type: Bug > Components: KahaDB >Affects Versions: 5.15.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 5.16.0 > > > when looking at the speed of broker.stop with kahadb and the scheduler store. > There is a full gc run, which can be expensive as the whole index needs to be > traversed. > Fast stop/restart is important for fast failover. Leaving gc for runtime, > where it has an effect on latency in the normal way, rather than > availability, is better. > > I am wondering if there is a use case for gc only at shutdown if the > cleanupInterval <= 0, indicating that there were no gc at runtime. The > alternative is adding another boolean to the config or adding that back in if > the need arises. > I am leaning towards just removing the gc call during shutdown. > > Note: matching the indexCacheSize to the index file size, trading off with > memory, does help to speed up the index (read) traversal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMQ-7086) KahaDB - don't perform expensive gc run on shutdown
[ https://issues.apache.org/jira/browse/AMQ-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663888#comment-16663888 ] Jeff Genender commented on AMQ-7086: [~gtully] my .02 is making it configurable is the way to go. > KahaDB - don't perform expensive gc run on shutdown > --- > > Key: AMQ-7086 > URL: https://issues.apache.org/jira/browse/AMQ-7086 > Project: ActiveMQ > Issue Type: Bug > Components: KahaDB >Affects Versions: 5.15.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 5.16.0 > > > when looking at the speed of broker.stop with kahadb and the scheduler store. > There is a full gc run, which can be expensive as the whole index needs to be > traversed. > Fast stop/restart is important for fast failover. Leaving gc for runtime, > where it has an effect on latency in the normal way, rather than > availability, is better. > > I am wondering if there is a use case for gc only at shutdown if the > cleanupInterval <= 0, indicating that there were no gc at runtime. The > alternative is adding another boolean to the config or adding that back in if > the need arises. > I am leaning towards just removing the gc call during shutdown. > > Note: matching the indexCacheSize to the index file size, trading off with > memory, does help to speed up the index (read) traversal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMQ-7086) KahaDB - don't perform expensive gc run on shutdown
[ https://issues.apache.org/jira/browse/AMQ-7086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663646#comment-16663646 ] Gary Tully commented on AMQ-7086: - The checkpoint=0 use case is from: AMQ-3646 disabling gc on shutdown will need to be configurable I think. > KahaDB - don't perform expensive gc run on shutdown > --- > > Key: AMQ-7086 > URL: https://issues.apache.org/jira/browse/AMQ-7086 > Project: ActiveMQ > Issue Type: Bug > Components: KahaDB >Affects Versions: 5.15.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 5.16.0 > > > when looking at the speed of broker.stop with kahadb and the scheduler store. > There is a full gc run, which can be expensive as the whole index needs to be > traversed. > Fast stop/restart is important for fast failover. Leaving gc for runtime, > where it has an effect on latency in the normal way, rather than > availability, is better. > > I am wondering if there is a use case for gc only at shutdown if the > cleanupInterval <= 0, indicating that there were no gc at runtime. The > alternative is adding another boolean to the config or adding that back in if > the need arises. > I am leaning towards just removing the gc call during shutdown. > > Note: matching the indexCacheSize to the index file size, trading off with > memory, does help to speed up the index (read) traversal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
