[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792495#comment-17792495
]
Kostiantyn Miklevskyi commented on AMQ-9383:
For sure it's your call to release 5.16.x or not. I'll just mention that AWS
managed ActiveMQ service allows for creating new broker instances of these
versions (at the point in time of writing this comment):
!image-2023-12-03-10-35-49-522.png!
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Attachments: image-2023-12-03-10-35-49-522.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784934#comment-17784934
]
Christopher L. Shannon commented on AMQ-9383:
-
[~jbonofre] - That makes sense, thanks for the clarification
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784931#comment-17784931
]
Jean-Baptiste Onofré commented on AMQ-9383:
---
[~cshannon] I merged on activemq-5.16.x just in case but I don't plan 5.16.x
new release. I will do 5.17/5.18/6.0.
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784608#comment-17784608
]
Christopher L. Shannon commented on AMQ-9383:
-
We should not be releasing another 5.16.x release. 5.16.x was announced as EOL
1.5 years ago in May 2022. We only recently did the 5.16.7 because of the
security issue but I'm not in favor if doing anymore 5.15.x or 5.16.x releases
etc.
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784493#comment-17784493
]
ASF subversion and git services commented on AMQ-9383:
--
Commit 3af9001e255cf862b4f6fb4fa0c0948a62038af7 in activemq's branch
refs/heads/activemq-5.16.x from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=3af9001e2 ]
AMQ-9383: Copy transport options before sending in introspection setter
(cherry picked from commit f4be8a6806206df3c9ddb6566c2e48eff767d55d)
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784492#comment-17784492
]
ASF subversion and git services commented on AMQ-9383:
--
Commit 48369bfe2bfd46264a1fb22fa0861499e7451705 in activemq's branch
refs/heads/activemq-5.17.x from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=48369bfe2 ]
AMQ-9383: Copy transport options before sending in introspection setter
(cherry picked from commit f4be8a6806206df3c9ddb6566c2e48eff767d55d)
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784491#comment-17784491
]
ASF subversion and git services commented on AMQ-9383:
--
Commit 526c2b07bafe8418d3b29ebeec2e5bdbe17ccd00 in activemq's branch
refs/heads/activemq-5.18.x from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=526c2b07b ]
AMQ-9383: Copy transport options before sending in introspection setter
(cherry picked from commit f4be8a6806206df3c9ddb6566c2e48eff767d55d)
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784490#comment-17784490
]
ASF subversion and git services commented on AMQ-9383:
--
Commit d23da10da80c37d01a42af1f8347193ba2baae22 in activemq's branch
refs/heads/main from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=d23da10da ]
Merge pull request #1113 from jbonofre/AMQ-9383
AMQ-9383: Copy transport options before sending in introspection setter
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784489#comment-17784489
]
ASF subversion and git services commented on AMQ-9383:
--
Commit f4be8a6806206df3c9ddb6566c2e48eff767d55d in activemq's branch
refs/heads/main from JB Onofré
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=f4be8a680 ]
AMQ-9383: Copy transport options before sending in introspection setter
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7, 5.16.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9383) Websocket transport options do not get applied
[
https://issues.apache.org/jira/browse/AMQ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784056#comment-17784056
]
Jean-Baptiste Onofré commented on AMQ-9383:
---
OK, no problem for 5.16.x ;)
> Websocket transport options do not get applied
> --
>
> Key: AMQ-9383
> URL: https://issues.apache.org/jira/browse/AMQ-9383
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
>Affects Versions: 5.15.16, 5.18.3, 5.17.6, 5.16.7
>Reporter: Kostiantyn Miklevskyi
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7
>
>
> Configure broker transport connector like this:
> {code:java}
> uri="ws://0.0.0.0:5680?amqp.traceFrames=truewireFormat=amqpwireFormat.transformer=jmswireFormat.allowNonSaslConnections=true"/>
> {code}
>
> Try to connect to this instance with rhea.js library.
> First attempt to connect would be successful.
> Second and all subsequent attempts would fail.
> The only way to "fix" this would be a broker restart.
>
> The issue is here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L162]
>
> transportOptions would be "consumed" by introspection on the first connection
> attempt, and on subsequent attempts "allowNonSaslConnections" and
> "transformer" would not be there, so won't be applied to wireformat and the
> result would be an error.
>
> Interestingly this was already spotted and fixed in the same class for MQTT
> subprotocol here:
> [https://github.com/apache/activemq/blob/4bbb055187166706103d785e9665efb439792c51/activemq-http/src/main/java/org/apache/activemq/transport/ws/jetty9/WSServlet.java#L115C86-L115C86]
> by simply creating a copy of transport options before sending it into
> introspecting setters.
>
> Please apply the same fix.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
