[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033085#comment-16033085 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1311#discussion_r119632869 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -643,7 +643,7 @@ protected CreateSessionMessage newCreateSession(String username, boolean autoCommitSends, boolean autoCommitAcks, boolean preAcknowledge) { - return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); --- End diff -- OK, 1.x and 1.5.5-x PRs should be good now. > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032934#comment-16032934 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1311#discussion_r119606267 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -643,7 +643,7 @@ protected CreateSessionMessage newCreateSession(String username, boolean autoCommitSends, boolean autoCommitAcks, boolean preAcknowledge) { - return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); --- End diff -- There's another commi I had to do on master to fix checkstyle. if you could please try building with: ``` mvn install -Pdev install -DskipTests=true ``` You will see where the checkstyle failed. Please amend and a push -f.. I have seen a Pull request for the wildfly fork, you will have to do the same now. > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032695#comment-16032695 ] Tomas Hofman commented on ARTEMIS-1187: --- Master PR: https://github.com/apache/activemq-artemis/pull/1298 1.x PR: https://github.com/apache/activemq-artemis/pull/1311 1.5.5 PR: https://github.com/rh-messaging/jboss-activemq-artemis/pull/193 > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032690#comment-16032690 ] ASF GitHub Bot commented on ARTEMIS-1187: - GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1311 ARTEMIS-1187 Incompatible version when recreating a session with olde… …r server https://issues.apache.org/jira/browse/ARTEMIS-1187 https://issues.jboss.org/browse/JBEAP-9522 Upstream PR: https://github.com/apache/activemq-artemis/pull/1298 You can merge this pull request into a Git repository by running: $ git pull https://github.com/TomasHofman/activemq-artemis JBEAP-9522-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1311.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1311 commit e6e366872252f80ce36d063925f7961e0a2015ee Author: Tomas HofmanDate: 2017-05-29T10:27:09Z ARTEMIS-1187 Incompatible version when recreating a session with older server > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032610#comment-16032610 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1298#discussion_r119549290 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -686,7 +686,7 @@ protected CreateSessionMessage newCreateSession(String username, boolean autoCommitSends, boolean autoCommitAcks, boolean preAcknowledge) { - return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); + return new CreateSessionMessage(name, sessionChannel.getID(), serverVersion, username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); --- End diff -- Thanks, I'm glad for feedback, I might have also be wrong... > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031386#comment-16031386 ] ASF subversion and git services commented on ARTEMIS-1187: -- Commit 8eb5ce9ebd67d2fe623fc42e9647e392d2dfdccc in activemq-artemis's branch refs/heads/master from [~thofman] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8eb5ce9 ] ARTEMIS-1187 Incompatible version when recreating a session with older server > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031388#comment-16031388 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1298 > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031385#comment-16031385 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1298#discussion_r119394970 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -686,7 +686,7 @@ protected CreateSessionMessage newCreateSession(String username, boolean autoCommitSends, boolean autoCommitAcks, boolean preAcknowledge) { - return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); + return new CreateSessionMessage(name, sessionChannel.getID(), serverVersion, username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); --- End diff -- Ohhh.. I see.. you're right! merging it.. sorry for the hassle.. just wanted to make sure what was going on. > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030820#comment-16030820 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user TomasHofman commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1298#discussion_r119296506 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -686,7 +686,7 @@ protected CreateSessionMessage newCreateSession(String username, boolean autoCommitSends, boolean autoCommitAcks, boolean preAcknowledge) { - return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); + return new CreateSessionMessage(name, sessionChannel.getID(), serverVersion, username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); --- End diff -- The ```newCreateSession()``` is only called in ```recreateSession()``` method, so my reasoning was that the message will be sent to the same server that the client was previously connected to (is that correct?), so the serverVersion that was previously established can be reused. The alternative could be to start a cycle of CreateSessionMessages with the highest know version and decrease the version if ```ActiveMQIncompatibleClientServerException``` is returned? I think this is how establishing new connection works. > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client.
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030312#comment-16030312 ] ASF GitHub Bot commented on ARTEMIS-1187: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1298#discussion_r119236680 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java --- @@ -686,7 +686,7 @@ protected CreateSessionMessage newCreateSession(String username, boolean autoCommitSends, boolean autoCommitAcks, boolean preAcknowledge) { - return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); + return new CreateSessionMessage(name, sessionChannel.getID(), serverVersion, username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null); --- End diff -- I'm not sure about this... the purpose is the client to tell the server which version is being used... it looks wrong to me. > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server
[ https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028213#comment-16028213 ] ASF GitHub Bot commented on ARTEMIS-1187: - GitHub user TomasHofman opened a pull request: https://github.com/apache/activemq-artemis/pull/1298 ARTEMIS-1187 Incompatible version when recreating a session with olde… …r server https://issues.apache.org/jira/browse/ARTEMIS-1187 https://issues.jboss.org/browse/JBEAP-9522 You can merge this pull request into a Git repository by running: $ git pull https://github.com/TomasHofman/activemq-artemis JBEAP-9522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1298 commit c3871a183f48b6cccaa3a65e7c14b2b64e16b39d Author: Tomas HofmanDate: 2017-05-29T10:27:09Z ARTEMIS-1187 Incompatible version when recreating a session with older server > Incompatible version when recreating a session with older server > > > Key: ARTEMIS-1187 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1187 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Tomas Hofman > > 1.5.x client is able to connect to 1.1.x server. However, when server is > reloaded following error occurs: > {noformat} > 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR > [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] > AMQ214003: Failed to handle failover > > ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS > message=AMQ119033: Server and client versions incompatible] > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407) > at > org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318) > at > org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215) > at > org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996) > at > org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {noformat} > This works correctly with 1.5 server and old 1.1 client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)