[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2018-03-09 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392979#comment-16392979
 ] 

clebert suconic commented on ARTEMIS-1514:
--

It's partially done...

we convert large messages as regular messages, but we don't stream yet.

> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2018-03-06 Thread Justin Bertram (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388217#comment-16388217
 ] 

Justin Bertram commented on ARTEMIS-1514:
-

Is this done [~clebertsuconic]?

> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260793#comment-16260793
 ] 

ASF subversion and git services commented on ARTEMIS-1514:
--

Commit b27ed5de16784f57a3f5582919cd378b5ba08263 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b27ed5d ]

ARTEMIS-1514 Fix File open on Large Message


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260778#comment-16260778
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1662


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260777#comment-16260777
 ] 

ASF subversion and git services commented on ARTEMIS-1514:
--

Commit eddb144debac2c3dd25e9354151e230e4ab73172 in activemq-artemis's branch 
refs/heads/master from [~martyntaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=eddb144 ]

ARTEMIS-1514 Fix read large message into buffer


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260715#comment-16260715
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1662

ARTEMIS-1514 Fix read large message into buffer

@clebertsuconic this fixes your previous commit.  Please take a look.

buffer.toByteBuffer() will generate a byte buffer with capacity set to the 
number of readable bytes on the buffer.  Since the buffer has no data, the 
capacity is set to 0.  This causes clients to not get the message body when 
doing large messages (without streaming).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1514-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1662


commit eddb144debac2c3dd25e9354151e230e4ab73172
Author: Martyn Taylor 
Date:   2017-11-21T13:22:27Z

ARTEMIS-1514 Fix read large message into buffer




> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255162#comment-16255162
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1655


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-16 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255160#comment-16255160
 ] 

ASF subversion and git services commented on ARTEMIS-1514:
--

Commit 9daa0321b668fbb1f45349f9e33937aa5a7c705e in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9daa032 ]

ARTEMIS-1514 Large message fix

I'm doing an overal improvement on large message support for AMQP
However this commit is just about a Bug on the converter.

It will be moot after all the changes I'm making, but I would rather keep this 
separate
as a way to cherry-pick on previous versions eventually.


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254443#comment-16254443
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1655
  
I got the PR tests to complete on my personal server. Something env at 
apache.. the tests here are good.


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253437#comment-16253437
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1655
  
@clebertsuconic Looks like the PR tests failed, but the failed result seems 
to be lost so I'm unable to restart.  Could you open another PR or push a 
change to get this to rerun.


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250664#comment-16250664
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1655
  
I'm still refactoring large messages, but this change is independent as it 
may be picked on previous versions (1.x for instance).


> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1514) Implementing AMQP LargeMessage

2017-11-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250663#comment-16250663
 ] 

ASF GitHub Bot commented on ARTEMIS-1514:
-

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1655

ARTEMIS-1514 Large message fix

I'm doing an overal improvement on large message support for AMQP
However this commit is just about a Bug on the converter.

It will be moot after all the changes I'm making, but I would rather keep 
this separate
as a way to cherry-pick on previous versions eventually.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis 
amqp-large-message

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1655.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1655


commit 5e1ae7aa029d4ea53335a893d25bcbe39f4ca423
Author: Clebert Suconic 
Date:   2017-11-13T21:36:47Z

ARTEMIS-1514 Large message fix

I'm doing an overal improvement on large message support for AMQP
However this commit is just about a Bug on the converter.

It will be moot after all the changes I'm making, but I would rather keep 
this separate
as a way to cherry-pick on previous versions eventually.




> Implementing AMQP LargeMessage
> --
>
> Key: ARTEMIS-1514
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1514
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)