[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-03-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390452#comment-16390452
 ] 

ASF subversion and git services commented on ARTEMIS-1669:
--

Commit 2a9381cd26f5c95e403d1d8ae507f7507d7fd616 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2a9381c ]

ARTEMIS-1669 Fixing test


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
> Fix For: 2.5.0
>
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388736#comment-16388736
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1857


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-03-01 Thread Jiri Ondrusek (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383304#comment-16383304
 ] 

Jiri Ondrusek commented on ARTEMIS-1669:


Hi, this is only a part of the fix. It allows to configure artemis to ignore 
JTA transaction. 

Second part is in JBOSS integration, when attribute is set to true (in some 
cases) - [https://github.com/jbossas/jboss-eap7/pull/2561]

Set of attribute is done via configuration properties propagated to ironjacamar 
(see previous PR in jboss-eap7): 

Map configProperties = ignoreJTA ? Collections.singletonMap(IGNORE_JTA, String.valueOf(ignoreJTA)) : 
Collections.emptyMap();

new ActivationImpl(null, null, transactionSupport, definitions, 
Collections.emptyList(), configProperties, 
Collections.emptyList(), null, null);

> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-03-01 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382596#comment-16382596
 ] 

clebert suconic commented on ARTEMIS-1669:
--

I don't understand how Pull Request is fixing this. You added a feature to 
ignore the Transaction if true. but if not set no change is done.

 

What is the bug after all?

> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-02-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376573#comment-16376573
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

Github user JiriOndrusek commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r170531201
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java
 ---
@@ -122,6 +122,10 @@
 
private String entries;
 
+   //fix of JBEAP-12720 - propagated value of transactional attribute 
JMSConnectionFactoryDefinition annotation with the
--- End diff --

Hi, I've missed this reference, too, I'll change it to ARTEMIS-1669.


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-02-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376490#comment-16376490
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r170513149
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQResourceAdapter.java
 ---
@@ -122,6 +122,10 @@
 
private String entries;
 
+   //fix of JBEAP-12720 - propagated value of transactional attribute 
JMSConnectionFactoryDefinition annotation with the
--- End diff --

Should this reference an Apache jira?


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-02-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368834#comment-16368834
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

Github user JiriOndrusek commented on the issue:

https://github.com/apache/activemq-artemis/pull/1857
  
@jbertram Hi, thank you for pointing it out, my bad, I've fixed it to 
Artemis.


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367840#comment-16367840
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r168862534
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRASessionFactoryImpl.java
 ---
@@ -819,13 +819,12 @@ protected ActiveMQRASession 
allocateConnection(boolean transacted,
 //from createSession
 // In a Java EE web or EJB container, when there is an active 
JTA transaction in progress:
 //Both arguments {@code transacted} and {@code 
acknowledgeMode} are ignored.
-if (inJtaTransaction()) {
+// fix of JBEAP-12720 - when a JMSConnectionFactoryDefinition 
annotation with the transactional attribute set to false="false" is set
--- End diff --

This should reference the ARTEMIS JIRA rather than JBEAP.


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356848#comment-16356848
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

GitHub user JiriOndrusek opened a pull request:

https://github.com/apache/activemq-artemis/pull/1857

ARTEMIS-1669 JMS message is not received when using a non-transaction…

…al JMSConnectionFactoryDefinition

Issue: https://issues.apache.org/jira/browse/ARTEMIS-1669

If JMSConnectionFactoryDefinition annotation with the transactional 
attribute set to false, connections should not participate in transactions. 
I've added parameter ignoreJTA (by default false - to keep current behavior). 
If parameter is set to true (== value in annotation is false), 
ActiveMQRASessionFactoryImpl.java then force correct behavior.

Integration test IgnoreJTATest.java makes sure, that it works.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1669

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1857


commit 12892e2285f5e546de776bd3869524225f65f876
Author: JiriOndrusek 
Date:   2018-02-08T11:47:10Z

ARTEMIS-1669 JMS message is not received when using a non-transactional 
JMSConnectionFactoryDefinition




> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)