[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371755#comment-16371755
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1881


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371662#comment-16371662
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169705458
  
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
 sudo: false
 language: java
 install: true
-script: mvn -Pfast-tests -Pextra-tests -B install
--- End diff --

Perhaps you could add a comment (don't know what's the format for comments 
on yml) documenting why the install is needed?


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371658#comment-16371658
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169705162
  
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
 sudo: false
 language: java
 install: true
-script: mvn -Pfast-tests -Pextra-tests -B install
--- End diff --

smoke-tests are depending on the install, as they will create the broker 
from the artemis-home under the distribution
if you remove this, those tests will not build.. as the build is failing 
for you now.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371573#comment-16371573
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1881
  
I'm looking into it now.  Trying to reproduce the failure locally, but have 
been unsuccessful so far.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371567#comment-16371567
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1881
  
@jbertram did you look into this failure?


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371516#comment-16371516
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169664598
  
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
 sudo: false
 language: java
 install: true
-script: mvn -Pfast-tests -Pextra-tests -B install
+script: mvn -Pfast-tests -Pextra-tests -B test
--- End diff --

I pulled that commit out so -Pextra-tests will remain in place.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370675#comment-16370675
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169482105
  
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
 sudo: false
 language: java
 install: true
-script: mvn -Pfast-tests -Pextra-tests -B install
+script: mvn -Pfast-tests -Pextra-tests -B test
--- End diff --

I told you in private.  That is to make sure the extra tests will compile. 


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370589#comment-16370589
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169453963
  
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
 sudo: false
 language: java
 install: true
-script: mvn -Pfast-tests -Pextra-tests -B install
+script: mvn -Pfast-tests -Pextra-tests -B test
--- End diff --

The two commits are independent.  One is to change 'install' to 'test'.  
The other is to remove '-Pextra-tests' as it's not actually doing anything in 
the build as far as I can tell.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370585#comment-16370585
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169452802
  
--- Diff: .travis.yml ---
@@ -1,7 +1,7 @@
 sudo: false
 language: java
 install: true
-script: mvn -Pfast-tests -Pextra-tests -B install
+script: mvn -Pfast-tests -Pextra-tests -B test
--- End diff --

I'm confused about this in regard to the previous commit. Did you mean 
-Pextra-tests


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370490#comment-16370490
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169429443
  
--- Diff: 
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
 ---
@@ -179,6 +182,7 @@ private void doCheck(String localaddress) throws 
Exception {
 
}
 
+   @Ignore("doesn't work in Travis CI environment")
--- End diff --

From what I can tell the failure is due to the way the ping command is 
being constructed and executed in 
org.apache.activemq.artemis.core.server.NetworkHealthCheck#purePing (i.e. via 
java.lang.ProcessBuilder). It appears the Travis CI environment simply won't 
allow it.  I'll investigate creating an assumption to test the environment.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370302#comment-16370302
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user gemmellr commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169394169
  
--- Diff: 
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
 ---
@@ -179,6 +182,7 @@ private void doCheck(String localaddress) throws 
Exception {
 
}
 
+   @Ignore("doesn't work in Travis CI environment")
--- End diff --

Is this because its failing due to lack of IPV6 in the env? If the test 
really needs that it should probably check it works and fail an assumption 
which will make the test skip in envs it cant possibly work in, as opposed to 
disabling the test everywhere.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370222#comment-16370222
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169374458
  
--- Diff: 
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
 ---
@@ -159,7 +159,7 @@ public void testParseLogger() throws Exception {
   Assert.assertEquals(2, check.getUrls().size());
}
 
-   @Test
+   //@Test
--- End diff --

Will do.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370213#comment-16370213
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1881#discussion_r169373030
  
--- Diff: 
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/NetworkHealthTest.java
 ---
@@ -159,7 +159,7 @@ public void testParseLogger() throws Exception {
   Assert.assertEquals(2, check.getUrls().size());
}
 
-   @Test
+   //@Test
--- End diff --

can you use @Ignore instead.

At least the test would be runnable within the IDE.


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370130#comment-16370130
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1881

ARTEMIS-1684 fail build for failed 'fast' tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1684

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1881


commit c19914a2058420166457d8d5131c3eca9df432d0
Author: Justin Bertram 
Date:   2018-02-20T15:16:09Z

ARTEMIS-1684 fail build for failed 'fast' tests




> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367623#comment-16367623
 ] 

Robbie Gemmell commented on ARTEMIS-1684:
-

I see that the build is caching the maven local repo, and the build is 
installing there each time. It might be good to either not install, or prevent 
the artemis bits from actually being cached, otherwise the cache will grow 
unchecked and there could be issues from interaction with stale artifacts from 
failed builds etc. This 
[https://docs.travis-ci.com/user/caching/#before_cache-phase] might offer a 
router if leaving it installing.

 

 

> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367608#comment-16367608
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1872


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365882#comment-16365882
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1872

ARTEMIS-1684 enable Travis CI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1684

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1872


commit 820837604abc298b8d7bfdcba994dfd7509cf194
Author: Justin Bertram 
Date:   2018-02-15T14:53:39Z

ARTEMIS-1684 enable Travis CI




> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)