[jira] [Commented] (ARTEMIS-1694) [DOC] Wrong default value for graceful-shutdown-enabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377399#comment-16377399
 ] 

ASF GitHub Bot commented on ARTEMIS-1694:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1885


> [DOC] Wrong default value for graceful-shutdown-enabled
> ---
>
> Key: ARTEMIS-1694
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1694
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Laurent Bigonville
>Assignee: Justin Bertram
>Priority: Minor
>
> Hi,
> In the documentation, there are difference in the default value for 
> graceful-shutdown-enabled
> Between 
> [https://activemq.apache.org/artemis/docs/latest/configuration-index.html] 
> and [https://activemq.apache.org/artemis/docs/latest/graceful-shutdown.html]
>  
> Looking at the code, I think the default is actually "true"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1694) [DOC] Wrong default value for graceful-shutdown-enabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377402#comment-16377402
 ] 

ASF GitHub Bot commented on ARTEMIS-1694:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1885
  
@jbertram you've been busy!! lots to merge :) +1


> [DOC] Wrong default value for graceful-shutdown-enabled
> ---
>
> Key: ARTEMIS-1694
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1694
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Laurent Bigonville
>Assignee: Justin Bertram
>Priority: Minor
>
> Hi,
> In the documentation, there are difference in the default value for 
> graceful-shutdown-enabled
> Between 
> [https://activemq.apache.org/artemis/docs/latest/configuration-index.html] 
> and [https://activemq.apache.org/artemis/docs/latest/graceful-shutdown.html]
>  
> Looking at the code, I think the default is actually "true"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1694) [DOC] Wrong default value for graceful-shutdown-enabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377398#comment-16377398
 ] 

ASF subversion and git services commented on ARTEMIS-1694:
--

Commit 03709fc7cfa8fc1c1f78940adc0a420792a7eecf in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=03709fc ]

ARTEMIS-1694 fix graceful-shutdown doc


> [DOC] Wrong default value for graceful-shutdown-enabled
> ---
>
> Key: ARTEMIS-1694
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1694
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Laurent Bigonville
>Assignee: Justin Bertram
>Priority: Minor
>
> Hi,
> In the documentation, there are difference in the default value for 
> graceful-shutdown-enabled
> Between 
> [https://activemq.apache.org/artemis/docs/latest/configuration-index.html] 
> and [https://activemq.apache.org/artemis/docs/latest/graceful-shutdown.html]
>  
> Looking at the code, I think the default is actually "true"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1694) [DOC] Wrong default value for graceful-shutdown-enabled

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372913#comment-16372913
 ] 

ASF GitHub Bot commented on ARTEMIS-1694:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1885

ARTEMIS-1694 fix graceful-shutdown doc



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1694

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1885


commit a4533b1fa80125ca6e12f97075967265bca598e4
Author: Justin Bertram 
Date:   2018-02-22T15:05:14Z

ARTEMIS-1694 fix graceful-shutdown doc




> [DOC] Wrong default value for graceful-shutdown-enabled
> ---
>
> Key: ARTEMIS-1694
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1694
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Laurent Bigonville
>Priority: Minor
>
> Hi,
> In the documentation, there are difference in the default value for 
> graceful-shutdown-enabled
> Between 
> [https://activemq.apache.org/artemis/docs/latest/configuration-index.html] 
> and [https://activemq.apache.org/artemis/docs/latest/graceful-shutdown.html]
>  
> Looking at the code, I think the default is actually "true"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)