[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-12-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722850#comment-16722850
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1975


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
> Fix For: 2.6.0
>
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-12-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722849#comment-16722849
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1975
  
Closing this PR as requested by Justin Bertram @jbertram 


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
> Fix For: 2.6.0
>
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-12-14 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721961#comment-16721961
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1975
  
I think this PR is moot at this point as this change is on the master and 
2.6.x branches (and Wildfly has moved to 2.6.x). @rstancel, can you close this 
PR?


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
> Fix For: 2.6.0
>
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430343#comment-16430343
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1975#discussion_r180048729
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -930,9 +930,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
--- End diff --

@clebertsuconic it was different issues. 
https://github.com/apache/activemq-artemis/pull/1990 . Should I create new PR 
in master?


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428722#comment-16428722
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1975#discussion_r179841255
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -930,9 +930,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
--- End diff --

Can you still keep the log.debug?

Didn't I see you doing this somewhere else? is that the same issue?


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414189#comment-16414189
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1975
  
@clebertsuconic Clebert, can you please merge also this PR? thanks


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414188#comment-16414188
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1975

[ARTEMIS-1761] Log warning if cluster is not able to connect at startup

Jira: https://issues.apache.org/jira/browse/ARTEMIS-1761
master commit: 
https://github.com/apache/activemq-artemis/commit/373c3db2ac4c3b79d4f777ee32498c924176eba6

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis 
ARTEMIS-1761_1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1975


commit 6c397fda732837191c63e65507ad58a16b25bf70
Author: Radovan Stancel 
Date:   2018-03-21T17:26:20Z

[ARTEMIS-1761] Log warning if cluster is not able to connect at startup




> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413941#comment-16413941
 ] 

ASF subversion and git services commented on ARTEMIS-1761:
--

Commit 373c3db2ac4c3b79d4f777ee32498c924176eba6 in activemq-artemis's branch 
refs/heads/master from [~rstancel]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=373c3db ]

[ARTEMIS-1761] Log one warning if cluster could not be formed because it's not 
possible to connect to other cluster node


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413943#comment-16413943
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1964
  
@rstancel I already rebased and merged it 


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413942#comment-16413942
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1964


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413945#comment-16413945
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1964
  
squashed it with an intermediate branch.


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413940#comment-16413940
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1964
  
@clebertsuconic yeap, I will do that once it will be approved


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413939#comment-16413939
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1964
  
i would squash these three commits into one... but we can do that at time 
of merge..




> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413909#comment-16413909
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel commented on the issue:

https://github.com/apache/activemq-artemis/pull/1964
  
@michaelandrepearce Done. Can you please check? Thanks


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
>  [artemis-commons-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_71]
>     at 
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411686#comment-16411686
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1964#discussion_r176795441
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
-   }
+   logger.warn("Bridge " + this + " is unable to connect to 
destination. Retrying...");
--- End diff --

Not really it should have its own, it’s a different issue, and so should 
have its own dedicated log error code and log output.


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411321#comment-16411321
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1964#discussion_r176724023
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
-   }
+   logger.warn("Bridge " + this + " is unable to connect to 
destination. Retrying...");
--- End diff --

@michaelandrepearce I have used the same message as in another if-else 
condition. is it ok?


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410968#comment-16410968
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1964#discussion_r176662690
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -927,9 +927,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
-   }
+   logger.warn("Bridge " + this + " is unable to connect to 
destination. Retrying...");
--- End diff --

Can we use the logger class's for this, as its no longer a debug message, 
should have proper code etc. etc.


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410254#comment-16410254
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1964
  
I amended the commit title... too big.. 

I am not strict with rules.. I just try to be reasonable..  sometimes even 
I bend them.. about number of characters per line on commit descriptions and 
the first line

but your commit line was huge.. impossible to read it on git logs... 


I use git log all the time.. so this would be an issue.. just to let you 
know in the future... 


Thanks for the commit BTW! :)


> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.createSessionFactory(ClusterConnectionBridge.java:136)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.connect(BridgeImpl.java:857)
>  [artemis-server-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl$ConnectRunnable.run(BridgeImpl.java:1048)
> 

[jira] [Commented] (ARTEMIS-1761) Log one warning if cluster could not be formed because it's not possible to connect to other cluster node

2018-03-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408307#comment-16408307
 ] 

ASF GitHub Bot commented on ARTEMIS-1761:
-

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1964

[ARTEMIS-1761] Log one warning if cluster could not be formed because…

… it's not possible to connect to other cluster node

Jira: https://issues.apache.org/jira/browse/ARTEMIS-1761

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1964


commit 0aad3b89948df94fa414e81d4b5190505940f4b1
Author: Radovan STANCEL 
Date:   2018-03-21T17:26:20Z

[ARTEMIS-1761] Log one warning if cluster could not be formed because it's 
not possible to connect to other cluster node




> Log one warning if cluster could not be formed because it's not possible to 
> connect to other cluster node
> -
>
> Key: ARTEMIS-1761
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1761
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.6, 2.5.0
>Reporter: Radovan Stancel
>Priority: Major
>
> If discovery-group receives connector which is not possible to use to create 
> cluster connection (using such connector fails) then server should log one 
> warning. Currently server is logging this on DEBUG level which is confusing 
> and it's not clear why cluster was not formed. It's just silently retrying 
> bad connector on background (on debug level).
> Current debug logs:
> {code}
> 14:43:45,777 DEBUG 
> [org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl] (Thread-4 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$3@3f47a5c5))
>  Bridge ClusterConnecti
> onBridge@516796ab [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl [server=ActiveMQServerImpl::serverUU
> ID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848 
> targetConnector=ServerLocatorImpl 
> (identity=(Cluster-connection-bridge::ClusterConnectionBridge@516796ab 
> [name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bf
> c, queue=QueueImpl[name=sf.my-cluster.6eca14fb-4535-11e7-bc50-3ca9f4349bfc, 
> postOffice=PostOfficeImpl 
> [server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8]]@2d035848
>  targetConnector=Server
> LocatorImpl [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  ?httpUpgradeEndpoint=https-acceptor
> ame=default=true=9080=localhost], 
> discoveryGroupConfiguration=null]]::ClusterConnectionImpl@386706758[nodeUUID=5630528e-4535-11e7-9213-3c970e9648c8,
>  connector=TransportConfiguration(
> name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting-impl-netty-NettyConnectorFactory)
>  
> ?httpUpgradeEndpoint=https-acceptor=default=true=8080=loca
> lhost, address=jms, 
> server=ActiveMQServerImpl::serverUUID=5630528e-4535-11e7-9213-3c970e9648c8])) 
> [initialConnectors=[TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-core-remoting
> -impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost],
>  discoveryGroupConfiguration=null]] is unable to connect to des
> tination. Retrying: ActiveMQNotConnectedException[errorType=NOT_CONNECTED 
> message=Unable to connect to server using configuration 
> TransportConfiguration(name=http-connector, 
> factory=org-apache-activemq-artemis-c
> ore-remoting-impl-netty-NettyConnectorFactory) 
> ?httpUpgradeEndpoint=https-acceptor=default=true=9080=localhost]
>     at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.connect(ClientSessionFactoryImpl.java:245)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:685)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
> org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:659)
>  [artemis-core-client-1.5.5.001-redhat-1.jar:1.5.5.001-redhat-1]
>     at 
>