[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835785#comment-17835785
]
Timothy A. Bish commented on ARTEMIS-209:
-
About the same place as before, proton-j still does this but I don't see it
being changed. There is protonj2 now but there is no effort to replace the
existing protocol head so the issue continues to exist in the broker as before.
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Charles E. Rolke
>Assignee: Timothy A. Bish
>Priority: Major
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835781#comment-17835781
]
Justin Bertram commented on ARTEMIS-209:
[~tabish], where are we on this? Can this issue be closed?
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Charles E. Rolke
>Assignee: Timothy A. Bish
>Priority: Major
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251922#comment-17251922
]
Timothy A. Bish commented on ARTEMIS-209:
-
A new engine has not been released so I hope Artemis isn't using it.
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Charles E. Rolke
>Assignee: Timothy A. Bish
>Priority: Major
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251915#comment-17251915
]
Justin Bertram commented on ARTEMIS-209:
[~tabish], is Artemis currently using the "new engine" or is development still
ongoing and the Artemis dependency will be updated later?
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Charles E. Rolke
>Assignee: Timothy A. Bish
>Priority: Major
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251853#comment-17251853
]
Timothy A. Bish commented on ARTEMIS-209:
-
The new engine does not behave like this no, it would simply emit a SASL
outcome of failed
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Charles E. Rolke
>Assignee: Timothy A. Bish
>Priority: Major
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251798#comment-17251798
]
Justin Bertram commented on ARTEMIS-209:
[~tabish] or [~robbie], is this something you think will actually be addressed
in Proton-J? If not we should close this.
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Charles E. Rolke
>Assignee: Timothy A. Bish
>Priority: Major
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995190#comment-15995190
]
Robbie Gemmell commented on ARTEMIS-209:
Yep. Related to https://issues.apache.org/jira/browse/PROTON-900. Most folks
seemed to think it was fine to do that, since it shouldnt make any difference
to the other side (fail is fail..), but I dislike it and raised it anyway. I
later came to realise it was semi deliberate to allow for other behaviours,
though perhaps we can find a middle ground for making it less silly the rest of
the time.
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Chuck Rolke
>Assignee: Timothy Bish
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995140#comment-15995140
]
Timothy Bish commented on ARTEMIS-209:
--
This would likely require a change to Proton-J to prevent from happening as the
header is being emitted from Proton-J following the SASL exchange.
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Chuck Rolke
>Assignee: Timothy Bish
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995043#comment-15995043
]
clebert suconic commented on ARTEMIS-209:
-
[~chug] Tim fixed something on master. can you try master?
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Chuck Rolke
>Assignee: Timothy Bish
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993399#comment-15993399
]
Chuck Rolke commented on ARTEMIS-209:
-
Tested again with 2.0 and the issue still exists.
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Chuck Rolke
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993250#comment-15993250
]
Justin Bertram commented on ARTEMIS-209:
Can you test this again with 2.0?
> [AMQP] Broker sends frames after SASL failure
> -
>
> Key: ARTEMIS-209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-209
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
>Affects Versions: 1.0.0
> Environment: SASL negotiation over AMQP
>Reporter: Chuck Rolke
>
> The client sends bogus credentials to the Artemis server. The server
> correctly fails with sasl.outcome code: auth(1). So far so good. Then the
> server sends an AMQP protocol negotiation frame as if everything was OK.
> After failing SASL the server should close the connection.
> Trace file:
> https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
> From the trace:
> {noformat}
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> init SASL (3): (1.0.0)
> 10.10.1.1:1340 -> 10.10.10.254:5672 -> method sasl.init
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init SASL (3): (1.0.0), method
> sasl.mechanisms, method sasl.outcome
> 10.10.1.1:1340 <- 10.10.10.254:5672 <-init AMQP (0): (1.0.0)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-209) [AMQP] Broker sends frames after SASL failure
[
https://issues.apache.org/jira/browse/ARTEMIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712138#comment-14712138
]
ASF subversion and git services commented on ARTEMIS-209:
-
Commit 4b79ddb0bd02f0a6913beb2f5d7aabf350933543 in activemq-artemis's branch
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=4b79ddb ]
ARTEMIS-209 fix keepAlive
- Received should be set to true on any package
[AMQP] Broker sends frames after SASL failure
-
Key: ARTEMIS-209
URL: https://issues.apache.org/jira/browse/ARTEMIS-209
Project: ActiveMQ Artemis
Issue Type: Improvement
Components: AMQP
Affects Versions: 1.0.0
Environment: SASL negotiation over AMQP
Reporter: Chuck Rolke
The client sends bogus credentials to the Artemis server. The server
correctly fails with sasl.outcome code: auth(1). So far so good. Then the
server sends an AMQP protocol negotiation frame as if everything was OK.
After failing SASL the server should close the connection.
Trace file:
https://people.apache.org/~chug/artemis/20150821-1/artemis-sasl-fail-but-sends-amqp-header.html
From the trace:
{noformat}
10.10.1.1:1340 - 10.10.10.254:5672 - init SASL (3): (1.0.0)
10.10.1.1:1340 - 10.10.10.254:5672 - method sasl.init
10.10.1.1:1340 - 10.10.10.254:5672 -init SASL (3): (1.0.0), method
sasl.mechanisms, method sasl.outcome
10.10.1.1:1340 - 10.10.10.254:5672 -init AMQP (0): (1.0.0)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
